diff --git a/lang/en.json b/lang/en.json index a2a1581..0643194 100644 --- a/lang/en.json +++ b/lang/en.json @@ -389,19 +389,19 @@ "DG.Settings.sortskills.hint": "Checked sorts by column. Unchecked sorts by row.", "DG.Settings.keepSanityPrivate.name": "Keep Sanity Private", "DG.Settings.keepSanityPrivate.hint": "Hide sanity from players on both character sheet and rolls.", - "DG.Settings.improvementroll.name": "Default Skill Improvement Roll", - "DG.Settings.improvementroll.hint": " Default 1d4. There have been multiple errata on this, choose which fits best for the pace of your game.", - "DG.Settings.improvementroll.1": "Flat +1", - "DG.Settings.improvementroll.2": "+1D3%", - "DG.Settings.improvementroll.3": "+1D4%", - "DG.Settings.improvementroll.4": "+1D4-1%", + "DG.Settings.skillImprovementFormula.name": "Default Skill Improvement Roll", + "DG.Settings.skillImprovementFormula.hint": " Default 1d4. There have been multiple errata on this, choose which fits best for the pace of your game.", + "DG.Settings.skillImprovementFormula.1": "Flat +1", + "DG.Settings.skillImprovementFormula.2": "+1D3%", + "DG.Settings.skillImprovementFormula.3": "+1D4%", + "DG.Settings.skillImprovementFormula.4": "+1D4-1%", "DG.Settings.alwaysShowHypergeometrySectionForPlayers.name": "Always Show Hypergeometry Section for Players", "DG.Settings.alwaysShowHypergeometrySectionForPlayers.hint": "Always show Hypergeometry item section for players, even if they don't have any items of that type.", "DG.Settings.showImpossibleLandscapesContent.name": "Show Impossible Landscapes Content", "DG.Settings.showImpossibleLandscapesContent.hint": "Show Impossible Landscapes-specific fields from character sheets.", "DG.Settings.automateSanity.name": "Show Impossible Landscapes-specific fields from character sheets.", "DG.Settings.skillFailure.name": "Auto set skill failure", - "DG.Settings.skillFailure.hint": "", + "DG.Settings.skillFailure.hint": "Activate this setting to always mark a failure checkbox upon failing a skill. This also enables an undo function in the chat card.", "DG.SettingsMenu.automation.name": "Automation Menu", "DG.SettingsMenu.automation.label": "Automation Menu", diff --git a/module/settings.js b/module/settings.js index d4303c5..809218f 100644 --- a/module/settings.js +++ b/module/settings.js @@ -35,7 +35,7 @@ const SettingForm = class extends HandlebarsApplicationMixin(ApplicationV2) { id: `${DG.ID}-setting-form`, classes: [DG.ID, "settings-menu"], window: {title: ``, resizable: true}, - position: {width: 500, height: 400}, + position: {width: 500, height: 'auto'}, actions: {}, form: { handler: this.onSubmit, @@ -111,6 +111,11 @@ class HandlerSettings extends SettingForm { requiresReload: true, type: Boolean, default: false, + }, + skillImprovementFormula: { + type: String, + choices: DG.skillImprovementFormulas, + default: "d4", } }; } @@ -167,20 +172,6 @@ export default function registerSystemSettings() { default: false, }); - game.settings.register("deltagreen", "skillImprovementFormula", { - name: game.i18n.localize("DG.Settings.improvementroll.name"), - hint: game.i18n.localize("DG.Settings.improvementroll.hint"), - scope: "world", // This specifies a world-stored setting - config: true, // This specifies that the setting appears in the configuration view - type: String, - choices: DG.skillImprovementFormulas, - default: "d4", // The default value for the setting, per the most recent errata. - onChange: (value) => { - // A callback function which triggers when the setting is changed - // console.log(value) - }, - }); - // obsolete - will be removed at some point game.settings.register("deltagreen", "characterSheetFont", { name: "World Font Choice",