Reorder the combat tab, and make weapons readyable

There was no way to ready a weapon. The strip under the characteristics reads
`equipped`, and the only toggle-equipped control on the sheet was on the ARMOUR list —
a weapon could only be readied by opening its item sheet and finding the tickbox
there. The weapons table now carries the same toggle, the row is tinted when readied,
and a line above the table says what the control does.

The tab runs in the order it is used: weapons, armour, defend, reaction, body last.
Weapons lead with 40px art and a display-face name, having previously sat below two
screens of anatomy and reaction arithmetic.

The figure is a partial, drawn in three places — header thumbnail, combat tab, anatomy
tab. Three inline copies would have been the template-layer version of the defect
check-rules exists to prevent: a location present in one drawing and missing from
another.

The header carries a 34px figure and every location with its damage and the armour
over it, so "how much armour is on the part that just got hit" is answered on the main
page without changing tab.

Also fixed: `.ringbrp-sheet a` outranks a bare `.rb-equip`, so an unequipped toggle was
painted white and read as lit — true of the armour toggle too, since it was added.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
slaguru666
2026-08-11 10:15:16 +01:00
co-authored by Claude Opus 5
parent 4bfa7110d0
commit 3421ed4a2e
110 changed files with 374 additions and 194 deletions
+34
View File
@@ -4391,3 +4391,37 @@ lighting the world.
Note for deployment: `template.json` is read when Foundry loads the system, so the new
`lightReachM` field did not exist on items until the server was restarted — the
migration then stamped it. A remote server needs the restart, not just a pull.
## The combat tab, reordered — and R-241, a weapon nobody could ready
**R-241. There was no way to ready a weapon.** The strip under the characteristics
reads `equipped`, and the only `toggle-equipped` control on the whole character sheet
was on the *armour* list. A weapon could only be readied by opening its item sheet and
finding the tickbox there — which is why the strip on most sheets showed whatever the
pack builder happened to have equipped and nothing else. The weapons table now carries
the same toggle, the row is tinted when it is readied, and a line above the table says
plainly what the control does.
**R-242. The off state did not look off.** `.ringbrp-sheet a` is more specific than a
bare `.rb-equip`, so an unequipped toggle was painted white and read as lit. That was
true of the armour toggle too, and had been since the toggle was added.
**The tab now runs in the order it is used**: weapons, armour, defend, reaction, and
the body last. Weapons lead with 40px art and a display-face name, because they are
what the tab is for and they were previously below two screens of anatomy and reaction
arithmetic.
**The figure is a partial now.** It is drawn in three places — the header thumbnail,
the combat tab and the anatomy tab — and it was previously twenty lines of inline
Handlebars that existed once. Three copies of that would have been the template-layer
version of the defect `check-rules` exists to prevent: a location present in one
drawing and missing from another. One partial, registered at init, three call sites.
The header now carries a **34px figure and every location with its damage and the
armour over it**, so the commonest question at the table — how much armour is on the
part that just got hit — is answered on the main page without changing tab.
Noted while working: the mini figure inherited `.rb-body-svg { max-width: 180px }`
from further down the stylesheet and blew the header out to 385px tall. Same-specificity
selectors, later one wins; the compound `.rb-body-svg.rb-body-mini` fixes it. Worth
remembering that this stylesheet is ordered by section rather than by specificity.