RingBRP/tools/check-scenarios.mjs

/**
 * check-scenarios — every skill a scenario tells the GM to roll must exist.
 *
 * THROUGH TRAIN asked for "[CUS: Ride, then Athletics]" through several drafts and a
 * playtest. There is no Ride skill in this game and there never has been, so that whole
 * boarding route was an instruction to roll a thing nobody has. Nothing caught it,
 * because the four other guards check rules, kits, language and templates — and a
 * scenario is prose.
 *
 * This reads every scenario source and GM document, pulls out the bracketed mechanic
 * tags, and resolves each named skill against SKILL_CATALOGUE. A scenario that names a
 * skill the catalogue does not carry fails the build.
 */

import { readFileSync, readdirSync } from "node:fs";
import { join, dirname } from "node:path";
import { fileURLToPath } from "node:url";
import { SKILL_CATALOGUE } from "./content.mjs";

const ROOT = join(dirname(fileURLToPath(import.meta.url)), "..");

const KNOWN = new Set(SKILL_CATALOGUE.map(r => (r[4] || r[0]).toLowerCase()));
// A tag may name a family without its specialisation — "Firearm", "Melee Weapon" — which
// is how a GM speaks and is not an error.
for (const r of SKILL_CATALOGUE) {
  const name = r[4] || r[0];
  const bare = name.replace(/\s*\([^)]*\)\s*$/, "").trim().toLowerCase();
  if (bare) KNOWN.add(bare);
}

/** Words that appear inside a tag but are never the skill being rolled. */
const NOISE = new Set([
  "average", "easy", "difficult", "hard", "formidable", "impossible",
  "and", "then", "or", "at", "on", "per", "each", "the", "a", "an",
  "only", "a fumble is a fall", "no roll", "automatic", "opposed",
  "with", "against", "for", "to", "vs", "versus", "first", "second",
  // the scenario template's own placeholder, and the catch-all phrasing
  "skill", "any applicable skill", "applicable skill", "any skill"
]);

/**
 * Pull the candidate skill names out of one tag body.
 * "Athletics — average; only a fumble is a fall"  -> ["Athletics"]
 * "Spot or Engineering"                           -> ["Spot", "Engineering"]
 * "Ride, then Athletics"                          -> ["Ride", "Athletics"]
 * "Persuade at −30% on the first pass"            -> ["Persuade"]
 */
function skillsIn(body) {
  // everything before the first descriptive break belongs to the roll itself
  const head = body.split(/[—–—;:]|\bat\b|\bwhen\b|\bif\b|\bfor\b|\bagainst\b/u)[0];
  return head
    .split(/\bor\b|\bthen\b|\band\b|[,/]/u)
    .map(x => x.replace(/[.…]+$/, "").replace(/\s+/g, " ").trim())
    .filter(x => x && !NOISE.has(x.toLowerCase()) && !/^\d/.test(x));
}

function tagsIn(text) {
  // [CUS: ...] as written in the markdown, and the HTML-escaped form in the generators
  const out = [];
  for (const m of text.matchAll(/\[CUS:\s*([^\]]+)\]/g)) out.push(m[1]);
  return out;
}

function stripHtml(s) {
  // The generators build these strings by concatenation, so a single tag is routinely
  // split across two source lines. Rejoin before anything tries to read it.
  return s.replace(/"\s*\+\s*"/g, "")
          .replace(/<[^>]+>/g, " ")
          .replace(/&mdash;/g, "—").replace(/&ndash;/g, "–")
          .replace(/&minus;/g, "−").replace(/&amp;/g, "&")
          .replace(/&frac12;/g, "").replace(/&ldquo;|&rdquo;/g, '"');
}

const files = [
  ...readdirSync(join(ROOT, "tools")).filter(f => f.startsWith("scenario-"))
    .map(f => ["tools/" + f, join(ROOT, "tools", f)]),
  ...readdirSync(join(ROOT, "docs", "scenarios")).filter(f => f.endsWith(".md"))
    .map(f => ["docs/scenarios/" + f, join(ROOT, "docs", "scenarios", f)])
];

const problems = [];
let tagCount = 0;

for (const [label, path] of files) {
  const raw = readFileSync(path, "utf8");
  // A line that explicitly says a skill does NOT exist is documentation, not an instruction.
  const text = stripHtml(raw)
    .split("\n")
    .filter(l => !/there is no .* skill|NO RIDE SKILL/i.test(l))
    .join("\n");
  for (const body of tagsIn(text)) {
    tagCount++;
    for (const cand of skillsIn(body)) {
      if (!KNOWN.has(cand.toLowerCase())) {
        problems.push(`${label}: [CUS: ${body.trim()}] — "${cand}" is not a skill`);
      }
    }
  }
}

if (problems.length) {
  console.error("check-scenarios: FAILED");
  for (const p of [...new Set(problems)]) console.error("  " + p);
  process.exit(1);
}

console.log(`check-scenarios: OK — ${files.length} scenario files, ${tagCount} mechanic `
  + `tags, every skill named resolves against ${SKILL_CATALOGUE.length} catalogue entries`);