From b237e3231414cc283dc5ea250a6c3942a5cdf703 Mon Sep 17 00:00:00 2001
From: Melon-PieldeSapo <hfazefiris@gmail.com>
Date: Thu, 21 Aug 2025 10:18:12 +0200
Subject: [PATCH] Character generator - v13 : remove hidden condition on skills
 pop-up dropdown as a temporary solution. (skill will not be filtered by
 pre-requisite)

---
 ...rator-skill-option-full-expert-dialog.html | 29 +---------
 ...rator-skill-option-full-master-dialog.html | 58 ++-----------------
 2 files changed, 7 insertions(+), 80 deletions(-)

diff --git a/templates/dialogs/actor-generator/actor-generator-skill-option-full-expert-dialog.html b/templates/dialogs/actor-generator/actor-generator-skill-option-full-expert-dialog.html
index e356ca7..2b7d170 100644
--- a/templates/dialogs/actor-generator/actor-generator-skill-option-full-expert-dialog.html
+++ b/templates/dialogs/actor-generator/actor-generator-skill-option-full-expert-dialog.html
@@ -28,7 +28,7 @@
                     </option>
 
                     {{#each skills.trained as |skill id|}}
-                    <option hidden value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
+                    <option value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
                         data-prerequisite_ids='[{{#each skill.system.prerequisite_ids as |id|}}"{{id}}"{{#unless @last}},{{/unless}}{{/each}}]'>
                         {{skill.name}}</option>
                     {{/each}}
@@ -37,29 +37,4 @@
             </div>
         </div>
     </form>
-</div>
-<script>
-
-    function updateDropdownExpert() {
-        // Logic to update dropdownTrained based on the selection of dropdownExpert
-
-        let dropdownExpert = document.getElementById('dropdownExpert');
-        let dropdownTrained = document.getElementById('dropdownTrained');
-        let selectedValue = dropdownExpert.options[dropdownExpert.selectedIndex].getAttribute('data-uuid');
-
-        let prerequisiteIds = JSON.parse(dropdownExpert.options[dropdownExpert.selectedIndex].getAttribute('data-prerequisite_ids'));
-
-        for (let i = 0; i < dropdownTrained.options.length; i++) {
-            let option = dropdownTrained.options[i];
-            let optionUuid = option.getAttribute('data-uuid');
-            if (prerequisiteIds.includes(optionUuid)) {
-                option.hidden = false;
-            } else {
-                option.hidden = true;
-                if (dropdownTrained.options[dropdownTrained.selectedIndex].getAttribute('data-uuid') == optionUuid) {
-                    dropdownTrained.selectedIndex = 0;
-                }
-            }
-        }
-    }
-</script>
\ No newline at end of file
+</div>
\ No newline at end of file
diff --git a/templates/dialogs/actor-generator/actor-generator-skill-option-full-master-dialog.html b/templates/dialogs/actor-generator/actor-generator-skill-option-full-master-dialog.html
index a6087db..e14bf2d 100644
--- a/templates/dialogs/actor-generator/actor-generator-skill-option-full-master-dialog.html
+++ b/templates/dialogs/actor-generator/actor-generator-skill-option-full-master-dialog.html
@@ -1,3 +1,5 @@
+<script type="text/javascript" src="relative/path/to/your/javascript.js"></script>
+
 <div class="mosh">
 
     <form id="skillForm" class="{{cssClass}} characterGeneratorSkillPopup">
@@ -27,7 +29,7 @@
                     </option>
 
                     {{#each skills.expert as |skill id|}}
-                    <option hidden value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
+                    <option value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
                         data-prerequisite_ids='[{{#each skill.system.prerequisite_ids as |id|}}"{{id}}"{{#unless @last}},{{/unless}}{{/each}}]'>
                         {{skill.name}}</option>
                     {{/each}}
@@ -41,7 +43,7 @@
                     </option>
 
                     {{#each skills.trained as |skill id|}}
-                    <option hidden value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
+                    <option value="{{skill.uuid}}" data-uuid="{{skill.uuid}}" {{skill.disabled}}
                         data-prerequisite_ids='[{{#each skill.system.prerequisite_ids as |id|}}"{{id}}"{{#unless @last}},{{/unless}}{{/each}}]'>
                         {{skill.name}}</option>
                     {{/each}}
@@ -50,54 +52,4 @@
             </div>
         </div>
     </form>
-</div>
-<script>
-    function updateDropdownMaster() {
-        // Logic to update dropdownExpert based on the selection of dropdownMaster
-
-        let dropdownMaster = document.getElementById('dropdownMaster');
-        let dropdownExpert = document.getElementById('dropdownExpert');
-        let selectedValue = dropdownMaster.options[dropdownMaster.selectedIndex].getAttribute('data-uuid');
-
-        let prerequisiteIds = JSON.parse(dropdownMaster.options[dropdownMaster.selectedIndex].getAttribute('data-prerequisite_ids'));
-
-        for (let i = 0; i < dropdownExpert.options.length; i++) {
-            let option = dropdownExpert.options[i];
-            let optionUuid = option.getAttribute('data-uuid');
-            if (prerequisiteIds.includes(optionUuid)) {
-                option.hidden = false;
-            } else {
-                option.hidden = true;
-                if (dropdownExpert.options[dropdownExpert.selectedIndex].getAttribute('data-uuid') == optionUuid) {
-                    dropdownExpert.selectedIndex = 0;
-                    let dropdownTrained = document.getElementById('dropdownTrained');
-                    dropdownTrained.selectedIndex = 0;
-                }
-            }
-        }
-    }
-
-
-    function updateDropdownExpert() {
-        // Logic to update dropdownTrained based on the selection of dropdownExpert
-
-        let dropdownExpert = document.getElementById('dropdownExpert');
-        let dropdownTrained = document.getElementById('dropdownTrained');
-        let selectedValue = dropdownExpert.options[dropdownExpert.selectedIndex].getAttribute('data-uuid');
-
-        let prerequisiteIds = JSON.parse(dropdownExpert.options[dropdownExpert.selectedIndex].getAttribute('data-prerequisite_ids'));
-
-        for (let i = 0; i < dropdownTrained.options.length; i++) {
-            let option = dropdownTrained.options[i];
-            let optionUuid = option.getAttribute('data-uuid');
-            if (prerequisiteIds.includes(optionUuid)) {
-                option.hidden = false;
-            } else {
-                option.hidden = true;
-                if (dropdownTrained.options[dropdownTrained.selectedIndex].getAttribute('data-uuid') == optionUuid) {
-                    dropdownTrained.selectedIndex = 0;
-                }
-            }
-        }
-    }
-</script>
\ No newline at end of file
+</div>
\ No newline at end of file