From d6b5bb2214b9f40599fcd9a8ba11f6ff75049e4b Mon Sep 17 00:00:00 2001 From: Daniel Tschiedel Date: Thu, 10 Dec 2020 21:20:36 -0300 Subject: [PATCH 1/4] fixing settings tab grid layout --- TheElephantAndMacawBanner/the_elephant_and_macaw_banner.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.css b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.css index b93d96a3bf..79c9f627cd 100644 --- a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.css +++ b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.css @@ -841,7 +841,7 @@ div.sheet-shadow-bottom-left::after { .sheet-settings-grid { display: grid; grid-template-columns: auto auto; - width: fit-content; + width: max-content; gap: 5px; } From 7097fa84bf610a6cd2cb42bffbd82295fa661ec8 Mon Sep 17 00:00:00 2001 From: Daniel Tschiedel Date: Thu, 10 Dec 2020 21:28:42 -0300 Subject: [PATCH 2/4] Some strings and translation fixes --- .../the_elephant_and_macaw_banner.html | 4 ++-- TheElephantAndMacawBanner/translation.json | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html index e180526b90..9fe970f659 100644 --- a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html +++ b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html @@ -923,7 +923,7 @@
  1. - modifier set for the test, + modifier chosen when rolling,
  2. @@ -938,7 +938,7 @@

    - For example: A character receives a Bless +2 during a battle, so the player should put 2 in the All tests modifier field. The character is using a rapier that gives +1 to Fencing, which should be represented as 1 in the skill´s Mod field. The player decides to make a normal melee attack (easy feat) on a creature with an Active Defense of 4. So after clicking the die beside Fencing for the test, the player should choose an easy feat and place -4 in the Mod field to subtract the creature´s defense. In the chat window, the “Mods” applied to the test should appear as -1, representing -4 + 2 + 1 for the three modifiers. + For example: A character receives a Bless +2 during a battle, so the player should put 2 in the All tests modifier field. The character is using an excepcional rapier that gives +1 to Fencing, which should be represented as 1 in the skill´s Mod field. The player decides to make a normal melee attack (easy feat) on a creature with an Active Defense of 4. So after clicking the die beside Fencing for the test, the player should choose an easy feat and place -4 in the Mod field to subtract the creature´s defense. In the chat window, the “Mods” applied to the test should appear as -1, representing -4 + 2 + 1 for the three modifiers.

    diff --git a/TheElephantAndMacawBanner/translation.json b/TheElephantAndMacawBanner/translation.json index 3784c198f2..b7eaefde28 100644 --- a/TheElephantAndMacawBanner/translation.json +++ b/TheElephantAndMacawBanner/translation.json @@ -65,10 +65,10 @@ "rolling_skills_instructions2": "The result will be shown in the chat window as the sum of three values:\n ", "rolling_skills_formula": "The 3d6 roll + the skill´s level bonus + other modifiers\n ", "rolling_skills_instructions3": "Other modifiers include:\n ", - "rolling_skills_instructions4": "modifier set for the test,\n ", + "rolling_skills_instructions4": "modifier chosen when rolling,\n ", "rolling_skills_instructions5": "the “Modify all skills” value and\n ", "rolling_skills_instructions6": "the Mod value set for the individual skill.\n ", - "rolling_skills_instructions7": "For example: A character receives a Bless +2 during a battle, so the player should put 2 in the All tests modifier field. The character is using a rapier that gives +1 to Fencing, which should be represented as 1 in the skill´s Mod field. The player decides to make a normal melee attack (easy feat) on a creature with an Active Defense of 4. So after clicking the die beside Fencing for the test, the player should choose an easy feat and place -4 in the Mod field to subtract the creature´s defense. In the chat window, the “Mods” applied to the test should appear as -1, representing -4 + 2 + 1 for the three modifiers.\n ", + "rolling_skills_instructions7": "For example: A character receives a Bless +2 during a battle, so the player should put 2 in the All tests modifier field. The character is using an excepcional rapier that gives +1 to Fencing, which should be represented as 1 in the skill´s Mod field. The player decides to make a normal melee attack (easy feat) on a creature with an Active Defense of 4. So after clicking the die beside Fencing for the test, the player should choose an easy feat and place -4 in the Mod field to subtract the creature´s defense. In the chat window, the “Mods” applied to the test should appear as -1, representing -4 + 2 + 1 for the three modifiers.\n ", "initiative_instructions": "Can be used for an initiative check. \n ", "untrained_skill_instructions": "Can be used for level 0 tests against easy or intermediate feats, as explained in the rulebook.\n\n ", "physical-condition": "Physical Condition", @@ -90,5 +90,6 @@ "result": "Result", "success": "Success", "failure": "Failure", - "epic_failure": "Epic failure!" + "epic_failure": "Epic failure!", + "epic_success": "Epic success!" } \ No newline at end of file From 653dae1477496eb2b285e910d5c96d3f296f855d Mon Sep 17 00:00:00 2001 From: Daniel Tschiedel Date: Thu, 10 Dec 2020 21:48:17 -0300 Subject: [PATCH 3/4] fixing name on help --- TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html index 9fe970f659..c11ac9f98b 100644 --- a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html +++ b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html @@ -823,7 +823,7 @@ understand how all the fields work on our Roll20 character sheet.

    - Names, + Name, Characteristics, History - These fields should be filled in From e06442c0864b0d2ba313284737895973a9095c65 Mon Sep 17 00:00:00 2001 From: Daniel Tschiedel Date: Sun, 13 Dec 2020 12:00:37 -0300 Subject: [PATCH 4/4] changing initiative roll to send it to the tracker --- TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html index c11ac9f98b..b505b72074 100644 --- a/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html +++ b/TheElephantAndMacawBanner/the_elephant_and_macaw_banner.html @@ -473,7 +473,7 @@

    + value="&{template:main} {{charname=@{character_name}}} {{check=@{initiative_label}}} {{initiative=[[3d6cs>7cf<0 &{tracker}]]}}"> Initiative