From 028cef29455e4e8d73ec667ac983a89a61998c6d Mon Sep 17 00:00:00 2001 From: Edgeworth E Date: Sat, 25 Feb 2023 06:50:30 -0800 Subject: [PATCH 1/2] remove attr_character_token img Once the big changes from the last pull request went live, I naturally discovered a bug in an edge case--if you create a fresh character sheet without a token assigned, attr_character_token doesn't get the default token image, but instead gets no image at all, which makes the top of the character sheet go wonky. All the solutions I could find for switching to displaying nothing when the image is missing end up being stripped out by Roll20 (e.g. onerror, using wrapping tags). I don't know whether this is a bug with attr_character_token, but it's easier to take the img tag out than it is to troubleshoot a possible bug there. Summary of behaviors with attr_character_token: 1) Works great: Character has token assigned 2) Works great: Character HAD token assigned, then was removed--shows the default token image 3) Missing image: Character has never had a token assigned, attr_character_token shows a broken image --- Magical-Kitties/Magical-Kitties-Save-the-Day.html | 1 - 1 file changed, 1 deletion(-) diff --git a/Magical-Kitties/Magical-Kitties-Save-the-Day.html b/Magical-Kitties/Magical-Kitties-Save-the-Day.html index 35b8d907de..c9f25dca50 100644 --- a/Magical-Kitties/Magical-Kitties-Save-the-Day.html +++ b/Magical-Kitties/Magical-Kitties-Save-the-Day.html @@ -1,6 +1,5 @@
-
Magical Kitties Save the Day! From a2753b89d178fb79a3f3b0a44cbcb5bbad7290dc Mon Sep 17 00:00:00 2001 From: Edgeworth E Date: Sat, 25 Feb 2023 10:04:58 -0800 Subject: [PATCH 2/2] shift Extra Dice Rolls button to the right With the token image missing, the spacing doesn't look quite right. So shift the Extra Dice Rolls button to the right to feel more "centered". --- Magical-Kitties/Magical-Kitties-Save-the-Day.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Magical-Kitties/Magical-Kitties-Save-the-Day.html b/Magical-Kitties/Magical-Kitties-Save-the-Day.html index c9f25dca50..7c9611b614 100644 --- a/Magical-Kitties/Magical-Kitties-Save-the-Day.html +++ b/Magical-Kitties/Magical-Kitties-Save-the-Day.html @@ -1,5 +1,5 @@
- +
Magical Kitties Save the Day!