ci(seedgo-audit): install memory extra so pyright resolves chromadb/numpy (DPLAN-0195)
Final straggler: memory scored 98% (diagnostics 55% = 9 pyright errors) in CI while 100% locally. Proven cause: the diagnostics standard runs pyright over every branch; memory's handlers import chromadb/numpy at module level. These are declared in the 'memory' optional-dependencies group, NOT 'dev' — and the audit job installed only '.[dev]', so pyright flagged them unresolved (reportMissingImports=error) → 9 false errors. My local .venv happens to have chromadb, which is why local audits read 100%. Fix: audit job installs '.[dev,memory]'. pyright now resolves memory's real, declared deps and the standard measures actual type-correctness (and matches a local audit). api imports openai (llm extra) but guards it lazily, so it stays 100% without that extra — only memory needed this. 12/13 were already green after the readme check-ignore fix; this clears the 13th. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
4c7e14a255
commit
27a175b2c9
@@ -58,7 +58,14 @@ jobs:
|
||||
python-version: "3.13"
|
||||
- run: |
|
||||
python -m pip install --upgrade pip
|
||||
pip install -e ".[dev]"
|
||||
# Install the `memory` extra (numpy/chromadb/fastembed) alongside dev:
|
||||
# the diagnostics standard runs pyright over every branch, and memory's
|
||||
# handlers import chromadb/numpy. Without these deps installed, pyright
|
||||
# reports them as unresolved imports (reportMissingImports=error) and
|
||||
# memory scores <100 — a false failure from a missing CI dep, not a code
|
||||
# defect. Installing the declared extra lets pyright resolve them so the
|
||||
# audit measures real type-correctness (and matches a local audit).
|
||||
pip install -e ".[dev,memory]"
|
||||
- name: Run seedgo standards audit
|
||||
run: python .github/scripts/seedgo_audit.py
|
||||
|
||||
|
||||
+7
-1
@@ -111,7 +111,13 @@ and this project uses [Calendar Versioning](https://calver.org/) in the format
|
||||
`cli_json`/`logs`/`artifacts` as "missing on disk" in CI only). The CI gate
|
||||
(`.github/scripts/seedgo_audit.py`) now also prints the failing standards and
|
||||
their check messages, so a sub-100 result says *why*, not just the percentage.
|
||||
Clean-tree and working-tree audits both report 13/13 = 100%. (DPLAN-0195)
|
||||
Finally, the `seedgo-audit` CI job now installs the `memory` extra
|
||||
(`pip install -e ".[dev,memory]"`): the `diagnostics` standard runs pyright over
|
||||
every branch, and memory's handlers import `chromadb`/`numpy` at module level —
|
||||
without those declared deps installed, pyright reported them as unresolved
|
||||
(`reportMissingImports=error`) and memory scored 55%, a false failure from a
|
||||
missing CI dep rather than a code defect. Clean-tree and working-tree audits
|
||||
both report 13/13 = 100%. (DPLAN-0195)
|
||||
- **Two latent Windows portability bugs caught by the new e2e harness** — both
|
||||
were always present in the code; they only surfaced now because this is the
|
||||
first CI to run `aipass init` scaffolding and real-branch `drone` routing on
|
||||
|
||||
Reference in New Issue
Block a user