feat(hooks): FPLAN-0270 Phase 5 — edit_gate Edit/MultiEdit reconstruction + diff (no false-reject)
Gate now covers Write/Edit/MultiEdit via _resolve_after_text (reconstruct post-edit text: Edit replace first/all, MultiEdit sequential) + _evaluate_limits + _check_trinity_change, all reusing @memory changed_entries. Because only NEW/CHANGED entries are checked, editing an unrelated field in a file full of legacy over-limit entries is ALLOWED — proven on devpulse's REAL local.json under enforce=true (unrelated todo edit allowed, over-limit edit blocked, file never written). Fail-open on old_string-not-found / invalid-JSON / import error / any exception. +17 tests (39 trinity, 511 hooks total), seedgo 100%, enforce false. @hooks side complete. Warn-first build (Phases 1-5) done. Part of DPLAN-0205. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
AIOSAI
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
54dcfb4823
commit
5336d8f61f
@@ -14,6 +14,7 @@ import importlib
|
||||
import json
|
||||
import os
|
||||
from pathlib import Path
|
||||
from typing import Any
|
||||
|
||||
from aipass.prax.apps.modules.logger import system_logger as logger
|
||||
|
||||
@@ -42,41 +43,85 @@ def _get_branch(file_path: str, package: str = "") -> str:
|
||||
return ""
|
||||
|
||||
|
||||
def _check_trinity_write(fp: Path, tool_input: dict, branch: str) -> dict | None:
|
||||
"""Check .trinity Write for over-limit entries. Returns block dict or None (allow)."""
|
||||
def _resolve_after_text(tool_name: str, tool_input: dict, current_text: str) -> str | None:
|
||||
"""Compute post-change file text for Edit/MultiEdit. Returns None on mismatch."""
|
||||
if tool_name == "Edit":
|
||||
old = tool_input.get("old_string", "")
|
||||
new = tool_input.get("new_string", "")
|
||||
if old not in current_text:
|
||||
return None
|
||||
if tool_input.get("replace_all", False):
|
||||
return current_text.replace(old, new)
|
||||
return current_text.replace(old, new, 1)
|
||||
if tool_name == "MultiEdit":
|
||||
edits = tool_input.get("edits", [])
|
||||
text = current_text
|
||||
for edit in edits:
|
||||
old = edit.get("old_string", "")
|
||||
new = edit.get("new_string", "")
|
||||
if old not in text:
|
||||
return None
|
||||
if edit.get("replace_all", False):
|
||||
text = text.replace(old, new)
|
||||
else:
|
||||
text = text.replace(old, new, 1)
|
||||
return text
|
||||
return None
|
||||
|
||||
|
||||
def _evaluate_limits(before: dict, after: dict, limits: dict, el: Any) -> dict | None:
|
||||
"""Diff changed entries and return block dict or None (allow)."""
|
||||
over = el.changed_entries(before, after, limits)
|
||||
if not over:
|
||||
return None
|
||||
if limits.get("enforce"):
|
||||
lines = ["Over-limit .trinity entries (shorten before saving):"]
|
||||
for v in over:
|
||||
lines.append(f" {v['entry_type']} [{v['key']}]: {v['length']}/{v['cap']} chars (+{v['over_by']})")
|
||||
return {
|
||||
"stdout": json.dumps({"decision": "block", "reason": "\n".join(lines)}),
|
||||
"exit_code": 2,
|
||||
"sound": "edit gate",
|
||||
}
|
||||
for v in over:
|
||||
logger.warning(
|
||||
"[HOOKS] edit_gate: over-limit .trinity entry %s [%s]: %d/%d (+%d) — warn only",
|
||||
v["entry_type"],
|
||||
v["key"],
|
||||
v["length"],
|
||||
v["cap"],
|
||||
v["over_by"],
|
||||
)
|
||||
return None
|
||||
|
||||
|
||||
def _check_trinity_change(fp: Path, tool_name: str, tool_input: dict, branch: str) -> dict | None:
|
||||
"""Check .trinity Write/Edit/MultiEdit for over-limit entries. Returns block dict or None."""
|
||||
try:
|
||||
el = importlib.import_module("aipass.memory.apps.handlers.json.entry_limits")
|
||||
limits = el.load_entry_limits(branch)
|
||||
if not limits.get("enabled"):
|
||||
return None
|
||||
content = tool_input.get("content", "")
|
||||
after = json.loads(content)
|
||||
|
||||
resolved_path = str(fp.resolve()) if not fp.is_absolute() else str(fp)
|
||||
before = {}
|
||||
if Path(resolved_path).exists():
|
||||
before = json.loads(Path(resolved_path).read_text(encoding="utf-8"))
|
||||
over = el.changed_entries(before, after, limits)
|
||||
if not over:
|
||||
return None
|
||||
if limits.get("enforce"):
|
||||
lines = ["Over-limit .trinity entries (shorten before saving):"]
|
||||
for v in over:
|
||||
lines.append(f" {v['entry_type']} [{v['key']}]: {v['length']}/{v['cap']} chars (+{v['over_by']})")
|
||||
return {
|
||||
"stdout": json.dumps({"decision": "block", "reason": "\n".join(lines)}),
|
||||
"exit_code": 2,
|
||||
"sound": "edit gate",
|
||||
}
|
||||
for v in over:
|
||||
logger.warning(
|
||||
"[HOOKS] edit_gate: over-limit .trinity entry %s [%s]: %d/%d (+%d) — warn only",
|
||||
v["entry_type"],
|
||||
v["key"],
|
||||
v["length"],
|
||||
v["cap"],
|
||||
v["over_by"],
|
||||
)
|
||||
return None
|
||||
|
||||
if tool_name == "Write":
|
||||
content = tool_input.get("content", "")
|
||||
after = json.loads(content)
|
||||
before = {}
|
||||
if Path(resolved_path).exists():
|
||||
before = json.loads(Path(resolved_path).read_text(encoding="utf-8"))
|
||||
else:
|
||||
if not Path(resolved_path).exists():
|
||||
return None
|
||||
current_text = Path(resolved_path).read_text(encoding="utf-8")
|
||||
before = json.loads(current_text)
|
||||
after_text = _resolve_after_text(tool_name, tool_input, current_text)
|
||||
if after_text is None:
|
||||
return None
|
||||
after = json.loads(after_text)
|
||||
|
||||
return _evaluate_limits(before, after, limits, el)
|
||||
except Exception as exc:
|
||||
logger.warning("[HOOKS] edit_gate: .trinity size check failed (allowing): %s", exc)
|
||||
return None
|
||||
@@ -154,9 +199,10 @@ def handle(hook_data: dict) -> dict:
|
||||
"sound": "edit gate",
|
||||
}
|
||||
|
||||
if tool_name == "Write" and fp.parent.name == ".trinity" and fp.name in _TRINITY_MEMORY_FILES:
|
||||
trinity_tools = ("Write", "Edit", "MultiEdit")
|
||||
if tool_name in trinity_tools and fp.parent.name == ".trinity" and fp.name in _TRINITY_MEMORY_FILES:
|
||||
if target_branch:
|
||||
block = _check_trinity_write(fp, tool_input, target_branch)
|
||||
block = _check_trinity_change(fp, tool_name, tool_input, target_branch)
|
||||
if block:
|
||||
return block
|
||||
|
||||
|
||||
@@ -7,7 +7,7 @@
|
||||
# Modified: 2026-06-13
|
||||
# =============================================
|
||||
|
||||
"""Tests for edit_gate .trinity character-limit check (Write tool, Phase 4)."""
|
||||
"""Tests for edit_gate .trinity character-limit check (Write/Edit/MultiEdit)."""
|
||||
|
||||
import importlib
|
||||
import json
|
||||
@@ -62,11 +62,15 @@ def _make_trinity_path(tmp_path, branch="hooks", filename="local.json"):
|
||||
return str(trinity_dir / filename)
|
||||
|
||||
|
||||
def _hook_data(file_path, content, tool_name="Write", cwd=None):
|
||||
def _hook_data(file_path, content=None, tool_name="Write", cwd=None, **extra_input):
|
||||
"""Build a hook_data dict for edit_gate.handle()."""
|
||||
tool_input = {"file_path": file_path}
|
||||
if content is not None:
|
||||
tool_input["content"] = content
|
||||
tool_input.update(extra_input)
|
||||
data = {
|
||||
"tool_name": tool_name,
|
||||
"tool_input": {"file_path": file_path, "content": content},
|
||||
"tool_input": tool_input,
|
||||
}
|
||||
if cwd:
|
||||
data["cwd"] = cwd
|
||||
@@ -364,46 +368,489 @@ class TestTrinityWriteCharNotByte:
|
||||
assert parsed["decision"] == "block"
|
||||
|
||||
|
||||
class TestTrinityEditMultiEditPassthrough:
|
||||
"""Edit/MultiEdit to .trinity file -> NOT blocked by Phase 4 check."""
|
||||
class TestTrinityEditClean:
|
||||
"""Edit to .trinity with entries under cap -> allowed."""
|
||||
|
||||
def test_edit_to_trinity_not_blocked(self, tmp_path):
|
||||
"""Edit tool to .trinity/local.json -> passes through (Phase 5 scope)."""
|
||||
def test_edit_clean_entry(self, tmp_path):
|
||||
"""Edit changes a key_learning to a short value -> allowed."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "old value"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"old value"',
|
||||
new_string='"new short value"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
assert result["stdout"] == ""
|
||||
|
||||
|
||||
class TestTrinityEditOverLimit:
|
||||
"""Edit producing over-limit entry -> blocked (enforce) or warned."""
|
||||
|
||||
def test_edit_over_limit_enforce_blocks(self, tmp_path):
|
||||
"""Edit pushes key_learning over 200 cap, enforce=True -> blocked."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "short"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"short"',
|
||||
new_string='"' + "x" * 250 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
parsed = json.loads(result["stdout"])
|
||||
assert parsed["decision"] == "block"
|
||||
assert "key_learnings" in parsed["reason"]
|
||||
|
||||
def test_edit_over_limit_warn_allows(self, tmp_path, caplog):
|
||||
"""Edit pushes key_learning over cap, enforce=False -> allowed + warn."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "short"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_WARN)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"short"',
|
||||
new_string='"' + "x" * 250 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
assert "warn only" in caplog.text
|
||||
|
||||
def test_edit_modifies_entry_to_exceed_cap(self, tmp_path):
|
||||
"""Edit modifies existing entry from under cap to over cap -> blocked."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "a" * 100}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"' + "a" * 100 + '"',
|
||||
new_string='"' + "b" * 250 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
parsed = json.loads(result["stdout"])
|
||||
assert parsed["decision"] == "block"
|
||||
|
||||
|
||||
class TestTrinityEditFailOpen:
|
||||
"""Edit fail-open: old_string not found, invalid JSON result."""
|
||||
|
||||
def test_edit_old_string_not_found_fail_open(self, tmp_path):
|
||||
"""old_string absent from file -> _resolve_after_text returns None -> allow."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "hello"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string="NONEXISTENT",
|
||||
new_string="x" * 500,
|
||||
)
|
||||
)
|
||||
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "Edit",
|
||||
"tool_input": {
|
||||
"file_path": file_path,
|
||||
"old_string": "old",
|
||||
"new_string": "x" * 500,
|
||||
},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_multiedit_to_trinity_not_blocked(self, tmp_path):
|
||||
"""MultiEdit tool to .trinity/local.json -> passes through (Phase 5 scope)."""
|
||||
def test_edit_producing_invalid_json_fail_open(self, tmp_path):
|
||||
"""Edit breaks JSON structure -> JSONDecodeError caught -> allow."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "hello"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"hello"',
|
||||
new_string='"hello',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_edit_nonexistent_file_allows(self, tmp_path):
|
||||
"""Edit to a .trinity file that doesn't exist yet -> allow."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {
|
||||
"file_path": file_path,
|
||||
"edits": [{"old_string": "a", "new_string": "x" * 500}],
|
||||
},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string="anything",
|
||||
new_string="x" * 500,
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
|
||||
class TestTrinityEditReplaceAll:
|
||||
"""Edit with replace_all=True vs False."""
|
||||
|
||||
def test_replace_all_true(self, tmp_path):
|
||||
"""replace_all=True replaces all occurrences -> checks result."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "aaa", "k2": "aaa"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"aaa"',
|
||||
new_string='"' + "x" * 250 + '"',
|
||||
replace_all=True,
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
parsed = json.loads(result["stdout"])
|
||||
assert parsed["decision"] == "block"
|
||||
|
||||
def test_replace_all_false_single(self, tmp_path):
|
||||
"""replace_all=False replaces first occurrence only -> one entry over."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "aaa", "k2": "bbb"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"aaa"',
|
||||
new_string='"' + "x" * 250 + '"',
|
||||
replace_all=False,
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
|
||||
|
||||
class TestTrinityEditCharNotByte:
|
||||
"""Character vs byte boundary via Edit tool."""
|
||||
|
||||
def test_em_dash_edit_at_cap_allowed(self, tmp_path):
|
||||
"""Edit producing 200 em-dashes (200 chars, 600 bytes) -> at cap -> allowed."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "short"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"short"',
|
||||
new_string='"' + "—" * 200 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_em_dash_edit_over_cap_blocked(self, tmp_path):
|
||||
"""Edit producing 201 em-dashes (201 chars, 603 bytes) -> over cap -> blocked."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "short"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"short"',
|
||||
new_string='"' + "—" * 201 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
|
||||
|
||||
class TestTrinityMultiEdit:
|
||||
"""MultiEdit: sequential edits, ordering, over-limit detection."""
|
||||
|
||||
def test_multiedit_clean(self, tmp_path):
|
||||
"""MultiEdit with both edits under cap -> allowed."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "aaa", "k2": "bbb"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
edits = [
|
||||
{"old_string": '"aaa"', "new_string": '"new_a"'},
|
||||
{"old_string": '"bbb"', "new_string": '"new_b"'},
|
||||
]
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {"file_path": file_path, "edits": edits},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_multiedit_over_limit_blocked(self, tmp_path):
|
||||
"""MultiEdit where second edit produces over-limit entry -> blocked."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "aaa", "k2": "bbb"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
edits = [
|
||||
{"old_string": '"aaa"', "new_string": '"short"'},
|
||||
{"old_string": '"bbb"', "new_string": '"' + "x" * 250 + '"'},
|
||||
]
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {"file_path": file_path, "edits": edits},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
parsed = json.loads(result["stdout"])
|
||||
assert parsed["decision"] == "block"
|
||||
|
||||
def test_multiedit_ordering_dependent(self, tmp_path):
|
||||
"""MultiEdit where edit 2 depends on edit 1's output -> applied sequentially."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "alpha"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
edits = [
|
||||
{"old_string": '"alpha"', "new_string": '"beta"'},
|
||||
{"old_string": '"beta"', "new_string": '"gamma"'},
|
||||
]
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {"file_path": file_path, "edits": edits},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_multiedit_old_string_not_found_fail_open(self, tmp_path):
|
||||
"""MultiEdit where an old_string is missing -> fail-open."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "hello"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
edits = [
|
||||
{"old_string": '"hello"', "new_string": '"world"'},
|
||||
{"old_string": '"NONEXISTENT"', "new_string": '"' + "x" * 500 + '"'},
|
||||
]
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {"file_path": file_path, "edits": edits},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
def test_multiedit_replace_all_in_edit(self, tmp_path):
|
||||
"""MultiEdit with replace_all=True in one edit -> replaces all occurrences."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {"key_learnings": {"k1": "zzz", "k2": "zzz"}}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
edits = [
|
||||
{"old_string": '"zzz"', "new_string": '"' + "x" * 250 + '"', "replace_all": True},
|
||||
]
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
{
|
||||
"tool_name": "MultiEdit",
|
||||
"tool_input": {"file_path": file_path, "edits": edits},
|
||||
"cwd": cwd,
|
||||
}
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
|
||||
|
||||
class TestTrinityEditUnrelatedFieldOnFatFile:
|
||||
"""THE critical no-false-reject test: unrelated edit on a file with legacy fat entries."""
|
||||
|
||||
def test_unrelated_edit_on_fat_file_allowed(self, tmp_path):
|
||||
"""File has 4000-char sessions + 500-char key_learnings (all legacy).
|
||||
Edit only touches a small todo. enforce=True. MUST be ALLOWED."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
|
||||
fat_sessions = [{"summary": "x" * 300} for _ in range(13)]
|
||||
fat_learnings = {f"k{i}": "y" * 500 for i in range(10)}
|
||||
existing = {
|
||||
"key_learnings": fat_learnings,
|
||||
"sessions": fat_sessions,
|
||||
"todos": [{"task": "old todo"}],
|
||||
}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"old todo"',
|
||||
new_string='"new todo"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
assert result["stdout"] == ""
|
||||
|
||||
def test_unrelated_edit_plus_new_over_limit_blocked(self, tmp_path):
|
||||
"""Fat file, but Edit ALSO adds a new over-limit entry -> blocked."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
|
||||
existing = {
|
||||
"key_learnings": {"old_fat": "y" * 500},
|
||||
"todos": [{"task": "old todo"}],
|
||||
}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"old todo"',
|
||||
new_string='"' + "z" * 250 + '"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 2
|
||||
|
||||
|
||||
class TestTrinityEditUnchangedLegacy:
|
||||
"""Edit that doesn't change legacy over-limit entries -> allowed."""
|
||||
|
||||
def test_edit_unchanged_legacy_allowed(self, tmp_path):
|
||||
"""Legacy over-limit key_learning unchanged by Edit -> allowed."""
|
||||
from aipass.hooks.apps.handlers.security.edit_gate import handle
|
||||
|
||||
file_path = _make_trinity_path(tmp_path, "hooks", "local.json")
|
||||
cwd = str(tmp_path / "src" / "aipass" / "hooks")
|
||||
existing = {
|
||||
"key_learnings": {"old_fat": "x" * 500, "k2": "short"},
|
||||
"todos": [{"task": "my todo"}],
|
||||
}
|
||||
Path(file_path).write_text(json.dumps(existing), encoding="utf-8")
|
||||
|
||||
with patch("importlib.import_module", return_value=_mock_entry_limits(_TEST_LIMITS_ENFORCE)):
|
||||
result = handle(
|
||||
_hook_data(
|
||||
file_path,
|
||||
tool_name="Edit",
|
||||
cwd=cwd,
|
||||
old_string='"short"',
|
||||
new_string='"still short"',
|
||||
)
|
||||
)
|
||||
|
||||
assert result["exit_code"] == 0
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user