Reorder the combat tab, and make weapons readyable

There was no way to ready a weapon. The strip under the characteristics reads
`equipped`, and the only toggle-equipped control on the sheet was on the ARMOUR list —
a weapon could only be readied by opening its item sheet and finding the tickbox
there. The weapons table now carries the same toggle, the row is tinted when readied,
and a line above the table says what the control does.

The tab runs in the order it is used: weapons, armour, defend, reaction, body last.
Weapons lead with 40px art and a display-face name, having previously sat below two
screens of anatomy and reaction arithmetic.

The figure is a partial, drawn in three places — header thumbnail, combat tab, anatomy
tab. Three inline copies would have been the template-layer version of the defect
check-rules exists to prevent: a location present in one drawing and missing from
another.

The header carries a 34px figure and every location with its damage and the armour
over it, so "how much armour is on the part that just got hit" is answered on the main
page without changing tab.

Also fixed: `.ringbrp-sheet a` outranks a bare `.rb-equip`, so an unequipped toggle was
painted white and read as lit — true of the armour toggle too, since it was added.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
slaguru666
2026-08-11 10:15:16 +01:00
co-authored by Claude Opus 5
parent 4bfa7110d0
commit 3421ed4a2e
110 changed files with 374 additions and 194 deletions
+34
View File
@@ -4391,3 +4391,37 @@ lighting the world.
Note for deployment: `template.json` is read when Foundry loads the system, so the new
`lightReachM` field did not exist on items until the server was restarted — the
migration then stamped it. A remote server needs the restart, not just a pull.
## The combat tab, reordered — and R-241, a weapon nobody could ready
**R-241. There was no way to ready a weapon.** The strip under the characteristics
reads `equipped`, and the only `toggle-equipped` control on the whole character sheet
was on the *armour* list. A weapon could only be readied by opening its item sheet and
finding the tickbox there — which is why the strip on most sheets showed whatever the
pack builder happened to have equipped and nothing else. The weapons table now carries
the same toggle, the row is tinted when it is readied, and a line above the table says
plainly what the control does.
**R-242. The off state did not look off.** `.ringbrp-sheet a` is more specific than a
bare `.rb-equip`, so an unequipped toggle was painted white and read as lit. That was
true of the armour toggle too, and had been since the toggle was added.
**The tab now runs in the order it is used**: weapons, armour, defend, reaction, and
the body last. Weapons lead with 40px art and a display-face name, because they are
what the tab is for and they were previously below two screens of anatomy and reaction
arithmetic.
**The figure is a partial now.** It is drawn in three places — the header thumbnail,
the combat tab and the anatomy tab — and it was previously twenty lines of inline
Handlebars that existed once. Three copies of that would have been the template-layer
version of the defect `check-rules` exists to prevent: a location present in one
drawing and missing from another. One partial, registered at init, three call sites.
The header now carries a **34px figure and every location with its damage and the
armour over it**, so the commonest question at the table — how much armour is on the
part that just got hit — is answered on the main page without changing tab.
Noted while working: the mini figure inherited `.rb-body-svg { max-width: 180px }`
from further down the stylesheet and blew the header out to 385px tall. Same-specificity
selectors, later one wins; the compound `.rb-body-svg.rb-body-mini` fixes it. Worth
remembering that this stylesheet is ordered by section rather than by specificity.
+6 -1
View File
@@ -880,5 +880,10 @@
"RINGBRP.Sight.LampNear": "{holder}'s, {m} m away — you are in it",
"RINGBRP.Sight.SomeLamp": "The light you are standing in",
"RINGBRP.Dialog.InLight": "I am in the light",
"RINGBRP.Dialog.InLightHint": "Ticked already if a lit lamp is within reach of your token. Tick it yourself when there are no tokens to measure."
"RINGBRP.Dialog.InLightHint": "Ticked already if a lit lamp is within reach of your token. Tick it yourself when there are no tokens to measure.",
"RINGBRP.Sheet.Ready": "Ready",
"RINGBRP.Sheet.ReadyToggle": "Ready this weapon — puts it in the strip at the top of the sheet",
"RINGBRP.Sheet.ReadyHint": "Click the fist to ready a weapon. Readied weapons appear in the strip under the characteristics, where they can be rolled without opening this tab.",
"RINGBRP.Sheet.BodyHead": "The body, and where it gets hit",
"RINGBRP.Sheet.MiniBodyHint": "Every location: damage taken, and the armour covering it."
}
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.196312 1737fb000 Recovering log #3
2026/08/11-09:44:12.196429 1737fb000 Level-0 table #5: started
2026/08/11-09:44:12.196537 1737fb000 Level-0 table #5: 3269 bytes OK
2026/08/11-09:44:12.196738 1737fb000 Delete type=0 #3
2026/08/11-09:44:12.196764 1737fb000 Delete type=3 #2
2026/08/11-10:11:58.113964 1752cb000 Recovering log #9
2026/08/11-10:11:58.114393 1752cb000 Delete type=3 #7
2026/08/11-10:11:58.114432 1752cb000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.979643 172267000 Delete type=3 #1
2026/08/11-10:01:07.582527 176517000 Recovering log #6
2026/08/11-10:01:07.582663 176517000 Level-0 table #8: started
2026/08/11-10:01:07.582827 176517000 Level-0 table #8: 4335 bytes OK
2026/08/11-10:01:07.583142 176517000 Delete type=0 #6
2026/08/11-10:01:07.583300 176517000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.205237 172fef000 Recovering log #3
2026/08/11-09:44:12.205611 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.205721 172fef000 Level-0 table #5: 4129 bytes OK
2026/08/11-09:44:12.205945 172fef000 Delete type=0 #3
2026/08/11-09:44:12.205992 172fef000 Delete type=3 #2
2026/08/11-10:11:58.123637 174abf000 Recovering log #9
2026/08/11-10:11:58.124065 174abf000 Delete type=3 #7
2026/08/11-10:11:58.124216 174abf000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:10.009129 17327f000 Delete type=3 #1
2026/08/11-10:01:07.594977 176d23000 Recovering log #6
2026/08/11-10:01:07.595333 176d23000 Level-0 table #8: started
2026/08/11-10:01:07.595474 176d23000 Level-0 table #8: 5069 bytes OK
2026/08/11-10:01:07.595768 176d23000 Delete type=0 #6
2026/08/11-10:01:07.595810 176d23000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.197435 172fef000 Recovering log #3
2026/08/11-09:44:12.198040 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.198321 172fef000 Level-0 table #5: 31614 bytes OK
2026/08/11-09:44:12.198514 172fef000 Delete type=0 #3
2026/08/11-09:44:12.198552 172fef000 Delete type=3 #2
2026/08/11-10:11:58.115761 175ad7000 Recovering log #9
2026/08/11-10:11:58.116061 175ad7000 Delete type=3 #7
2026/08/11-10:11:58.116179 175ad7000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.981180 17327f000 Delete type=3 #1
2026/08/11-10:01:07.584322 176d23000 Recovering log #6
2026/08/11-10:01:07.584745 176d23000 Level-0 table #8: started
2026/08/11-10:01:07.585166 176d23000 Level-0 table #8: 38366 bytes OK
2026/08/11-10:01:07.585428 176d23000 Delete type=0 #6
2026/08/11-10:01:07.585590 176d23000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.184168 172fef000 Recovering log #3
2026/08/11-09:44:12.185997 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.187435 172fef000 Level-0 table #5: 223489 bytes OK
2026/08/11-09:44:12.187693 172fef000 Delete type=0 #3
2026/08/11-09:44:12.187728 172fef000 Delete type=3 #2
2026/08/11-10:11:58.104873 175ad7000 Recovering log #9
2026/08/11-10:11:58.105121 175ad7000 Delete type=3 #7
2026/08/11-10:11:58.105148 175ad7000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.996017 172a73000 Delete type=3 #1
2026/08/11-10:01:07.565661 176d23000 Recovering log #6
2026/08/11-10:01:07.567596 176d23000 Level-0 table #8: started
2026/08/11-10:01:07.569268 176d23000 Level-0 table #8: 286534 bytes OK
2026/08/11-10:01:07.569897 176d23000 Delete type=0 #6
2026/08/11-10:01:07.570096 176d23000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.193256 1737fb000 Recovering log #3
2026/08/11-09:44:12.193611 1737fb000 Level-0 table #5: started
2026/08/11-09:44:12.193707 1737fb000 Level-0 table #5: 3295 bytes OK
2026/08/11-09:44:12.193908 1737fb000 Delete type=0 #3
2026/08/11-09:44:12.193951 1737fb000 Delete type=3 #2
2026/08/11-10:11:58.111179 1742b3000 Recovering log #9
2026/08/11-10:11:58.111621 1742b3000 Delete type=3 #7
2026/08/11-10:11:58.111656 1742b3000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:10.003815 172267000 Delete type=3 #1
2026/08/11-10:01:07.578452 176517000 Recovering log #6
2026/08/11-10:01:07.578743 176517000 Level-0 table #8: started
2026/08/11-10:01:07.578908 176517000 Level-0 table #8: 3619 bytes OK
2026/08/11-10:01:07.579232 176517000 Delete type=0 #6
2026/08/11-10:01:07.579267 176517000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.181257 172fef000 Recovering log #3
2026/08/11-09:44:12.182096 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.182622 172fef000 Level-0 table #5: 58065 bytes OK
2026/08/11-09:44:12.182900 172fef000 Delete type=0 #3
2026/08/11-09:44:12.182935 172fef000 Delete type=3 #2
2026/08/11-10:11:58.102156 175ad7000 Recovering log #9
2026/08/11-10:11:58.102452 175ad7000 Delete type=3 #7
2026/08/11-10:11:58.102485 175ad7000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.987323 173a8b000 Delete type=3 #1
2026/08/11-10:01:07.561384 176d23000 Recovering log #6
2026/08/11-10:01:07.562078 176d23000 Level-0 table #8: started
2026/08/11-10:01:07.562682 176d23000 Level-0 table #8: 74653 bytes OK
2026/08/11-10:01:07.563017 176d23000 Delete type=0 #6
2026/08/11-10:01:07.563204 176d23000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.200848 172fef000 Recovering log #3
2026/08/11-09:44:12.201122 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.201397 172fef000 Level-0 table #5: 30975 bytes OK
2026/08/11-09:44:12.201635 172fef000 Delete type=0 #3
2026/08/11-09:44:12.201675 172fef000 Delete type=3 #2
2026/08/11-10:11:58.118905 174abf000 Recovering log #9
2026/08/11-10:11:58.119473 174abf000 Delete type=3 #7
2026/08/11-10:11:58.119498 174abf000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:10.007699 172267000 Delete type=3 #1
2026/08/11-10:01:07.588947 176d23000 Recovering log #6
2026/08/11-10:01:07.589575 176d23000 Level-0 table #8: started
2026/08/11-10:01:07.589919 176d23000 Level-0 table #8: 31649 bytes OK
2026/08/11-10:01:07.590195 176d23000 Delete type=0 #6
2026/08/11-10:01:07.590234 176d23000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.190287 1737fb000 Recovering log #3
2026/08/11-09:44:12.190653 1737fb000 Level-0 table #5: started
2026/08/11-09:44:12.190822 1737fb000 Level-0 table #5: 7486 bytes OK
2026/08/11-09:44:12.191038 1737fb000 Delete type=0 #3
2026/08/11-09:44:12.191067 1737fb000 Delete type=3 #2
2026/08/11-10:11:58.108810 1742b3000 Recovering log #9
2026/08/11-10:11:58.109145 1742b3000 Delete type=3 #7
2026/08/11-10:11:58.109174 1742b3000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.973842 172a73000 Delete type=3 #1
2026/08/11-10:01:07.573933 17752f000 Recovering log #6
2026/08/11-10:01:07.574377 17752f000 Level-0 table #8: started
2026/08/11-10:01:07.574672 17752f000 Level-0 table #8: 9877 bytes OK
2026/08/11-10:01:07.575009 17752f000 Delete type=0 #6
2026/08/11-10:01:07.575053 17752f000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.202502 171fd7000 Recovering log #3
2026/08/11-09:44:12.202661 171fd7000 Level-0 table #5: started
2026/08/11-09:44:12.202854 171fd7000 Level-0 table #5: 16892 bytes OK
2026/08/11-09:44:12.203092 171fd7000 Delete type=0 #3
2026/08/11-09:44:12.203146 171fd7000 Delete type=3 #2
2026/08/11-10:11:58.120643 1742b3000 Recovering log #9
2026/08/11-10:11:58.120895 1742b3000 Delete type=3 #7
2026/08/11-10:11:58.120916 1742b3000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:10.002176 173a8b000 Delete type=3 #1
2026/08/11-10:01:07.591406 175d0b000 Recovering log #6
2026/08/11-10:01:07.591579 175d0b000 Level-0 table #8: started
2026/08/11-10:01:07.591796 175d0b000 Level-0 table #8: 17462 bytes OK
2026/08/11-10:01:07.592037 175d0b000 Delete type=0 #6
2026/08/11-10:01:07.592183 175d0b000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.203885 1737fb000 Recovering log #3
2026/08/11-09:44:12.204195 1737fb000 Level-0 table #5: started
2026/08/11-09:44:12.204288 1737fb000 Level-0 table #5: 3739 bytes OK
2026/08/11-09:44:12.204494 1737fb000 Delete type=0 #3
2026/08/11-09:44:12.204520 1737fb000 Delete type=3 #2
2026/08/11-10:11:58.122039 1752cb000 Recovering log #9
2026/08/11-10:11:58.122569 1752cb000 Delete type=3 #7
2026/08/11-10:11:58.122614 1752cb000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:10.000153 172267000 Delete type=3 #1
2026/08/11-10:01:07.593261 17752f000 Recovering log #6
2026/08/11-10:01:07.593387 17752f000 Level-0 table #8: started
2026/08/11-10:01:07.593525 17752f000 Level-0 table #8: 4143 bytes OK
2026/08/11-10:01:07.593758 17752f000 Delete type=0 #6
2026/08/11-10:01:07.593895 17752f000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.191930 172fef000 Recovering log #3
2026/08/11-09:44:12.192079 172fef000 Level-0 table #5: started
2026/08/11-09:44:12.192222 172fef000 Level-0 table #5: 5770 bytes OK
2026/08/11-09:44:12.192448 172fef000 Delete type=0 #3
2026/08/11-09:44:12.192478 172fef000 Delete type=3 #2
2026/08/11-10:11:58.110071 175ad7000 Recovering log #9
2026/08/11-10:11:58.110287 175ad7000 Delete type=3 #7
2026/08/11-10:11:58.110314 175ad7000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.976561 172267000 Delete type=3 #1
2026/08/11-10:01:07.576370 175d0b000 Recovering log #6
2026/08/11-10:01:07.576741 175d0b000 Level-0 table #8: started
2026/08/11-10:01:07.576905 175d0b000 Level-0 table #8: 6447 bytes OK
2026/08/11-10:01:07.577157 175d0b000 Delete type=0 #6
2026/08/11-10:01:07.577191 175d0b000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
View File
+1 -1
View File
@@ -1 +1 @@
MANIFEST-000004
MANIFEST-000010
+3 -5
View File
@@ -1,5 +1,3 @@
2026/08/11-09:44:12.199441 1737fb000 Recovering log #3
2026/08/11-09:44:12.199690 1737fb000 Level-0 table #5: started
2026/08/11-09:44:12.199821 1737fb000 Level-0 table #5: 6939 bytes OK
2026/08/11-09:44:12.200021 1737fb000 Delete type=0 #3
2026/08/11-09:44:12.200051 1737fb000 Delete type=3 #2
2026/08/11-10:11:58.117614 1752cb000 Recovering log #9
2026/08/11-10:11:58.117913 1752cb000 Delete type=3 #7
2026/08/11-10:11:58.117935 1752cb000 Delete type=0 #9
+5 -1
View File
@@ -1 +1,5 @@
2026/08/11-09:43:09.983507 172267000 Delete type=3 #1
2026/08/11-10:01:07.587264 176517000 Recovering log #6
2026/08/11-10:01:07.587412 176517000 Level-0 table #8: started
2026/08/11-10:01:07.587590 176517000 Level-0 table #8: 8283 bytes OK
2026/08/11-10:01:07.587831 176517000 Delete type=0 #6
2026/08/11-10:01:07.587866 176517000 Delete type=3 #4
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

Some files were not shown because too many files have changed in this diff Show More