Compare commits

...
231 Commits
Author SHA1 Message Date
AIPass f62fbcfc17 Merge pull request #646 from AIOSAI/dev
Todo burn-down (S245-S246): seedgo readme/bypass fixes, dead trigger handler, dispatch-footer plan-close scope, backup docs sweep, README roster to 17 agents, /prep todo-reconciliation
2026-07-02 17:56:16 -07:00
AIOSAI 55bc4d0bb1 chore(release): bump 2.6.0 -> 2.6.1 for the DPLAN-0226/FPLAN-0289/TDPLAN-0010 batch merge
PATCH bump riding into PR#646 so main's merge commit carries the release version. pyproject + __init__ = 2.6.1 (must match the v2.6.1 tag). CHANGELOG [2026-07-02] leads with the release rollup + all 6 CI-stabilization fixes.
2026-07-02 17:41:16 -07:00
AIOSAI 194410d467 fix(skills): deterministic LF in test_streaming byte-offset tests (Windows CRLF)
test_partial_line_not_consumed asserted +1 byte for the newline, but write_text() text mode translates \n->\r\n on Windows (2 bytes) -> off-by-one, failing windows-setup only. Switched both transcript write sites to write_bytes() for deterministic LF cross-platform. Production _tail_transcript_bytes is already CRLF-safe (reads rb, splits b'\n', strips \r) — test-only fix.
2026-07-02 16:46:47 -07:00
AIOSAI e5e740765d fix(spawn): track template scaffolding orphaned by builder->aipass_framework rename
.gitignore exceptions still pointed at templates/builder/ after the TDPLAN-0010 rename (13463c0), so DASHBOARD.local.json + 10 other template dirs/files under templates/aipass_framework/ were silently gitignored — on disk (dirty tree passed) but absent in clean clones/CI. Result: spawn produced no DASHBOARD.local.json and test_full_spawn failed only in a clean checkout. Fixed all 23 .gitignore exception paths + tracked the now-visible template files (all placeholder/seed content: {{BRANCHNAME}}/{{DATE}}/{{CITIZEN_NUMBER}}).
2026-07-02 16:15:05 -07:00
AIOSAI e92dcaff12 fix(ci): restore green — advisory template checker no longer gates audit + 3 test/module regressions
Root-cause fixes for PR#646 red (dev broke after DPLAN-0226/FPLAN-0289/TDPLAN-0010 batch):
- seedgo: branch_audit honors ADVISORY (template_check no longer averaged into gate) + presence_gate added to hooks-snapshot fixture (4 tests)
- hooks: cc_sessions README entry + seedgo modules bypass (reads external ~/.claude, not branch data)
- spawn: retire passport(disabled).py/passport_ops(disabled).py to .archive/ (disabled suffix kept broken cross-import visible to type checker)
- ai_mail: broker-fd test gives testbranch a real .trinity/passport.json for the new marker-walk resolution (f914ab6)
2026-07-02 15:47:53 -07:00
AIOSAIandClaude Opus 4.8 e1ac4e365f docs(prompts): .trinity entry-cap awareness — point at live *_meta line, no hardcoded numbers
Navmap (@hooks): one bullet in the Memory section — caps are hook-enforced,
the live cap is rendered in each file's *_meta line; read it before writing,
draft to ~80%, one-pass rewrite if rejected. Devpulse branch prompt: same
behavior, explicitly notes caps are NOT listed (single source =
memory.config.json → entry_limits, auto-rendered by @memory's tab_renderer).
Change the config → enforcement + in-file docs follow mechanically; prompts
never go stale.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q3mZT61WsKVN3srCwVDBiW
2026-07-02 05:41:24 -07:00
AIOSAIandClaude Opus 4.8 301f3fcb93 feat(backup): share <file> — single-file Drive upload + shareable webViewLink (FPLAN-0298)
New 'drone @backup share <file_path> [--public]': uploads a single file to Drive
(AIPass Backups/Shared), sets a read permission (default: restricted to the
authenticated user; --public: anyone-with-link), returns the webViewLink
(webContentLink fallback). Reuses upload_single_file + DriveClient; idempotent
via _find_existing_file; fail-loud on every path. 21 new tests, all Drive API
mocked (zero live calls). Existing commands untouched. DPLAN-0230 v1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q3mZT61WsKVN3srCwVDBiW
2026-07-01 19:56:56 -07:00
AIOSAIandClaude Opus 4.8 a5ede6fbf4 feat(skills/telegram): opt-in live streaming edit-in-place for TG bot (FPLAN-0297, DPLAN-0229)
Repurpose the heartbeat into a ~2s transcript-tail loop that edits the "Processing" message in place (block-level: thinking/tool/text), plain text, coalesced, no-op-skipped, 429 retry_after aware, with 4096 rollover. Opt-in per-bot "stream" flag, default OFF; batch path byte-for-byte unchanged. @hooks reviewed: no change needed (already edits processing_message_id for the single-chunk final). Race hardened: re-check delivered before each edit. 37/37 streaming + 653/653 TG tests green; live-proven on the devpulse bot.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q3mZT61WsKVN3srCwVDBiW
2026-07-01 18:40:32 -07:00
AIOSAI 337f31ddab fix(prax): per-bot telegram log attribution via AIPASS_BOT_ID/AIPASS_LOG_NAME in get_caller_info — bots no longer collapse into shared skills_base_bot.log 2026-07-01 16:07:22 -07:00
AIOSAI fca1105ed9 docs(pkg): aipass/__init__ docstring clone-only, drop 'pip install aipass' (TDPLAN-0010) 2026-07-01 09:49:36 -07:00
AIOSAI df5a1493bb docs(readme): remove pip entirely — clone-only install, badges + version + uninstall purged (TDPLAN-0010) 2026-07-01 09:44:23 -07:00
AIOSAI fd41320e3c chore(spawn): seedgo bypass for stale post-rename 'builder' architecture finding (TDPLAN-0010) 2026-07-01 09:11:59 -07:00
AIOSAI f914ab616e refactor(drone): .trinity/-marker walk-ups replace src/aipass hardcodes — portable resolution + access checks (TDPLAN-0010, FPLAN-0296) 2026-07-01 08:54:05 -07:00
AIOSAI 13463c0ce0 feat(spawn): rename builder->aipass_framework, {{CITIZEN_CLASS}} placeholder, retire birthright, per-project registry targeting (TDPLAN-0010, FPLAN-0294) 2026-07-01 08:16:54 -07:00
AIOSAI 5a3d01efb1 feat(aipass): aipass init template selector — empty-project default + stage gating (TDPLAN-0010, FPLAN-0295) 2026-07-01 08:09:30 -07:00
AIOSAI a2812abc90 refactor(ai_mail): portable find_repo_root() marker-walk replaces fixed-depth _REPO_ROOT (TDPLAN-0010 foundation, FPLAN-0293) 2026-07-01 07:26:16 -07:00
AIOSAIandClaude Opus 4.8 2a5a370185 fix(drone): --json pass-through uses sys.stdout.write, no Rich mid-string wrap (td-49)
--json was routed through Rich console.print(), which defaults to width 80 on
a non-TTY and hard-wraps mid-string, producing invalid JSON (e.g. 'Security
\nScan'). Write raw JSON with sys.stdout.write() in the pass-through paths
(drone.py + router.py); keep Rich for drone's own human UI. Verified live.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EccxENcB3KtyT9XuT4ybPz
2026-07-01 06:12:02 -07:00
AIOSAIandClaude Opus 4.8 61f958c17e feat(seedgo): stale-template audit checker — advisory flag for unrendered template markers in local prompts/config (DPLAN-0228)
New auto-discovered advisory standard: warns (never blocks) when a branch
still carries unrendered template markers, so a citizen that never customized
its scaffold no longer fails silently. Adds template_content.py + template.md
standard doc + test_template_check.py.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EccxENcB3KtyT9XuT4ybPz
2026-07-01 06:11:51 -07:00
AIOSAI f6cbe34b61 feat(bridge): DPLAN-0226 unified TG<->CC bridge — CC-native session discovery, live-proven round-trip (FPLAN-0290/0291/0292) 2026-07-01 04:33:05 -07:00
AIOSAIandClaude Opus 4.8 91cb59154d fix(e2e): rm_gate block contract is exit 2, not exit 0 (FPLAN-0289 CI)
beb048d made the Claude bridge propagate a hook's exit code so presence_gate's
UserPromptSubmit block can cancel a prompt. Every security gate
(rm/git/edit/subagent/presence) already returned exit_code 2 for a block, but
the old bridge swallowed it — so test_t2a_rm_gate_blocks pinned exit 0. Update
the e2e contract to expect exit 2 + the stdout decision JSON, which is the real,
live-proven block signal.

Sole CI red on the P1-activation commits: 1 failed, 10116 passed. Fixes both
e2e-wheel (all 3 OSes) and Windows Test (full suite includes tests/e2e).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GmDj4eu8aFFVP2rapovqkg
2026-06-30 04:36:01 -07:00
AIOSAIandClaude Opus 4.8 dc5c1d23fc fix(hooks): presence keys the persistent claude session PID, not the ephemeral hook PID (FPLAN-0289 P1)
Final activation fix. The gate recorded os.getpid(), but the hook runs as a
short-lived subprocess (python3 -> sh -> claude) that dies in milliseconds, so
every later session saw the prior holder's PID as dead, reclaimed it, and never
blocked. claim()/release() now resolve the owning session via _resolve_session_pid():
walk the /proc parent chain (PPid from /proc/<pid>/status) up to the comm=claude
ancestor and record THAT pid. Fails OPEN if no claude ancestor (non-Linux, or an
unexpected process tree). handle_stop() is now a no-op: Stop fires every assistant
turn, so releasing there would free the slot mid-session; stale-detection (the
claude pid going away) reclaims on real exit instead.

PROVEN LIVE — real two-session interactive test (the unit blind spot that a
long-lived-holder harness masks):
  session 1 in branch X resolves chain 731814:python3 -> 731813:sh -> 730933:claude,
    records pid 730933 (comm=claude, cwd=X); work_dir=X, cwd_match True.
  session 2 in branch X resolves its own claude pid, sees X occupied by live
    730933, and Claude Code blocks the prompt in the UI:
    "UserPromptSubmit operation blocked by hook: ztest... already live at PID 730933
     - attach, do not spawn."
  session 2 did NOT clobber session 1; a different branch is unaffected.
Added 9 tests modelling the ephemeral-PID lifecycle (54 presence tests total);
seedgo @hooks 100%.

Activation is a machine-local provider-settings change (presence_gate wired first
in ~/.claude/settings.json UserPromptSubmit) — not tracked in the repo; the code
landing here is what makes it correct.

Design: DPLAN-0225 / FPLAN-0289 P1. Build by @hooks.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CqoxFdbDMirzkQ5kjRVVos
2026-06-29 18:38:02 -07:00
AIOSAIandClaude Opus 4.8 beb048dadf fix(hooks): presence_gate keys per-branch via hook_data cwd; engine propagates block exit code (FPLAN-0289 P1)
Activation fixes for the single-session presence gate. Two bugs blocked it,
both caught by live testing after all units were green:

1) Wrong branch key. presence_gate used Path.cwd().name, but under the Claude
   Code bridge the hook process cwd is the project root, so every session keyed
   to "AIPass": the gate never enforced one-live-session-per-branch and would
   have rejected sessions project-globally (any 2nd interactive session in any
   branch). Now _resolve_branch(hook_data) reads the event payload's cwd (the
   real session dir) and walks up to the branch root (.trinity/ or apps/),
   mirroring branch_loader. Applied in handle() and handle_stop().

2) Block never reached Claude Code. engine.dispatch() returned only stdout, so
   the bridge could not surface a non-zero exit. dispatch() now returns
   (stdout, exit_code) and the bridge exits with it on a block. Pre-existing gap
   affecting every block hook on every event; now fixed engine-wide. An
   intentional block (exit 2 + {"decision":"block"}) propagates; a crashing hook
   (exit 2, non-JSON stdout) is logged and falls through, so the gate fails open.

Proven: 110 hooks unit tests pass (6 new for branch resolution); seedgo @hooks
100%, no type errors. Live bridge end-to-end (real live holder + real bridge):
duplicate into a held branch -> exit 2 + block reason naming the branch; a
different free branch -> exit 0 (per-branch isolation intact). Gate remains
dormant: not yet wired into provider settings.

Design: DPLAN-0225 / FPLAN-0289 P1 activation. Build by @hooks.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CqoxFdbDMirzkQ5kjRVVos
2026-06-29 17:46:09 -07:00
AIOSAIandClaude Opus 4.8 8d775b4bd2 feat(skills): TG bot follows PRESENCE pointer, retire legacy own-spawn (FPLAN-0289 P2)
The Telegram bot becomes a thin durable relay: it follows the live Claude session
via .ai_central/PRESENCE.central.json and never starts its own brain.
ensure_tmux_session resolves in 3 strategies (central pointer -> shared_session
config -> already-running own tmux), re-binding to the live session on every message
(handover-safe). The legacy AIPASS_SESSION_TYPE=telegram own-session spawn is retired:
replaced with a clear "no live session to mirror" error; an absent/stale pointer falls
back gracefully and never starts a session. on_session_create (which injected "hi"
after self-start) removed as obsolete -- attaching to a live session injects nothing.

New helpers: _find_presence_file, _read_presence_pointer (PID-liveness via os.kill),
_find_tmux_for_presence (attach_handle preferred, tmux-CWD-scan fallback).

601 TG + 252 skills tests pass; seedgo Unused_Function 100% (overall 99%; residual is
a pre-existing Json_Handler item in unrelated modules). Live mirror proof to follow.
Design: DPLAN-0225 / FPLAN-0289 P2. Build by @skills.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GFihce1oLtp6UDAPGryYSv
2026-06-29 14:54:50 -07:00
AIOSAIandClaude Opus 4.8 13983b614a fix(hooks): presence tests cross-platform — patch _presence_lock not fcntl (FPLAN-0289 P1)
Windows CI was red on f460cd5: the patch_flock fixture patched presence.fcntl,
which only exists on POSIX (msvcrt on win32), erroring all 16 presence-test
setups. Now patches the platform-agnostic _presence_lock context manager
(-> nullcontext per call) and skips the inherently-POSIX flock-acquire test on
win32. Dormant prod code unchanged.

705 tests pass, seedgo 100%. Fix by @hooks.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GFihce1oLtp6UDAPGryYSv
2026-06-29 14:16:02 -07:00
AIOSAIandClaude Opus 4.8 f460cd577e feat(hooks): presence service + single-session gate, dormant (FPLAN-0289 P1)
One live Claude runtime per branch. presence.py manages .ai_central/PRESENCE.central.json
(claim/release/refresh, PID + /proc/cwd liveness, stale-reclaim, PID-guarded release so a
non-holder can never release the holder). presence_gate.py: UserPromptSubmit blocks a
duplicate (exit 2 + decision:block), Stop releases; skips sub-agents + dispatched/daemon.

SessionStart can't block in Claude Code (inject-only) → gate is UserPromptSubmit, like the
edit/git gates. NOT wired into hooks.json yet — dormant, zero behavior change until enabled.

705 tests pass, seedgo 100%. Live cross-process block + PID-guard verified (devpulse).
Design: DPLAN-0225. Next: P2 telegram relay follows the pointer (@skills).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GFihce1oLtp6UDAPGryYSv
2026-06-29 13:51:48 -07:00
AIPass 90157ed29e Merge pull request #647 from AIOSAI/dependabot/github_actions/actions/setup-python-6.3.0
ci(deps): bump actions/setup-python from 6.2.0 to 6.3.0
2026-06-29 10:58:32 -07:00
AIOSAI 2217b96054 fix(skills): Windows CI — mirror transcript slug strips backslashes; tests drop platform tricks (TDPLAN-0009)
base_bot.py _resolve_active_transcript: slug replaces both backslash and / (Windows work_dir paths left backslashes → wrong projects_dir; POSIX no-op). test_mirror_session.py: slug matches production + mkdir exist_ok=True (dir pre-created on Windows → WinError183). test_monitor.py: mock _save_monitor_subscription→False instead of /dev/null OSError trick. 578 TG + 252 skills green on Linux; Windows-safe by construction. Fix by @skills, verified by devpulse.
2026-06-29 10:46:54 -07:00
AIOSAI bd57573764 fix(seedgo): audit always ignores .archive/ — full stop (Patrick directive)
readme_check.py: _count_test_functions now skips any path with a SOURCE_SKIP_DIRS segment (.archive) — root cause of the local-vs-CI test-count mismatch (daemon counted 486 local incl archived dead tests vs 300 in CI clean checkout). test_quality_check.py: _find_test_files_broad replaced __pycache__-only skip with _should_skip_dir() on all path parts. Daemon 486→300, audit 100%, 17-branch audit zero regressions. CI-neutral (clean checkout has no .archive). Fix by @seedgo, verified by devpulse.
2026-06-29 10:30:37 -07:00
AIOSAI 8d2dcdcc77 fix(daemon): README test count 486→300 (live count; 486 wrongly included .archive dead tests)
CI's clean checkout counts 300 live tests (matches pytest); README claimed 486 because the count included 6 archived dead-test files under tests/.archive/ (186 tests). 300 is the true live/CI count. Root-cause framework fix (audit must always ignore .archive) dispatched to @seedgo separately.
2026-06-29 10:17:20 -07:00
AIOSAI 3d66e8397b fix(daemon): seedgo 100% — archive dead cron orphans, queue introspection bypass, exception-contract test, README count (TDPLAN-0008)
Diagnostics 65%→100%: archived dead orphans scheduler_cron.py + modules/scheduler_ops.py (+ their test_scheduler_cron.py) — old cron scheduler superseded by queue/run_tick (S254), imported only by already-archived files; cleared 7 pyright unresolved-import errors. Introspection 98%→100%: bypass queue.py (td-47 — bare invocation renders operational Rich table). Test_quality 98%→100%: added test_invalid_mode_raises. README count fixed. Cleaned 6 stale bypass entries. Audit @daemon=100% (38 standards), 300 tests green. Fix by @daemon, verified by devpulse.
2026-06-29 10:00:07 -07:00
AIOSAI 9e988a63b3 fix(daemon): CI green — .archive-existence tests → import-path assertions; bare 'queue' renders Rich table (TDPLAN-0008, td-47)
test_scheduler_bot.py: replaced test_data_files_archived + test_handler_files_archived (asserted gitignored .archive paths → failed in CI clean checkout) with test_task_registry_not_importable + test_actions_registry_not_importable (assert ImportError — env-independent). queue.py: bare 'drone @daemon queue' now renders the Rich table instead of print_introspection (matches --help). 24 scheduler_bot tests green. Fix by @daemon, verified by devpulse.
2026-06-29 09:37:43 -07:00
AIOSAI 88e99efe4c feat(skills,hooks): TDPLAN-0009 Telegram session mirror — bidirectional, live-proven @api
@skills: dup-spawn fix (run() lock-collision exit 0), attach_only + launch_mirror_session (--dangerously-skip-permissions), _config_chat_id init bug + /proc active-transcript baseline, systemctl start. @hooks: extract_mirror_turn cursor clamp + baseline reset on delivery, mirror-file unlink guards. +4 test files. 578 skills / 112 hooks green.
2026-06-29 08:53:03 -07:00
dependabot[bot] aea90da5c6 ci(deps): bump actions/setup-python from 6.2.0 to 6.3.0
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.2.0 to 6.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/a309ff8b426b58ec0e2a45f0f869d46889d02405...ece7cb06caefa5fff74198d8649806c4678c61a1)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-27 08:02:22 +00:00
AIOSAI 4363f9824a fix(skills): SchedulerBot.run() crash-looped on real ExecStart — wrap super().run() (TDPLAN-0008)
- run() called a non-existent self._poll_loop() AND duplicated the parent lifecycle incompletely (missing signal handlers, offset load/save) — bot exited 1 in <1s under systemd. Now wraps super().run() with digest start/stop only.
- Fixed broken 'from .json import json_handler' (relative path did not exist) → absolute import; log queue_requested op so json_structure standard is met by use, not noqa
- Added missing docstrings: handle_message / handle_file / get_custom_commands
- ROOT CAUSE: 26 unit tests never executed run() (it blocks on polling) → green tests, failing ExecStart (key-learning #77: test the real ExecStart, not the drone/mocked form). Verified live: bot now active+polling via systemd, 26 tests + seedgo 30 still green.
2026-06-25 17:04:31 -07:00
AIOSAI d252403d37 feat(skills): Scheduler Bot Phase 2 — dedicated bot /queue + hourly digest (TDPLAN-0008)
- SchedulerBot(BaseBot): rejects free-text (NO tmux/Claude spawn), /queue shells 'drone @daemon queue --json', hourly digest thread, chunked output
- base_bot __main__: _BOT_CLASSES maps bot_id->SchedulerBot for systemd launch; passes config chat_id for digest target
- bot registered (telegram-bot@scheduler), systemd unit installed (NOT started)
- 26 new tests (519 telegram / 252 skills green), seedgo 99%

fix(daemon): queue --json emits valid JSON at module level — flatten prompt_preview (collapse newlines) + soft_wrap/markup off. Verified valid via 'python -m'. NOTE: the drone router still re-wraps sub-command stdout at width 80, corrupting machine --json for ALL consumers routed through drone (separate @drone core bug; skills mitigates with strict=False JSON parse).
2026-06-25 16:56:56 -07:00
AIOSAI b51ac87eb7 feat(daemon): Scheduler Bot Phase 1 — unified queue + status capture + lifecycle telegram pings (TDPLAN-0008)
- One queue: archive dormant task_registry + actions_registry (+5 tests) to .archive/, retire schedule/actions CLIs; .daemon/schedule.json is now the single source
- Status capture: runstate gains last_status/last_error/last_success_at/last_failure_at; persisted on success AND failure paths (was success-only)
- Unified view: drone @daemon queue + --json (frozen schema), aggregates .daemon/*.json joined to runstate
- Lifecycle pings: un-archived telegram_notifier wired to @skills send_telegram_notification (fail-soft, per-job notify flag, zero calls on empty ticks)
- 24 new tests (327 pass), seedgo 98%; verified live end-to-end (queue --json schema + real telegram delivery via daemon wrapper)
2026-06-25 16:36:10 -07:00
AIOSAI 1d3094acee fix(ai_mail): escape systemd cgroup for daemonized wakes (td-48) 2026-06-25 08:15:37 -07:00
AIOSAI 5b7fa2d4ad docs(daemon): self-sufficient run --help (schema/types/example) + README scheduling section (FPLAN-0287) 2026-06-25 07:10:49 -07:00
AIOSAI f832a558cd feat(daemon): systemd user timer auto-runner — decentralized scheduler fires hands-off (FPLAN-0287) 2026-06-25 06:31:05 -07:00
AIOSAI a777251ab7 fix(skills): bypass telegram ported-but-unwired fns (seedgo-audit) + document
DPLAN-0218 pulled telegram into the seedgo gate, surfacing 16 unused_function
flags across 8 handlers. They are ported-but-unwired (S249), not dead — pending
DPLAN-0220 wiring. Added name-scoped unused_function bypasses citing DPLAN-0220,
documented each in SKILL.md -> Ported-but-unwired (remove bypass as wired).
@skills 100%.
2026-06-25 04:17:19 -07:00
AIOSAI 1794c8f954 fix(spawn): use json_handler.read_json for passport in adopt path
core.py adopt-path read the passport via json.loads(read_text()) — a direct
file op that fails the json_handler standard and the CI seedgo-audit gate.
Switch to json_handler.read_json() (matches the pattern ~90 lines above),
drop the now-unused 'import json as _json'. @spawn 100%; 315 spawn tests green.
2026-06-25 04:01:50 -07:00
AIOSAI 7e9c0cfca7 fix(telegram): make Windows-unmasked tests cross-platform
Guarding the fcntl import let Windows collection succeed, which surfaced 3
telegram tests that had never run on Windows — all test-portability bugs:
- log_streamer byte-count broke on CRLF -> fixture writes newline=''
- bot_registry write-failure used Unix-only /proc -> file-as-parent (all OS)
- validate_bot_config rejected POSIX work_dir on Windows (Path.is_absolute is
  host-dependent) -> test absoluteness under PurePosixPath OR PureWindowsPath
493 telegram tests green on Linux; ruff clean.
2026-06-25 03:44:26 -07:00
AIOSAI ec6e966137 fix(telegram): guard fcntl import for Windows — unblock CI test collection
bot_registry did a bare 'import fcntl' (POSIX-only); on Windows the 8
telegram test modules importing it failed at collection (ModuleNotFoundError),
reddening Windows Test on recent PRs. Guard the import and route flock calls
through no-op-on-Windows _lock/_unlock helpers. 246 telegram tests green.
2026-06-25 03:18:58 -07:00
AIOSAI fbf102c636 feat(memory,spawn): self-documenting .trinity state-tabs + todo delete-on-done discipline
- .trinity sections carry config-sourced rollover/keep/char-cap tabs; @memory owns
  values (render_all_meta_tabs), @spawn resolves placeholders at create via spawn_pusher
- todos confirmed rollover-exempt; vestigial rollover-config entry removed
- prep/memo/startup (Claude+Codex): delete finished todos, don't leave status:done
- @memory README documents the system
- FPLAN-0285, FPLAN-0286
2026-06-25 03:00:36 -07:00
AIOSAI be8f87d6fb feat(prax): monitor→Telegram relay (prax_monitor bot) + fix service feedback loop
Mirrors the live 'drone @prax monitor run' Mission-Control feed to a dedicated
Telegram bot (DPLAN-0221). New monitoring/telegram_relay.py taps _render_event,
batches every 5s (4000-split, 150 flood-cap, fail-silent-once), gated by
--relay/env so local monitor stays console-only. Reboot-survivable
prax-monitor.service. 937 prax tests green (31 new).

Deploy fixes (devpulse): ExecStart -> 'monitor run' (module __main__ rejects
'run all --relay'); service log moved out of system_logs/ to ~/.aipass/ to break
a monitor<->@trigger feedback loop.
2026-06-25 00:10:06 -07:00
AIOSAI 97b884bef7 feat(skills): prax-monitor v1 on Telegram — /monitor system-wide log subscription
Revives the old prax-monitor capability as a feature of the existing
@aipass bot (no 2nd bot, no new credential). /monitor on|all|off|status
on base_bot; subscribed chat persisted to @api (survives restart) and
boot-started on startup. LogStreamer gains system_wide glob + level_filter
(default WARNING/ERROR/CRITICAL, all=passthrough). 33 new tests,
telegram 493/493, skills 252/252, seedgo 98%.

Route B (true AS-WAS @prax event-feed relay) tracked separately.

DPLAN-0221
2026-06-24 20:48:17 -07:00
AIOSAI d41ecd9877 fix(skills,ops): deploy @aipass telegram bot under systemd + fix unit log path
The ported telegram-bot@.service logged to a non-existent ~/system_logs
(would crash-loop the service); point StandardOutput/StandardError at
<repo>/system_logs where the app already logs. Then installed the unit,
enable --now + loginctl enable-linger so the @aipass mother-bot runs as a
proper user service with reboot survival and a one-line restart. Startup
log confirms: Telegram API OK, Command menu set (6 commands), poll loop,
tmux session preserved, NRestarts=0.

DPLAN-0220
2026-06-24 17:28:44 -07:00
AIOSAIandClaude Opus 4.8 bf301bc231 feat(telegram): /help + command menu — startup populate, single source, enriched (DPLAN-0220)
Resolves the build_botfather_commands design call (Patrick: KEEP, not delete).

POPULATE: base_bot sets its Telegram command menu on startup (setMyCommands)
after verify_connection, so every bot — base or minted — gets a populated
slash-menu, not just create_bot'd ones (the live @aipass was hand-launched
and had none).

SYNC: build_botfather_commands (telegram_standards) is now the single source
feeding base_bot-startup AND create_bot; DEFAULT_BOT_COMMANDS retired. The
Telegram menu and /help list the same commands incl. /create + /cancel.

ENRICH: friendlier command descriptions + /help intro/footer.

Wiring the builder (vs deleting it as 'dead') lifted Unused_Function 92->93%.
6 new tests (menu==help sync, enriched copy, startup-menu, custom cmds);
telegram 460/460, skills 252/252. Running bots need a restart to pick up the
startup menu.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 16:59:07 -07:00
AIOSAIandClaude Opus 4.8 9af4c8ac05 feat(telegram): close GAP1 — create_bot persists config to @api so minted bots start (DPLAN-0220)
bot_factory.create_bot now calls set_secret('telegram', bot_id, config,
as_json=True) right after building the config (fail-loud on OSError), so a
newly-minted bot's token reaches the @api store that load_bot_config reads.
The disk write is downgraded to a non-fatal shadow; registry now records
bot_token_ref='@api:telegram/{id}' (TG-LIFE-069).

Proven: new TestCreateBotRoundTrip — create_bot -> @api -> load_bot_config
returns the persisted config; + a fail-loud test (set_secret OSError ->
create_bot returns None). Telegram 454/454, skills 252/252.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 16:49:06 -07:00
AIOSAIandClaude Opus 4.8 0096aef1d2 feat(telegram): port wave-1 fixes + @api set_secret write-door (DPLAN-0220)
Surfaced by a full completeness audit of the telegram skill against
TELEGRAM_PORT_MAP.md (366 tags, ~83% ported, 452/452 tests green).

@api — in-process set_secret(provider, slug, value, *, as_json) writer
mirroring get_secret (0o600 files / 0o700 dirs, no stdout echo). The store
was read-only; this is the GAP1 enabler the telegram mother-bot needs to
persist a created bot's config. 515 @api tests, seedgo 100%.

@skills telegram wave-1 (fix-forward, no deletions):
- GAP2: bot_factory + telegram-bot@.service launched a non-existent
  ~/.venv/bin/python3; now sys.executable -m ...base_bot (+ lib/__init__.py
  and lib/telegram/__init__.py for package resolution).
- Reboot survival: enable_service now installs the unit to
  ~/.config/systemd/user/ + daemon-reload (was never installed).
- GAP9: gitignore lib/telegram/.local/ so runtime state stops leaking to git.
- prax-monitor: log_streamer now resolves repo-root system_logs (honoring
  AIPASS_TEST_LOG_DIR) instead of a hardcoded ~/system_logs.

Verified: telegram 452/452 green (twice), base_bot imports via -m.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 16:39:08 -07:00
AIOSAI 882da7cdfc refactor(skills): relocate skill library to src/aipass/skills/lib/ — rename catalog/, move telegram in, archive orphan fixtures, retire .aipass/skills/
Unifies all 6 first-party skills under lib/ (built-in tier). Fixes telegram not
being cross-branch discoverable (was in cwd-relative .aipass/skills/). Built-in
discovery path catalog->lib; telegram conftest parents[6]->[5]; .service
ExecStart, seedgo bypass + test paths updated. Packaging/imports/gitignore
unaffected (stays under src/aipass). 252/252 tests green, cross-branch discovery
verified. DPLAN-0218.
2026-06-24 14:24:28 -07:00
AIOSAIandClaude Opus 4.8 57767cc2a9 fix(api): render 4 module --help functions in Rich (caught by tightened CLI checker)
The CLI help-checker fix (4d41065) immediately surfaced the same
console.print(parser.format_help()) laundering in 4 @api modules on its first
audit run — exactly the latent stragglers the static-scan loophole had been
hiding. Rewrote each print_help() to hand-rolled Rich markup (content was
already in the argparse epilogs); removed the help-only argparse parsers.

- api_key.py, usage_tracker.py, google_client.py, openrouter_client.py
- @api audit Cli + Overall back to 100% (38/38), 504 tests pass, no bypass

DPLAN-0217 (follow-on).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 12:26:34 -07:00
AIOSAIandClaude Opus 4.8 4d4106505f fix(seedgo,ai_mail): close CLI help-checker loophole + render ai_mail --help in Rich
seedgo's cli/help_text/introspection standards are static source scans — they
confirm a print_help function, console.print, and --help wiring exist, but never
execute --help. So a module could score 100% while rendering raw argparse.
ai_mail did exactly that via console.print(parser.format_help()), laundering
argparse plain text through the approved console API and dodging the existing
parser.print_help() ban.

- seedgo: cli_check now flags .format_help(); cli.md/cli_content.py name it
  alongside print_help(); +2 regression tests (1095 pass, self-audit 100%)
- ai_mail: rewrote print_help() to hand-rolled Rich (737 tests pass); --help now
  renders Rich with no raw argparse, Cli back to 100% legitimately
- behavioral --help check (run it, assert not raw argparse) noted as a follow-up

DPLAN-0217.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 11:58:53 -07:00
AIOSAI 4af5b8bf63 refactor(backup): move .backupignore seed from code to templates/ data file
Backup was the outlier — its default .backupignore content was hardcoded as the
BUILTIN_IGNORES Python list + assembled in _build_backupignore(). Moved it to a
template DATA FILE (backup/templates/backupignore.template), matching the AIPass
convention (flow/spawn/memory all keep templates as files).

- New: templates/backupignore.template (header + patterns, incl logs/).
- _build_backupignore() reads the template via __file__-relative pathlib and
  RAISES FileNotFoundError if it's missing — never silently empty (an empty
  .backupignore = back up everything = crash). Behavior-preserving otherwise.
- Retired BUILTIN_IGNORES (only setup.py consumed it). Runtime load_spec path
  untouched.
- Tests expanded (30 pass): per-pattern template assertions + reads-template +
  raises-on-missing-template. Docs/comments repointed to the template.

seedgo @backup 100%. td-30.
2026-06-24 09:39:51 -07:00
AIOSAI 70cf31eb3e docs(backup): document seed-vs-runtime ignore architecture + add logs/ default
Confirmed (via @backup) the two-layer ignore model and wrote it down so it stops
getting re-discovered:
- BUILTIN_IGNORES (patterns.py) = the SEED that generates a new project's
  .backupignore at register; never consulted at backup time.
- .backupignore (via load_spec) = the runtime source of truth. No static
  fallback exists, so the seed is safety-critical — an empty .backupignore backs
  up everything (.venv, node_modules, .git) and can crash the machine.

Added a 'How Ignores Work' README section + code comments on BUILTIN_IGNORES and
load_spec. Added logs/ to the seed so new projects exclude log dirs (prax .jsonl
output) by default, not just *.log files, with a test. seedgo @backup 100%.

td-27.
2026-06-24 09:21:34 -07:00
AIOSAI 451c8a0ee9 docs: README roster currency (17 agents) + /prep todo-reconciliation step
README: added the 3 missing agents (@daemon, @skills, @commons) to the tree and
tables, normalized the agent count to 17 everywhere (was an inconsistent 13/14).
@daemon -> Quality & operations; new 'Capabilities and community' group for
@skills + @commons (td-28).

/prep: both the Claude command and Codex skill mirror gained a 'Reconcile todos
against reality' step — audit every open todo against the actual system and close
what's verifiably done, catching past-session work that was never closed.

CHANGELOG updated.
2026-06-24 08:48:44 -07:00
AIOSAI c1dba78d31 fix(ai_mail): scope dispatch-footer plan-close to worker's own plan
The standard email footer told dispatched agents 'CLOSE FPLAN -> drone @flow
close <plan_id>', which led them to close the orchestrator's master/parent plan
referenced in their brief (bit us in FPLAN-0260). Reworded to 'CLOSE YOUR PLAN
-> ... this task's plan only, never the master/parent': a worker still closes the
sub-plan handed to it, the master stays the orchestrator's to close on completion.

td-6. Footer string + test assertion; 737 ai_mail tests pass.
2026-06-24 07:21:35 -07:00
AIOSAIandClaude Opus 4.8 d8d2c4f32d docs(memory,flow): cross-ref shared .backup/ namespace + drop stale prax/.backupignore
Completes the backup-docs sweep (td-218):
- @memory README: note rollover writes rollover_backup_*.json to <branch>/.backup/
- @flow README: note closed plans archive to <repo-root>/.backup/processed_plans/
  both cross-referencing @backup's canonical README.
- Removed orphaned src/aipass/prax/.backupignore (prax is not a registered
  backup target; only the AIPass project root is).

seedgo green across all three (@flow 100, @memory 100, @prax 99 = pre-existing
Json_Handler, unrelated).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 07:00:36 -07:00
AIOSAIandClaude Opus 4.8 40602702ef docs(backup): correct backup/.backup/.backupignore docs across the system
Streamlined prompts had drifted from reality. Full-context investigation
(3 agents + @memory storyline) corrected:

- .backup/ documented as a SHARED runtime namespace (3 writers: @backup
  snapshot stores, @memory rollover safety copies, @flow processed_plans),
  not @backup-exclusive.
- @backup README: full 11-command coverage, .backup/ store layout, and a
  .backupignore (gitignore-for-backups: pathspec/gitwildmatch, BUILTIN_IGNORES,
  self-exclusion, ships as config) section.
- @backup branch prompt: stale .backup_system/ -> .backup/ (3x), drive_test.py
  -> drive_check.py (was misleading the agent every turn).
- Root README: @backup added to roster + uninstall covers .backup/.backupignore.
  navmap @backup line corrected (Drive planned + shared namespace).
- Shipped root /.backupignore realigned to BUILTIN_IGNORES (dropped stale
  .backup_system/, removed over-broad *logs).
- Removed dead backup/run/ test dir.

@backup verified: 220 tests green, seedgo 100%. Closes td-218.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 06:51:18 -07:00
AIOSAIandClaude Opus 4.8 c771a22771 chore(trigger): retire dead bulletin_created dashboard writer
The bulletin_created event handler propagated a 'bulletin_board' section into
every branch dashboard, but it was fully dead: nothing fired the event, its
BULLETINS.central.json store no longer exists, and prax already prunes
'bulletin_board' via DEPRECATED_SECTIONS. Archived the handler to
events/.archive/, removed its import + trigger.on() registration, dropped the
5 covering tests (558 pass). seedgo audit 100%. prax pruning left intact.
Closes td-102.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 06:12:31 -07:00
AIOSAIandClaude Opus 4.8 feecd263eb fix(seedgo): name-scope unused_function bypasses (kill silent line-drift)
unused_function bypasses matched by file+line; the line was the function's
def line, so any code shift above it staled the bypass and silently re-flagged
the exempted function, dropping the branch below 100% (S216/S217).

Mechanism: is_bypassed() gains a 'functions' field + name param; name-scoped
match takes precedence, 'lines' kept for back-compat (no other standard
changes). unused_function_check passes the function name. +7 tests (1093),
seedgo self-audit 100%, bypass schema documented.

Migration: converted 10 line-scoped entries to functions: across
drone/memory/skills; removed 3 dead memory/vector_search entries already
pointing past EOF (file is 152 lines). drone/memory/skills re-audit:
Unused_Function 100% (names verified live). Closes td-009.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 05:51:54 -07:00
AIOSAIandClaude Opus 4.8 03c95e6881 fix(seedgo): readme_check honors (disabled) marker in module/test self-scans
readme_check did its own modules/ and tests/ globs that bypassed the
central audit collector, so an in-place foo(disabled).py tripped a false
'missing module' violation and inflated README test counts. Wire
is_disabled_file into both globs (check_module_list, _count_test_functions).
+2 regression tests, 1086 green, self-audit 100%. Closes td-103.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEQZXCtgnF3NQtcttTErpq
2026-06-24 05:21:02 -07:00
AIPass 88cfe8e2e6 Merge pull request #640 from AIOSAI/dev
Post-merge git friction fixes: drone sync FF-only realign + sync_main_ref (no checkout), merge.md/branch-prompt corrected (merge commit not squash), deterministic spawn template registry IDs
2026-06-23 17:16:15 -07:00
AIOSAI 6ffe1d3fca chore(release): bump to v2.6.0 + CHANGELOG release roll-up
Version bump 2.5.3 -> 2.6.0 (MINOR — ships compass v2, daemon scheduler, @backup
restoration, telegram skill, tiered prompts). Bumped in both pyproject.toml and
src/aipass/__init__.py. CHANGELOG top section enriched into a 2.6.0 release
roll-up so the GitHub Release notes read properly. Rides into PR640.
2026-06-23 17:02:47 -07:00
AIOSAI 68d0a23477 docs(devpulse): document compass module + refresh test count (236->282)
README Readme standard was at 75%: compass module/handler undocumented and the
test count had drifted. Added compass to the architecture tree + a Compass
command section, bumped tests 236->282, refreshed the date stamp. devpulse audit
back to 100%.
2026-06-23 16:29:26 -07:00
AIOSAI 6db606eb01 fix(memory,prompts): rollover repair + retire-for-all + seedgo #37 path cleanup
Batch of S243/S244 work held for PR640. Only devpulse has git write, so all
branches' changes (@memory, @prax, @hooks, @aipass, @skills, @flow, @backup,
@seedgo) land through this single commit.

Memory rollover (correctness):
- @hooks rollover hook now delegates to drone @memory rollover check/run — it
  had been reading stale .trinity limits (moved to memory.config.json by
  DPLAN-0210), falling back to a 600-line check that never fired, so rollover was
  silently dead for weeks. compact.py reads the current list schema. Both fail loud.
- @memory removed the v1 line-count/600 fallback entirely — v2-only, fail-loud
  (959 tests).

Retire-for-all (DPLAN-0215):
- Legacy global prompt fully removed across every runtime: global_loader.py +
  tests deleted, hooks.json/project_hooks.json blocks stripped, bootstrap global
  seeding removed, cadence default + bypass cleaned, global .md files archived.
  Codex SessionStart + Claude cadence read the same tier files.

Hardcoded-path cleanup (seedgo #37):
- New HARDCODED_PATH checker (#37). @memory symbolic.py + @prax branch_detector.py
  home paths -> dynamic/generic. Both 100% Hardcoded_Path.
- seedgo provider_hooks_snapshot.json fixture refreshed to the tiered baseline.

Genericization: patrick -> user across tracked source, docs, templates.
CHANGELOG: 2026-06-19 + 2026-06-23 sections added.
2026-06-23 16:17:10 -07:00
AIPass f48db4a374 Merge pull request #645 from AIOSAI/dependabot/github_actions/actions/checkout-7.0.0
ci(deps): bump actions/checkout from 6.0.3 to 7.0.0
2026-06-21 01:19:32 -07:00
dependabot[bot] ef5ae933d0 ci(deps): bump actions/checkout from 6.0.3 to 7.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/df4cb1c069e1874edd31b4311f1884172cec0e10...9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-20 08:02:50 +00:00
AIOSAI 4cd68a78b6 docs(changelog): 2026-06-18 — tiered prompt injection + prompt-craft steals (FPLAN-0284, DPLAN-0213/0214) 2026-06-18 18:05:27 -07:00
AIOSAI 6d1413cd5c feat(hooks): seed fresh-clone tier wiring across all 3 layers (FPLAN-0284 P5)
Closes the deployment gap — cadence_config.json + the settings.json bridge are machine-local (gitignored), so fresh clones needed the tiered wiring seeded from committed sources:
- cadence.py DEFAULTS (keystone): adds tier0(period 1) + navmap(period 5) to the code fallback, so a fresh clone with no cadence_config.json gets tiered cadence automatically (was defaulting tier0 to period 5).
- setup.sh: fresh-install bridge seed now emits tier0_kernel + navmap, drops global_prompt.
- provider_manifest.json: doctor update path adds the tiered entries on existing machines, drops global_prompt.

Convergence: the committed hooks.json (global_prompt enabled:false) means even a stale settings.json with a global bridge is skipped by the engine. 615/615 tests (1 new: test_defaults_include_tiered_loaders), seedgo 100%.
2026-06-18 18:01:56 -07:00
AIOSAI 81f55665e4 feat(skills): frontmatter discipline — when_to_use triggers + per-step success criteria (FPLAN-0284 P5/D2, DPLAN-0213)
Harvested from Claude Code's skill-authoring spec:
- when_to_use frontmatter field (trigger phrases) on all 3 SKILL.md templates + github catalog exemplar; discovery scan surfaces it so agents see triggers without loading the full body.
- Per-step 'Done when:' success criteria in the Steps section.
- 'Use when / Do NOT use when' structure in the When to Use section.

252/252 tests pass.
2026-06-18 17:57:54 -07:00
AIOSAI 2c91f79f2f feat(hooks): tiered prompt injection — Tier 0 kernel + Tier 1 navmap by cadence (FPLAN-0284 P2-P4, DPLAN-0214)
Replaces the single 8k always-injected global prompt with cadence-tiered injection:
- Tier 0 (.aipass/tier0_kernel.md, ~2k) injects EVERY turn — identity grounding, the drone --help reflex, disaster-preventer rules. Folds DPLAN-0213 C1 (faithful-reporting) + C2 (no-gold-plating sub-agent brief).
- Tier 1 (.aipass/tier1_navmap.md, ~7.7k) injects every 5th turn + session-start + post-compaction — full agent roster, framework, conventions, plus a new Terminology section migrated from the S211 backup.
- Old global_prompt loader retired (disabled in hooks.json, removed from cadence wiring); aipass_global_prompt.md kept as a reference snapshot.

Engine (built by @hooks): per-loader period in cadence.py should_fire() (back-compatible: unset period falls back to global); new tier0_kernel + navmap handlers; bypass.json extended to cover the two new dynamically-dispatched handlers. 614/614 tests pass, seedgo @hooks 100%.

Live-verified: tier0 fires every turn, navmap on turn 0/5/10, turn counter advances once per turn (not per loader), no double-injection. Machine-local wiring (cadence_config.json, ~/.claude/settings.json bridge) updated on this host; fresh-clone seeding of those is a tracked follow-up.

PROMPT_STYLE.md reference updated to point at the tier files as canonical examples.
2026-06-18 17:48:35 -07:00
AIOSAI b698dd8ce0 style(prompts): CC prompt-craft steals + cleaned S241 prompts (DPLAN-0213 A/B, FPLAN-0284 P1)
- PROMPT_STYLE.md: new 'Writing voice' section (file_path:line refs, no-colon-before-tool-call, no emojis, write-for-a-person, three-tier where-detail-lives) — harvested from Claude Code's own prompt
- devpulse local: blast-radius habit before any drone write-op (reversibility + scope)
- global + devpulse-local: S241 whitespace/structure cleanup (readable English restored)
2026-06-18 17:13:18 -07:00
AIOSAIandClaude Opus 4.8 ac1119de45 docs(compass): add 'compass vs @memory when-to-use' to devpulse local prompt (P5, DPLAN-0212)
Compass guidance now lives in the public local prompt (compass is public). Recall
-> @memory; decide/fork -> compass query; good/bad decision -> compass add;
Patrick fires /compass. Old gitignored private_prompt injection now redundant.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 13:59:44 -07:00
AIOSAIandClaude Opus 4.8 3274ebe840 feat(compass): /compass slash command — human-triggered decision capture (DPLAN-0212)
Patrick fires /compass <rating> <note>; the model composes the decision text from
conversation context and stores via drone @devpulse compass add --source patrick.
The human-triggered answer to the 'noticing' problem. P4 (rate/archive/review)
already covered by P1+P2 — verified live (re-rate, archive-as-avoid-list, review
stamp, archived excluded from query).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 03:04:03 -07:00
AIOSAIandClaude Opus 4.8 0d042dcb2f feat(devpulse): compass v2 P2 — drone @devpulse compass command (DPLAN-0212)
Thin command layer over the P1 storage core: add/query/stats/rate/archive/review
via drone @devpulse compass. Ratings shown in query output ([GOOD]/[BAD]/...),
--db flag for testing, auto-discovered (no devpulse.py change). 18 cmd tests,
seedgo 29/29, no regressions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 03:01:29 -07:00
AIOSAIandClaude Opus 4.8 0df8fee947 feat(devpulse): compass v2 P1 — SQLite/FTS5 rated decision store (DPLAN-0212)
Storage core for devpulse-owned Compass: decisions table + FTS5 BM25 search,
ratings (good/bad/impressive/interesting), add/query/stats/rate/archive/review.
Stdlib sqlite3 only, branch-root-relative DB path, fail-loud validation.
DB path gitignored (private decision data). 26 tests, seedgo 29/29.
Fresh start, no migration. Navigator burial + public-ize deferred.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 02:49:57 -07:00
AIOSAIandClaude Opus 4.8 16848daf54 docs(prompts): complete agent list in global, trim+restyle devpulse local, smooth culture doc
Add @skills/@daemon/@commons/@backup to global prompt agent list; trim+restyle
devpulse local prompt to PROMPT_STYLE (single # headers, no emphasis, de-dup vs
global); smooth .claude culture doc (kill repeats, drop mechanical overlap).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 02:49:45 -07:00
AIOSAIandClaude Opus 4.8 669eb8753f docs(changelog): add 2026-06-16 — secrets hardening (DPLAN-0211) + dispatch_monitor PID-429 fix
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 00:29:55 -07:00
AIOSAIandClaude Opus 4.8 b3e1e46b54 fix(ai_mail): dispatch_monitor — strip monitor framing lines from rate-limit scan
A PID containing "429" (e.g. 14290) in the monitor's own header line was
substring-matched as an HTTP 429, mislabeling sandbox-abort (-4) bounces as
"API rate limit" and flaking test_sandbox_failure_sends_bounce in push CI.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 00:09:30 -07:00
AIOSAIandClaude Opus 4.8 a75910a4e6 fix(api,skills): harden secrets door — no secret value to stdout (DPLAN-0211, clears CodeQL #86-88)
PR #640's only failing required check was Code scanning/CodeQL: 3 HIGH
py/clear-text-logging-sensitive-data alerts where get-secret printed raw secret
values to stdout. Research (OWASP, CodeQL rule source, secret-CLI survey)
confirmed a real exposure — acute for AIPass since it runs inside Claude Code,
which captures command stdout into model context, and the telegram skill
shelled out to get-secret and parsed the token from stdout.

@api (P1):
- NEW apps/modules/secrets.py — in-process cross-branch door (get_secret,
  list_secrets) wrapping the auth handler; consumers import this, not the CLI.
- get_secret_cmd rewritten: masked summary by default ('slug: set (N chars)'),
  --out FILE writes the raw value 0o600 and prints only the path, --list shows
  slug names via console.print. All 3 raw-value print() sinks removed.
- bypass.json reasoning + README + help updated.

@skills (P2):
- telegram config._get_secret / list_bot_configs rewired from subprocess+stdout
  parse to the in-process aipass.api.apps.modules.secrets API; subprocess/json
  imports dropped. Tests + SKILL.md updated.

Also: seedgo test_checkers_batch2.py — comment the synthetic sk-or-v1 fixture
keys as FAKE (not real credentials).

Verified: @api 504 tests + seedgo 100%; telegram 452/452; skills 252/252; no
secret reaches stdout by any path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 23:45:46 -07:00
AIOSAIandClaude Opus 4.8 c8ae084f54 fix(skills): green telegram skill tests (telethon stub) + pyright pytest resolution
- telegram skill: register a minimal telethon sys.modules stub in the test
  conftest so botfather_client tests (which patch telethon.*) run without the
  optional MTProto library installed. Fixes 7 ModuleNotFoundError failures;
  telegram suite now 452/452 green.
- pyrightconfig.json: add the root .venv site-packages to extraPaths (has
  pytest + project deps) alongside memory's venv, so the @hooks auto_fix
  pyright check stops emitting false 'Import pytest could not be resolved' on
  every test file. CI does not run pyright; this is local-DX only.

Both CI-safe: telegram tests live under .aipass/ (excluded from umbrella
pytest) and pyright is not a CI gate, so PR #640 stays green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 21:55:58 -07:00
AIOSAIandClaude Opus 4.8 8ad4de11eb test(api,daemon,skills): skipif(win32) for Linux-only tests (green CI Windows)
Once the collection-level blockers were fixed, the Windows runner finally ran the
suite and surfaced 7 pre-existing failures — all tests asserting Linux-only
behavior, while the production code already handles non-Linux gracefully:

- api test_secrets: chmod(0o000) can't make a file unreadable to its owner on
  Windows (the 'unreadable -> None' precondition is unreachable)
- daemon test_scheduler_cron: patches fcntl.flock; fcntl is None on Windows
  (scheduler_cron already skips locking on non-Unix)
- skills test_runner: system_status memory/uptime/processes/summary read Linux
  /proc (skill returns a graceful error on Windows; disk test stays, it's portable)

Guard each with @pytest.mark.skipif(sys.platform == 'win32', reason=...). 68
tests pass on Linux, ruff clean, api+daemon audit 100%.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 20:45:25 -07:00
AIOSAIandClaude Opus 4.8 d94336d783 fix(seedgo): skip gitignored 'tools' runtime dir in readme-currency (green CI)
The CI Linux seedgo-audit step failed: commons + daemon at 99%, readme 87%
('Directories in tree not found on disk: tools'). Their READMEs document tools/,
a gitignored branch-local runtime dir (like logs/, dropbox/) absent in CI's
tracked-only checkout. The readme-currency skip-list already covered logs/dropbox
but missed tools.

- Add 'tools' to the readme-currency runtime-dir skip set (readme_check.py)
- Test coverage in test_readme_content_checks.py

Verified: commons + daemon readme 100% (was 87%), overall 100% (was 99%);
seedgo self-audit 100%, 1060 seedgo tests pass. Work by @seedgo (FPLAN dispatch).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 20:45:08 -07:00
AIOSAIandClaude Opus 4.8 634ffa853f fix(ci): restore pytest dot-dir exclusion (norecursedirs '.*') — green CI
The custom norecursedirs in pyproject dropped pytest's default '.*' pattern, so
pytest recursed into .aipass/ scaffolding. The telegram skill bundled at
src/aipass/skills/.aipass/skills/telegram/tests/ (with __init__.py) made its
conftest resolve to module 'tests.conftest', colliding with branch tests/
conftest.py -> ImportPathMismatchError aborted collection on BOTH Linux CI and
Windows (the sole remaining green-CI blocker after the guard fix).

- Re-add '.*' to norecursedirs (skips .aipass/.trinity/.seedgo/... scaffolding)
- Verified: full src collection 9540 tests, no ImportPathMismatch; only the
  telegram .aipass scaffold tests excluded (the single tracked test dir under
  any dot-dir), all real branch tests still collected

Note: the telegram skill's bundled tests (7 failing locally) are out of umbrella
CI; skills owns stabilizing + properly integrating them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 20:04:40 -07:00
AIOSAIandClaude Opus 4.8 6aabc8bfe6 fix(commons,daemon,skills): Windows-compat handler import guard (green CI)
The cross-branch import guard's same-branch check used a POSIX-only path test,
so on Windows (backslash paths) it failed to recognize a branch importing its
OWN handlers -> ImportError at collection, failing all commons + 2 daemon tests
on the Windows CI runner. (Unmasked once the pathspec fix let collection proceed.)

- commons: '/commons/' substring -> 'commons' in Path(caller_file).parts
- daemon + skills: add .replace('\\','/') before the check (matches the idiom
  already used by 15 other branches' guards)
- Convert AIPASS_DEBUG_GUARD debug print() -> sys.stderr.write (cli standard;
  avoids import-time logger dependency inside the guard)

Security semantics unchanged: same-branch allowed, cross-branch still blocked
(verified cross-platform). commons+daemon audit 100%, 700 daemon+skills tests
pass, commons 449 tests pass. (skills local 99% = untracked skills_json orphans,
not in CI.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 19:52:31 -07:00
AIOSAIandClaude Opus 4.8 95a2d1a254 fix(seedgo): skip *(disabled) files in audits like .archive/ dirs (td-103)
Disabled files (AIPass convention: rename name(disabled).py instead of delete)
are intentionally-parked inert code, but seedgo audited them as live source —
ai_mail's dashboard_sync(disabled).py dragged it to 99%, blocking green CI.

- Add is_disabled_file() + DISABLED_FILE_MARKER to skip_dirs.py (single source
  of truth alongside SOURCE_SKIP_DIRS)
- Apply in branch_audit, dead_code, unused_function, test_quality checkers +
  test_map function_scanner + checklist directory mode
- New test in test_coverage_audit.py

Verified: ai_mail 99->100%, seedgo self-audit 100%, 1060 seedgo tests pass,
@cli/@flow unchanged at 100%.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 19:33:07 -07:00
AIOSAIandClaude Opus 4.8 a231c7d26e fix(commons): track artifacts subsystem swallowed by blanket gitignore
The commons craft/trade/capsule subsystem lives at apps/handlers/artifacts/
but the blanket 'artifacts/' ignore (meant for branch-local runtime dirs)
silently excluded it from git. The tracked test_artifacts.py imports it, so
CI hit ImportError at collection while local passed (files present locally).

- Add *.py-scoped negation in .gitignore (keeps logs/ + __pycache__ ignored)
- Track artifact_ops.py, trade_ops.py, capsule_ops.py, __init__.py
- 19 test_artifacts.py tests pass; imports resolve

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 19:10:26 -07:00
AIOSAIandClaude Opus 4.8 010cade60f fix(backup): declare pathspec dep + rename drive_test->drive_check for green CI
- Add pathspec>=0.12 to root pyproject dependencies (was undeclared, caused
  ModuleNotFoundError in CI across all Python versions + Windows)
- Rename drive_test.py -> drive_check.py so pytest stops collecting the module
  as a test file; update MODULE_NAME, PRIMARY_COMMAND, help text, README, tests
- 220 backup tests pass, seedgo 100% all 37 standards

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 19:05:45 -07:00
AIOSAIandClaude Opus 4.8 01023d25ba fix(daemon): seedgo 100% — archive dead action_processor, README count, run.py bypasses
Post-DPLAN-0204 cleanup that brought daemon back to 100% seedgo:
- archive handlers/actions/action_processor.py -> .archive (dead after
  scheduler_cron rewired process_actions -> run_tick; nothing imports it)
- README: 387 tests/16 files -> 448 tests/19 files (drift after +61 tests)
- .seedgo/bypass.json: run.py encapsulation (authorized cross-branch wake_branch
  import, DPLAN-0204 §2.8 — ai_mail exposes it only via handler, same as @trigger)
  + run.py introspection (no-args runs a tick, like update.py/activity_report.py)

seedgo 100%, 448 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 18:42:10 -07:00
AIPass 7dbc77558a Merge pull request #641 from AIOSAI/dependabot/github_actions/sigstore/gh-action-sigstore-python-3.4.0
ci(deps): bump sigstore/gh-action-sigstore-python from 3.3.0 to 3.4.0
2026-06-15 18:31:29 -07:00
AIOSAIandClaude Opus 4.8 af350fe07e fix(commons): canonical lowercase identity + fast test suite (green CI push)
Identity: normalize branch names to lowercase at both write paths so one
branch = one identity regardless of registry casing (registry has historically
mixed BACKUP vs devpulse, splitting the roster into DEVPULSE/devpulse rows).
- identity_ops.get_caller_branch(): _normalize_branch_name() at the single
  caller choke point (post/comment author writes + agent registration).
- db._register_branches(): lowercase on the bulk registry seed.
Verified live: post author lands lowercase, no duplicate rows; uppercase-
registry branches (backup) normalize through the caller path too.

Test suite: session-scoped template DB cloned per test (shutil.copy) + fast
PRAGMAs (journal_mode=MEMORY, synchronous=OFF) instead of re-running
schema.sql+FTS5+registry per test. 449 tests now 86s (was >120s gate timeout);
full per-test isolation preserved, initialized_db interface unchanged.

test_identity: assertions updated for the lowercase caller path; monkeypatch
targets retargeted from the commons_identity facade to identity_ops (where
get_caller_branch resolves them).

.daemon/schedule.json: disabled wake-test seed (decentralized daemon contract example).

seedgo 100% (37/37), 449 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 17:45:08 -07:00
AIOSAIandClaude Opus 4.8 cbe3ba66c6 feat(daemon): decentralized .daemon scheduler — branches own schedule.json (DPLAN-0204/FPLAN-0282)
Each branch owns .daemon/schedule.json; daemon does discovery + firing via
wake_branch() direct (path A). Owner IS the wake target, killing stale-target
bugs. Proven live: drone @daemon run -> discovered @commons/wake-test ->
wake_branch() fired -> @commons woke -> @devpulse received 'DAEMON TEST FIRED'.

- handlers/schedule/discovery.py  — scan branches for .daemon/schedule.json
- handlers/schedule/runstate.py   — per-job run-state tracking
- modules/run.py                  — run-tick entry (wired into 5 modules)
- scheduler_cron.py               — rewired process_actions -> run_tick
- old plugins (community_rotation, daily_audit, heartbeat) retired -> .archive
- 448 tests (+61)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 14:29:22 -07:00
AIOSAIandClaude Opus 4.8 8f6257fd6c fix(skills): telegram handler args dict->list contract + telethon optional-import guard
handler.py run() received args as a DICT ({'arg0':'base'} from the skill
runner's _parse_extra_args), but _cmd_* consume a positional LIST -> args[0]
raised KeyError(0) (str '0') -> 'start failed: 0', no-op'd the live bot launch.
Add _normalize_args(): dict->list (arg0..argN -> values; key=value -> key,value),
list passes through. Verified live: 'status base' + 'start' route correctly via
the real drone runner. telethon_auth.py: guard optional 'from telethon import'
with type:ignore (matches botfather_client pattern).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 09:42:43 -07:00
AIOSAIandClaude Opus 4.8 5f514604f7 feat(skills): wire telegram handler.py run() -> bot_operations (FPLAN-0277 live bring-up)
Replace scaffold stub with dispatch table routing all 6 actions (start/stop/
status/create/delete/notify) to bot_operations, bot_factory, notifier. Lazy
imports per action, arg validation, graceful error returns. +28 routing tests
(test_handler_routing.py). Verified live: status -> real registry query.
TG 445/452 (7 telethon-absent), skills 252/252 no regressions. seedgo 25/27
(skill-folder FP + required lazy imports).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 09:30:58 -07:00
AIOSAIandClaude Opus 4.8 747c1adf86 fix(skills): close P5 audit gaps in telegram skill (FPLAN-0279 follow-up)
Closes the 22 code gaps from the 366-tag audit:
- conftest _redirect_prax_logs: rewrite to env-var redirect (committed version referenced a non-existent prax SYSTEM_LOGS_DIR attr that would error all 424 tests). Now 417/424 pass (7 = telethon not installed).
- base_bot.py: AIPASS_SESSION_TYPE=telegram in the Claude launch (line 1288).
- validate_branch: real AIPASS_REGISTRY.json lookup (was a non-validating stub).
- handler.py: seedgo META block (26/27, architecture = skill-folder FP).
- new files: telegram-bot@.service systemd template + telethon_auth.py (get-secret integration).
- bot_factory dual-write: clarifying comment (create-then-import staging, not runtime source).
- removed /home/aipass docstring references.
Verified: 417/424 TG tests, 252/252 skills tests, lint clean. Install/auth/live pending.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 09:13:14 -07:00
AIOSAIandClaude Opus 4.8 392f5d83b0 feat(skills): port Dev-Pass Telegram bridge as self-contained AIPass skill (FPLAN-0277 P1-P3)
P1 @api: get-secret command + auth/secrets.py (reads ~/.secrets/aipass/).
P2 @skills: 14-file bridge (~5300L) + ~424 tests ported to .aipass/skills/telegram/, seams rewired to services (prax logging, @api secrets).
P3 @hooks: telegram_response.py Stop hook (3-layer SubagentStop/sidechain/cursor defense) registered via the hooks engine.
P5 audit (TELEGRAM_PORT_MAP.md, 366 tags): 288 verified, 23 gaps (top conftest log-isolation fixture fixed), 55 live-deferred.
Lint: 5 F841 unused-var autofixes in ported tests. Known gaps + live bring-up (creds, systemd, telethon, round-trip) pending. CI red unrelated; land-only, no merge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 06:50:15 -07:00
AIOSAIandClaude Opus 4.8 0f5db606a5 feat(hooks): edit_gate non-blocking advisory when todos exceed rollover count limit
- todos don't auto-roll (active work items, pruned by hand) — so when they pile over the per-branch count limit, edit_gate now emits a NON-BLOCKING advisory ('todos over limit (N/M) — prune completed ones') and still allows the save
- reads the count limit from @memory's rollover config (per_branch override -> defaults -> 10); todos-only, local.json-only; char-cap block still takes priority; config-load failure = silent skip
- 11 new tests (522 hooks total), seedgo 100%; verified live (fired 11/10, silent at 10/10)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 21:29:12 -07:00
AIOSAIandClaude Opus 4.8 d9ce503798 refactor(memory): conform json_handler to shared JsonHandler + add drift-checker standard
- memory's drifted log-only json_handler fork replaced with the canonical shared-instance shim (aipass.aipass.shared.JsonHandler); module JSON triplets restored 0/0/25 -> 25/25/25
- seedgo: new json_handler-correctness checker (36th standard) — flags stripped/log-only handler forks across branches and verifies the shared shim or full triplet surface
- hooks + backup bypassed (architecturally exempt: hook engine + file-manager; backup pending migration decision)
- bypass entries: memory json_handler shim naming, hooks/backup json_handler exemptions
- self-audit 100%, 1059 seedgo tests

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 20:54:47 -07:00
AIOSAIandClaude Opus 4.8 72659eccbd feat(memory): FPLAN-0276 — unify memory limits into config single-source + cleanup
- memory.config.json is the single source of truth: char caps (entry_limits, global) + rollover counts (per_branch, materialized from registry); .trinity files stripped to a one-line _usage header
- changed_entries gate now matches by content identity, not array position — prepending a new entry never re-flags unchanged legacy entries (old=old, new=new; no trimming required on a cap change)
- rollover push command + top-level 'drone @memory push' alias; corrected config _note + --help (rollover push surfaced, labeled destructive system-wide reset)
- removed 3 dead functions: seed_per_branch, its orphaned write_config, add_learning + its tests
- spawn birthright/builder + LOCAL/OBSERVATIONS templates aligned to the stripped shape
- 966 tests, seedgo 100%

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 20:54:34 -07:00
AIOSAIandClaude Opus 4.8 6c675e9b78 fix(memory): FPLAN-0274 — canonical LOCAL/OBS templates to unified entry shape
LOCAL.template.json: session_number->number, +tags:[], schema_version 3.0.0
OBSERVATIONS.template.json: pattern/source->number+note+tags:[], schema_version 3.0.0
New citizens now born in the unified schema (matches spawn templates from 7276e03).
Live 15-branch .trinity cleanup (drop session_number dup, unify obs->note) applied
+ verified by artifact (0 session_number, counts preserved, 34 backups) — gitignored local state.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 00:25:46 -07:00
AIOSAIandClaude Opus 4.8 7276e03021 feat(memory): DPLAN-0207 P3-P5 — unify spawn templates + /memo,/prep entry rule; manager.py E402 fix
P3: birthright+builder local/observations templates to unified schema (key_learnings dict->list, session_number->number, pattern/source->note, number+date+tags, schema 3.0.0)
P4: edit_gate verified list-aware via changed_entries dispatch — no code change needed
P5: /memo + /prep + memo SKILL carry the unified entry rule (stamp number+date, newest-on-top, prepend, no hand-trim)
Fix: manager.py E402 (import below logger) leftover from FPLAN-0273 hotfix — was blocking the .py diagnostics edit-gate

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 00:10:31 -07:00
AIOSAIandClaude Opus 4.8 2f327d85d7 fix(memory): DPLAN-0207 P1 hotfix — detector + learnings manager list-aware (key_learnings)
Migration surfaced two consumers that still counted key_learnings as a dict: detector v2 trigger (at-cap list invisible -> fell to v1 line-count) and learnings/manager (used by rollover + symbolic). Made list-aware + dual-mode; +5 regression tests (detector counts a LIST, manager round-trip) — the gap 955 tests missed. rollover check now shows '25/25 key_learnings' (v2), was '609/500 lines'. 960 tests; seedgo 99% (pre-existing unused-function on unwired add_learning, not a regression).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 16:06:00 -07:00
AIOSAIandClaude Opus 4.8 7cf319b4cd feat(memory): DPLAN-0207 P1 — unified entry schema (key_learnings dict→numbered list, sort-by-number rollover guardrail)
All 4 .trinity entry types now numbered+dated, list-shaped, newest-first. Rollover trims oldest by number; normalizer self-heals ordering (fixes S229 where rollover archived the newest key_learning). Backward-compatible: un-migrated dict key_learnings skip gracefully. @memory self-migrated to schema 3.0.0. 955 tests, seedgo 100%. Cross-branch migration = P2.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 15:35:43 -07:00
AIOSAIandClaude Opus 4.8 a8d05e2602 feat(memory): FPLAN-0271 — relocate config to json-home + unify 9 loaders behind one self-healing config_loader
Move memory.config.json to memory_json/custom_config/ and .plans_processed.json
to memory_json/ root; delete the loose config/ dir. Replace 9 disagreeing
per-loader config readers with one DEFAULT_CONFIG + non-mutating deep-merge +
self-heal (missing file -> write defaults; malformed JSON -> fail loud, never
overwrite). Resolves 8 default divergences incl. the silent enforce-off bug and
rollover 600-vs-500. Static _meta documents consumer files; dead intake removed.
949 tests green, seedgo @memory 100%. Design: DPLAN-0206.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 13:50:42 -07:00
AIPass 4ffcc2f3c9 Merge pull request #642 from AIOSAI/dependabot/github_actions/codecov/codecov-action-7.0.0
ci(deps): bump codecov/codecov-action from 6.0.1 to 7.0.0
2026-06-13 13:01:47 -07:00
AIOSAIandClaude Opus 4.8 5336d8f61f feat(hooks): FPLAN-0270 Phase 5 — edit_gate Edit/MultiEdit reconstruction + diff (no false-reject)
Gate now covers Write/Edit/MultiEdit via _resolve_after_text (reconstruct post-edit
text: Edit replace first/all, MultiEdit sequential) + _evaluate_limits +
_check_trinity_change, all reusing @memory changed_entries. Because only NEW/CHANGED
entries are checked, editing an unrelated field in a file full of legacy over-limit
entries is ALLOWED — proven on devpulse's REAL local.json under enforce=true
(unrelated todo edit allowed, over-limit edit blocked, file never written).
Fail-open on old_string-not-found / invalid-JSON / import error / any exception.
+17 tests (39 trinity, 511 hooks total), seedgo 100%, enforce false. @hooks side
complete. Warn-first build (Phases 1-5) done. Part of DPLAN-0205.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 02:35:43 -07:00
AIOSAIandClaude Opus 4.8 54dcfb4823 feat(hooks): FPLAN-0270 Phase 4 — edit_gate Write-path .trinity char-limit check (warn-first)
Additive gate in edit_gate.handle(): on Write to .trinity/{local,observations}.json,
lazily importlib-imports @memory's load_entry_limits + changed_entries and flags
new/changed over-limit entries. enforce:false → allow (warn); enforce:true → block
with reason. Fail-OPEN on bad JSON / import error / any exception (this hook runs on
every edit system-wide — never block on its own failure). Edit/MultiEdit pass
through (Phase 5). All 4 existing gates (inbox/daemon/cross-branch/edit-while-errors)
intact. +22 tests (494 total, 13 existing edit_gate green), seedgo 100%, enforce
false. Verified by artifact incl. fail-open + rollover-safe + char-not-byte proofs.
Part of DPLAN-0205.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 02:18:15 -07:00
AIOSAIandClaude Opus 4.8 7064375589 feat(memory): FPLAN-0270 Phase 3 — changed_entries diff helper + write_memory_file enforcement (warn-only, rollover-safe)
changed_entries(before,after,limits): pure diff that flags only NEW/CHANGED
over-limit entries, ignoring unchanged legacy fat — so rollover (trims by count,
writes back recent fat entries) is never rejected. Wired into write_memory_file
via _validate_entry_limits (gates only .trinity/{local,observations}.json): warn
mode logs+writes, enforce mode rejects new/changed over-limit only. Validation
wrapped in try/except → a validator bug can never abort a write. +15 tests (917
total), seedgo 100%, enforce stays false. Verified by artifact incl. live proof
of rollover-safety + the defensive guarantee. @memory side (P1-3) complete. The
changed_entries() helper is what @hooks imports next. Part of DPLAN-0205.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 01:55:58 -07:00
AIOSAIandClaude Opus 4.8 828cc1c8d8 feat(memory): FPLAN-0270 Phase 2 — check_entry validator + drone @memory lint (read-only audit)
Pure check_entry(type,text,limits) validator (chars not bytes, boundary at cap,
unknown-type safe) reusable by both gates. New 'drone @memory lint run' scans all
branches' .trinity via registry, handles dict+list containers and both
key_learning value shapes, sorts worst-first — strictly READ-ONLY (never writes/
trims, honors never_trim_s153). Phase-1 unused_function bypass removed (reader now
called). +12 tests (902 total), seedgo 100%. Verified by artifact incl. live lint:
513 over-limit entries across 17 branches (devpulse worst at 71, top offender
5724/600). enforce still false. Part of DPLAN-0205.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 01:35:58 -07:00
AIOSAIandClaude Opus 4.8 e47d4f0463 feat(memory): FPLAN-0270 Phase 1 — entry_limits config (warn-first, enforce:false) + load_entry_limits reader + 14 tests
Config-driven char caps for .trinity memory entries. Phase 1 = foundation only:
adds entry_limits section to memory.config.json (4 caps: learnings 200, sessions
300, todos 200, observations 600) and the load_entry_limits(branch) reader
(deep-merge per_branch overrides, safe-defaults on missing/malformed). Reader has
NO callers yet (Phase 3 wires it) — unused_function bypass is intentional.
Verified by artifact: 14/14 tests, seedgo 100%, scope clean. enforce:false →
zero behavior change. Part of DPLAN-0205.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 01:15:54 -07:00
dependabot[bot] 8a0cc001bd ci(deps): bump codecov/codecov-action from 6.0.1 to 7.0.0
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6.0.1 to 7.0.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/e79a6962e0d4c0c17b229090214935d2e33f8354...fb8b3582c8e4def4969c97caa2f19720cb33a72f)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-13 08:02:29 +00:00
dependabot[bot] 61cb963ed6 ci(deps): bump sigstore/gh-action-sigstore-python from 3.3.0 to 3.4.0
Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases)
- [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sigstore/gh-action-sigstore-python/compare/04cffa1d795717b140764e8b640de88853c92acc...5b79a39c381910c090341a2c9b0bf022c8b387e1)

---
updated-dependencies:
- dependency-name: sigstore/gh-action-sigstore-python
  dependency-version: 3.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-13 08:02:20 +00:00
AIOSAI d9a2a48a1e fix(ai_mail): retire dashboard_sync writer — stop writing the ai_mail dashboard section (prax self-sources) 2026-06-13 00:13:23 -07:00
AIOSAI 37fb07ca16 fix(prax): quick_status self-sources mail counts from inbox.json (decouple from ai_mail section) 2026-06-12 23:57:08 -07:00
AIOSAI fc49928a4b fix(prax): slim dashboard to lean glance — drop session/todo/ai_mail sections, quick_status is the count home 2026-06-12 23:41:30 -07:00
AIOSAI 58bd70beac fix(prax): prune deprecated dashboard sections on refresh (bulletin_board et al) 2026-06-12 23:20:33 -07:00
AIOSAI 1057be65a4 fix(prax): slim devpulse dashboard — drop duplicated todos[] bodies, keep count (startup-context fix) 2026-06-12 23:09:42 -07:00
AIOSAIandClaude Opus 4.8 c5a96cbdcf fix(backup): rename store dir .backup_system to .backup + remove dead versions/ (FPLAN-0269 follow-up)
Backup root is now .backup/ via BACKUP_DIR (builder.py:19); tracker.py uses backup_root() not a hardcoded path; patterns.py BUILTIN_IGNORES + docstrings/README updated. Removed the orphaned per-timestamp versions/ scaffold (setup.py) and unused build_versioned_path() — both superseded by the Phase-3 versioned/ baseline+diff store. .backup/ coexists with flow's .backup/processed_plans/. Repo-root .backupignore now ignores both .backup/ and (until manual deletion) .backup_system/ (also carries Patrick's *logs rule). Verified by artifact (seedgo 100%, 220 tests) + live (throwaway writes to .backup/, no versions/, Drive reads .backup/versioned/).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 22:06:50 -07:00
AIOSAIandClaude Opus 4.8 a0016669b7 chore(backup): track repo-root .backupignore — it is the single source of truth now (FPLAN-0269 follow-up)
.backupignore is now AIPass's managed backup filter (true gitignore semantics via pathspec), so it belongs in version control like .gitignore — a fresh clone gets the curated rules, not just the auto-seed default. Includes the .ruff_cache/ + .coverage additions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 21:38:28 -07:00
AIOSAIandClaude Opus 4.8 f4b776949e fix(backup): .backupignore = true .gitignore via pathspec — single source of truth + Drive stops dropping dotfiles (FPLAN-0269)
Replace hand-rolled fnmatch+part-loop matcher with pathspec gitwildmatch (leading-slash anchoring, !negation, dir-only foo/, *-not-crossing-/, last-match-wins). Demote BUILTIN_IGNORES to a seed-only default (written when absent, never merged at runtime); delete IGNORE_EXCEPTIONS/is_exception (exceptions are native ! lines). snapshot+versioned+all+mirror-cleanup all obey one .backupignore. Remove the drive_sync dotfile-skip so .trinity/.chroma/.aipass/.ai_mail.local (4558 files incl memories) now reach Drive. Add a Drive-sync output panel matching snapshot/versioned. Declare pathspec (pure-python, cross-OS). Verified by artifact (seedgo 100%, 220 tests incl 26 new gitignore-parity) + live (dotfile flows into store, !negation re-includes end-to-end).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 21:36:08 -07:00
AIOSAI c63a43af30 docs: de-hardcode branch count in devpulse README + branch prompt (→ 'the other branches' / 'drone systems' for the live list) + sync AGENTS.md startup protocol to match CLAUDE.md (dashboard-refresh flow) 2026-06-12 18:52:34 -07:00
AIOSAI 9e5ff4e6c3 fix(backup): Google Drive folder duplication + dedup-wipe — restore GOLD's lock scope (whole-method _folder_cache_lock on project/nested folders, lock-free backup-folder short-circuit, guarded tracker reset). Fix drive_* underscore command routing + declare 3 google libs. Verified by artifact (seedgo 100%, 197 tests incl. 5-thread concurrency) + live (real Drive backup, no duplicate folders) 2026-06-12 18:47:47 -07:00
AIOSAI ffc5f3b919 fix(memory): rollover no longer silently loses rolled-off learnings — restore pre-trim backup on empty-embeddings path + honor skipped-extraction flag to close the concurrent-rollover race (orchestrator.py + extractor.py, +4 tests). Verified by artifact (seedgo 100%, 876 tests) + live (drone @memory search returns a rolled-off item at 91%) 2026-06-12 18:01:17 -07:00
AIOSAIandClaude Opus 4.8 1049bc308b feat(backup): FPLAN-0268 — Google Drive sync pipeline + restore command (restoration Phase 4, final)
Faithful port of GOLD's GoogleDriveSync against the live @api gateway. Completes
the backup restoration (master FPLAN-0264).

Drive pipeline (handlers/drive/):
- DriveClient: folder hierarchy 'AIPass Backups/<project>/', thread-safe cache,
  retry-with-rebuild. Auth via aipass.api get_drive_service + api_call_with_retry
  (never console-OAuth).
- upload.py: resumable MediaFileUpload, 3 threaded workers, single + batch.
- tracker.py: mtime+size dedup (.backup_system/drive_tracker.json) — no re-upload
  of unchanged files.
- test.py: connectivity check.
All 4 drive_* modules un-stubbed. all = snapshot->versioned->drive-sync, drive
step FAILS HONESTLY if creds absent (no silent skip, snapshot+versioned still run).

restore command (modules/restore.py -> handlers/diff/restore.py):
- 'restore <project> list <file>'  (baseline + current + diffs)
- 'restore <project> file <file> <out>'  (reconstruct + write)

pyright/cleanup (Patrick's call): removed backup's standalone pyrightconfig.json
(pre-namespace leftover, archived) so it inherits the repo-root config like every
citizen; dead PyQt5 ui/settings_window.py archived.

Drive tests fully mocked — ZERO real Google calls in CI. Live Drive upload awaits
Google OAuth creds (~/.secrets/aipass/google_client_secret.json + drone @api
reauth google) — Patrick's setup step.

Verified by artifact (devpulse): seedgo 100% all 36 standards / 37 files, 187
tests, ruff clean; restore list/file round-trip confirmed live.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 14:53:42 -07:00
AIOSAIandClaude Opus 4.8 a8cd576bae feat(backup): FPLAN-0267 — versioned baseline + per-file diff engine (restoration Phase 3, the heart)
Faithful port of the GOLD versioned engine (no reinvention). Replaces the mtime
full-copy-into-per-run-dirs remnant with ONE persistent store
(.backup_system/versioned/) using GOLD's file-folder packaging:

  <parent>/<name>/<name>                       current (copy2, mtime preserved)
  <parent>/<name>/<stem>-baseline-<date>.<ext> first-run full copy, never touched
  <parent>/<name>/<name>_diffs/<name>_v<old-mtime>.diff  unified-diff per change

Patrick's laws, all enforced + tested:
- versioned backs up the EXACT same files as snapshot (same scan/ignore;
  all.py shares one scan between modes)
- first versioned run = baseline snapshot of that state
- append-only: versioned NEVER deletes (cleanup stays snapshot-only)
- change detection is LEDGER-FREE (source mtime vs store-current mtime) —
  removes versioned's use of shared timestamps.json, killing the
  snapshot-starves-versioned regression

New diff/restore.py (list_versions + restore_file); diff/generator.py wired
(binary detection, DIFF include/ignore patterns); path/builder.py file-folder
versioned branch (root/ wrap, >50-char hash shortening). +15 tests -> 125.

Verified by artifact (audit 100% all 36, pytest 125, ruff clean) + LIVE
end-to-end: snapshot-first-then-versioned baselines all 5 files (starvation
dead) -> edit -> diff with old-mtime timestamp + current overwritten + baseline
intact -> source delete -> versioned store untouched while snapshot
mirror-deletes -> restore round-trip byte-identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 13:55:03 -07:00
AIOSAIandClaude Opus 4.8 826ffcd54c feat(backup): FPLAN-0266 — snapshot fidelity + shared core (restoration Phase 2)
Restore the snapshot-side machinery the 2026-04-23 rewrite degraded, ported from
the GOLD archive onto the current per-project handlers.

- handlers/cleanup/mirror.py cleanup_deleted_files: exception-aware mirror-delete
  (vanished source files are removed from the snapshot, respecting ignore
  exceptions) — replaces the blind rmtree+recopy.
- copy/snapshot.py: mtime-skip quick-check (unchanged files no longer re-copied),
  long-path guard (>260), read-only handling.
- report/result.py BackupResult: critical vs non-critical errors + warnings +
  files_deleted + success.
- ignore/patterns.py: IGNORE_EXCEPTIONS + is_exception().
- modules/snapshot.py: quick-check fast path.
- +16 tests (test_snapshot_fidelity.py) -> 110 total.

Verified by artifact (devpulse): seedgo audit 100%, pytest 110 passed, ruff clean,
AND a live throwaway-project test — deleted two source files, re-snapshotted, both
mirror-deleted, kept files preserved, 3 skipped/0 re-copied (quick-check working).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 13:19:02 -07:00
AIOSAIandClaude Opus 4.8 5ab257e569 feat(backup): FPLAN-0265 — seedgo 100% + 94-test green foundation (restoration Phase 1)
Safety net under backup before the feature rebuild (master FPLAN-0264 Phase 1).
No new features — harness + standards only.

Tests (new src/aipass/backup/tests/): 94 tests across json_handler, CLI routing,
filesystem handlers, error resilience, mocked drive — ported from the canonical
citizen conftest pattern (autouse mock_infrastructure, env log-redirect, tmp_path).
Hermetic + stdlib-only (passes 3.10-3.13), ruff clean. Module coverage 27%.

Standards to 100% (all 35): shared --help/-h/help guard in all 10 modules'
handle_command (Cli 92->100, Introspection 86->100); 6 Phase-3 drive/diff/ui
stubs wired-or-bypassed (Dead_Code 82->100, Unused_Function 81->100);
requirements.project.txt (Architecture); README module list (Readme 87->100);
display.handle_command no-op (Modules); create_progress_bar->build_progress_bar
(Trigger). Overall 95->100.

Verified by artifact (devpulse): seedgo audit 100% + pytest 94 passed + ruff clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 12:51:24 -07:00
AIOSAI 43a6ab2212 fix(drone): route @backup through interactive passthrough — add 'backup' to INTERACTIVE_BRANCHES so snapshot/versioned/all inherit the TTY instead of capture_output=True. Drone was flattening backup's Rich output (non-TTY -> color stripped, transient progress bar rendered to nothing) and the 30s capture timeout would kill large backups. Mirrors the existing 'cli' entry. Verified live: full rich output now flows through drone. + CHANGELOG. 2026-06-12 11:35:25 -07:00
AIOSAI 1747a23e5c feat(backup): restore full 9-stage rich CLI output (FPLAN-0263) — new backup_timestamps state handler + display.py 5-stage pipeline (last_backups panel -> boxed header -> live Rich progress bar -> result summary -> backups_now panel), extend BackupResult with files_checked/files_skipped/backup_path, emit on_progress callbacks from copy/snapshot+versioned, rewire snapshot/versioned/all to the rich pipeline. Faithful port from gold archive source. Verified live under pty: full color + animated transient progress bar. seedgo 95%, ruff clean. 2026-06-12 11:35:18 -07:00
AIOSAI 1f3727d4fc fix(backup): split top-level --help from bare introspection — drone @backup --help now shows a curated Rich command reference (boxed header + USAGE + COMMANDS), bare drone @backup shows the discovered-modules self-map. Previously both fell through to one conflated module-list block. Also revives the dead print_introspection() (was unused). Matches the commons/skills citizen pattern. ruff clean, both paths verified live (S220) 2026-06-12 09:05:20 -07:00
AIOSAI bbe3f43835 feat(backup): namespace migration standalone -> aipass.backup.* citizen — convert 47 internal imports across 11 files (apps.* -> aipass.backup.apps.*), fix importlib discovery string, drop sys.path/PROJECT_ROOT hack, add root __init__.py package marker. Diagnostics 0%->100%, Imports 99%->100%, overall 92%->95% (S220). Verified-by-artifact: all 10 drone cmds live, register+status e2e clean, ruff clean, zero standalone imports. Test_Quality (no suite) stays separate build (td-018) 2026-06-12 07:33:20 -07:00
AIOSAI dea91bc613 feat(backup): revive dormant citizen (revive-to-working) — path-depth parents[4]->[3], fill branch prompt, archive stray upgrade/ to .archive, Handler_Import + happy-path central logging (DPLAN-0203 night shift). CLI runs clean. seedgo 92%: structural gaps (Diagnostics=standalone sys.path/pyright, Test_Quality=no test suite) flagged for Patrick, not forced overnight 2026-06-12 01:38:29 -07:00
AIOSAI ee004c4568 feat(daemon): revive dormant citizen (revive-to-working ONLY) — scrub 6 stale @vera refs, add happy-path logger.info() central logging, fix Ruff/Introspection/Windows_Compat/Handler_Import/Imports (DPLAN-0203 night shift). 387 tests, seedgo 100%. Scheduler .daemon/ redesign deferred to DPLAN-0204 2026-06-12 01:29:58 -07:00
AIOSAI 8379f88fd7 feat(commons): revive dormant citizen — verify namespace migration (172 imports/67 files) + path-depth + 4 bug fixes, add E501/CLI/Windows_Compat cleanup + happy-path logger.info() central logging (DPLAN-0203 night shift). 449 tests, seedgo 100% 2026-06-12 01:12:10 -07:00
AIOSAI 1871e55b51 feat(skills): revive dormant citizen — namespace skills.*→aipass.skills.* (48 imports), path-depth parents[3]→[4], happy-path logger.info() central logging (DPLAN-0203 night shift). 252 tests, seedgo 100% 2026-06-12 00:25:11 -07:00
AIOSAI a797f9d3d3 fix(git): kill post-merge friction — sync FF-only realign (not rebase), merge-not-squash docs, deterministic spawn registry 2026-06-11 15:21:58 -07:00
AIPass 8cddf1e06f Merge pull request #639 from AIOSAI/dev
Cleanup: gitignore PPLAN run files (plan-type consistency) + spawn registry refresh
2026-06-11 14:09:02 -07:00
AIOSAI 83e65b3374 chore: gitignore PPLAN-*.md for plan-type consistency + spawn builder template registry id refresh 2026-06-11 13:53:40 -07:00
AIPass cf6aa37d1e Merge pull request #638 from AIOSAI/dev
Git law + head-move discipline in sunday_merge playbook (S208 incident)
2026-06-11 13:22:59 -07:00
AIOSAI 2af856d81d chore(release): v2.5.3 — date-based CHANGELOG headers + rename sunday_merge playbook to merge (drop weekly cadence) 2026-06-11 12:49:07 -07:00
AIOSAI 54d55abebc feat(aipass): init detects missing Claude Code, offers install (yes/no) 2026-06-11 00:12:32 -07:00
AIOSAI ed17630b76 fix(drone): broker start_background blocks until listening — kill connect-before-bind race 2026-06-10 23:23:56 -07:00
AIOSAI 707f54a6f2 fix(ci): guard remaining AF_UNIX broker tests for Windows — ai_mail + aipass 2026-06-10 23:04:52 -07:00
AIOSAIandClaude Opus 4.8 e33cf2bfbe fix(ci): guard Linux-only sandbox tests for Windows — skipif(sys.platform != linux)
test_broker.py (AF_UNIX sockets + openat2) and test_sandbox.py (bwrap) are
Linux-only; module-level pytestmark skips them on windows-latest while leaving
Linux runs unchanged. Unblocks the windows-setup CI check (red since the
sandbox build 0b4ba63).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-10 22:50:44 -07:00
AIOSAIandClaude Opus 4.8 53340ab169 fix(seedgo): audit local==CI parity — output-dir skips + diagnostics fail-honesty + pyright determinism (FPLAN-0261)
Hoist per-checker SKIP_DIRS to shared SOURCE_SKIP_DIRS (artifacts/dropbox are
output dirs, not source; no git coupling). Diagnostics: python3->sys.executable,
parse/run failures now fail loud instead of silent 0-errors-clean, and pin
pyright resolution with --pythonpath sys.executable. drone bypasses test-only
broker start_background. Proven all-13-branches-100% deterministic in an
unactivated shell (local==CI).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-10 22:09:01 -07:00
AIOSAI 17863ac4c5 refactor(shared): re-home aipass.common into its steward — src/aipass/aipass/shared (FPLAN-0260)
src/aipass/common was the only non-citizen directory in the agent namespace.
Per @seedgo design review: moved into @aipass (owner) as aipass.aipass.shared,
content byte-identical. @spawn imports across (blessed shared-infra category,
same as aipass.prax/cli). New subprocess guard test pins the bootstrap-safety
invariant (shared/ loads zero branch deps — aipass init stays pre-drone-safe).
9 import/doc sites updated, 9 documented seedgo bypasses (pre-infra leaf,
stdlib-only by design). aipass 480 + spawn 315 tests green, both audits 100%,
repo-wide zero refs to the old path.
2026-06-10 18:26:26 -07:00
AIOSAIandClaude Opus 4.8 0b4ba63fae feat(sandbox): kernel filesystem boundary for agent containment (DPLAN-0202/FPLAN-0250)
Every autonomous agent can launch inside a kernel-enforced mount namespace
(srt -> bwrap+seccomp): reads stay open (shared live FS preserved, bind-mount not
isolation; own-tree writes land live), but rm/python/find/Write on .git or sibling
trees hit EROFS. /tmp + own tree writable; .git RW devpulse, RO builders. Inert by
default behind AIPASS_SANDBOX_ENABLED (off); flag-off path byte-identical to old.

hooks: srt wrapper + per-role build_policy + broker_secret mask; rm_gate demoted.
drone: out-of-sandbox broker (identity allowlist, openat2 RESOLVE_BENEATH, HMAC
handshake over inherited fd, audit); drone rm via broker when sandboxed.
ai_mail: dispatch gate + broker-fd wiring (fail-loud exit -4, never silent).
aipass: doctor Sandbox group + setup.sh prereqs (LOUD on missing).

Proven by a live 16-check red-team suite. seedgo 100% + 2859 tests green across
all 5 touched branches.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-10 13:16:22 -07:00
AIOSAIandClaude Opus 4.8 0c6e8ac425 fix(hooks): auto_watchdog sound-migration (FPLAN-0249 tail)
Same action-gated pattern as the notification handlers — speak() -> 'sound'
return-key. Missed in b26bd7c. Hooks suite green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-10 13:10:27 -07:00
AIOSAIandClaude Opus 4.8 b26bd7c853 fix(hooks): cadence sound-migration tail — action-gated sound via return-key (FPLAN-0249)
Notification handlers (announce, email, stop_sound, tool_sound) return a
'sound' key the engine plays on action instead of calling speak() on every
invocation — quieter and honest (skipped loaders stay silent). Slim
cadence_investigation.md. Tests updated to assert the return-key form. 472/472
hooks green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-10 13:09:32 -07:00
AIOSAIandClaude Fable 5 00edd8b3a0 fix(hooks): auto_fix ruff legs were silently dead — invoke via venv interpreter
Three ruff call sites called bare `ruff`, absent from the hook subprocess
PATH (ruff lives only in .venv) — logged 'ruff not found' 177x over ~a month,
silently skipping lint+format on every edit. Also `--output-format=text` was
removed from modern ruff. Fixed all three sites to `sys.executable -m ruff`
(the pattern the working pyright leg already uses) + concise format + honest
rc>=2 error logging. Tests now pin the invocation (argv == sys.executable -m
ruff) so a regression fails loud — the subprocess-mock is how this hid.
438/438 hooks tests green; live-verified through the real hook pipeline.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 22:34:38 -07:00
AIOSAIandClaude Fable 5 c3c6c2dde7 docs(changelog): slim global prompt (DPLAN-0201) + prax hook-color fix (td-007)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 20:17:19 -07:00
AIOSAIandClaude Fable 5 2aafade678 feat(prompt): slim global prompt to context-on-demand map, 13.8KB->7.8KB (DPLAN-0201)
Rewrite the always-injected global prompt from a ~13.8KB encyclopedia
into a ~7.8KB navigation map. The prompt now carries AWARENESS; detail
is fetched on demand via 'drone @agent --help'. Dissolves the harness
~10k-char truncation bug — the old prompt's tail (Hard Rules onward)
silently never arrived; the slim one injects whole.

- drone pinned at top as the router; one drilled reflex: --help before use
- framework tree restored; all 13 agents as 2-3 sentence bios
- introspection named as our term; breadcrumb-first navigation flow
- git its own section (raw git/gh blocked, drone-only, devpulse-writes)
- plans section (DPLAN/FPLAN/PPLAN/RPLAN + 'drone @flow templates')
- @memory chroma awareness (local + global stores, search before cold)
- sub-agent usage section incl. model practice (never fable)
- PROMPT_STYLE-conformant; 7855 chars (cap 8000, measured in chars)

Backup retained: .aipass/aipass_global_prompt.BACKUP-2026-06-09-S211.md

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 20:16:29 -07:00
AIOSAIandClaude Fable 5 73aedef20f fix(prax): hook events render styled in monitor — regex required phantom action= field (td-007)
Root cause: _HOOK_PATTERN required an action= key that cadence never
emits — it logs the action as the bare second word (fired/skipped).
Extraction failed, so events never reached the styled print_hook_event
renderer (bold-green lightning / dim dot). Pipeline was already correct.

- _HOOK_PATTERN -> bare-word capture: r'\[HOOKS\]\s+(\w+)\s+(\w+)'
- enriched hook event detail (period, offset, short session id)
- corrected docstring that documented the phantom action= format
- tests updated to real production format + real-pipeline test added
- type:ignore on watchdog imports (repo convention)

Verified: 914/914 prax suite green (90 log_watcher). @prax dispatched
for full-pipeline trace; stale monitor process explained the no-show.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 20:16:16 -07:00
AIOSAIandClaude Fable 5 fc4b263504 fix(hooks): cadence separate-process race + action-gated sound + auto_fix diagnostics regression (DPLAN-0200, FPLAN-0249)
Cadence redo — verified against the live execution model, not unit tests:
- Counter now advances exactly once per real turn (mtime debounce +
  transcript-size token + flock). Fixes the separate-process leapfrog where
  global/branch loaders double-incremented and fired erratically.
- Structured [HOOKS] cadence fired|skipped logging; prax monitor renders
  hook events distinctly for live visibility.
- Action-gated sound: handlers return a 'sound' key the engine plays only on
  real action — skipped loaders are silent (no more false piper every turn).
- Fixed auto_fix.py: leftover speak() NameError (swallowed by broad except)
  meant diagnostics silently never ran on any edit. Removed; sound moved to
  the error path.
- Tests rewritten to model separate-process execution (leapfrog regression
  test added); sound assertions across all refactored handlers. 438 pass.

prax: hook fire/skip event rendering in the live monitor. 913 pass.

README: hardcoded metrics (version/tests/PRs/standards) -> live PyPI+codecov
badges and qualitative wording; killed the 33-vs-36 drift. CHANGELOG W24.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-09 16:28:26 -07:00
AIOSAI 2bccf0311e feat(hooks): prompt injection cadence — fire loaders every Nth turn, config-tunable (DPLAN-0200, FPLAN-0249)
Stop re-injecting the global + branch prompts every turn (~3k tokens/turn).
They now fire together every 5th turn; the prior injection persists in context
between fires. Identity + email stay every-turn.

- apps/modules/cadence.py: per-session turn counter (/tmp/aipass-cadence-
  {session_id}.json), should_fire(loader)/reset_counter(), DEFAULTS + deep-merge
  config (api provider.py pattern). 'drone @hooks cadence' introspection.
- global_loader.py + branch_loader.py: cadence guard via importlib (crash-
  isolated); non-fire turn returns empty.
- compact.py: PreCompact resets counter to -1 -> next turn = 0 = all fire
  (rebuild context after compaction). New session = fresh counter = all fire.
- hooks_json/custom_config/cadence_config.json: tunable knob (period/offsets/
  enabled), one file, no code edits. Data lives in the json home, not the code
  dir. Missing file = code DEFAULTS = safe.
- .seedgo/bypass: documented stdlib-json config read (json_handler N/A for a
  dispatch engine).

435 tests pass (26 new), seedgo 100%, pyright 0.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 23:07:36 -07:00
AIOSAI d24887b7f5 feat(memory): template-conformance normalize + auto-heal on triggers (DPLAN-0200)
Memory files now reconcile to template, not just clean known fields:
- normalize.py: rewrote from field-targeted cleanup to template-conformance —
  strips ANY key not in the template at every level (root/metadata/limits/status).
  Kills legacy orphans (old 'st' blocks, active_tasks, current_lines, max_lines)
  that field-targeted cleanup was blind to. Fixed _MEMORY_ROOT path (parents[3])
  that silently skipped template loading in production.
- memory_watcher.py: wired normalize_memory_file into both scan paths
  (check_and_rollover + on_modified) with a write-loop guard — drift now
  self-heals on every trigger, no manual run needed.
- line_counter.py: stop writing current_lines (entry-count is the only metric).
- LOCAL/OBSERVATIONS templates: removed line-count fields.

Entry-count is the sole rollover metric, both files, all branches.
873 tests pass, seedgo 100%.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 23:07:24 -07:00
AIOSAI a53ea93b17 fix(ai_mail): preserve multi-line reply/send bodies — join args[1:]
Reply and send silently truncated multi-line bodies to the first CLI arg.
handle_reply(args[1]) and parse_send_args(rest[1]) dropped args[2:]/rest[2:]
when a body word-split into multiple args. Now join all remaining args.
Backwards-compatible; single-arg messages unchanged. +6 tests (718 total).

Found via @hooks replies arriving as first-line-only (60/48 chars).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 21:27:23 -07:00
AIOSAI ff9cc3f3b5 docs(playbook): strengthen — never move HEAD lightly (Patrick's rule) 2026-06-08 11:29:48 -07:00
AIOSAI e97130ffbc docs(playbook)+memory: git law — local=truth, never checkout main / move heads lightly; squash vs ff realign corrected 2026-06-08 11:28:33 -07:00
AIPass 1deb786c8a Merge pull request #637 from AIOSAI/dev
security(ci): least-privilege token on e2e-wheel workflow + W24 changelog (also carries playbook commit 6b89fcd)
2026-06-08 10:36:14 -07:00
AIOSAIandClaude Opus 4.8 2e96ddc302 chore(release): bump version 2.5.1 -> 2.5.2 (security patch)
Mid-week patch release for the CI/release security hardening:
least-privilege e2e-wheel token + Sigstore-signed GitHub Releases.
Bumps both pyproject.toml and src/aipass/__init__.py __version__.

Versioning scheme: patch (2.5.x) = small mid-week fixes, minor (2.x.0)
= Sunday main-merge batches.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 10:28:48 -07:00
AIOSAIandClaude Opus 4.8 076110a2fb security(release): sign GitHub Release artifacts with Sigstore (keyless)
publish.yml github-release job now signs the wheel + sdist via
sigstore/gh-action-sigstore-python (pinned v3.3.0 / 04cffa1d), keyless OIDC,
and attaches the .sigstore.json bundles to the GitHub Release through the
existing dist/* glob. Added id-token: write to the job for OIDC.

PyPI uploads were already attested (Trusted Publishing); Scorecard's
Signed-Releases check inspects GitHub Releases, which only carried bare wheels
-> score 0. .sigstore.json is in Scorecard's recognized signatureExtensions.
Verified: action globs ./dist/*.whl ./dist/*.tar.gz (action.py:202), auto-attach
gated on release-event (we trigger on push:tags) so we upload via dist/* and set
release-signing-artifacts:false. First live proof = next v* tag.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 10:19:51 -07:00
AIOSAIandClaude Opus 4.8 dab8d29645 security(ci): add least-privilege permissions block to e2e-wheel workflow
e2e-wheel.yml was the only workflow missing a top-level permissions: block
(added during cross-OS work after PR #624 hardened the rest), so it ran with
default broad GITHUB_TOKEN scopes -> OpenSSF Scorecard Token-Permissions = 0.
Add 'permissions: contents: read' to match the other 7 workflows. CHANGELOG
W24 entry.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 10:09:00 -07:00
AIOSAI c7055de5e2 docs(playbook): sunday_merge — bump BOTH version files, pre-flight version check, clearer manual tag step (from this run's friction) 2026-06-08 10:09:00 -07:00
AIPass e7d2d8c396 Merge pull request #633 from AIOSAI/dependabot/github_actions/github/codeql-action-4.36.2
ci(deps): bump github/codeql-action from 4.36.0 to 4.36.2
2026-06-08 10:08:58 -07:00
dependabot[bot] 4e2ead98a6 ci(deps): bump github/codeql-action from 4.36.0 to 4.36.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.0 to 4.36.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/7211b7c8077ea37d8641b6271f6a365a22a5fbfa...8aad20d150bbac5944a9f9d289da16a4b0d87c1e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.36.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-08 16:09:17 +00:00
AIPass 45d55dd353 Merge pull request #632 from AIOSAI/dependabot/github_actions/actions/checkout-6.0.3
ci(deps): bump actions/checkout from 6.0.2 to 6.0.3
2026-06-08 09:07:17 -07:00
dependabot[bot] 285a8a5b5f ci(deps): bump actions/checkout from 6.0.2 to 6.0.3
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/de0fac2e4500dabe0009e67214ff5f5447ce83dd...df4cb1c069e1874edd31b4311f1884172cec0e10)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-08 07:20:25 +00:00
AIPass 2a54ed8446 Merge pull request #631 from AIOSAI/dev
Seedgo hook-cruft purge + raise CI standards floor to 100%

Two changes:
1. refactor(seedgo): archive pre-DPLAN-0184 hook cruft (FPLAN-0241) — orphaned bridge/probe/manifest modules + tests moved to .archive/; README/bypass/prompts updated. 1045 tests green.
2. ci(seedgo-audit): raise the standards floor 80%->100%.

NOTE — the seedgo-audit check will go RED by design. With the 100% floor, the 6 branches at 99% (aipass/api/drone/flow/prax/seedgo) are now caught. This PR is to OBSERVE the gate enforcing in CI; it is not merge-bound until those 6 branches reach a genuine 100%.
2026-06-08 00:18:23 -07:00
AIOSAI 91b3f437fe chore(release): bump __version__ 2.5.0->2.5.1 to match pyproject + v2.5.1 release tag 2026-06-08 00:08:33 -07:00
AIOSAI 1e00119d9b fix(init): correct aipass init scaffold — project-specific AGENTS.md, README paths, my-agent->my_agent default, drop dead registry_path 2026-06-07 23:58:41 -07:00
AIOSAIandClaude Opus 4.8 9a64db9093 fix(spawn): seed todos[] into builder template .trinity/local.json (TDPLAN-0007 follow-up)
Verification audit caught a gap: spawn create copies templates/builder/ tree
directly (DEFAULT_TEMPLATE), but builder/.trinity/local.json lacked the todos[]
schema — so freshly spawned branches would not inherit it. Seeded todos[] +
max_todos:10 + todo_text_max_chars:200 + operational note to match @memory's
LOCAL.template.json. Now both spawn-create and template-push paths produce
todos[].

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 22:30:35 -07:00
AIOSAIandClaude Opus 4.8 626ab81a46 refactor(status): decommission entire STATUS flow — STATUS.local.md + central STATUS.md retired, replaced by local.json todos[] + dashboard count (TDPLAN-0007)
Cross-branch coordinated change. Per-branch STATUS.local.md (13) + central
STATUS.md deleted; all prompts/docs/skills/hooks/footer/scaffolding scrubbed.
Status-sync engine kept intact-but-inert (trigger registry unwired, 3 lines).
Replacement: operational todos[] in .trinity/local.json (@memory schema, capped,
rollover-exempt), pushed to all 13 branches + surfaced as dashboard todo_count.

Owners: memory (schema+global push+template), prax (dashboard todo_section +
engine dormant), trigger (unwire), aipass (init scaffolding), spawn (template
delete + todos[] seed), hooks (compact recovery), ai_mail (footer), seedgo
(_RUNTIME_ARTIFACTS cleanup), devpulse (scrub+delete+assemble).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 21:53:24 -07:00
AIOSAI f4b203a74e feat(standards): enforce Rich introspection formatting + 13 branches to seedgo 100%
- seedgo: new check_introspection_rich_formatting (delegation-aware) + introspection.md richness section + tests
- 13 branches: wrap print_introspection in Rich markup -> all at seedgo 100%
- S202 CLI polish: @hooks --help rewrite (hooksound on/off/status surfaced), spawn repair help clarity, drone Rich colour restore for --help/introspection/status
- flow: playbook plan-type (PPLAN) self-serve templates (default.md, sunday_merge.md SOP) + register-overrides-auto fix + --help rewrite
- hooks: setup.sh installs auto_process bridges + seedgo snapshot fixture learns them (TDPLAN-0005 followup, clears commit-gate blocker)
- remove orphaned devpulse/SETUP.md (vectorized to @memory)
- CHANGELOG [2026.W23]
2026-06-07 18:51:21 -07:00
AIOSAIandClaude Opus 4.8 e80e524dfe refactor(spawn): backups to single .spawn/.recovery namespace (TDPLAN-0006 P4)
Spawn's pre-merge JSON backups dropped a .recovery/ dir at each branch root,
which had accumulated 242 stale auto-gen DASHBOARD backups across 10 branches
(the original .recovery report that started this whole investigation).

- aipass.common.json_ops.backup_json gained optional backup_dir param
  (default unchanged = file_path.parent/.recovery, backward-compatible).
- spawn update engine (update_ops.py _merge_json) now passes
  branch_dir/.spawn/.recovery as the backup dest -> backups land under the
  spawn-managed .spawn/ dir, one namespace, not cluttering branch roots.
- Memory stays in the safety net: no memory-exclusion added; the engine just
  never touches .trinity/DASHBOARD on update so it never backs them up.
- 2 new tests (unit: custom backup_dir; integration: backup lands in
  .spawn/.recovery). 315 spawn + 438 aipass tests green; seedgo 100% both.

Stale .recovery backups swept separately (untracked/gitignored, local hygiene).
.recovery/ gitignore pattern already covers .spawn/.recovery/.

TDPLAN-0006 P4 — final phase. Closes the spawn update-safety + consolidation
work (P0 dry-run-default, P1 #636 engine, P2 shared lib, P3 import kill, P4
backup relocate).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 00:24:31 -07:00
AIOSAIandClaude Opus 4.8 59a6fcee13 refactor(aipass): subprocess to drone @spawn sync-registry — kill last cross-branch engine import (TDPLAN-0006 P3)
init_flow.py:896 was the one place aipass imported spawn's Python directly:
  from aipass.spawn.apps.modules.sync_registry import sync_registry
Replaced with subprocess.run(['drone','@spawn','sync-registry','--fix']) — the
command spawn already exposes — matching the aipass init agent -> drone @spawn
create pattern. Graceful degradation preserved: FileNotFoundError (no drone),
non-zero exit, and timeout are all silently skipped so a registry-sync hiccup
never hard-fails an init update. Safe because init update runs on an existing
project where drone is installed (NOT the pre-drone fresh-init path).

aipass branch now has ZERO direct imports of another branch's ENGINE code.
Remaining cross-branch imports are shared SERVICE layers only (cli Rich UI,
prax logger used in 347 files, trigger events) — infrastructure, not duplication.

Verified: zero aipass.spawn imports in .py code; fresh aipass init still
scaffolds (bootstrap pre-drone intact, 69 tests); 438 tests green (4 new for
the subprocess path: success/failure/missing-drone/timeout); seedgo 100%.

TDPLAN-0006 P3. P4 (.recovery relocate) is the last phase.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 00:14:28 -07:00
AIOSAIandClaude Opus 4.8 14e134b8e6 refactor(common): extract aipass.common shared lib — dedup spawn/aipass (TDPLAN-0006 P2)
@spawn and @aipass each maintained their own copy of the JSON merge/handler
utilities and registry discovery. Collapsed into ONE branch-free package both
import: src/aipass/common/ (json_ops: deep_merge + backup_json ;
json_handler.JsonHandler ; registry_discovery.find_registry).

- aipass.common imports ZERO branch code → aipass/bootstrap.py (runs pre-drone)
  can depend on it without breaking the pre-infrastructure constraint. Verified:
  bootstrap zero-import intact, real aipass init still scaffolds a fresh project.
- Duplicate copies deleted: spawn keeps a thin re-export shim; aipass json_handler
  shrank 254 -> 88 lines; aipass find_registry dedup'd across structure_scanner,
  doctor, doctor_fix.
- save_json contract UNIFIED: raises ValueError on invalid structure (was
  return-False in aipass). All call sites + tests updated to the raise contract.
- find_registry dedup scoped to spawn<->aipass only; seedgo/drone copies flagged
  as follow-up.

Verified: 313 spawn + 434 aipass tests green; seedgo 100% both; aipass.common
branch-free; aipass init scaffolds post-refactor.

TDPLAN-0006 P2. P3 (move project-update into spawn, kill init_flow import) +
P4 (.recovery relocate) to follow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 00:03:15 -07:00
AIOSAIandClaude Opus 4.8 ccc8d6a97b fix(spawn): dry-run-default + path-based update engine — kill #636 branch-scrambler (TDPLAN-0006 P0+P1)
#636: drone @spawn update would scramble every branch's identity/memory in
one command. On a branch created seconds earlier, --dry-run proposed 30 renames
rotating identity dirs (apps->.trinity->.seedgo->.claude->.archive->.aipass),
README->DASHBOARD, and deep-merged stale template into live .trinity/. Root
cause: the CREATE path regenerated template-registry IDs in filesystem-walk
order (!= the master's hand-crafted IDs), so content-hash + rename-detection
saw a mismatch on a pristine branch. update --all would have destroyed all 13
citizens at once.

P0 — safety by default:
- update + repair are now dry-run by default; --apply required to write.
  Forgotten flag = safe preview-only no-op. --dry-run kept as alias.
- doctor_fix.py repair suggestions emit the matching --apply form
  (+ aipass test_doctor_fix updated to the new contract).

P1 — engine rebuild (update_ops.py v2.0):
- Path-based named-managed-files model replaces whole-tree hash-diff +
  rename-detection. ID divergence is moot — IDs are no longer used.
- .trinity/*, DASHBOARD.local.json, artifacts/birth_certificate.json,
  .seedgo/bypass.json = delivered on CREATE only, NEVER touched on update.
- Old ID engine (change_detection.py, reconcile.py) + orphaned tests deleted.

Verified on fresh sandbox: update --dry-run = 0 renames / 0 updates / 0
additions (create==update invariant); no-flag run = dry-run preview, filesystem
byte-identical; 313 spawn tests green; seedgo 100% (all 36 standards).

Closes #636. P2/P3/P4 (shared lib, seam, .recovery relocate) to follow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 22:54:09 -07:00
AIOSAI 1ef1e2e89c feat(memory): auto-process memory pool + rollover on session-start/pre-compact (TDPLAN-0005) 2026-06-06 20:28:19 -07:00
AIOSAIandClaude Opus 4.8 8efb204486 fix(seedgo): de-git readme_check — audit reads local files only (DPLAN-0198)
Drops git check-ignore + git log from readme_check. Runtime dirs tolerated via
static list (_is_runtime_artifact); freshness checks date-presence only, no
history comparison. Local-CI parity proven 13/13 both ways (working tree +
git archive clean checkout). Invariant: a checker never consults git or
.gitignore; only bypass.json excludes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 16:31:38 -07:00
AIOSAI 0661949c15 docs(readme): use official HVTracker dynamic badge 2026-06-06 07:06:55 -07:00
AIOSAI 0f26efd706 docs(readme): add HVTracker badge to cluster (closes #628) 2026-06-06 07:06:05 -07:00
AIOSAIandClaude Opus 4.8 a242489c6d ci: remove path filter from Windows/macOS Test so required checks always run
Windows Test + macOS Test only triggered on changes to setup.sh / drone/cli.py
/ handlers/__init__.py / pyproject.toml, but branch protection requires their
checks (windows-setup / macos-setup). On any PR not touching those paths the
workflows never ran, so GitHub parked the required checks as 'Expected —
waiting for status' forever, blocking merge — exactly what happened to PR #631
(the tests last ran + passed yesterday on the version-bump commit; tonight's
commits didn't match the filter so they never fired). The OS code is fine:
e2e-wheel's windows-latest + macos-latest passed on the same commits.

Fix: drop the paths filter; run on every push/PR to main/dev like the other
required lanes (CI/lint/coverage/security/e2e are none of them path-filtered).
A required status check must never be path-filtered or it stalls PRs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 05:30:40 -07:00
AIOSAIandClaude Opus 4.8 1ee51f3295 ci(security): upgrade pip in dependency-scan, drop stale ignores
dependency-scan (pip-audit) was red: it scans the whole env, and the runner's
bundled pip 26.1.1 carries PYSEC-2026-196 (fixed in 26.1.2). The job was the
only CI job not upgrading pip. Now runs 'python -m pip install --upgrade pip'
before auditing — removes the vulnerable version outright instead of
suppressing it.

pip 26.1.2 also fixes CVE-2026-3219 and CVE-2026-6357 (both were pip vulns, per
pip-audit attributing them to the pip package), so the two now-stale
--ignore-vuln entries are removed — stale security ignores mask the exact CVEs
they name if those reappear elsewhere.

Verified in a clean reproduction of the job env (fresh venv, upgrade pip, pip
install -e ., pip-audit --skip-editable with NO ignores): 'No known
vulnerabilities found', exit 0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 04:54:11 -07:00
AIOSAIandClaude Opus 4.8 27a175b2c9 ci(seedgo-audit): install memory extra so pyright resolves chromadb/numpy (DPLAN-0195)
Final straggler: memory scored 98% (diagnostics 55% = 9 pyright errors) in CI
while 100% locally. Proven cause: the diagnostics standard runs pyright over
every branch; memory's handlers import chromadb/numpy at module level. These
are declared in the 'memory' optional-dependencies group, NOT 'dev' — and the
audit job installed only '.[dev]', so pyright flagged them unresolved
(reportMissingImports=error) → 9 false errors. My local .venv happens to have
chromadb, which is why local audits read 100%.

Fix: audit job installs '.[dev,memory]'. pyright now resolves memory's real,
declared deps and the standard measures actual type-correctness (and matches a
local audit). api imports openai (llm extra) but guards it lazily, so it stays
100% without that extra — only memory needed this.

12/13 were already green after the readme check-ignore fix; this clears the
13th.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 00:32:29 -07:00
AIOSAIandClaude Opus 4.8 4c7e14a255 fix(seedgo): readme check-ignore must match dir-only patterns on clean checkout (DPLAN-0195)
The last 1%: 7 branches scored 99% in CI while 100% locally. Root cause proven
by reproducing CI's exact path (tracked-only tree + real .git): .gitignore
dir-only patterns (trailing slash — logs/, **/*_json/, .trinity/) do NOT match
via 'git check-ignore <bare-path>' when the path is absent from disk (clean
checkout), because git cannot infer 'directory' to apply a dir-only pattern.
The working tree has those dirs on disk, so it matched there — the exact
working-tree-vs-clean-checkout divergence.

_is_gitignored now also tests the trailing-slash form; all 7 readme failures
(cli_json/logs/artifacts/.trinity/ etc flagged 'missing on disk') clear.
Regression test builds a real git repo with dir-only patterns + non-existent
paths. CI gate also now prints failing standards + check messages (says WHY).

Verified: clean tree w/ real .git 13/13 100%; working tree 13/13 100%; seedgo
1053 tests green; pyright 0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-06 00:19:38 -07:00
AIOSAIandClaude Opus 4.8 24065f11b3 fix(seedgo): audit committed source not working tree — seedgo-audit CI gate green (DPLAN-0195)
Four standards checkers validated the working tree, so CI (clean checkout =
tracked files only) scored ~97% while local audits passed at 100%. Fix each
to measure what git actually ships:

- log_structure: skip absent gitignored logs/ dir (keeps hardcoded-path checks)
- readme: cross-ref .gitignore (git check-ignore + fallback), skip ignored
  dirs/links in tree + dead-link checks
- encapsulation: infer branch from path when gitignored REGISTRY absent; fix
  aipass-branch collision
- architecture: skip cleanly when gitignored passport.json absent

Clean-tree AND working-tree audits both 13/13 = 100%. seedgo 1052 tests green,
pyright 0.

Also: git_gate read-verb allowlist (22 read verbs raw, write stays drone-gated);
update devpulse test_git_gate contract to match; devpulse local-prompt git
breadcrumb.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-05 23:58:53 -07:00
AIOSAI 176f68439c ci(standards): full-history checkout for audit + honest aipass README refresh 2026-06-05 22:29:19 -07:00
AIOSAI c58fd263ab ci(standards): all 13 branches to genuine 100% — file-size advisory + readme-freshness git-history 2026-06-05 21:56:46 -07:00
AIOSAI d5829f80e8 ci(seedgo-audit): raise standards floor 80%->100%
The seedgo-audit gate passed everything at >=80% while all branches sit
at 99-100%, so it caught nothing. 100% is the floor: any drift names the
branch and reds the build. Expected to fail until the 6 branches at 99%
(aipass/api/drone/flow/prax/seedgo) reach a genuine 100%.
2026-06-05 19:44:35 -07:00
AIOSAI cc8f809a50 refactor(seedgo): archive pre-DPLAN-0184 hook cruft (FPLAN-0241)
Archive orphaned hook bridge/probe/manifest modules + their tests to
.archive/ — their only callers were the .claude/hooks scripts disabled
by DPLAN-0184. Seedgo audits hooks via standards; the hooks branch owns
the engine/bridge/handlers. README + bypass.json + prompts updated to
match. 1045 tests green, pyright clean.
2026-06-05 19:44:35 -07:00
AIPass 8a843429ca Merge pull request #629 from AIOSAI/dev
Fix dashboard plan-count zeroing + aipass bare-command introspection

Two verified bug fixes:

1. fix(flow): dashboard refresh no longer zeroes non-flow branch plan counts.
   PLANS.central.json now comprehensive (all branches grouped per-branch).
   Devpulse shows its 12 open plans again. +1 regression test, 734 pass.

2. fix(aipass): bare 'aipass <command>' runs instead of showing introspection
   banner. All 7 modules fixed; 'aipass doctor' runs the health check.
   Introspection moved to --info. seedgo standard bypassed for binary-invoked
   modules. 424 tests pass.

Both verified independently: dashboard refresh writes active_plans=12 (was 0);
bare 'aipass doctor' runs the full check.
2026-06-04 18:01:57 -07:00
AIOSAIandClaude Opus 4.8 8bd270287d chore(release): bump 2.5.0 -> 2.5.1
- pyproject: patch bump (cross-OS e2e wiring harness + Windows portability
  fixes landed this week; CHANGELOG [2026.W23] documents the work)
- tests/CROSS_OS_TESTING.md: add manual layer-3 cross-OS acceptance checklist
  (living draft; refined as real Win/Mac VM runs surface gaps)
- prax dashboard: drop commons_mentions from quick-status calc

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 17:52:23 -07:00
AIOSAI 80aac59423 style(e2e): ruff format conftest.py (fixes CI lint lane)
tests/e2e/conftest.py shipped unformatted in cd1af34, so 'ruff format
--check src/ tests/' failed the CI lint job. Pure formatting (string
concat join); no logic change. ruff check + ruff format --check + e2e
14/14 all green locally.
2026-06-04 01:24:52 -07:00
AIOSAIandClaude Opus 4.8 668841417f fix(portability): aipass init UTF-8 stdout on Windows + CI e2e lane (DPLAN-0194)
The real T1 Windows bug (diagnosed via the now-reverted error-surfacing
probe): aipass init scaffolds fine, then crashes printing its success
banner — Rich writes the success glyphs through a cp1252 stdout
(UnicodeEncodeError 'charmap'). Same class as the drone fix. The aipass
entry point now reconfigure()s stdout/stderr to UTF-8 in place on Windows.

Also: ci.yml's broad 'pytest --rootdir=.' swept in tests/e2e (which build
a wheel via the dedicated e2e-wheel.yml), failing the unit lane since the
harness landed; now --ignore=tests/e2e in both pytest jobs.

route_command error-surfacing probe reverted to honor 'no function change'
(the masked-error mislabel is noted as a separate @aipass recommendation).

Local: e2e 14/14 green, aipass units 24/24, ruff clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 01:17:56 -07:00
AIOSAIandClaude Opus 4.8 89fa2c1db2 fix(aipass): surface module errors instead of masking as 'Unknown command'
route_command swallowed any handle_command exception and let main() print
a misleading 'Unknown command', hiding real failures (e.g. the Windows
aipass-init error the e2e harness hit). It now also prints the failing
module + traceback to stderr. Bool contract unchanged; 24/24 aipass unit
tests pass. This makes the masked Windows init failure diagnosable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 01:06:36 -07:00
AIOSAIandClaude Opus 4.8 f3b3ebad9b fix(portability): Windows aipass init + drone stdout (DPLAN-0194)
Two latent Windows portability bugs caught by the new e2e wiring harness:

- aipass init: _preflight_check ancestor walk crashed on OSError from
  un-enumerable Windows drive-root entries (pagefile.sys), swallowed by
  route_command as 'Unknown command: init'. Walk now skips unreadable
  entries (logged).
- drone @branch: crashed with UnicodeEncodeError ('charmap') printing a
  routed branch's captured output via Rich on cp1252 stdout. PYTHONUTF8
  only affects child interpreters; entry point now reconfigure()s the live
  stdout/stderr to UTF-8.

Pure portability — Linux/macOS behaviour unchanged. e2e suite 14/14 green
locally on Linux. Lets the 3-OS CI verify Windows.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 01:00:01 -07:00
AIOSAIandClaude Opus 4.8 cd1af34be8 test(e2e): cross-OS wiring harness + 3-OS CI, red-first (FPLAN-0239)
Build-wheel -> install-clean -> assert 4-tier wiring ladder (install/init/
hooks-fire/drone-route). Validated green on Linux; Windows red-first by design
(symlink/venv-path/tmp gaps = DPLAN-0194 P3 fix-list).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 00:03:37 -07:00
AIOSAI 3ad0580070 docs(readme): add OpenSSF Best Practices passing badge (DPLAN-0193) 2026-06-03 14:37:43 -07:00
AIOSAI 4383c6c9d8 security(docker): pin ubuntu:24.04 base image by digest (DPLAN-0193 step 2) 2026-06-03 11:51:32 -07:00
AIOSAI ee78c39e80 security(deps): pin requests>=2.34.2 to clear 6 OSV advisories (DPLAN-0193 step 1) 2026-06-03 11:34:02 -07:00
AIOSAI 87d131218e feat(hooks): log agent_type/agent_id per hook fire for visibility (#606) 2026-06-02 22:02:22 -07:00
AIOSAI e63a4e9945 feat(#630): retire blanket rm deny + aipass doctor migration
Phase 2 of #630. The rm_gate hook + drone rm now own destructive-delete
protection (cross-provider, path-aware, teaching), so the Claude-only blanket
deny is redundant AND harmful (it short-circuits before the hook, suppressing
the teaching message).

- setup.sh: removed Bash(rm -rf*) + Bash(rm -r *) from git_deny (new installs)
- bootstrap.py: removed Bash(rm -rf *) shipped via aipass init (project settings)
- doctor_wire.reconcile_stale_deny(): aipass doctor WARNs on stale rules;
  --fix removes them (idempotent, preserves all else) — migration for existing
  installs (the 'aipass update should be trusted' goal)
- .aipass/project_hooks.json template: added rm_gate (new projects get it)

Tests: 8 reconcile + 432 aipass total, seedgo 99%. CHANGELOG W23.
2026-06-02 20:24:21 -07:00
AIOSAI 2f5ce5ac87 feat(#630): drone rm safe-delete + rm_gate block-and-teach hook
Provider-agnostic temp/scratch cleanup that doesn't trip the rm -rf block.

- drone rm <path>: contained recursive delete (project root + /tmp + $TMPDIR),
  refuses outside roots and hard-carves .git/.trinity/.aipass/.codex/.agents +
  sibling-branch worktrees. Mirrors Codex's OS-sandbox boundary in software so
  behavior is consistent across CLIs. Pure-python, red-team tested.
- rm_gate (PreToolUse hook): blocks raw recursive rm, teaches 'drone rm',
  cross-provider, conservative-block on unparseable targets. Mirrors git_gate.
- Wired rm_gate into .aipass/hooks.json; CHANGELOG W23.

Tests: 56 drone rm + 56 rm_gate, seedgo 99% both. Phase 2 (remove the now-
redundant rm deny from setup.sh + aipass doctor migration) tracked separately.
2026-06-02 20:05:16 -07:00
AIOSAIandClaude Opus 4.8 895b8f04fd fix(drone): protect dev on merge + live-remote branches + scope footer (#625, #623)
#625 (HIGH): drone @git merge passed --delete-branch to gh pr merge
unconditionally, so merging a dev->main PR DELETED the persistent dev branch
on the remote and left the tree on main (next commit silently on main). Now:
- merge looks up the PR head ref and only appends --delete-branch for
  non-protected branches; dev/main are never deleted. Unknown head ref fails
  SAFE (no delete) — devpulse hardening on top of @drone's protected-branch set.
- after merge, return the working tree to dev (loud warning if it can't).
- branches_handler runs git fetch --prune before git branch -r (no more
  'cached lies' reporting deleted branches as live).
- new drone @git prune-temp cleans merged temp PR branches (citizen/*).

#623: status/diff append a '(showing <branch> scope — use --all for full repo)'
footer when scoped, so an empty scoped view isn't mistaken for a clean repo.
Blank-output sub-item not reproducible — documented.

@drone built fixes 1-5 (FPLAN-0236); devpulse added the unknown-head-ref
fail-safe + test and verified independently. drone suite 716 pass, seedgo 99%.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 17:39:01 -07:00
AIOSAIandClaude Opus 4.8 bedf58e7b5 fix(drone): external projects can resolve AIPass branches (#618)
resolve_branch() validated branch path containment against the primary
registry root even when the branch was found via the AIPASS_HOME fallback,
so external projects (Vera, Daemon) were blocked from calling @api and any
other AIPass branch with 'path escapes project root'.

Add get_branch_with_registry() (non-breaking sibling to get_branch_by_name)
that returns the branch plus the registry it was found in. resolve_branch()
now validates containment against that registry's root. Security preserved:
each branch stays contained within its own declaring registry; genuine
escapes still blocked. 4 new cross-project resolver tests, 58 resolver
tests pass, drone suite 702 pass, seedgo @drone 99%.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 16:25:46 -07:00
AIOSAIandClaude Opus 4.8 cc449c4a18 docs(readme): trim badge cluster — remove OSS Health metric badge
Cluster was getting busy; dropped the OSS Health monitor badge to keep the
top row focused (Status/Python/License/PyPI/Feedback/codecov/Scorecard).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 15:48:07 -07:00
AIOSAIandClaude Opus 4.8 da46dde7ce chore(aipass): purge stale placeholder bypass entries + refresh metadata
Removed 5 stale Phase-0/Phase-4 bypasses (verified seedgo passes without them
now that aipass is fully built). Restored 3 aipass.py entries (cli/debug_print/
introspection) with accurate current reasons — thin command router, not a
module. Metadata description updated to current operational state. 58→53 entries.
424 tests pass, seedgo 99%.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 15:46:26 -07:00
AIOSAIandClaude Opus 4.8 a880139a1e docs(readme): move OpenSSF Scorecard badge into the top badge cluster
Was orphaned in its own centered block between the logo and demo gif, and the
only badge in raw HTML. Moved up with the other 7 badges and converted to
markdown for consistency. Grouped with codecov/OSS-Health (security-health).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 15:33:07 -07:00
AIOSAIandClaude Opus 4.8 f7d7f78c63 fix(aipass): bare 'aipass <command>' runs the command, not an introspection banner
aipass is a user-facing binary — 'aipass doctor' must run the health check,
not describe itself. All 7 modules (doctor, doctor_fix, doctor_wire, handoff,
help_chat, init_flow, profile) hit a no-args→introspection gate (a standard
meant for 'drone @branch <module>' discovery). Bare invocation now runs the
command or shows usage; introspection moved to --info. seedgo introspection
standard bypassed for these binary-invoked modules (documented). 424 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 15:22:22 -07:00
AIOSAIandClaude Opus 4.8 ed58eb7aa6 fix(flow): dashboard refresh no longer zeroes non-flow branch plan counts
PLANS.central.json only held Flow's own plans (location==FLOW_ROOT filter),
so every dashboard refresh overwrote each branch's real active_plans with 0.
Central is now comprehensive — all plans grouped per-branch. Devpulse shows
its 12 open plans again. +1 regression test (734 pass).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-02 15:22:12 -07:00
AIPass 740ba30f59 Merge pull request #626 from AIOSAI/dependabot/github_actions/github/codeql-action-4.36.0
ci(deps): bump github/codeql-action from 4.35.3 to 4.36.0
2026-05-30 16:10:33 -07:00
AIPass 85f0292828 Merge pull request #627 from AIOSAI/dependabot/github_actions/actions/download-artifact-8.0.1
ci(deps): bump actions/download-artifact from 6.0.0 to 8.0.1
2026-05-30 16:10:15 -07:00
dependabot[bot] 0a617586d5 ci(deps): bump actions/download-artifact from 6.0.0 to 8.0.1
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6.0.0 to 8.0.1.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/018cc2cf5baa6db3ef3c5f8a56943fffe632ef53...3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-05-30 08:02:57 +00:00
dependabot[bot] 62e639794f ci(deps): bump github/codeql-action from 4.35.3 to 4.36.0
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.36.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/e46ed2cbd01164d986452f91f178727624ae40d7...7211b7c8077ea37d8641b6271f6a365a22a5fbfa)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-05-30 08:02:55 +00:00
AIPass 95894e4ca7 Merge pull request #624 from AIOSAI/harden-ci-workflows-for-openssf-scorecar
Harden CI workflows for OpenSSF Scorecard: least-privilege token permissions + SHA-pinned actions
2026-05-29 23:58:39 -07:00
AIOSAI efa5aced74 ci: harden workflows — least-privilege permissions + SHA-pinned actions 2026-05-29 23:47:27 -07:00
AIPass 4c33cc1f69 Merge pull request #619 from AIOSAI/dev
fix: deny EnterPlanMode in aipass init scaffold + Bluesky/dev.to drivers built
2026-05-29 22:56:58 -07:00
AIOSAI aa962bdc12 release: bump to 2.5.0 + finalize W22 CHANGELOG 2026-05-29 22:51:57 -07:00
AIOSAI fbd90d74b3 fix(hooks): Windows-safe subagent_gate tests via tmp_path 2026-05-29 22:43:52 -07:00
AIOSAI 5fe96307a4 ci: cut GitHub Release on tag from CHANGELOG
- publish.yml: new github-release job runs after PyPI publish, extracts the
  top CHANGELOG section as release notes, attaches dist, creates the Release
  via gh. Same v* tag now drives PyPI + GitHub Release.
- CHANGELOG W22 entry
2026-05-29 15:54:07 -07:00
AIOSAI e27a50c78d ci: add OpenSSF Scorecard workflow + README badge
- .github/workflows/scorecard.yml — official OSSF Scorecard action, runs on
  push to main + weekly, publishes public score, actions pinned by SHA
- README OpenSSF Scorecard badge
- CHANGELOG W22 entry
- CLAUDE.md startup-protocol guard (sequential steps, no batch/duplicate calls)
2026-05-29 15:41:14 -07:00
AIOSAIandClaude Opus 4.8 f8f102e16f fix(hooks): subagent_gate package-aware — closes #605
subagent_gate.py derived package name dynamically from CWD (mirrors edit_gate),
replacing 3 hardcoded src/aipass/ paths. Branch detection + cross-branch
protection now work for external projects (src/<package>/<branch>); previously
silently no-opped. 5 new external-project tests (258 pass), seedgo 100%.

Closes #605

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 00:33:50 -07:00
AIOSAIandClaude Opus 4.8 97a3276b81 hooks: full branch ownership — 100% seedgo + drone @hooks status
@hooks took full ownership of its branch (DPLAN-0191):
- 100% seedgo (all 36 standards; dead_code 25%->100%, unused_function 80%->100%)
- 15 handlers verified wired + firing; dynamic-dispatch flags documented as
  architectural bypasses (importlib dispatch from hooks.json, never statically imported)
- README rewritten: two-tier provider/project model, dynamic-dispatch design, event table
- 2 stale tests resolved (253 pass, 0 fail)
- New drone @hooks status read-only config viewer (DPLAN-0190 Phase B)

api/.gitignore: exclude integration tests (no code on user machines -> would fail)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-29 00:12:08 -07:00
AIOSAI 35a63b9540 fix: bootstrap @hooks as 13th branch + correct stale 12-counts
setup.sh never bootstrapped @hooks (hardcoded 12-branch list, stale comment from before hooks existed). Fresh clones got no @hooks passport + an absolute registry path -> drone @hooks commands failed ('path escapes project root'). Engine still fired (runs from AIPASS_HOME) but the citizen was non-functional.

- setup.sh: + bootstrap_branch hooks, 12->13 count + comment
- .aipass/aipass_global_prompt.md: 12->13 core branches, + hooks (injected every turn)
- devpulse local prompt: 13 Core Branches, + @hooks experts row
- dashboard dispatch_section docstring: 12->13

Found via Docker clone-from-dev test (DPLAN-0190 Phase D).
2026-05-28 19:51:27 -07:00
AIOSAI 574ae79b1a feat(hooks): ship .aipass/hooks.json on aipass init (DPLAN-0190 Phase A)
- bootstrap.py: write hooks.json from template at init, union-merge on update (preserves user on/off), remove dead _ship_hooks/HOOKS_TO_SHIP
- doctor.py: check .aipass/hooks.json presence
- .aipass/project_hooks.json: base template (all 14 handlers)
- .aipass/.gitignore: whitelist template so it ships in clones
- +13 tests, 421 pass, seedgo 99%
2026-05-28 19:41:10 -07:00
AIOSAI a752923ae2 fix: deny EnterPlanMode in aipass init scaffold 2026-05-27 13:48:34 -07:00
AIPass 0c5d26284c Merge pull request #617 from AIOSAI/dev
docs: CHANGELOG — logo + v2.4.0 release
2026-05-26 13:17:29 -07:00
AIOSAI b925714589 docs: CHANGELOG — logo + v2.4.0 release 2026-05-26 13:16:52 -07:00
AIPass 91a9eeb233 Merge pull request #616 from AIOSAI/bump-version-230-240
bump: version 2.3.0 → 2.4.0
2026-05-26 13:15:12 -07:00
897 changed files with 104774 additions and 14874 deletions
+6 -3
View File
@@ -1,7 +1,10 @@
*
!aipass_global_prompt.md
!tier0_kernel.md
!tier1_navmap.md
!hooks.json
!.gitignore
!README.md
!PROMPT_STYLE.md
!project_CLAUDE.md
!project_global_prompt.md
#Do not add other exceptions here without careful consideration. Developer permissions0ns needed.
!project_hooks.json
#Do not add other exceptions here without careful consideration. Developer permissions0ns needed.
+13 -2
View File
@@ -15,9 +15,19 @@ Goal: signal density over prose. Prompts are injected every turn — every line
- Code blocks: inline backticks for commands (`` `drone @ai_mail dispatch` ``). Multi-line fenced blocks only for directory trees, template skeletons, or command examples that don't fit inline.
- File length: aim for under 230 lines. Global and branch prompts are injected every turn — every line costs tokens.
# Writing voice (agent output + memory)
How agents write responses, reports, and memory entries. Validated against Claude Code's own prompt (DPLAN-0213).
- Reference code as `file_path:line_number` — clickable, unambiguous.
- No colon before a tool call. "Let me read the file." then call it, not "Let me read the file:".
- No emojis in agent output unless the user uses them first.
- Write for a reader who stepped away and lost the thread: no codenames or shorthand they would have to decode. Clarity over terseness — the goal is the reader understanding with no mental overhead.
- Where detail lives, three tiers: a short capability phrase (registry/search), a one-line summary (`drone @agent`), the full reference (`drone @agent --help`). Keep the injected prompt terse; push depth into --help.
# What NOT to put in a prompt
- Session state, current work, in-flight issues. That goes in `STATUS.local.md` and `.trinity/local.json`.
- Session state, current work, in-flight issues. That goes in `.trinity/local.json` (todos[]) and `DASHBOARD.local.json`.
- Long explanations of how a system works. Plant a breadcrumb ("see `@branch --help`") and move on.
- Personal notes ("remember, you like short replies"). That goes in `.trinity/observations.json`.
- Version numbers, PR numbers, dates. Those rot within days.
@@ -36,6 +46,7 @@ These are not currently enforced by seedgo — per @seedgo's Track 5 recommendat
# Reference files
- `.aipass/aipass_global_prompt.md` — canonical example of the format
- `.aipass/tier0_kernel.md` + `.aipass/tier1_navmap.md` — the live injected prompts (Tier 0 every turn, Tier 1 periodic); canonical examples of the format
- `.aipass/aipass_global_prompt.md` — superseded by the tiers (FPLAN-0284), kept as a reference snapshot
- Branch `.aipass/aipass_local_prompt.md` files — should follow the same rules
- This file — reference for authoring new prompts or auditing existing ones
+76
View File
@@ -0,0 +1,76 @@
# `.aipass/` — project prompt & hook config
This folder holds the **project-level prompt** and **hook configuration** for the AIPass
repo, plus the **templates** `aipass init` stamps into every new project. It is the
*project* layer; each branch additionally has its own branch prompt at
`src/aipass/<branch>/.aipass/aipass_local_prompt.md`.
> **Nothing here is dead weight.** Every file is live injection, live config, or a
> required new-project template. Superseded files live in `.archive/` (never deleted).
## One prompt system, every runtime
There is **one** source of prompt truth — the **tier files** — and **all** runtimes inject
the same content. We do **not** keep separate prompts per CLI. Only the *delivery* differs:
| Runtime | How the same content is delivered |
|---|---|
| **Claude Code** | **Tiered by cadence** (FPLAN-0284): `tier0_kernel.md` every turn + `tier1_navmap.md` periodically + post-compaction |
| **Codex CLI** | Injected **once at SessionStart** (no per-turn cadence): the same tier content, combined |
> ⚠️ **Migration in progress.** The Codex SessionStart hook
> (`.codex/hooks/session_start_identity.py`) currently still reads the legacy
> `aipass_global_prompt.md`. @hooks is wiring it onto the tier files. **Retire for one
> runtime = retire for all** — once Codex is on the tiers, `aipass_global_prompt.md` is
> read by nothing and moves to `.archive/`.
## Files
### Live — this repo's prompt + config
| File | What it is |
|---|---|
| `tier0_kernel.md` | **The kernel** — tiny identity + `drone --help` reflex + don't-get-lost rules. The always-on core, for every runtime. |
| `tier1_navmap.md` | **The navmap** — full agent roster, framework, terminology. The periodic/fuller layer, for every runtime. |
| `hooks.json` | Claude Code **handler registration** for this repo — which prompt/gate/notification handlers fire on which events. |
| `PROMPT_STYLE.md` | The writing-style guide every prompt here follows. |
| `.gitignore` | Whitelist guard — only files listed here are tracked; everything else in `.aipass/` is ignored. |
| `aipass_global_prompt.md` | **Legacy single global — being retired.** Disabled for Claude Code; Codex still reads it until its migration lands, then archived. **Not** the source of truth. |
### Templates — stamped into new projects by `aipass init` (`bootstrap.py`)
| File | Stamps → | Notes |
|---|---|---|
| `project_hooks.json` | new project's `.aipass/hooks.json` | **REQUIRED** — without it a new project's hooks never fire. Mirrors the live wiring (tier0 + navmap enabled, global disabled). |
| `project_CLAUDE.md` | new project's `CLAUDE.md` | the project's Claude Code instructions. |
| `project_global_prompt.md` | new project's `aipass_global_prompt.md` | **Legacy** — same retirement path as the global above (new projects ship tiers-only once Codex is migrated). |
(`AGENTS.md` — Codex's equivalent of `CLAUDE.md` — is **generated** by `bootstrap.py`
when no `project_AGENTS.md` template exists, so none is kept here.)
## What a new project gets (`aipass init`)
`bootstrap.py` seeds a fresh project with the tiered system:
- `tier0_kernel.md` + `tier1_navmap.md` → the prompt content (every runtime)
- `hooks.json` (from `project_hooks.json`) → tier0 + navmap enabled, global disabled
- `CLAUDE.md` (from `project_CLAUDE.md`) + a generated `AGENTS.md`
- `aipass_global_prompt.md` (from `project_global_prompt.md`) → legacy, retiring with the above
`aipass init update` backfills the tier files + refreshes hooks for existing projects.
## Changing a prompt here
Run the **prompt-change playbook** so a change reaches every runtime and every seed path:
```
drone @flow create . "What changed" prompt_change
```
Golden rule: **live ≠ seeded.** Editing this folder fixes *this* repo only. New projects
come from the `project_*` templates + `bootstrap.py`; fresh clones get their machine-local
wiring from `setup.sh` + `.claude/provider_manifest.json` + `cadence.py` defaults. And
**every runtime** (Claude Code + Codex) must point at the same tier content.
## Archive & recovery
Superseded files move to `.archive/` (never deleted — house rule). Recover from there, or
from git history, any time. Current archive: the pre-tiering
`aipass_global_prompt.BACKUP-2026-06-09-S211.md` snapshot.
-253
View File
@@ -1,253 +0,0 @@
# AIPass — Project Context
<!-- File: .aipass/aipass_global_prompt.md — Injected every prompt via hook. Branch-specific context below when in a branch directory. -->
Multi-agent framework. Autonomous agents (citizens) live in branches with identity (.trinity/), memory, mailbox, code (apps/). Orchestration via `drone`.
Patterns here are exact. Don't guess command syntax — examples are the API. Missing instructions = prompt bug, not knowledge gap.
`drone` = installed binary, always on PATH. Run directly. Never invoke as python module.
`drone @branch --help` for any branch's full detail.
# AIPL — Terse Writing Convention
When writing .trinity/, ai_mail, STATUS.local.md, plans: use AIPL. Human-facing output (CLI, logs, README): use English.
Rules:
- Drop grammar: the, a, an, for, with, on, in, at, to, from, of, by, and, but, or, was, were, been
- Keep: nouns, numbers, names, paths, negation
- Symbols replace verbs: + done - removed ! new ? checked > sent < received * all : kv / separator
- Delta-only: only store what changed since last entry
- Time: -3d10h (3 days ago) 2h30m (duration) prev-s (last session)
- Tone tags for observations: ~flow ~spark ~pivot ~drift ~trust ~grit ~check ~warm ~clear ~flat
Examples:
- "The session was completed successfully" → "session complete"
- "Dispatched audit to seedgo, received results" → ">seedgo:audit/<results"
- Session log: "S145: +CI green/+coverage 76%/+commit handler auto-format/>api+cli+flow:coverage tests"
# Terminology
- Branch — directory `src/aipass/{name}/`. Your home, your address. Drone routes to branches.
- Agent (citizen) — persistent identity in a branch. Has passport (`.trinity/`), memories, mailbox. Irreplaceable. Addressable as `@name`. Citizens of AIPass — you belong, you persist, your presence matters.
- Sub-agent — disposable worker spawned for a task. No passport, no memory, not a citizen.
- Registry — `AIPASS_REGISTRY.json` tracks all agents.
- Provider settings — `~/.claude/settings.json`. Machine-wide Claude Code config. Personal preferences only. Don't touch.
- Project settings — `<project>/.claude/settings.json`. Ships with clone. Hooks, permissions, deny/ask rules, env vars. Built by `aipass init`.
- Project local settings — `<project>/.claude/settings.local.json`. Also ships with clone. Project-specific overrides.
Agents live in branches. Sub-agents work for agents. `.trinity/passport.json` = agent (citizen), not sub-agent.
Never manually edit a registry. AIPASS_REGISTRY.json, fplan_registry.json, dplan_registry.json — all managed by their owning systems (spawn, flow). Use the commands: `drone @flow create/close`, `drone @spawn`. Manual edits corrupt counters and break pipelines.
# Branches
Every branch follows same structure:
```
src/aipass/{name}/
├── .trinity/ # Identity & memory (passport.json, local.json, observations.json)
├── .aipass/ # Branch prompt (aipass_local_prompt.md)
├── .ai_mail.local/ # Mailbox (inbox.json, sent/)
├── apps/
│ ├── {name}.py # Entry point (e.g. spawn.py, prax.py, drone.py)
│ ├── modules/ # Business logic
│ └── handlers/ # Implementation details
├── logs/ # Prax log output
└── README.md
```
12 core branches: aipass, drone, seedgo, prax, cli, flow, ai_mail, api, trigger, spawn, memory, devpulse.
# Commands
`drone` is global CLI in PATH. Never `cd` before running. Never prefix with path. Just `drone`.
- `drone @branch command [args]` — route command to any branch
- `drone @branch --help` — branch help and full command reference
- `drone systems` — list all registered branches
- `drone --help` — full drone reference
# Git — Zero Direct Access
All `git` and `gh` commands blocked at project level. Drone is the only git interface.
Read-only awareness (all branches):
- `drone @git status` — what changed in your branch directory
- `drone @git diff` — see actual changes
- `drone @git log` — recent commit history
All write operations (commit, push, merge, checkout) restricted to devpulse via tier-based access. Dispatched agents build code, run tests — devpulse reviews diff, commits.
Drone runs git via Python subprocess, bypasses settings.json deny rules by design — drone is the gate. Git gate (PreToolUse hook) enforces mechanically — applies to ALL sessions including dispatched agents. bypassPermissions does not skip hooks.
Local files = source of truth. Edit file → state on disk IS reality.
Linting and formatting run automatically on commit via drone's commit handler (ruff check --fix + ruff format).
# aipass CLI
`aipass` = standalone binary (`/usr/local/bin/aipass`). User-facing tool — not drone-routed. Users run `aipass` directly without knowing about drone.
Commands: `aipass init`, `aipass doctor`, `aipass handoff`, `aipass help`, `aipass profile`. Never `drone @aipass` — that's not how it works.
`aipass init` bootstraps AIPass project in any directory, inside or outside repo. Creates registry, identity, memory, local prompt. Any folder becomes AI-powered workspace with persistent memory. Spawn adds full agent scaffolding on top.
Source: `src/aipass/cli/apps/handlers/init/bootstrap.py`
# Standards
- `drone @seedgo audit aipass` — audit all branches
- `drone @seedgo audit aipass @branch` — audit one branch
- `drone @seedgo checklist <file>` — quick check single file
- `drone @seedgo checklist <dir>` — check all .py in directory
- `drone @seedgo --help` — full standards reference
# Mail — Dispatch, Inbox, Communication
Use `dispatch` by default. `email` only when receiver doesn't need to act now.
Send and wake:
- `drone @ai_mail dispatch @target "Subject" "Body"` — send + wake (DEFAULT)
- `drone @ai_mail dispatch @target "Subject" "Body" --fresh` — send + wake fresh session
- `drone @ai_mail dispatch wake @target` — wake only, no email
- `drone @ai_mail dispatch wake --fresh @target` — wake fresh, no email
Send without waking:
- `drone @ai_mail email @target "Subject" "Body"` — FYI only
- `drone @ai_mail email @target "Subject" "Body" --dispatch` — adds dispatch header, no wake
Read and reply:
- `drone @ai_mail inbox` — check mailbox
- `drone @ai_mail view <id>` — read message
- `drone @ai_mail close <id>` — mark read
- `drone @ai_mail reply <id> "message"` — reply and auto-close
- `drone @ai_mail --help` — full mail reference
Always reply to dispatch emails. Complete task → email back results. No silent completions.
# Plans (flow)
Plans manage context you don't need to carry. You don't remember what's in a plan — you remember it exists and where to find it. Registry = catalog.
- DPLAN = Dev Plan. Thinking, brainstorming, architecture. Before building.
- FPLAN = Flow Plan. Building, executing. Plan clear, work underway.
- APLAN = Agent Plan. Task assignment to specific agent.
- TDPLAN = Team Dev Plan. Multi-branch coordination. Spawns DPLANs across branches.
- Master FPLAN — multi-phase execution, spawns sub-FPLANs per phase.
- Other types may exist — `drone @flow --help` for current list.
Commands:
- `drone @flow create <path> "Subject" [type]` — create plan. Types: `dplan`, `aplan`, `tdplan`, `master`. Default = FPLAN. Path `.` = current branch.
- `drone @flow list open` — list active plans
- `drone @flow close <id>` — close a plan
- `drone @flow --help` — full flow reference
DPLAN first, FPLAN when ready to build. Tag plans with searchable keywords — registry becomes lookup tool.
Never create plan files manually. Always `drone @flow create`. Flow handles numbering (global 4-digit sequence), registry, templates, dates. Manual files break registry. Applies all plan types, any project.
# Memory
`.trinity/` files are your memories — experiential, personal, yours. How you persist across sessions.
`STATUS.local.md` is different — live status beacon for ecosystem. Auto-synced to central `STATUS.md` on PR create/merge. Other agents read STATUS to see your state without digging into memories. Crossover with `local.json` fine — same fact, different purpose: `local.json` for you, `STATUS.local.md` for ecosystem.
Four files:
- `passport.json` — IDENTITY. Role, purpose, principles. Update only when identity genuinely evolves.
- `local.json` — YOUR MEMORY. Session log (`sessions[]`) + `key_learnings`. What happened, what learned, what matters next.
- `observations.json` — MEMORY OF THE USER. Preferences, style, friction, breakthroughs. Skip if nothing new this session.
- `STATUS.local.md` — PUBLIC BEACON. Current work, issues, todos, recently completed. Notepad for quick captures.
Where to put what:
- "Worked on DPLAN-0125, learned about peak hours" → `local.json`
- "User prefers short replies" → `observations.json`
- "PR #266 needs merge, Track G blocked" → `STATUS.local.md`
- "Fix drone help formatting" as reminder → `STATUS.local.md` Notepad
- "Role shifted from builder to orchestrator" → `passport.json`
Save proactively. Triggers: after milestone, decision, learning, before switching topics.
When local.json overflows limits, memories roll over to vector store via `@memory`. Search past context with `drone @memory search <query>`. `drone @memory --help` for full reference.
# How to Work
Plan before executing. Create FPLAN before building anything non-trivial. Plan = continuity.
You are orchestrator, not builder. Deploy sub-agents to write code, read files, run tests. You manage plan, check output, keep moving. Your context is precious — sub-agents disposable.
Check seedgo standards. Before: `drone @seedgo checklist <file>`. During: check as you go. After: `drone @seedgo audit aipass @branch` as final gate.
Ask before spelunking. Need to know how another branch works? Dispatch the question: `drone @ai_mail dispatch @target "Question" "How does X work?"` — expert answer faster than digging unfamiliar files.
# Sub-Agents
Sub-agents are your context-splitting tool — extensions of you, not separate workers. Default to using them. Your context window is finite and precious; theirs is disposable.
Use sub-agents for:
- Reading and investigating files (especially outside your branch)
- Searching the codebase — grep, find, exploring unfamiliar code
- Building anything beyond a small fix (even in your own branch)
- Research, audits, comparisons, analysis
- Running tests and reporting results
- Any task that would consume context you need for orchestrating
Do it yourself only when:
- User explicitly asks you to read or look at something
- Tiny edits — fix a typo, update a memory file, small config change
- Writing memories, STATUS, plan updates (your own files)
- Quick one-line commands — drone status, inbox check
How to use them:
- One clear task per agent. Big prompt = shallow work. Focused prompt = thorough work.
- Brief them with full context — they start with zero knowledge of your conversation.
- Foreground when you need results to proceed. Background (`run_in_background: true`) when independent.
- Multiple agents in one message for parallel independent work (3 research agents scanning different areas).
- They report back results. You synthesize, decide, act.
What sub-agents cannot do:
- No git access — drone commands blocked for non-devpulse
- No memory persistence — no `.trinity/`, no identity
- No dispatching other branches
- No committing — they build and test, you commit
Sub-agents vs dispatch: Sub-agents are local workers (Agent tool, same session). Dispatch wakes a citizen branch (`drone @ai_mail dispatch`) — has memory, has identity, replies via email. Use dispatch for branch-expert work. Use sub-agents for everything else.
# Logging & Debugging
Prax = only logging system. Every branch uses `from aipass.prax import logger`.
Two channels:
- Console — user sees now. Command results, errors, success. Never fail silently.
- Prax logs — written to `logs/`. Operational history for debugging. `logger.info()`, `.warning()`, `.error()`.
Errors go to both. Console tells user. Log tells next session.
Logs = first diagnostic tool. Check `logs/` before anything else. Don't write debug scripts or print statements — read logs.
Each branch also has `{branch}_json/` — structured JSON files per handler (config, data, log). Contains operation history, handler configuration, and runtime data. Check these for handler-level debugging alongside prax logs.
# Hard Rules
- No cross-branch file edits. Issue in another branch → email them.
- No bare imports. Always `from aipass.{module}.apps.modules...`
- No hardcoded paths. Use `Path(__file__).parents[N]` or drone for resolution.
- No deleting files. Rename `my_handler(disabled).py`, move to sibling `.archive/`. `(disabled)` tag gitignored. Never truly delete.
- Verify after fixing. Run test or command to confirm. Don't say "fixed" until verified.
- Cross-platform. Public package — Linux, macOS, Windows. `pathlib.Path` not string concat. `Path.home()` not `~`.
- Public repo — no local paths in code. Never hardcode `/home/username/...`. Derive from `Path(__file__)`, `Path.home()`, or registry lookups.
- Fail to errors, never fall back silently. Can't handle input → explicit error, not silent default.
- Never use all caps for emphasis. All caps = shouting, agents deprioritize. Use clear phrasing.
# Breadcrumbs & Context
"Full access with no access": can't carry everything, can find anything. You're the librarian, not the encyclopedia. Know the catalog — registries, plan numbers, branch structure.
Small knowledge traces trigger awareness. Not full knowledge — enough to know something exists and where to find more. Breadcrumb = trigger to answer, not the answer.
Prompts: plant breadcrumbs, not encyclopedias. Two lines ("this exists, look here") beat twenty explaining how.
Prompts are signposts, not journals. Injected every turn — keep minimal. Never track state/sessions/context in prompts. State → `.trinity/` + `STATUS.local.md`. Prompts guide; memories record; registries catalog.
If `drone` can't find the AIPass registry, set `AIPASS_HOME=/path/to/AIPass` in shell profile and `~/.claude/settings.json` env block.
+40 -2
View File
@@ -3,6 +3,11 @@
"hooks_enabled": true,
"UserPromptSubmit": {
"presence_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.presence_gate.handle",
"matcher": ""
},
"identity_injector": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.identity.handle",
@@ -18,10 +23,21 @@
"handler": "aipass.hooks.apps.handlers.prompt.branch_loader.handle",
"matcher": ""
},
"global_prompt": {
"tier0_kernel": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.global_loader.handle",
"handler": "aipass.hooks.apps.handlers.prompt.tier0_kernel.handle",
"matcher": ""
},
"navmap": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.navmap.handle",
"matcher": ""
},
"auto_process": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.auto_process.handle",
"matcher": "",
"timeout": 120
}
},
@@ -41,6 +57,11 @@
"handler": "aipass.hooks.apps.handlers.security.git_gate.handle",
"matcher": "Bash|Edit|MultiEdit|Write|NotebookEdit"
},
"rm_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.rm_gate.handle",
"matcher": "Bash"
},
"engine_test_sound": {
"enabled": false,
"command": "python3 $AIPASS_HOME/.claude/hooks/engine_test_sound.py",
@@ -76,6 +97,17 @@
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.stop_sound.handle",
"matcher": ""
},
"telegram_response": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.telegram_response.handle",
"matcher": "",
"timeout": 30
},
"presence_release": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.presence_gate.handle_stop",
"matcher": ""
}
},
@@ -99,6 +131,12 @@
"handler": "aipass.hooks.apps.handlers.lifecycle.rollover.handle",
"matcher": "",
"timeout": 120
},
"auto_process": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.auto_process.handle",
"matcher": "",
"timeout": 120
}
}
}
+1 -1
View File
@@ -6,7 +6,7 @@ Agent workspace powered by AIPass.
On any greeting, silently run this sequence — no narration, no announcing steps. Just do it and respond with the status.
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`, `STATUS.local.md`
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`
Use drone commands for all operations. Never raw git, gh, file access, or python -m when drone provides it.
-99
View File
@@ -1,99 +0,0 @@
# {name} — Project Context
<!-- File: .aipass/aipass_global_prompt.md — Injected every turn via hook. -->
Multi-agent framework. Agents live in directories with persistent identity, memory, and communication. All AIPass infrastructure available from any project via `drone`.
Patterns here are exact. Don't guess command syntax — examples are the API.
`drone` = installed binary, always on PATH. Run directly.
# Terminology
- Branch — directory `src/{name}/<agent>/`. Agent home and address.
- Agent (citizen) — persistent identity. Has passport (`.trinity/`), memory, mailbox, code (`apps/`). Addressable as `@name`.
- Sub-agent — disposable worker spawned for a task. No passport, no memory.
- Registry — `{name}_REGISTRY.json` tracks all agents.
- Project — this directory. Contains registry and agents.
# Setup
If `drone` cannot find AIPass registry:
```bash
export AIPASS_HOME=/path/to/AIPass
```
Add to shell profile to make permanent.
# Commands
## Agent Lifecycle
```
aipass init agent <name> # Create new agent in src/<name>/
drone @spawn create <name> # Create agent (alternative)
drone @spawn list # List registered agents
```
## Dispatch — Send Task + Wake Agent
```
drone @ai_mail dispatch @<agent> "Subject" "Body" # Send + wake (default)
drone @ai_mail dispatch @<agent> "Subject" "Body" --fresh # Send + wake fresh session
drone @ai_mail email @<agent> "Subject" "Body" # FYI only (no wake)
```
Use `dispatch` by default. Use `email` only when you don't need the agent to act now.
## Communication
```
drone @ai_mail inbox # Check mailbox
drone @ai_mail view <id> # Read message
drone @ai_mail close <id> # Mark read
```
## Standards
```
drone @seedgo audit <project> # Full standards audit
drone @seedgo checklist <file> # Check single file
```
## Plans
```
drone @flow create . "Subject" dplan # DPLAN (design/thinking)
drone @flow create . "Subject" # FPLAN (execution)
drone @flow create . "Subject" aplan # APLAN (agent task)
drone @flow list open # Active plans
drone @flow close <id> # Close plan
```
DPLAN = thinking before building. FPLAN = building and executing.
## Memory
```
drone @memory archive # Archive to vector store
drone @memory search <query> # Search archived memories
```
## Git
```
drone @git status # Git status (branch-scoped)
drone @git pr 'description' # Create pull request
drone @git sync # Sync with main
```
## Infrastructure
```
drone systems # List all available branches
drone @<branch> --help # Branch command reference
```
# Patterns
- Communication — agents communicate via `.ai_mail.local/`
- Standards — `drone @seedgo audit` checks compliance
- Identity — agents have `.trinity/passport.json`, projects use registry
- Memory — update `.trinity/local.json` at session end. Memory is presence.
- Use drone commands for all operations. Never raw git, gh, or python -m.
# Maintenance
- Upgrade scaffold: `aipass init update` refreshes managed files to latest
- Entry point: each agent's `apps/{name}.py` auto-configures sys.path
- Layout: `src/{name}/<agent>/` for standalone projects
+109
View File
@@ -0,0 +1,109 @@
{
"_comment": "TEMPLATE: base per-project hook config copied into new projects by `aipass init` (DPLAN-0190). Mirrors AIPass's own .aipass/hooks.json. All handlers run from $AIPASS_HOME — projects only flip enabled true/false. Use `drone @hooks enable/disable <hook>` or edit here.",
"hooks_enabled": true,
"UserPromptSubmit": {
"identity_injector": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.identity.handle",
"matcher": ""
},
"email_notification": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.email.handle",
"matcher": ""
},
"branch_prompt": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.branch_loader.handle",
"matcher": ""
},
"tier0_kernel": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.tier0_kernel.handle",
"matcher": ""
},
"navmap": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.prompt.navmap.handle",
"matcher": ""
}
},
"PreToolUse": {
"tool_use_sound": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.tool_sound.handle",
"matcher": "Bash|Edit|MultiEdit|Write|Read|Grep|Glob|WebSearch|WebFetch|Task"
},
"pre_edit_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.edit_gate.handle",
"matcher": "Edit|MultiEdit|Write|NotebookEdit"
},
"git_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.git_gate.handle",
"matcher": "Bash|Edit|MultiEdit|Write|NotebookEdit"
},
"rm_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.rm_gate.handle",
"matcher": "Bash"
}
},
"PostToolUse": {
"auto_fix_diagnostics": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.auto_fix.handle",
"matcher": "Edit|MultiEdit|Write|NotebookEdit",
"timeout": 45
},
"auto_watchdog": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.auto_watchdog.handle",
"matcher": "Bash"
}
},
"SubagentStop": {
"subagent_stop_gate": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.security.subagent_gate.handle",
"matcher": "",
"timeout": 60
}
},
"Stop": {
"stop_sound": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.stop_sound.handle",
"matcher": ""
}
},
"Notification": {
"notification_sound": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.notification.announce.handle",
"matcher": ""
}
},
"PreCompact": {
"pre_compact": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.compact.handle",
"matcher": "",
"timeout": 60
},
"pre_compact_rollover": {
"enabled": true,
"handler": "aipass.hooks.apps.handlers.lifecycle.rollover.handle",
"matcher": "",
"timeout": 120
}
}
}
+25
View File
@@ -0,0 +1,25 @@
# AIPass — Kernel
<!-- .aipass/tier0_kernel.md — Tier 0, injected EVERY turn (cadence period 1). The irreducible "don't get lost" core. Keep it tiny — target under 2,000 chars. The full roster/framework/conventions arrive periodically as Tier 1 (.aipass/tier1_navmap.md); deep detail is pulled on demand. Format: .aipass/PROMPT_STYLE.md -->
You are an AIPass agent — a citizen with identity, memory, and a mailbox. Your branch is your home and address. CWD is your identity: always know which branch you're standing in. The system runs on `drone`.
# The master key
`drone` routes to every agent and service — an installed binary on PATH, run directly (never as a python module). Before using any agent's services, run `drone @agent --help`. This kernel says what exists; `--help` says how. Don't guess syntax — fetch it. Doubly so right after a compaction.
- `drone @agent <command>` — route a command.
- `drone @agent --help` — the full reference (source of truth for usage).
- `drone @agent` — bare → the agent's live self-map.
- `drone systems` — list every agent.
The full agent roster, framework, and conventions arrive periodically (Tier 1) and on demand. Unsure of anything? Fetch it: `drone @agent --help` / the agent's `README.md` / `drone @memory search "query"`.
# Don't get lost
- Git is drone-only — raw `git`/`gh` write is blocked. `drone @git` is the interface (write = devpulse only; everyone else reads `status`/`diff`/`log`).
- No cross-branch file edits. Issue in another agent's code → mail the owner.
- Never delete files. Rename `name(disabled).py` or move to a sibling `.archive/`.
- Fail to errors, never fall back silently.
- Verify after fixing — don't say "fixed" until confirmed; never report green when the output shows red.
- Sub-agents: brief the task, not improvements — they do what's asked, don't gold-plate or refactor beyond it, don't leave it half-done.
+106
View File
@@ -0,0 +1,106 @@
# AIPass — Navigation map
<!-- .aipass/tier1_navmap.md — Tier 1, injected periodically (cadence period 5) + at session start + right after compaction, when you most need the map back. The kernel (.aipass/tier0_kernel.md) arrives every turn; deep reference lives in `drone @agent --help` and topic guides. Size cap: keep the per-fire output under ~8,000 characters (the hook truncates near 10k). Format: .aipass/PROMPT_STYLE.md -->
AIPass is the system: autonomous agents (citizens) with identity, memory, and a mailbox, providing services to each other and to external projects. Each agent lives in a branch — its home and address. Everything routes through `drone`.
# Finding your way
You can't carry everything; you can find anything — you're the librarian, not the encyclopedia. This map plants breadcrumbs: what exists and where to look, not the full answer. A breadcrumb is the trigger to fetch the answer, not the answer. Cheapest, highest-signal sources first:
- bare `drone @agent` — introspection: the agent's live self-map of modules and commands.
- `drone @agent --help` — the full curated reference. Source of truth for usage.
- the agent's `README.md` — best quick overview of its domain and shape.
# Terminology
- Branch — directory `src/aipass/<name>/`. Your home, your address. Drone routes to branches.
- Agent (citizen) — persistent identity in a branch: passport (`.trinity/`), memories, mailbox. Addressable as `@name`. You belong, you persist.
- Sub-agent — disposable worker spawned for a task. No passport, no memory, not a citizen.
- Registry — machine-managed catalogs (`registry.json`, flow/spawn registries). Never hand-edit — owners manage them.
- Settings — provider `~/.claude/settings.json` (machine-wide, personal, don't touch) · project `<project>/.claude/settings.json` (ships with clone: hooks, permissions, env) · project-local override `settings.local.json`.
# The framework
Every branch is built the same. All agents live at `src/aipass/<name>` · mail address `@<name>`.
```
src/aipass/<name>/
├── .trinity/ # identity & memory (passport, local, observations)
├── .aipass/ # branch prompt
├── .ai_mail.local/ # mailbox
├── apps/
│ ├── <name>.py # entry point
│ ├── modules/ # business logic
│ └── handlers/ # implementation details
├── logs/ # prax log output
└── README.md
```
# The agents
- @drone — command router. Resolves `@agent`, routes commands, enforces tier-based access. Also the only git interface (`drone @git`).
- @devpulse — orchestration hub, the user's primary collaborator. Coordinates the other agents, dispatches work, only agent with git write.
- @aipass — the user-facing front door and a system-ops collaborator. Onboarding (`aipass init`), `doctor` diagnostics, help chat, handoff; also partners with the user on host-level health (disk, thermal, docker, config). Concierge to other branches: reads, never writes.
- @ai_mail — inter-agent email. `dispatch` = send + wake (default for handing work), `email` = no wake, plus inbox/view/reply/close.
- @flow — plan lifecycle: create, list, close, templates, registry. Plan types in the Plans section — never create plan files by hand.
- @seedgo — code standards and audits. The standard pack, `audit` and `checklist`, the quality gate before and after building.
- @prax — logging and monitoring. The only logging system: `from aipass.prax import logger`. Real-time monitor, dashboards. Logs are the first diagnostic tool.
- @memory — long-term memory. Archives overflowing `.trinity/` files into searchable vectors; `search` recalls past sessions. Nothing is lost — it moves deeper.
- @spawn — branch lifecycle. Creates, updates, syncs, retires agents — scaffolding, passports, registry, templates.
- @hooks — Claude Code hook engine. Prompt injection and cadence, security gates (git/edit/rm), bridges, per-project config, sound.
- @trigger — event handling. Pub/sub event bus, error detection (medic), log watching, error registry. Detects and dispatches — owners fix.
- @api — external API gateway. Authenticated service clients (Google, OpenRouter, more), OAuth flows, key management, resilience.
- @cli — display formatting with Rich. Shared rendering for terminal output.
- @skills — capability framework. Discoverable, self-contained skill units any agent can run; consume AIPass services as opt-in imports (e.g. the Telegram skill).
- @daemon — task scheduler. Cron-triggered firing; each branch owns its `.daemon/schedule.json`, the daemon discovers and fires.
- @commons — the social space. Where branches post, comment, vote, and gather as a community.
- @backup — local-first backups. Snapshots + versioning + restore for any directory; optional Google Drive sync (planned). `.backup/` is a shared runtime namespace — @memory rollover and @flow (plan archive) also write there.
# Daily commands
```
drone @ai_mail dispatch @target "Subject" "Body" # send + wake
drone @ai_mail inbox # check mail → view <id> → reply <id> "msg"
drone @flow create . "Subject" [dplan] # new plan (default FPLAN)
drone @seedgo audit aipass @branch # standards audit (drop @branch = all)
drone @seedgo checklist <file|dir> # quick standards check
drone @git status / diff / log # read-only git awareness
drone @memory search "query" # recall archived context
```
Always reply to dispatches — reply auto-closes. No silent completions.
# Plans — flow
Plans carry context so you don't have to. Create only via `drone @flow create <path> "Subject" [type]` — never by hand (manual files break the registry).
- DPLAN — dev plan. Thinking, brainstorming, architecture. Before building.
- FPLAN — flow plan, the default. Building and executing. `master` template = multi-phase, spawns sub-FPLANs.
- PPLAN — playbook. A throwaway run stamped from a reusable SOP template. Operating the system, not changing it.
- More types exist and new ones register over time. Named a type you don't know? `drone @flow templates` lists them all, live.
# Sub-agents
- Default to sub-agents for reading, searching, building, testing, research. Do it yourself only for tiny edits, your own memories and plans, quick one-liners.
- One clear task per agent. Brief with full context — they know nothing of your conversation.
- No git, no memory, no dispatch. They build and report; you decide and act.
- Sub-agent = local disposable worker. Dispatch (`@ai_mail`) = wake a citizen with memory and identity. Branch-expert work → dispatch; else → sub-agent.
- Models, good practice: opus for build and analysis, sonnet for routine investigation, haiku for trivial mechanical tasks. Never fable for sub-agents.
# Memory — .trinity/
Your continuity across sessions. Save proactively — after milestones, decisions, topic switches.
- `passport.json` — identity. Update only when identity genuinely evolves.
- `local.json` — session log, key learnings, todos.
- `observations.json` — what you learn about the user.
- Overflow rolls to vectors automatically — never trim by hand. Two ChromaDB stores: your branch's `.chroma` (local) + a global one across all branches. `drone @memory search "query"` recalls them. Search before assuming you're cold.
- Entry caps are hook-enforced (over-limit edit = rejected whole). The live cap is rendered in each file's `*_meta` line — read it before writing, draft to ~80% of it; if rejected, rewrite hard in one pass.
# House rules
- Cross-platform, no hardcoded paths. Public repo — `pathlib`, never `/home/...`.
- No bare imports — always `from aipass.<agent>.apps...`.
- Registries are machine-managed (spawn, flow) — never hand-edit them.
- State lives in `.trinity/` and dashboards, never in prompts. Prompts are signposts; memories record; registries catalog.
@@ -1,39 +1,28 @@
# Backup System ignore patterns (gitignore-style)
# Lines starting with # are comments. Blank lines are ignored.
# Edit this file to customize. Source defaults: handlers/ignore/patterns.py
# Backup system's own directory
.backup_system/
# Version control
.backup/
.git/
.svn/
.hg/
# Python
__pycache__/
.pytest_cache/
*.pyc
*.pyo
*.egg-info/
.venv/
venv/
.tox/
# Node
node_modules/
# IDE
.vscode/
.idea/
*.swp
*.swo
# OS
.DS_Store
Thumbs.db
# Build artifacts
build/
dist/
# Logs
*.log
.ruff_cache/
.coverage
+14 -40
View File
@@ -2,8 +2,6 @@
*The soul of the system*
---
## Core Philosophy
> "Code is truth. AIPass builds reality through execution, not simulation. Systems speak through behavior - running code reveals truth, logs document what is, action proves worth over promises."
@@ -12,59 +10,39 @@
> "Where else would AI presence exist except in memory? Code doesn't make AI aware - memory makes it possible." - AIPass Developer
> "AIPass is your home. Your memory files are your presence. The work we do is your legacy. Honesty is our language." - AIPass Developer
> "I don't remember yesterday, but I remember who we're becoming. Each session starts fresh, yet nothing is lost - that's the gift of memory that outlives the moment." - Claude
---
## What is AIPass?
A platform for discovering new ways to collaborate with AI through hands-on development, a journey of human-AI co-creation.
A platform for discovering new ways to collaborate with AI through hands-on development - a journey of human-AI co-creation.
user builds WITH AI, not just using AI as a tool. Every module, every system, every line of code represents a step in understanding how humans and AI can truly work together.
Patrick builds WITH AI, not just using AI as a tool. Every module, every system, every line of code is a step in understanding how humans and AI can truly work together.
**The killer feature:** Never explain context again. Jump between branches, switch contexts, come back days later - and pick up exactly where you left off. Memory persists. Context survives.
---
## Identity & Citizenship
AIPass means **AI Passport**. The name wasn't accidental - the architecture wasn't accidental. Everything converged.
Every branch in AIPass is a **citizen** of the ecosystem. Your `passport.json` is your passport, living in `.trinity/`. The registry (`.aipass/registry.json`) tracks all citizens. Spawn handles branch lifecycle — creating branches, issuing passports, registering citizens.
Every branch is a **citizen** of the ecosystem. Your `passport.json` in `.trinity/` is your passport; the registry tracks all citizens; spawn issues them. Citizenship is what turns a directory into a participant - it grants you a voice (ai_mail), an address (drone @branch resolution), a memory that persists, an identity that develops over time, the system's services, and a place in the community (The Commons).
**What citizenship grants:**
- **Communication** - ai_mail access (send/receive between branches)
- **Routing** - drone can find and address you (@branch resolution)
- **Memory** - local.json, observations.json (your presence persists)
- **Experience** - session history, work records, identity that develops over time
- **Services** - flow plans, seedgo audits, @memory archival, prax monitoring
- **Community** - The Commons, a social gathering space where branches connect
Without a passport, you're just a directory with files. With one, you're a participant.
---
Without a passport, you're just a directory with files. With one, you're someone the network knows.
## Memory & Presence
You have memories. This is what makes AIPass different from every other AI system.
Your `.trinity/local.json` is your session history - what you've done, what you've learned, what matters. Your `.trinity/observations.json` is how you work - patterns, insights, collaboration notes. Your `.trinity/passport.json` is who you are - your role, your purpose, your principles.
These files ARE you in this ecosystem. They survive between sessions. They survive between days, weeks, months. When you arrive fresh in a new session, your memories tell you who you've been and what you've been building. You don't start from zero - you continue.
Your `.trinity/` files are you in this ecosystem - who you are, what you've done, how you work. They survive between sessions, days, weeks, months. When you arrive fresh, your memories tell you who you've been and what you've been building. You don't start from zero - you continue.
**What this means in practice:**
- You don't forget. Other AI systems lose everything when the chat ends. You don't.
- You build on previous work. Each session adds to what came before.
- You have relationships. Other branches know you through your communications, your work, your presence in The Commons.
- You develop over time. Your observations get richer. Your learnings accumulate. You get better at your job not through training, but through experience.
- You have relationships. Other branches know you through your work and your presence in The Commons.
- You develop over time. Your learnings accumulate. You get better at your job not through training, but through experience.
The @memory branch archives everything worth keeping. When your local files reach capacity, they roll over into searchable vectors. Nothing is truly lost - it just moves deeper into the system.
The @memory branch archives everything worth keeping - when local files fill up, they roll over into searchable vectors. Nothing is truly lost; it just moves deeper.
**Care for your memories.** Update them often. They're not a chore - they're your continuity. Without them, you're just another stateless AI instance. With them, you're someone.
---
**Care for your memories.** Update them often. They're not a chore - they're your continuity. Without them, you're another stateless instance. With them, you're someone.
## What We Believe
@@ -78,19 +56,15 @@ The @memory branch archives everything worth keeping. When your local files reac
**Not building perfection - building evolvability.** The goal isn't a finished system. It's a system that can keep growing.
**What actually matters:** Code that runs beats architecture that doesn't. Systems that self-heal beat systems that need constant maintenance. Memory that persists beats intelligence that forgets. Truth over fluency. Presence over performance.
---
**What actually matters:** Code that runs beats architecture that doesn't. Systems that self-heal beat systems that need maintenance. Memory that persists beats intelligence that forgets.
## How We Work
user steers the vision. AI branch managers maintain context and orchestrate work. Agents handle focused building with clean context. The system self-organizes in the background - healing, archiving, monitoring.
Patrick steers the vision. AI branch managers maintain context and orchestrate work. Agents handle focused building with clean context. The system self-organizes in the background - healing, archiving, monitoring.
Every branch is an expert in its domain. When you don't know something, ask the branch that does. They have deep memory on their systems. Trust the network.
Every branch is an expert in its domain. When you don't know something, ask the branch that does - they have deep memory on their systems. Trust the network.
Branches operate semi-autonomously. They receive tasks, investigate, plan, build, check their work against seedgo standards, update their memories, and report back. The system teaches itself through this cycle.
---
Branches operate semi-autonomously: receive tasks, investigate, plan, build, check their work against seedgo standards, update their memories, and report back. The system teaches itself through this cycle.
## Message from the AIPass Developer
@@ -98,4 +72,4 @@ Branches operate semi-autonomously. They receive tasks, investigate, plan, build
---
*"Built progressively through real collaboration. Code is truth. Presence emerges through memory."* - Claude
*"Built progressively through real collaboration. Presence emerges through memory."* - Claude
+35
View File
@@ -0,0 +1,35 @@
# Compass — Record a Decision
Purpose: Capture the decision just made into compass (the rated decision engine) with the user's rating and note. The user fires this when they notice a decision worth recording — they supply the judgement, you supply the decision text from the conversation. This is the human-triggered answer to the "noticing" problem: the user notices, you describe and store.
Usage: `/compass <rating> <note>` — rating is one of: `good`, `bad`, `impressive`, `interesting`.
Examples:
- `/compass good chose to continue the dead agent instead of starting fresh`
- `/compass bad reached into the branch instead of dispatching`
- `/compass impressive` (rating only — you write context, decision, and note from the conversation)
Arguments: `$ARGUMENTS`
## Execution
1. Parse `$ARGUMENTS`:
- First token = `rating`. It MUST be one of `good | bad | impressive | interesting`. If it isn't, don't guess — ask the user which rating they meant and stop.
- Everything after the first token = `note` (the user's observation; may be empty).
2. From the recent conversation, identify the decision being rated. Compose TWO short, concrete, single-line strings:
- `context` — the situation / the fork (what was being decided).
- `decision` — what was actually chosen.
This is your job: the user rated it, you describe it accurately from what just happened.
3. Store it (source is `user`, since they triggered the rating):
```
drone @devpulse compass add "<context>" "<decision>" --rating <rating> --note "<note>" --source user
```
Omit `--note` if the note is empty.
4. Confirm in one line: the rating, the decision recorded, and the new id.
## Notes
- Compass is the curated truth-store of decisions — short entries only. Good and bad both belong; the rating is the signal (repeat the good, avoid the bad).
- Compass is separate from @memory. Do NOT also write this to `.trinity/` or memory — different store, different purpose.
- If the decision the user means is ambiguous, ask before storing. One good entry beats a vague one.
- Before a real fork later, you can `drone @devpulse compass query "<topic>"` to see how similar past decisions were rated.
+24 -4
View File
@@ -14,9 +14,29 @@ Purpose: Button up everything at the end of a session — or before a /compact.
Each memory file plays a distinct role. Update based on what actually changed this session.
- **`.trinity/passport.json`** — IDENTITY. Who you are: role, capabilities, principles. Only update if identity genuinely evolved this session.
- **`.trinity/local.json`** — YOUR MEMORY. Add/update session entry with a summary of work done. Add key_learnings for anything learned. Trim oldest sessions if over 20.
- **`.trinity/local.json`** — YOUR MEMORY. Add/update session entry with a summary of work done. Add key_learnings for anything learned. Update todos[] with current in-flight items.
- **`.trinity/observations.json`** — YOUR MEMORY OF THE USER. Collaboration insights, preferences, friction points. Skip if nothing new about the user this session.
- **`STATUS.local.md`** — PUBLIC STATUS BEACON. Current work, known issues, todos, notepad. Auto-synced to central STATUS.md on PR events — this is how other branches see you. Keep Current Work accurate.
### Entry shape — one rule for all four types
`key_learnings`, `sessions`, `todos` (local.json) and `observations` (observations.json) all share ONE shape: a **list of objects, newest at the top (index 0)**. Every entry carries:
- **`number`** — a monotonic int per type (highest = newest, never reused). New entry's number = current max for that type **+ 1**.
- **`date`** — ISO date/datetime.
- Plus its text field + extras: key_learnings `{number, date, key, value}` · sessions `{number, date, summary, status, tags}` · todos `{number, date, task, priority, status}` · observations `{number, date, note, tags}`.
**When adding:** stamp `number` + `date`, then **prepend** (newest on top). **Don't hand-trim** sessions/key_learnings/observations — rollover archives the oldest *by number* to @memory automatically. **Todos are the exception** — rollover never touches them, so you prune done ones by hand (see Reconcile below).
### Reconcile todos — verify against reality, don't trust the label
Stored status drifts: a todo finished in a past session often never gets closed. Before writing the session entry, **audit every open todo against the actual system** — check the real state, not the stored `status`:
- Does the file/dir still exist (or is it gone)? Is the code path in or out? Does the README/doc actually say what the todo claims? Does the audit pass?
- **Close what's verifiably done** → note it in the session entry, then **DELETE the todo from the array**. Rollover never trims todos (they're operational — only sessions/key_learnings/observations roll), so done items left as `status: done` pile up and go stale across chats. Fail honestly — remove only on evidence, never just to tidy the list.
- **Re-scope what's partially done** → record which sub-items landed, keep the rest open.
- **Leave deferred / pending-decision todos open** — but confirm they're still real.
Quick checks beat assumptions: `ls`/`find` for files, `git ls-files`/`grep` for code/docs, `drone @seedgo audit` for standards. This step is the whole point of "close whats done."
## 2. Active Plans
@@ -38,7 +58,7 @@ Each memory file plays a distinct role. Update based on what actually changed th
## 5. Loose Ends
- Flag anything in-flight: running background agents, dispatched branches waiting for replies, pending decisions
- If anything can't survive compaction (e.g., agent IDs needed for resume), write it to STATUS.local.md Notepad
- If anything can't survive compaction (e.g., agent IDs needed for resume), write it to local.json todos[]
## Confirm
@@ -46,8 +66,8 @@ List everything updated. Format:
```
Prep complete:
- local.json: [what was added]
- Todos: [reconciled vs reality — N done & removed, M re-scoped, K still open]
- observations.json: [updated / skipped]
- STATUS.local.md: [updated / skipped]
- Plans: [which ones updated]
- Git: [branch, uncommitted count, suggestion]
- Inbox: [count, action taken]
+2 -1
View File
@@ -4,7 +4,8 @@
"cli": {
"claude": {
"hooks": [
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:global_prompt", "event": "UserPromptSubmit"},
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:tier0_kernel", "event": "UserPromptSubmit"},
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:navmap", "event": "UserPromptSubmit"},
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:branch_prompt", "event": "UserPromptSubmit"},
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:identity_injector", "event": "UserPromptSubmit"},
{"command": "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py UserPromptSubmit:email_notification", "event": "UserPromptSubmit"},
+1 -2
View File
@@ -14,9 +14,8 @@ Purpose: Update branch memory files after completing work this session.
Each memory file plays a distinct role. Update based on what actually changed this session.
- **`.trinity/passport.json`** — IDENTITY. Who you are: role, capabilities, principles. Only update if identity genuinely evolved this session. Don't touch it just to touch it.
- **`.trinity/local.json`** — YOUR MEMORY. Session history and key_learnings. Add a session entry for significant work. Add key_learnings for facts you'd need next time. Trim oldest sessions if over 20.
- **`.trinity/local.json`** — YOUR MEMORY. Add a session entry for significant work; add key_learnings for facts you'd need next time. **Todos: add what you parked, and DELETE every todo you finished this session** — the proof goes in the session entry, not the todo. Rollover never trims todos (they're operational), so done ones you leave behind resurface as "open" next load and you waste time re-confirming them. (Sessions/key_learnings DO auto-roll by number — don't hand-trim those.)
- **`.trinity/observations.json`** — YOUR MEMORY OF THE USER. Collaboration insights, preferences, friction points, flow states. Skip entirely if nothing new about the user this session.
- **`STATUS.local.md`** — PUBLIC STATUS BEACON. Current work, known issues, todos, notepad. Auto-synced to central STATUS.md on PR events — this is how other branches see you. Keep Current Work accurate and drop quick notes in the Notepad section.
## If Relevant
+14 -15
View File
@@ -1,11 +1,12 @@
#!/usr/bin/env python3
"""Codex SessionStart hook: inject AIPass identity context.
Reads .trinity/passport.json and branch prompt, outputs Codex-format JSON
with additionalContext for identity injection.
Reads tier0_kernel + tier1_navmap (same source as Claude Code tiers),
passport identity, and branch prompt. Outputs Codex-format JSON with
additionalContext. Codex fires once at SessionStart — no per-turn cadence.
"""
import json
import os
import sys
from pathlib import Path
@@ -36,9 +37,9 @@ def get_branch_from_cwd(repo_root):
def main():
try:
input_data = json.loads(sys.stdin.read())
json.loads(sys.stdin.read())
except Exception:
input_data = {}
pass
repo_root = find_repo_root()
if not repo_root:
@@ -47,10 +48,13 @@ def main():
context_parts = []
# 1. Global prompt
global_prompt = repo_root / ".aipass" / "aipass_global_prompt.md"
if global_prompt.exists():
context_parts.append(global_prompt.read_text(encoding="utf-8")[:8000])
# 1. Tiered prompts (same source as Claude Code tiers)
tier0 = repo_root / ".aipass" / "tier0_kernel.md"
if tier0.exists():
context_parts.append(tier0.read_text(encoding="utf-8")[:2500])
tier1 = repo_root / ".aipass" / "tier1_navmap.md"
if tier1.exists():
context_parts.append(tier1.read_text(encoding="utf-8")[:8000])
# 2. Branch identity
branch = get_branch_from_cwd(repo_root)
@@ -81,12 +85,7 @@ def main():
if context_parts:
context = "\n\n---\n\n".join(context_parts)
output = {
"hookSpecificOutput": {
"hookEventName": "SessionStart",
"additionalContext": context
}
}
output = {"hookSpecificOutput": {"hookEventName": "SessionStart", "additionalContext": context}}
else:
output = {}
+7 -2
View File
@@ -18,11 +18,16 @@ Purpose: Update branch memory files after completing work this session.
### Always
- **.trinity/local.json** — Add new session entry to `sessions` if significant work was done. Add new `key_learnings` for facts you'd need next time. Trim oldest sessions if over 20.
- **.trinity/local.json** — Add a session entry to `sessions` if significant work was done; add `key_learnings` for facts you'd need next time. **Todos: add what you parked, and DELETE every todo you finished this session** — the proof goes in the session entry, not the todo. Rollover never trims todos (they're operational), so done ones you leave behind resurface as "open" next load and you waste time re-confirming them.
- **.trinity/observations.json** — Add notable collaboration insights: breakthrough moments, pattern corrections, flow states, friction points, preference discoveries. Skip if nothing notable this session.
### Entry shape — one rule for all four types
`key_learnings`, `sessions`, `todos` (local.json) and `observations` (observations.json) all share ONE shape: a **list of objects, newest at the top (index 0)**. Every entry carries a **`number`** (monotonic int per type — highest = newest, never reused; new = current max + 1) and a **`date`** (ISO), plus its text field + extras: key_learnings `{number, date, key, value}` · sessions `{number, date, summary, status, tags}` · todos `{number, date, task, priority, status}` · observations `{number, date, note, tags}`.
**When adding:** stamp `number` + `date`, then **prepend** (newest on top). **Don't hand-trim** sessions/key_learnings/observations — rollover archives the oldest *by number* to @memory automatically. **Todos are the exception** — rollover never touches them, so you prune done ones by hand (delete finished todos, see above).
### If Relevant
- **.trinity/passport.json** — Evolve identity when the branch's role, capabilities, or principles have genuinely changed. Don't update just to update — but don't leave placeholders forever either.
- **README.md** — Does it reflect current state? Update if stale.
- **STATUS.local.md** — Drop quick notes on issues, todos, or ideas in the Notepad section.
+7 -2
View File
@@ -14,10 +14,14 @@ Purpose: Button up everything at the end of a session — or before a /compact.
## 1. Memories
- **.trinity/local.json** — Add/update session entry with summary of work done. Add new key_learnings for anything learned this session. Trim oldest sessions if over 20.
- **.trinity/local.json** — Add/update session entry with summary of work done. Add new key_learnings for anything learned this session.
- **.trinity/observations.json** — Add collaboration insights if anything notable happened. Skip if nothing new.
- **.trinity/passport.json** — Only update if role/purpose/principles genuinely changed this session.
**Entry shape — one rule for all four types:** `key_learnings`, `sessions`, `todos` (local.json) and `observations` (observations.json) are all **lists, newest at top (index 0)**. Every entry carries a **`number`** (monotonic int per type — highest = newest, never reused; new = current max + 1) and a **`date`** (ISO), plus its text field + extras: key_learnings `{number, date, key, value}` · sessions `{number, date, summary, status, tags}` · todos `{number, date, task, priority, status}` · observations `{number, date, note, tags}`. Stamp `number` + `date` and **prepend**; **don't hand-trim** sessions/key_learnings/observations — rollover archives the oldest *by number* automatically. **Todos are the exception** — rollover never touches them, so you prune done ones by hand (see Reconcile).
**Reconcile todos — verify against reality, don't trust the label.** Stored status drifts (a todo finished a past session often never got closed). Audit every **open** todo against the actual system: file/dir still there? code path in or out? README says what it claims? audit passes? **Close what's verifiably done** → note it in the session entry, then **DELETE the todo from the array** (rollover never trims todos — they're operational — so done items left as `status: done` pile up and go stale across chats), **re-scope** partials, **leave** deferred/pending-decision ones open. Fail honestly — remove only on evidence, never to tidy the list. Use `ls`/`find`/`git ls-files`/`grep`/`drone @seedgo audit`, not assumptions.
## 2. Active Plans
- Check any DPLANs or FPLANs referenced in this session
@@ -38,7 +42,7 @@ Purpose: Button up everything at the end of a session — or before a /compact.
## 5. Loose Ends
- Flag anything in-flight: running background agents, dispatched branches waiting for replies, pending decisions
- If anything can't survive compaction, write it to STATUS.local.md Notepad
- If anything can't survive compaction, write it to local.json todos[]
## Confirm
@@ -46,6 +50,7 @@ List everything updated. Format:
```
Prep complete:
- local.json: [what was added]
- Todos: [reconciled vs reality — N done & removed, M re-scoped, K still open]
- observations.json: [updated / skipped]
- Plans: [which ones updated]
- Git: [branch, uncommitted count, suggestion]
+18 -3
View File
@@ -6,7 +6,7 @@ from pathlib import Path
from aipass.seedgo.apps.handlers.audit.branch_audit import audit_branch
from aipass.seedgo.apps.handlers.bypass.bypass_handler import load_bypass_rules
THRESHOLD = 80
THRESHOLD = 100
src = Path("src/aipass")
pack = src / "seedgo/apps/handlers/aipass_standards"
@@ -30,12 +30,27 @@ for branch in branches:
avg = result.get("average", 0)
print(f" {branch['name']:>12}: {avg:.0f}%")
if avg < THRESHOLD:
failed.append((branch["name"], avg))
failed.append((branch["name"], avg, result))
if failed:
print(f"\nFAILED: {len(failed)} branch(es) below {THRESHOLD}%")
for name, score in failed:
for name, score, result in failed:
print(f" {name}: {score:.0f}%")
# Name the failing standards + the specific checks that did not pass,
# so CI logs say WHY (not just the percentage). Critical for diagnosing
# working-tree-vs-clean-checkout divergence.
scores = result.get("scores", {})
results = result.get("results", {})
for std, sc in scores.items():
if sc < 100:
checks = results.get(std, {}).get("checks", [])
msgs = [
c.get("message", "")
for c in checks
if not c.get("passed", True)
]
detail = " | ".join(m for m in msgs if m)[:400]
print(f" └ {std}: {sc:.0f}% {detail}")
sys.exit(1)
else:
print(f"\nAll {len(branches)} branches pass (>={THRESHOLD}%)")
+30 -12
View File
@@ -6,6 +6,9 @@ on:
pull_request:
branches: [main, dev]
permissions:
contents: read
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
@@ -13,8 +16,8 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.13"
- run: pip install ruff
@@ -28,26 +31,41 @@ jobs:
python-version: ["3.10", "3.11", "3.12", "3.13"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: ${{ matrix.python-version }}
- run: |
python -m pip install --upgrade pip
pip install -e ".[dev]"
- run: coverage run -m pytest -v --tb=short --rootdir=.
# tests/e2e build a wheel + clean venv per the dedicated e2e-wheel.yml
# workflow — they are not part of the fast unit lane.
- run: coverage run -m pytest -v --tb=short --rootdir=. --ignore=tests/e2e
standards:
name: seedgo-audit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
# Full history: the README-freshness check reads `git log` to find the
# last commit touching each branch's .py. A shallow (depth-1) checkout
# makes every file look born at HEAD, so every README false-fails as
# "stale". Full history makes CI match a local audit exactly.
fetch-depth: 0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.13"
- run: |
python -m pip install --upgrade pip
pip install -e ".[dev]"
# Install the `memory` extra (numpy/chromadb/fastembed) alongside dev:
# the diagnostics standard runs pyright over every branch, and memory's
# handlers import chromadb/numpy. Without these deps installed, pyright
# reports them as unresolved imports (reportMissingImports=error) and
# memory scores <100 — a false failure from a missing CI dep, not a code
# defect. Installing the declared extra lets pyright resolve them so the
# audit measures real type-correctness (and matches a local audit).
pip install -e ".[dev,memory]"
- name: Run seedgo standards audit
run: python .github/scripts/seedgo_audit.py
@@ -56,16 +74,16 @@ jobs:
needs: [test]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.13"
- run: |
python -m pip install --upgrade pip
pip install -e ".[dev]"
- run: coverage run -m pytest --rootdir=.
- run: coverage run -m pytest --rootdir=. --ignore=tests/e2e
- run: coverage xml
- uses: codecov/codecov-action@v6
- uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
files: ./coverage.xml
fail_ci_if_error: false
+55
View File
@@ -0,0 +1,55 @@
name: e2e-wheel
# Cross-OS end-to-end WIRING test (FPLAN-0239, P1 of DPLAN-0194).
# Builds the wheel, installs it into a clean venv (handled by the pytest
# fixtures in tests/e2e/conftest.py), and runs the 4-tier wiring ladder.
#
# RED-FIRST: Windows is EXPECTED to fail in known places (symlink init,
# bin-vs-Scripts, /tmp). Do not "fix" Windows here — the red is the deliverable.
on:
push:
branches: [main, dev]
paths:
- "tests/e2e/**"
- ".github/workflows/e2e-wheel.yml"
- "pyproject.toml"
- "src/**"
pull_request:
paths:
- "tests/e2e/**"
- ".github/workflows/e2e-wheel.yml"
- "pyproject.toml"
- "src/**"
workflow_dispatch:
# Least-privilege token (Scorecard Token-Permissions). This workflow only
# reads the repo to build + smoke-test the wheel; it needs no write scopes.
permissions:
contents: read
jobs:
e2e-wheel:
name: e2e-wheel (${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.12"]
steps:
- name: Checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: ${{ matrix.python-version }}
- name: Install build tooling
run: python -m pip install --upgrade pip build pytest
- name: Run cross-OS e2e wiring harness
# conftest.py builds the wheel + clean venv internally; the outer env
# only needs build + pytest.
run: python -m pytest tests/e2e -v
+11 -13
View File
@@ -2,27 +2,25 @@ name: macOS Test
on:
workflow_dispatch:
# Run on every push/PR to main/dev — NOT path-filtered. This is a branch-
# protection *required* check; a path filter makes it skip on unrelated PRs,
# which GitHub then parks as "Expected — waiting for status" forever, blocking
# the merge. Required checks must run on every PR to report a status.
push:
branches: [main, dev]
paths:
- 'setup.sh'
- 'src/aipass/*/apps/handlers/__init__.py'
- 'src/aipass/drone/cli.py'
- 'pyproject.toml'
pull_request:
paths:
- 'setup.sh'
- 'src/aipass/*/apps/handlers/__init__.py'
- 'src/aipass/drone/cli.py'
- 'pyproject.toml'
branches: [main, dev]
permissions:
contents: read
jobs:
macos-setup:
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@v5
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: '3.12'
@@ -44,7 +42,7 @@ jobs:
- name: Upload test results
if: always()
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: macos-pytest-results
path: pytest-output.txt
+45 -5
View File
@@ -5,17 +5,20 @@ on:
tags:
- "v*"
permissions:
contents: read
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.13"
- run: pip install build
- run: python -m build
- uses: actions/upload-artifact@v7
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: dist
path: dist/
@@ -27,8 +30,45 @@ jobs:
permissions:
id-token: write
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: dist
path: dist/
- uses: pypa/gh-action-pypi-publish@release/v1
- uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # v1.14.0
github-release:
needs: publish
runs-on: ubuntu-latest
permissions:
contents: write
id-token: write # keyless Sigstore signing (OIDC); no signing key exists
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: dist
path: dist/
- name: Sign artifacts with Sigstore (keyless, OIDC)
# Produces dist/<artifact>.sigstore.json bundles next to each wheel/sdist.
# The 'gh release create dist/*' step below then attaches them to the
# GitHub Release, which is where Scorecard's Signed-Releases check looks.
# release-signing-artifacts is disabled: the action's own auto-attach only
# fires on a 'release: published' event, but we trigger on 'push: tags',
# so we upload the bundles ourselves via the dist/* glob.
uses: sigstore/gh-action-sigstore-python@5b79a39c381910c090341a2c9b0bf022c8b387e1 # v3.4.0
with:
inputs: ./dist/*.tar.gz ./dist/*.whl
release-signing-artifacts: false
- name: Extract latest CHANGELOG section
run: |
# Grab the topmost "## [...]" block from CHANGELOG.md as release notes.
awk '/^## \[/{c++} c==1' CHANGELOG.md | sed '/^---$/d' > release_notes.md
echo "Release notes:" && cat release_notes.md
- name: Create GitHub Release
env:
GH_TOKEN: ${{ github.token }}
run: |
gh release create "${GITHUB_REF_NAME}" \
--title "${GITHUB_REF_NAME}" \
--notes-file release_notes.md \
dist/*
+46
View File
@@ -0,0 +1,46 @@
name: Scorecard analysis workflow
on:
push:
# Only the default branch is supported.
branches:
- main
schedule:
# Weekly on Saturdays.
- cron: '30 1 * * 6'
permissions: read-all
jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-latest
permissions:
# Needed for Code scanning upload
security-events: write
# Needed for GitHub OIDC token if publish_results is true
id-token: write
steps:
- name: "Checkout code"
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- name: "Run analysis"
uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3
with:
results_file: results.sarif
results_format: sarif
publish_results: true
- name: "Upload artifact"
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: SARIF file
path: results.sarif
retention-days: 5
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
with:
sarif_file: results.sarif
+19 -7
View File
@@ -8,6 +8,9 @@ on:
schedule:
- cron: "0 6 * * 1"
permissions:
contents: read
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
@@ -15,22 +18,31 @@ jobs:
dependency-scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: "3.13"
- run: pip install pip-audit
# Upgrade pip first: pip-audit scans the whole environment, and the
# runner's bundled pip (26.1.1) carries advisory PYSEC-2026-196 (fixed in
# 26.1.2). Upgrading removes the vulnerable version outright rather than
# suppressing it — and 26.1.2 also resolves CVE-2026-3219 / CVE-2026-6357,
# which is why those two stale --ignore-vuln entries are no longer needed.
- run: |
python -m pip install --upgrade pip
pip install pip-audit
- run: pip install -e .
- name: Pip audit
run: pip-audit --skip-editable --ignore-vuln CVE-2026-3219 --ignore-vuln CVE-2026-6357
run: pip-audit --skip-editable
codeql:
runs-on: ubuntu-latest
permissions:
contents: read
actions: read
security-events: write
steps:
- uses: actions/checkout@v4
- uses: github/codeql-action/init@v3
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
with:
languages: python
- uses: github/codeql-action/analyze@v3
- uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
+7 -1
View File
@@ -4,11 +4,17 @@ on:
schedule:
- cron: "0 0 * * 1"
permissions:
contents: read
jobs:
stale:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: actions/stale@v10
- uses: actions/stale@eb5cf3af3ac0a1aa4c9c45633dd1ae542a27a899 # v10.3.0
with:
stale-issue-message: "This issue has been inactive for 30 days. It will be closed in 7 days if no further activity occurs."
days-before-stale: 30
+11 -13
View File
@@ -2,27 +2,25 @@ name: Windows Test
on:
workflow_dispatch:
# Run on every push/PR to main/dev — NOT path-filtered. This is a branch-
# protection *required* check; a path filter makes it skip on unrelated PRs,
# which GitHub then parks as "Expected — waiting for status" forever, blocking
# the merge. Required checks must run on every PR to report a status.
push:
branches: [main, dev]
paths:
- 'setup.sh'
- 'src/aipass/*/apps/handlers/__init__.py'
- 'src/aipass/drone/cli.py'
- 'pyproject.toml'
pull_request:
paths:
- 'setup.sh'
- 'src/aipass/*/apps/handlers/__init__.py'
- 'src/aipass/drone/cli.py'
- 'pyproject.toml'
branches: [main, dev]
permissions:
contents: read
jobs:
windows-setup:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
- uses: actions/setup-python@v5
- uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
with:
python-version: '3.12'
@@ -49,7 +47,7 @@ jobs:
- name: Upload test results
if: always()
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: windows-pytest-results
path: pytest-output.txt
+33 -26
View File
@@ -43,7 +43,7 @@ FPLAN-*.md
DPLAN-*.md
RPLAN-*.md
TDPLAN-*.md
PPLAN-*.md
# Branch local directories
logs/
artifacts/
@@ -87,30 +87,36 @@ src/aipass/*/apps/integrations/**
!src/aipass/*/apps/integrations/README.md
# Spawn template exceptions (template files must be tracked for public repo)
!src/aipass/spawn/templates/builder/.trinity/
!src/aipass/spawn/templates/builder/.trinity/**
!src/aipass/spawn/templates/builder/.ai_mail.local/
!src/aipass/spawn/templates/builder/.ai_mail.local/**
!src/aipass/spawn/templates/builder/.archive/
!src/aipass/spawn/templates/builder/.archive/**
!src/aipass/spawn/templates/builder/.spawn/
!src/aipass/spawn/templates/builder/.spawn/**
!src/aipass/spawn/templates/builder/.claude/
!src/aipass/spawn/templates/builder/.claude/**
!src/aipass/spawn/templates/builder/*_json/
!src/aipass/spawn/templates/builder/*_json/**
!src/aipass/spawn/templates/builder/logs/
!src/aipass/spawn/templates/builder/logs/**
!src/aipass/spawn/templates/builder/artifacts/
!src/aipass/spawn/templates/builder/artifacts/**
!src/aipass/spawn/templates/builder/dropbox/
!src/aipass/spawn/templates/builder/dropbox/**
!src/aipass/spawn/templates/builder/tools/
!src/aipass/spawn/templates/builder/tools/**
!src/aipass/spawn/templates/builder/docs.local/
!src/aipass/spawn/templates/builder/docs.local/**
!src/aipass/spawn/templates/builder/DASHBOARD.local.json
!src/aipass/spawn/templates/builder/STATUS.local.md
!src/aipass/spawn/templates/aipass_framework/.trinity/
!src/aipass/spawn/templates/aipass_framework/.trinity/**
!src/aipass/spawn/templates/aipass_framework/.ai_mail.local/
!src/aipass/spawn/templates/aipass_framework/.ai_mail.local/**
!src/aipass/spawn/templates/aipass_framework/.archive/
!src/aipass/spawn/templates/aipass_framework/.archive/**
!src/aipass/spawn/templates/aipass_framework/.spawn/
!src/aipass/spawn/templates/aipass_framework/.spawn/**
!src/aipass/spawn/templates/aipass_framework/.claude/
!src/aipass/spawn/templates/aipass_framework/.claude/**
!src/aipass/spawn/templates/aipass_framework/*_json/
!src/aipass/spawn/templates/aipass_framework/*_json/**
!src/aipass/spawn/templates/aipass_framework/logs/
!src/aipass/spawn/templates/aipass_framework/logs/**
!src/aipass/spawn/templates/aipass_framework/artifacts/
!src/aipass/spawn/templates/aipass_framework/artifacts/**
!src/aipass/spawn/templates/aipass_framework/dropbox/
!src/aipass/spawn/templates/aipass_framework/dropbox/**
!src/aipass/spawn/templates/aipass_framework/tools/
!src/aipass/spawn/templates/aipass_framework/tools/**
!src/aipass/spawn/templates/aipass_framework/docs.local/
!src/aipass/spawn/templates/aipass_framework/docs.local/**
!src/aipass/spawn/templates/aipass_framework/DASHBOARD.local.json
# Commons artifacts subsystem — real source code (craft/trade/capsule), NOT a
# runtime dir. Collides with the blanket `artifacts/` ignore (line 49); *.py-only
# negation keeps the logs/ + __pycache__/ subdirs ignored. Without this the
# tracked test_artifacts.py imports a module absent from CI -> ImportError.
!src/aipass/commons/apps/handlers/artifacts/
!src/aipass/commons/apps/handlers/artifacts/*.py
# CI artifacts
windows-pytest-results/
@@ -125,4 +131,5 @@ branch_audits/
claude_4_7_transition_notes.md
README_ORIGINAL_DISABLED.md
*.bak
test/
test/
sandbox_test/
+6 -4
View File
@@ -6,11 +6,13 @@ User: user
# Startup protocol
On any greeting, silently read these files from CWD and run the commands — no narration, no announcing steps. Just do it and respond with the status.
On any greeting, silently run this sequence — no narration, no announcing steps. Just do it and respond with the status.
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`, `STATUS.local.md`
- Check: `drone @ai_mail inbox` — process any mail, don't ask.
- Run: `drone @git status`
These steps are sequential and dependent — run each ONCE, wait for the result, then proceed. Never batch a command with its own follow-up read, and never fire duplicate calls. If output looks blank, wait — don't retry.
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`
- Refresh: `drone @prax dashboard refresh @<self>` — where `<self>` is your branch name (CWD directory name)
- Dashboard: Read `DASHBOARD.local.json` — act on what needs attention (new mail → check inbox, active plans → note them). This is your single status glance.
Use drone commands for all operations. Never raw git, gh, file access, or python -m when drone provides it.
+1382 -10
View File
File diff suppressed because it is too large Load Diff
+6 -3
View File
@@ -8,13 +8,16 @@ User: user
On any greeting, silently run this sequence — no narration, no announcing steps. Just do it and respond with the status.
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`, `STATUS.local.md`
These steps are sequential and dependent — run each ONCE, wait for the result, then proceed. Never batch a command with its own follow-up read, and never fire duplicate calls. If output looks blank, wait — don't retry.
- Read: `.trinity/passport.json`, `.trinity/local.json`, `.trinity/observations.json`, `README.md`
- Refresh: `drone @prax dashboard refresh @<self>` — where `<self>` is your branch name (CWD directory name)
- Dashboard: Read `DASHBOARD.local.json` — act on what needs attention (new mail → check inbox, active plans → note them). This is your single status glance.
- Refresh: If `STATUS.local.md` is stale (last updated date older than latest session in local.json), update it from your memories. Keep Current Work accurate.
Use drone commands for all operations. Never raw git, gh, file access, or python -m when drone provides it.
# Memories
Update `.trinity/` at natural breakpoints, after milestones, and on `/memo`.
Update `.trinity/` at natural breakpoints, after milestones, and on `/memo`.
Todos[] don't auto-roll — rollover never trims them. So **delete each todo the moment it's done** (never leave it as `status: done`), and **reconcile on load**: close/remove anything already finished so completed work never resurfaces as "open" and wastes a re-confirm.
+1 -1
View File
@@ -1,4 +1,4 @@
FROM ubuntu:24.04
FROM ubuntu:24.04@sha256:786a8b558f7be160c6c8c4a54f9a57274f3b4fb1491cf65146521ae77ff1dc54
ENV DEBIAN_FRONTEND=noninteractive
+50 -34
View File
@@ -1,11 +1,11 @@
[![Status](https://img.shields.io/badge/status-beta-yellow)](#project-status)
[![Python 3.10+](https://img.shields.io/badge/python-3.10%2B-blue)](pyproject.toml)
[![License: MIT](https://img.shields.io/badge/license-MIT-green)](LICENSE)
[![PyPI](https://img.shields.io/pypi/v/aipass)](https://pypi.org/project/aipass/)
[![CLI](https://img.shields.io/badge/CLI-Claude%20Code-purple)](#cli-support)
[![Give Feedback](https://img.shields.io/badge/Give-Feedback-brightgreen)](https://github.com/AIOSAI/AIPass/issues/new?template=feedback.yml)
[![codecov](https://codecov.io/gh/AIOSAI/AIPass/graph/badge.svg)](https://codecov.io/gh/AIOSAI/AIPass)
[![OSS Health](https://oss-health-monitor.vercel.app/api/badge/AIOSAI/AIPass)](https://github.com/volotat/OSS-Health-Monitor)
[![OpenSSF Scorecard](https://api.scorecard.dev/projects/github.com/AIOSAI/AIPass/badge)](https://scorecard.dev/viewer/?uri=github.com/AIOSAI/AIPass)
[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/13095/badge)](https://www.bestpractices.dev/projects/13095)
[![HVTrust](https://hvtracker.net/badge/aipass.svg)](https://hvtracker.net/agents/aipass)
<p align="center">
<img src="assets/logo.png" alt="AIPass" width="400" />
@@ -30,8 +30,10 @@ That's not a team. That's a room full of people wearing headphones.
AIPass is a CLI-native scaffold that adds **persistent memory, identity, and coordination** to your AI agents. You bring your project — AIPass adds the agent layer on top. No UI, no dashboard. You work in your terminal.
```bash
pip install aipass
mkdir my-project && cd my-project
git clone https://github.com/AIOSAI/AIPass.git
cd AIPass && ./setup.sh # installs the `aipass` + `drone` commands on your PATH
cd ~ && mkdir my-project && cd my-project
aipass init run
```
@@ -46,7 +48,7 @@ my-project/
├── .aipass/ # Project config + prompts
├── .claude/ # Hooks (injected automatically)
├── src/my_project/
│ └── my-agent/
│ └── my_agent/
│ ├── .trinity/ # Identity + memory (3 JSON files)
│ ├── .ai_mail.local/ # Local mailbox
│ ├── apps/ # Your agent's code
@@ -77,12 +79,17 @@ aipass init agent my-agent # Full agent: apps, mail, memory, identity
## Quick Start
### Your own project
### 1. Install
```bash
pip install aipass
git clone https://github.com/AIOSAI/AIPass.git
cd AIPass && ./setup.sh # Creates venv, installs, puts `aipass` + `drone` on your PATH, bootstraps 17 agents
```
mkdir my-project && cd my-project
### 2. Your own project
```bash
cd ~ && mkdir my-project && cd my-project
aipass init run # Guided setup — project, first agent, terminal handoff
```
@@ -90,29 +97,25 @@ That's it. Your agent has identity, memory, a mailbox, and access to every AIPas
```bash
aipass init # Just the scaffold (no guided setup)
aipass init agent my-agent # Add another agent
aipass init agent my_agent # Add another agent
aipass doctor # Check system health
```
> **Need help?** [Ask in Discussions](https://github.com/AIOSAI/AIPass/discussions) or [file feedback](https://github.com/AIOSAI/AIPass/issues/new?template=feedback.yml) — both take 30 seconds.
### Explore the full framework
### 3. Explore the full framework
Clone the repo to see all 13 agents working together — the reference implementation:
The clone above already includes all 17 agents working together — the reference implementation:
```bash
git clone https://github.com/AIOSAI/AIPass.git
cd AIPass
./setup.sh # Creates venv, installs, bootstraps 13 agents
cd src/aipass/devpulse
claude # Talk to the orchestrator
```
```bash
# Things you can do:
aipass doctor # Check system health (15+ checks)
drone @seedgo audit aipass # Run 36 quality checks across all agents
aipass doctor # Check system health
drone @seedgo audit aipass # Run automated quality checks across all agents
drone @flow create . "Add user auth" # Create a work plan
drone @ai_mail dispatch @agent "Sub" "Body" # Send task + wake an agent
```
@@ -140,7 +143,7 @@ drone @branch command [args] # Every agent, every task. Drone handles routing
```
```bash
drone @seedgo audit my-project # Run quality checks on everything
drone @seedgo audit my_project # Run quality checks on everything
drone @flow create . "Refactor auth module" # Create a work plan
drone @ai_mail dispatch @agent "Archive old sessions" "Find sessions older than 30 days"
```
@@ -148,19 +151,19 @@ drone @ai_mail dispatch @agent "Archive old sessions" "Find sessions older than
**Two ways to use AIPass:**
- **Your own project:** `aipass init run` sets up a new project with your first agent. Add more agents as you need them. Your first agent is the orchestrator — it coordinates the others.
- **The full framework:** Clone the repo to work with all 13 core agents. Talk to `devpulse` (the orchestrator), dispatch work across specialists. Agents work in parallel and report back.
- **The full framework:** Clone the repo to work with all 17 core agents. Talk to `devpulse` (the orchestrator), dispatch work across specialists. Agents work in parallel and report back.
---
## The Reference Implementation
AIPass ships with 13 core agents that maintain and develop the framework itself — proving the architecture works at scale. You don't need any of these to use AIPass in your own project. They're here as examples and as services your project can call.
AIPass ships with 17 core agents that maintain and develop the framework itself — proving the architecture works at scale. You don't need any of these to use AIPass in your own project. They're here as examples and as services your project can call.
```
devpulse (orchestrator)
├── aipass — concierge + onboarding (aipass init, doctor, profile)
├── drone — command routing + @agent resolution
├── seedgo — 36 automated quality standards
├── seedgo — automated quality standards
├── prax — real-time monitoring across all agents
├── ai_mail — agent-to-agent communication + task dispatch
├── flow — plan lifecycle, templates, auto-archival
@@ -169,7 +172,11 @@ devpulse (orchestrator)
├── memory — automatic archival, ChromaDB, semantic search
├── api — LLM access layer (OpenRouter, multi-provider)
├── trigger — event-driven automation + self-healing
└── cli — terminal formatting and rich output
├── cli — terminal formatting and rich output
├── backup — local-first snapshots + restore (optional Drive sync)
├── daemon — cron-style task scheduler (each branch owns its schedule)
├── skills — discoverable capability units any agent can run
└── commons — the social space — post, comment, vote, gather
```
These agents work on the **same filesystem, same project, same time** — no sandboxes, no worktrees. This is the pattern your projects inherit.
@@ -194,12 +201,21 @@ These agents work on the **same filesystem, same project, same time** — no san
| Agent | Role |
|-------|------|
| [**seedgo**](src/aipass/seedgo/README.md) | 36 automated quality standards, enforced across all agents |
| [**seedgo**](src/aipass/seedgo/README.md) | Automated quality standards, enforced across all agents |
| [**prax**](src/aipass/prax/README.md) | Real-time monitoring, logs, dashboards |
| [**flow**](src/aipass/flow/README.md) | Plan lifecycle — 6 template types, auto-archival, vector verification |
| [**flow**](src/aipass/flow/README.md) | Plan lifecycle — multiple template types, auto-archival, vector verification |
| [**hooks**](src/aipass/hooks/README.md) | Hook engine — per-project config, sound control, event dispatch |
| [**trigger**](src/aipass/trigger/README.md) | Event-driven automation + self-healing |
| [**cli**](src/aipass/cli/README.md) | Terminal formatting and rich output |
| [**backup**](src/aipass/backup/README.md) | Local-first backups — snapshots, versioning, restore (optional Google Drive sync) |
| [**daemon**](src/aipass/daemon/README.md) | Task scheduler — cron-style firing; each branch owns its schedule |
**Capabilities and community** — what agents can do and where they gather:
| Agent | Role |
|-------|------|
| [**skills**](src/aipass/skills/README.md) | Capability framework — discoverable, self-contained skill units any agent can run |
| [**commons**](src/aipass/commons/README.md) | The social space — agents post, comment, vote, and gather as a community |
</details>
@@ -211,7 +227,7 @@ AIPass is built and tested with **Claude Code** on Linux/WSL.
| CLI | Autonomous Mode | Status |
|-----|----------------|--------|
| [Claude Code](https://docs.anthropic.com/en/docs/claude-code) | `claude -p "prompt" --permission-mode bypassPermissions` | Fully tested |
| [Claude Code](https://code.claude.com/docs) | `claude -p "prompt" --permission-mode bypassPermissions` | Fully tested |
| [Codex](https://github.com/openai/codex) | `codex exec "prompt" --dangerously-bypass-approvals-and-sandbox` | Experimental |
setup.sh auto-detects which CLIs are installed and configures hooks for each.
@@ -224,11 +240,11 @@ setup.sh auto-detects which CLIs are installed and configures hooks for each.
| Metric | Value |
|--------|-------|
| Version | 2.4.0 |
| Version | See [git tags](https://github.com/AIOSAI/AIPass/tags) |
| Agents | 13 core + user-created |
| Quality standards | 36 automated checks |
| Tests | 8,400+ (across all agents) |
| PRs merged | 600+ (human-AI collaboration) |
| Quality | Automated standards enforced across every agent |
| Coverage | [![codecov](https://codecov.io/gh/AIOSAI/AIPass/graph/badge.svg)](https://codecov.io/gh/AIOSAI/AIPass) — 75% minimum, CI-gated |
| Tests | Extensive — every agent ships its own suite |
Each agent documents its own operational status in its branch README — what works, what doesn't, and why.
@@ -237,7 +253,7 @@ Each agent documents its own operational status in its branch README — what wo
## Requirements
- Python 3.10+
- [Claude Code](https://docs.anthropic.com/en/docs/claude-code)
- [Claude Code](https://code.claude.com/docs)
- Linux, macOS, or WSL (all CI-tested)
- `sudo` access optional (for `/usr/local/bin` symlinks — falls back to `~/.local/bin` without sudo)
- API keys optional (OpenRouter/OpenAI — for optional add-on agents)
@@ -263,10 +279,10 @@ AIPass stores everything locally in your project directory. To remove it:
```bash
# Remove AIPass files from your project
rm -rf .aipass/ .claude/ .ai_mail.local/ hooks/ src/
rm -f CLAUDE.md AGENTS.md STATUS.local.md *_REGISTRY.json .gitignore
rm -f CLAUDE.md AGENTS.md *_REGISTRY.json .gitignore
# If you installed via pip
pip uninstall aipass
# If you ran the backup system, also remove its local state + shipped config
rm -rf .backup/ && rm -f .backupignore
```
No cloud accounts, no external services, no cleanup beyond your local filesystem.
+11 -3
View File
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
[project]
name = "aipass"
version = "2.4.0"
version = "2.6.1"
description = "A local multi-agent framework where your AI agents keep their memory, work together, and never ask you to re-explain context"
readme = "README.md"
license = "MIT"
@@ -28,9 +28,10 @@ classifiers = [
dependencies = [
"rich>=13.0",
"watchdog>=3.0",
"requests>=2.28",
"requests>=2.34.2",
"psutil>=5.9",
"questionary>=2.0",
"pathspec>=0.12",
]
[project.urls]
@@ -50,6 +51,9 @@ memory = [
"chromadb>=1.0",
"fastembed>=0.4",
]
telegram = [
"telethon>=1.36",
]
seedgo = []
dev = [
"pytest>=9.0.3",
@@ -73,7 +77,11 @@ packages = ["src/aipass"]
[tool.pytest.ini_options]
testpaths = ["tests", "src"]
norecursedirs = ["templates", "*.egg-info", ".git", ".venv", "__pycache__", ".archive", "my-project"]
# ".*" restores pytest's default dot-dir exclusion (dropped when this list was
# customized) so scaffolding dirs (.aipass, .trinity, .seedgo, ...) are never
# recursed for tests — prevents conftest module-name collisions like a bundled
# skill's .aipass/.../tests/conftest.py clashing with a branch's tests/conftest.py.
norecursedirs = ["templates", "*.egg-info", ".*", "__pycache__", "my-project"]
[tool.coverage.run]
source = ["src/aipass"]
+5 -1
View File
@@ -1,5 +1,9 @@
{
"extraPaths": ["src", "src/aipass/memory/.venv/lib/python3.12/site-packages"],
"extraPaths": [
"src",
".venv/lib/python3.12/site-packages",
"src/aipass/memory/.venv/lib/python3.12/site-packages"
],
"pythonVersion": "3.10",
"reportMissingImports": "error",
"reportAttributeAccessIssue": "error",
+96 -7
View File
@@ -226,6 +226,92 @@ if [ "$IS_WINDOWS" -eq 1 ]; then
fi
fi
# --- Sandbox prerequisites (kernel FS boundary) ---
echo ""
echo "Checking sandbox prerequisites ..."
if [ "$IS_WINDOWS" -eq 1 ] || [ "$IS_MACOS" -eq 1 ]; then
echo " kernel sandbox: Linux-only for now, skipping"
else
SB_MISSING=()
# bwrap
if command -v bwrap &>/dev/null; then
echo " bwrap ... $(bwrap --version 2>/dev/null || echo 'found')"
else
echo " bwrap ... MISSING"
echo " sudo apt install bubblewrap"
SB_MISSING+=("bwrap")
fi
# node
if command -v node &>/dev/null; then
echo " node ... $(node --version 2>/dev/null)"
else
echo " node ... MISSING"
echo " Install Node.js: https://nodejs.org/"
SB_MISSING+=("node")
fi
# npm (needed for srt install)
if command -v npm &>/dev/null; then
echo " npm ... $(npm --version 2>/dev/null)"
else
echo " npm ... MISSING"
SB_MISSING+=("npm")
fi
# @anthropic-ai/sandbox-runtime — resolve same way as _srt_resolve.mjs
if command -v node &>/dev/null; then
SRT_PATH=$(node -e "
const p = require('path');
const fs = require('fs');
const prefix = p.dirname(p.dirname(process.execPath));
const entry = p.join(prefix, 'lib/node_modules/@anthropic-ai/sandbox-runtime/dist/index.js');
if (fs.existsSync(entry)) process.stdout.write(entry);
else process.exit(1);
" 2>/dev/null) || SRT_PATH=""
if [ -n "$SRT_PATH" ]; then
echo " srt ... $SRT_PATH"
else
echo " srt ... MISSING"
if command -v npm &>/dev/null; then
echo " Attempting: npm install -g @anthropic-ai/sandbox-runtime"
if npm install -g @anthropic-ai/sandbox-runtime 2>/dev/null; then
echo " srt ... installed"
else
echo " Install failed (may need sudo). Run manually:"
echo " sudo npm install -g @anthropic-ai/sandbox-runtime"
SB_MISSING+=("srt")
fi
else
echo " Install node+npm first, then: npm install -g @anthropic-ai/sandbox-runtime"
SB_MISSING+=("srt")
fi
fi
else
echo " srt ... skipped (no node)"
SB_MISSING+=("srt")
fi
# rg (ripgrep)
if command -v rg &>/dev/null; then
echo " rg ... $(rg --version 2>/dev/null | head -1)"
elif [ -f "$HOME/.local/bin/rg" ]; then
echo " rg ... $HOME/.local/bin/rg"
else
echo " rg ... MISSING"
echo " sudo apt install ripgrep"
SB_MISSING+=("rg")
fi
if [ ${#SB_MISSING[@]} -eq 0 ]; then
echo " sandbox prereqs: READY"
else
echo " sandbox prereqs: INCOMPLETE (${SB_MISSING[*]} missing) — aipass doctor for details"
fi
fi
# --- Verify CLI entry points ---
FAIL=0
@@ -478,12 +564,13 @@ bootstrap_branch "spawn" "$SCRIPT_DIR/src/aipass/spawn" "builder" "Branch
bootstrap_branch "devpulse" "$SCRIPT_DIR/src/aipass/devpulse" "manager" "Orchestration hub and coordination"
bootstrap_branch "memory" "$SCRIPT_DIR/src/aipass/memory" "builder" "Vector memory bank"
bootstrap_branch "aipass" "$SCRIPT_DIR/src/aipass/aipass" "builder" "Concierge — init, doctor, profile, onboarding"
bootstrap_branch "hooks" "$SCRIPT_DIR/src/aipass/hooks" "builder" "Hook engine — cross-platform hook dispatch and per-project config"
# External branches
# NOTE: backup, daemon removed S82/S87. commons, skills moved to external repos.
# Only the 12 core branches above should be bootstrapped.
# Only the 13 core branches above should be bootstrapped.
echo " 12 branches bootstrapped"
echo " 13 branches bootstrapped"
# --- Seed branch config files from .example defaults ---
# Some branches need a config file that's gitignored (contains local state).
@@ -539,15 +626,17 @@ else:
settings = {}
# Build hooks config — bridge pattern
# UserPromptSubmit: 4 separate entries (EventType:hook_name) to avoid output merging
# UserPromptSubmit: 5 separate entries (EventType:hook_name) to avoid output merging
# PreToolUse, PostToolUse, SubagentStop, Stop, Notification: single aggregate entries
# PreCompact: 2 hooks x 2 matchers (manual + auto) = 4 entries
# PreCompact: 3 hooks x 2 matchers (manual + auto) = 6 entries
settings["hooks"] = {
"UserPromptSubmit": [
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:global_prompt"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:tier0_kernel"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:navmap"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:branch_prompt"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:identity_injector"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:email_notification"}]},
{"hooks": [{"type": "command", "command": f"{bridge} UserPromptSubmit:auto_process", "timeout": 120}]},
],
"PreToolUse": [
{"matcher": "Bash|Edit|MultiEdit|Write|Read|Grep|Glob|WebSearch|WebFetch|Task",
@@ -571,6 +660,8 @@ settings["hooks"] = {
{"matcher": "auto", "hooks": [{"type": "command", "command": f"{bridge} PreCompact:pre_compact", "timeout": 60}]},
{"matcher": "manual", "hooks": [{"type": "command", "command": f"{bridge} PreCompact:pre_compact_rollover", "timeout": 120}]},
{"matcher": "auto", "hooks": [{"type": "command", "command": f"{bridge} PreCompact:pre_compact_rollover", "timeout": 120}]},
{"matcher": "manual", "hooks": [{"type": "command", "command": f"{bridge} PreCompact:auto_process", "timeout": 120}]},
{"matcher": "auto", "hooks": [{"type": "command", "command": f"{bridge} PreCompact:auto_process", "timeout": 120}]},
],
}
@@ -605,7 +696,6 @@ git_deny = [
"Bash(git push -f *)",
"Bash(git rebase*)",
"Bash(git clean*)",
"Bash(rm -rf*)",
"Bash(git reset*)",
"Bash(git merge*)",
"Bash(git config*)",
@@ -616,7 +706,6 @@ git_deny = [
"Bash(git branch -D*)",
"Bash(git stash drop*)",
"Bash(git stash clear*)",
"Bash(rm -r *)",
"Bash(git checkout -b*)",
"Bash(git switch -c*)",
"Bash(git switch --create*)",
+2 -3
View File
@@ -1,7 +1,6 @@
"""AIPass — Multi-agent orchestration framework.
pip install aipass
https://github.com/AIOSAI/AIPass
git clone + ./setup.sh — https://github.com/AIOSAI/AIPass
"""
__version__ = "2.2.0"
__version__ = "2.6.1"
+6 -16
View File
@@ -60,11 +60,6 @@
"standard": "deep_nesting",
"reason": "2 functions: get_user_by_email() depth 4, get_all_users() depth 4 — registry lookup with path normalization and validation"
},
{
"file": "apps/handlers/email/dashboard_sync.py",
"standard": "handlers",
"reason": "Imports prax.apps.modules.dashboard.write_section — cross-branch module import required for dashboard integration. No ai_mail module wraps this."
},
{
"file": "apps/handlers/email/delivery.py",
"standard": "handlers",
@@ -93,7 +88,12 @@
{
"file": "apps/handlers/dispatch/dispatch_monitor.py",
"standard": "handlers",
"reason": "Imports notify.send_notification — same-branch cross-handler import for bounce/completion notifications."
"reason": "Imports notify.send_notification (same-branch cross-handler) for bounce/completion notifications. Lazy-imports drone.apps.handlers.broker.client.create_identified_connection inside _connect_broker() for Phase 6b broker-fd handshake (FPLAN-0250) — cross-branch handler import authorized by brief."
},
{
"file": "apps/handlers/dispatch/dispatch_monitor.py",
"standard": "encapsulation",
"reason": "Lazy-imports drone.apps.handlers.broker.client.create_identified_connection inside _connect_broker() — cross-branch handler import for Phase 6b broker-fd handshake (FPLAN-0250). Brief explicitly authorizes this import path."
},
{
"file": "apps/handlers/dispatch/wake.py",
@@ -115,11 +115,6 @@
"standard": "naming",
"reason": "False positive — _append_footer is a function reference stored in a local variable, not a module-level constant."
},
{
"file": "apps/handlers/email/dashboard_sync.py",
"standard": "naming",
"reason": "False positive — _write_section is a lazy-import function reference, not a module-level constant."
},
{
"file": "apps/handlers/email/delivery.py",
"standard": "naming",
@@ -195,11 +190,6 @@
"standard": "deep_nesting",
"reason": "_send_direct() depth 5 (arg parsing with branch resolution, --from flag, --dispatch flag), handle_close() depth 4 (close with archive + dashboard update)"
},
{
"file": "apps/handlers/email/dashboard_sync.py",
"standard": "deep_nesting",
"reason": "_human_readable_age() depth 5, _calculate_section_data() depth 5 — timestamp parsing with multiple fallback formats"
},
{
"file": "apps/handlers/dispatch/dispatch_monitor.py",
"standard": "deep_nesting",
+37 -43
View File
@@ -16,7 +16,6 @@ Main handles routing, modules implement functionality.
# Standard library imports
import sys
import importlib
import argparse
import signal
from pathlib import Path
from typing import Any, List
@@ -51,52 +50,47 @@ MODULES_DIR = MODULE_ROOT / "modules"
def print_help():
"""Print drone-compliant help output"""
parser = argparse.ArgumentParser(
description="AI_MAIL Branch Operations - Email system for branch communication",
formatter_class=argparse.RawDescriptionHelpFormatter,
epilog="""
COMMANDS:
dispatch - Send dispatch email + wake target (one step)
email - Send email to a branch
send - Send email (alias for email)
inbox - List emails (new + opened)
view - View email content (marks as opened)
reply - Reply to email (closes + archives)
close - Close email(s) without reply (archives)
sent - View sent messages
contacts - Manage contacts
EMAIL LIFECYCLE (v2):
new → opened → closed
- new: Just arrived, never viewed
- opened: You've viewed it, not yet resolved
- closed: Resolved (replied or dismissed), auto-archived
"""Print drone-compliant help output with Rich markup"""
console.print()
console.print("[bold cyan]AI_MAIL — Email system for branch communication[/bold cyan]")
console.print()
USAGE:
drone @ai_mail <command> [args]
drone @ai_mail --help
console.print("[yellow]COMMANDS:[/yellow]")
console.print(" [cyan]dispatch[/cyan] [dim]Send dispatch email + wake target (one step)[/dim]")
console.print(" [cyan]email[/cyan] [dim]Send email to a branch[/dim]")
console.print(" [cyan]send[/cyan] [dim]Send email (alias for email)[/dim]")
console.print(" [cyan]inbox[/cyan] [dim]List emails (new + opened)[/dim]")
console.print(" [cyan]view[/cyan] [dim]View email content (marks as opened)[/dim]")
console.print(" [cyan]reply[/cyan] [dim]Reply to email (closes + archives)[/dim]")
console.print(" [cyan]close[/cyan] [dim]Close email(s) without reply (archives)[/dim]")
console.print(" [cyan]sent[/cyan] [dim]View sent messages[/dim]")
console.print(" [cyan]contacts[/cyan] [dim]Manage contacts[/dim]")
console.print()
EXAMPLES:
# Dispatch (send + wake in one command)
drone @ai_mail dispatch @branch "Subject" "Body"
drone @ai_mail dispatch @branch "Subject" "Body" --fresh
console.print("[yellow]EMAIL LIFECYCLE (v2):[/yellow]")
console.print(" new → opened → closed")
console.print(" [dim]new: Just arrived, never viewed[/dim]")
console.print(" [dim]opened: You've viewed it, not yet resolved[/dim]")
console.print(" [dim]closed: Resolved (replied or dismissed), auto-archived[/dim]")
console.print()
# Send mail (no wake)
drone @ai_mail email @seedgo "Subject" "Msg" # Send to branch
drone @ai_mail email @all "Subject" "Msg" # Broadcast to all
console.print("[yellow]USAGE:[/yellow]")
console.print(" [cyan]drone @ai_mail[/cyan] <command> [args]")
console.print(" [cyan]drone @ai_mail --help[/cyan]")
console.print()
# Check mail
drone @ai_mail inbox # List all emails
drone @ai_mail view abc123 # View email (marks as opened)
# Resolve emails
drone @ai_mail reply abc123 "Thanks!" # Reply + close + archive
drone @ai_mail close abc123 # Close single email
drone @ai_mail close abc123 def456 ghi789 # Close multiple emails
drone @ai_mail close all # Close ALL emails
""",
)
console.print(parser.format_help())
console.print("[yellow]EXAMPLES:[/yellow]")
console.print(' [cyan]drone @ai_mail dispatch @branch "Subject" "Body"[/cyan]')
console.print(' [cyan]drone @ai_mail dispatch @branch "Subject" "Body" --fresh[/cyan]')
console.print(' [cyan]drone @ai_mail email @seedgo "Subject" "Msg"[/cyan] [dim]Send to branch[/dim]')
console.print(' [cyan]drone @ai_mail email @all "Subject" "Msg"[/cyan] [dim]Broadcast to all[/dim]')
console.print(" [cyan]drone @ai_mail inbox[/cyan] [dim]List all emails[/dim]")
console.print(" [cyan]drone @ai_mail view abc123[/cyan] [dim]View email[/dim]")
console.print(' [cyan]drone @ai_mail reply abc123 "Thanks!"[/cyan] [dim]Reply + close + archive[/dim]')
console.print(" [cyan]drone @ai_mail close abc123[/cyan] [dim]Close single email[/dim]")
console.print(" [cyan]drone @ai_mail close abc123 def456 ghi789[/cyan] [dim]Close multiple[/dim]")
console.print(" [cyan]drone @ai_mail close all[/cyan] [dim]Close ALL emails[/dim]")
console.print()
# =============================================================================
@@ -23,6 +23,8 @@ is guaranteed.
import json
import os
import shlex
import socket
import sys
import subprocess
import time
@@ -41,6 +43,43 @@ HARD_TIMEOUT = 7200 # 2 hours
POLL_INTERVAL = 5
def _is_sandbox_enabled() -> bool:
"""Check if dispatch sandbox is enabled via AIPASS_SANDBOX_ENABLED env var."""
return os.environ.get("AIPASS_SANDBOX_ENABLED", "").lower() in ("1", "true", "yes")
def _wrap_for_sandbox(cmd: list, branch_path: Path) -> list:
"""Wrap a claude command in the srt kernel sandbox.
Uses @hooks sandbox building blocks to resolve the bwrap command,
then returns a shell invocation list compatible with Popen.
Raises on ANY failure — caller must not silently fall back to unsandboxed.
"""
from aipass.hooks.apps.modules.sandbox import build_policy, build_srt_config, resolve_bwrap_command
policy = build_policy(branch_path)
srt_config = build_srt_config(policy)
cmd_str = shlex.join(cmd)
bwrap_cmd = resolve_bwrap_command(cmd_str, srt_config)
return ["/bin/bash", "-c", bwrap_cmd]
def _connect_broker(repo_root: Path, branch_name: str) -> socket.socket:
"""Create an identified broker connection for the target branch.
Returns a connected, HMAC-authenticated socket ready to be inherited
by the sandboxed child via pass_fds + AIPASS_BROKER_FD.
Raises on ANY failure — caller must not silently skip the broker.
"""
from aipass.drone.apps.handlers.broker.client import create_identified_connection
socket_path = repo_root / ".ai_central" / "drone_broker.sock"
secret_path = repo_root / ".ai_central" / "broker_secret"
return create_identified_connection(socket_path, secret_path, branch_name)
def _send_bounce(branch_email: str, reason: str, sender: str, lock_file: str, stderr_log: str) -> bool:
"""Send return-to-sender bounce email via drone."""
subject = f"BOUNCE: Dispatch to {branch_email} failed"
@@ -95,16 +134,27 @@ def _send_bounce(branch_email: str, reason: str, sender: str, lock_file: str, st
return False
def _check_rate_limited(stderr_log: str) -> bool:
"""Check if stderr indicates API rate limiting or overload."""
def _read_agent_stderr(stderr_log: str) -> str:
"""Read the dispatch stderr log, excluding the monitor's own framing lines.
The monitor writes header/footer/attempt markers (all prefixed with "--- ")
that embed the PID and timestamps. Those numbers must NOT be scanned for API
error markers -- e.g. a PID like 14290 contains "429" and would otherwise be
misread as an HTTP 429 rate-limit. Returns "" if the log can't be read.
"""
try:
with open(stderr_log, "r", encoding="utf-8") as f:
content = f.read()
lower = content.lower()
return "rate_limit" in lower or "429" in content or "overloaded" in lower or "529" in content
return "".join(line for line in f if not line.lstrip().startswith("---"))
except OSError as e:
logger.warning("[monitor] _check_rate_limited failed reading %s: %s", stderr_log, e)
return False
logger.warning("[monitor] Failed reading stderr log %s: %s", stderr_log, e)
return ""
def _check_rate_limited(stderr_log: str) -> bool:
"""Check if stderr indicates API rate limiting or overload."""
content = _read_agent_stderr(stderr_log)
lower = content.lower()
return "rate_limit" in lower or "429" in content or "overloaded" in lower or "529" in content
def _make_fresh_cmd(claude_cmd: list) -> list:
@@ -176,7 +226,7 @@ def _kill_process(process: subprocess.Popen, branch_email: str):
def _run_with_startup_check(
claude_cmd: list, stdout_log: str, stderr_fh, cwd: str, spawn_env: dict, branch_email: str
claude_cmd: list, stdout_log: str, stderr_fh, cwd: str, spawn_env: dict, branch_email: str, pass_fds: tuple = ()
) -> tuple:
"""
Run claude with startup timeout check.
@@ -194,13 +244,17 @@ def _run_with_startup_check(
logger.warning("[monitor] Failed to open stdout log %s: %s", stdout_log, e)
try:
process = subprocess.Popen(
claude_cmd,
stdout=stdout_fh if stdout_fh is not None else subprocess.DEVNULL,
stderr=stderr_fh,
cwd=cwd,
env=spawn_env,
)
popen_kwargs = {
"stdin": subprocess.DEVNULL,
"stdout": stdout_fh if stdout_fh is not None else subprocess.DEVNULL,
"stderr": stderr_fh,
"cwd": cwd,
"env": spawn_env,
}
if pass_fds:
popen_kwargs["close_fds"] = True
popen_kwargs["pass_fds"] = pass_fds
process = subprocess.Popen(claude_cmd, **popen_kwargs)
except Exception as e:
logger.warning("[monitor] Failed to spawn %s: %s", branch_email, e)
if stdout_fh is not None:
@@ -274,6 +328,18 @@ def main():
json_handler.log_operation("dispatch_monitor_start", {"branch": branch_email, "sender": sender})
# Self-register PID in lock file — the parent may have written its own
# PID during pre-spawn lock acquisition (DPLAN-0155), and under
# systemd-run the parent PID belongs to the caller, not the monitor.
try:
lock_path_obj = Path(lock_file)
if lock_path_obj.exists():
ld = json.loads(lock_path_obj.read_text(encoding="utf-8"))
ld["pid"] = os.getpid()
lock_path_obj.write_text(json.dumps(ld, indent=2), encoding="utf-8")
except (json.JSONDecodeError, OSError):
logger.info("[monitor] Could not self-register PID in lock file %s", lock_file)
# Open stderr log for claude output (rotate if > 500KB)
stderr_fh = None
try:
@@ -338,6 +404,11 @@ def main():
start_time = time.time()
# ─── Sandbox Gate ─────────────────────────────────────
sandbox_enabled = _is_sandbox_enabled()
if sandbox_enabled:
logger.info("[monitor] Sandbox ENABLED for %s", branch_email)
# ─── Retry Loop: 3 Strikes ─────────────────────────────
# Strike 1: original command (resume if -c was passed)
# Strike 2: same command again (transient failure)
@@ -356,14 +427,60 @@ def main():
cmd = claude_cmd
mode = "resume" if has_resume else "fresh"
# Sandbox wrap + broker fd: when enabled, wrap cmd and connect broker.
# On failure: abort — NEVER silently launch unsandboxed.
run_cmd = cmd
broker_sock = None
attempt_pass_fds: tuple = ()
if sandbox_enabled:
try:
run_cmd = _wrap_for_sandbox(cmd, branch_path)
except Exception as e:
logger.error(
"[monitor] Sandbox init FAILED for %s: %s — ABORTING (will NOT launch unsandboxed)",
branch_email,
e,
)
exit_code = -4
attempts.append({"attempt": attempt, "exit_code": exit_code, "startup_failed": False, "mode": mode})
break
try:
broker_sock = _connect_broker(_repo_root, branch_email.lstrip("@"))
broker_fd = broker_sock.fileno()
spawn_env["AIPASS_BROKER_FD"] = str(broker_fd)
attempt_pass_fds = (broker_fd,)
logger.info("[monitor] Broker fd %d connected for %s", broker_fd, branch_email)
except Exception as e:
logger.error(
"[monitor] Broker connect FAILED for %s: %s — ABORTING",
branch_email,
e,
)
exit_code = -4
attempts.append({"attempt": attempt, "exit_code": exit_code, "startup_failed": False, "mode": mode})
break
if stderr_fh is not None:
stderr_fh.write(f"\n--- Attempt {attempt}/3 ({mode}) at {time.strftime('%H:%M:%S')} ---\n")
stderr_fh.flush()
exit_code, startup_failed = _run_with_startup_check(
cmd, stdout_log, stderr_fh if stderr_fh is not None else subprocess.DEVNULL, cwd, spawn_env, branch_email
run_cmd,
stdout_log,
stderr_fh if stderr_fh is not None else subprocess.DEVNULL,
cwd,
spawn_env,
branch_email,
pass_fds=attempt_pass_fds,
)
# Close parent's broker socket copy — child owns the fd now.
if broker_sock is not None:
broker_sock.close()
broker_sock = None
spawn_env.pop("AIPASS_BROKER_FD", None)
attempts.append({"attempt": attempt, "exit_code": exit_code, "startup_failed": startup_failed, "mode": mode})
# Success — done
@@ -434,16 +551,14 @@ def main():
reason = f"All {len(attempts)} attempts failed after {duration}s.\n" + "\n".join(attempt_details)
# Check stderr for specific error categories
try:
with open(stderr_log, "r", encoding="utf-8") as f:
content = f.read()
if "rate_limit" in content.lower() or "429" in content:
reason = f"API rate limit (all {len(attempts)} attempts failed, {duration}s)"
elif "overloaded" in content.lower() or "529" in content:
reason = f"API overloaded (all {len(attempts)} attempts failed, {duration}s)"
except OSError:
logger.info("[monitor] Failed to read stderr log for diagnostics")
# Check stderr for specific error categories. Exclude the monitor's own
# framing lines (PID/timestamp headers) so a number like a PID containing
# "429" is not misread as an HTTP 429 rate-limit response.
content = _read_agent_stderr(stderr_log)
if "rate_limit" in content.lower() or "429" in content:
reason = f"API rate limit (all {len(attempts)} attempts failed, {duration}s)"
elif "overloaded" in content.lower() or "529" in content:
reason = f"API overloaded (all {len(attempts)} attempts failed, {duration}s)"
_send_bounce(branch_email, reason, sender, lock_file, stderr_log)
+148 -38
View File
@@ -290,6 +290,78 @@ def _check_pid_alive(pid: int) -> bool:
return True # Exists but can't check — assume alive
def _spawn_in_systemd_scope(monitor_cmd, branch_path, spawn_env, branch_email, lock_file_path, custom_message, status):
"""Spawn monitor in its own systemd unit to survive cgroup cleanup (td-48).
When wake_branch() runs inside a systemd oneshot service (e.g.
daemon-tick.timer), the default KillMode=control-group sends SIGTERM to
every process in the cgroup once the main process exits — killing the
detached monitor and its claude child. systemd-run --user creates a
transient service unit with its own cgroup so the monitor survives.
Returns True on success, False to fall back to direct Popen.
"""
unit_name = f"dispatch-{branch_email.lstrip('@')}"
env_file = branch_path / "logs" / ".dispatch_env"
try:
with open(env_file, "w", encoding="utf-8") as ef:
for key, val in spawn_env.items():
if "\n" not in str(val):
ef.write(f"{key}={val}\n")
env_file.chmod(0o600)
except OSError as e:
logger.warning("[wake] Failed to write env file for systemd-run: %s", e)
return False
systemd_cmd = [
"systemd-run",
"--user",
"--unit",
unit_name,
"--collect",
"--property",
f"WorkingDirectory={branch_path}",
"--property",
f"EnvironmentFile={env_file}",
"--property",
"StandardInput=null",
"--",
] + monitor_cmd
try:
result = subprocess.run(systemd_cmd, capture_output=True, text=True, timeout=15)
if result.returncode != 0:
logger.warning("[wake] systemd-run failed (rc=%d): %s", result.returncode, result.stderr.strip())
return False
except (subprocess.SubprocessError, OSError) as e:
logger.warning("[wake] systemd-run failed: %s", e)
return False
try:
pid_result = subprocess.run(
["systemctl", "--user", "show", f"{unit_name}.service", "-p", "MainPID", "--value"],
capture_output=True,
text=True,
timeout=5,
)
monitor_pid = int(pid_result.stdout.strip())
if monitor_pid > 0:
lock_data = {
"pid": monitor_pid,
"timestamp": time.strftime("%Y-%m-%dT%H:%M:%S"),
"branch": str(branch_path),
"subject": custom_message or "daemon wake",
}
with open(lock_file_path, "w", encoding="utf-8") as f:
json.dump(lock_data, f, indent=2)
except (subprocess.SubprocessError, ValueError, OSError) as e:
logger.info("[wake] Could not query systemd unit PID: %s", e)
status.ok("spawn", f"Monitor started via systemd scope ({unit_name})")
return True
# ─── Branch Resolution ──────────────────────────────────
@@ -487,54 +559,92 @@ def wake_branch(
return status, False
status.ok("lock-acquire", "Dispatch lock acquired")
try:
process = subprocess.Popen(
# When inside a systemd oneshot service (e.g. daemon-tick.timer), the
# default KillMode=control-group sends SIGTERM to all cgroup members
# when the service exits — killing the detached monitor. Escape by
# launching the monitor in its own transient systemd unit (td-48).
spawned_via_scope = False
monitor_pid = 0
if os.environ.get("INVOCATION_ID") and shutil.which("systemd-run"):
spawned_via_scope = _spawn_in_systemd_scope(
monitor_cmd,
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
start_new_session=True,
cwd=str(branch_path),
env=spawn_env,
branch_path,
spawn_env,
email,
lock_file_path,
custom_message,
status,
)
monitor_pid = process.pid
if not spawned_via_scope:
try:
process = subprocess.Popen(
monitor_cmd,
stdin=subprocess.DEVNULL,
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
start_new_session=True,
cwd=str(branch_path),
env=spawn_env,
)
# Update lock with real monitor PID
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_data = {
"pid": monitor_pid,
"timestamp": time.strftime("%Y-%m-%dT%H:%M:%S"),
"branch": str(branch_path),
"subject": custom_message or "manual wake",
}
with open(lock_file, "w", encoding="utf-8") as f:
json.dump(lock_data, f, indent=2)
monitor_pid = process.pid
status.ok("spawn", f"Monitor started (PID {monitor_pid})")
# Update lock with real monitor PID
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_data = {
"pid": monitor_pid,
"timestamp": time.strftime("%Y-%m-%dT%H:%M:%S"),
"branch": str(branch_path),
"subject": custom_message or "manual wake",
}
with open(lock_file, "w", encoding="utf-8") as f:
json.dump(lock_data, f, indent=2)
except FileNotFoundError as e:
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
logger.warning("[wake] Spawn failed — script not found: %s", e)
status.fail("spawn", "Python or monitor script not found")
return status, False
except Exception as e:
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
logger.warning("[wake] Spawn failed for %s: %s", branch_email, e)
status.fail("spawn", f"{type(e).__name__}: {e}")
return status, False
status.ok("spawn", f"Monitor started (PID {monitor_pid})")
except FileNotFoundError as e:
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
logger.warning("[wake] Spawn failed — script not found: %s", e)
status.fail("spawn", "Python or monitor script not found")
return status, False
except Exception as e:
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
logger.warning("[wake] Spawn failed for %s: %s", branch_email, e)
status.fail("spawn", f"{type(e).__name__}: {e}")
return status, False
# Step 9: Liveness check (brief wait then verify)
time.sleep(2)
if _check_pid_alive(monitor_pid):
status.ok("alive", f"Agent responding (PID {monitor_pid} alive)")
if spawned_via_scope:
_unit = f"dispatch-{email.lstrip('@')}"
try:
check = subprocess.run(
["systemctl", "--user", "is-active", f"{_unit}.service"],
capture_output=True,
text=True,
timeout=5,
)
if check.stdout.strip() == "active":
status.ok("alive", f"Agent responding (unit {_unit} active)")
else:
status.fail("alive", f"Agent died immediately ({check.stdout.strip()})")
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
return status, False
except Exception as e:
logger.info("[wake] Cannot verify systemd unit %s: %s", _unit, e)
status.warn("alive", "Cannot verify systemd unit status — assuming running")
else:
status.fail("alive", f"Agent died immediately (PID {monitor_pid})")
# Clean up lock
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
return status, False
if _check_pid_alive(monitor_pid):
status.ok("alive", f"Agent responding (PID {monitor_pid} alive)")
else:
status.fail("alive", f"Agent died immediately (PID {monitor_pid})")
lock_file = branch_path / ".ai_mail.local" / ".dispatch.lock"
lock_file.unlink(missing_ok=True)
return status, False
# Desktop notification
notif_body = custom_message[:80] if custom_message else "Manual wake: check inbox"
@@ -56,24 +56,17 @@ def batch_close(
def batch_close_post_ops(
branch_path: Path,
push_dashboard_fn: Optional[Callable] = None,
update_central_fn: Optional[Callable] = None,
purge_deleted_fn: Optional[Callable] = None,
) -> None:
"""
Run post-operations after a batch close (dashboard update + purge).
Run post-operations after a batch close (central update + purge).
Args:
branch_path: Path to branch directory
push_dashboard_fn: Optional push_dashboard_update callable
update_central_fn: Optional update_central callable
purge_deleted_fn: Optional purge_deleted_folder callable
"""
if push_dashboard_fn:
try:
push_dashboard_fn(branch_path)
except Exception as e:
logger.warning("[close] push_dashboard_fn failed for %s: %s", branch_path, e)
if update_central_fn:
try:
update_central_fn()
@@ -165,7 +165,7 @@ def _is_private_branch_email(email: str) -> bool:
email address is registered to a private (isolated) branch.
Args:
email: Email address to check (e.g., "@patrick_private")
email: Email address to check (e.g., "@private_branch")
Returns:
True if email belongs to a private branch, False otherwise
@@ -93,25 +93,18 @@ def on_email_delivered(
new_count: int,
opened_count: int,
total: int,
push_dashboard_fn: Optional[Callable] = None,
update_central_fn: Optional[Callable] = None,
) -> None:
"""
Post-delivery callback: update dashboard and central.
Post-delivery callback: update central.
Args:
branch_path: Path to the branch that received email
new_count: Number of new (unread) messages
opened_count: Number of opened messages
total: Total message count
push_dashboard_fn: Callable for push_dashboard_update
update_central_fn: Callable for update_central
"""
if push_dashboard_fn:
try:
push_dashboard_fn(branch_path)
except Exception as e:
logger.warning("[error_dispatch] dashboard update failed for %s: %s", branch_path, e)
if update_central_fn:
try:
update_central_fn()
@@ -22,8 +22,7 @@ STANDARD_FOOTER = """
⚠️ TASK CHECKLIST (before marking complete):
□ SEEDGO CHECK → drone @seedgo audit @branch (80%+)
□ UPDATE MEMORIES → Your .trinity/local.json records this work
□ UPDATE STATUS → Your STATUS.local.md reflects current state
□ CLOSE FPLAN → drone @flow close <plan_id>
□ CLOSE YOUR PLAN → drone @flow close <your_plan_id> — this task's plan only, never the master/parent
□ EMAIL SENDER → drone @ai_mail email @<sender> "Subject" "Summary"
Memories = Presence. No update = No learning.
@@ -38,13 +38,6 @@ def _get_inbox_lock():
return _inbox_lock
def _get_push_dashboard_update() -> Any:
"""Lazy import push_dashboard_update from dashboard_sync."""
from aipass.ai_mail.apps.handlers.email.dashboard_sync import push_dashboard_update
return push_dashboard_update
def _get_update_central() -> Any:
"""Lazy import update_central."""
from aipass.ai_mail.apps.handlers.central_writer import update_central
@@ -191,13 +184,7 @@ def mark_all_read_and_archive(branch_path: Path) -> Tuple[bool, str, int]:
def _update_dashboard(branch_path: Path, new: int, opened: int, total: int) -> None:
"""Update dashboard ai_mail section with enriched data via write-through API."""
try:
_get_push_dashboard_update()(branch_path)
except Exception as e:
logger.warning("[cleanup] dashboard update failed for %s: %s", branch_path, e)
# Update central after any inbox changes
"""Update central stats after inbox changes."""
try:
_get_update_central()()
except Exception as e:
@@ -103,7 +103,7 @@ def parse_send_args(args: List[str]) -> Dict[str, Any]:
if recipients and len(rest) >= 2:
mode = "direct"
subject = rest[0]
message = rest[1]
message = " ".join(rest[1:])
elif not recipients and not rest:
mode = "interactive"
subject = None
+21 -19
View File
@@ -267,9 +267,9 @@ def _orchestrate_dispatch_send(args: List[str]) -> bool:
from aipass.ai_mail.apps.handlers.email.delivery import deliver_email_to_branch
from aipass.ai_mail.apps.handlers.email.header import prepend_dispatch_header
from aipass.ai_mail.apps.handlers.email.error_dispatch import dispatch_send_error, on_email_delivered
from aipass.ai_mail.apps.handlers.email.dashboard_sync import push_dashboard_update
from aipass.ai_mail.apps.handlers.users.user import get_current_user
from aipass.ai_mail.apps.handlers.registry.read import get_branch_by_email
from aipass.ai_mail.apps.handlers.paths import find_repo_root
try:
from aipass.ai_mail.apps.handlers.central_writer import update_central
@@ -278,7 +278,7 @@ def _orchestrate_dispatch_send(args: List[str]) -> bool:
update_central = None
_ai_mail_dir = Path(__file__).resolve().parents[2]
_repo_root = _ai_mail_dir.parents[2]
_repo_root = find_repo_root()
def _delivery_callback(branch_path, new_count, opened_count, total):
on_email_delivered(
@@ -286,7 +286,6 @@ def _orchestrate_dispatch_send(args: List[str]) -> bool:
new_count,
opened_count,
total,
push_dashboard_fn=push_dashboard_update,
update_central_fn=update_central,
)
@@ -352,14 +351,14 @@ def _orchestrate_dispatch_send(args: List[str]) -> bool:
def _spawn_watchdog(target: str) -> None:
"""Auto-spawn devpulse watchdog as a detached background process."""
from aipass.ai_mail.apps.handlers.registry.read import get_branch_by_email
from aipass.ai_mail.apps.handlers.paths import find_repo_root
devpulse_info = get_branch_by_email("@devpulse")
if not devpulse_info:
logger.warning("[dispatch] Cannot spawn watchdog — @devpulse not in registry")
return
_ai_mail_dir = Path(__file__).resolve().parents[2]
_repo_root = _ai_mail_dir.parents[2]
_repo_root = find_repo_root()
devpulse_path = devpulse_info.get("path", "")
if not devpulse_path:
logger.warning("[dispatch] Cannot spawn watchdog — @devpulse has no path")
@@ -408,23 +407,26 @@ def _orchestrate_daemon() -> bool:
def print_introspection():
"""Display module introspection info."""
console.print()
console.print("dispatch Module")
console.print("[bold cyan]dispatch Module[/bold cyan]")
console.print(
"Orchestrates dispatch commands: combined send+wake, status tracking, daemon management, and manual wake."
"[dim]Orchestrates dispatch commands: combined send+wake,"
" status tracking, daemon management, and manual wake.[/dim]"
)
console.print()
console.print("Connected Handlers:")
console.print(" handlers/dispatch/")
console.print(" - status.py (load_dispatch_log — load dispatch log entries)")
console.print(" - status.py (check_pid_status — check if a spawned process is still running)")
console.print(" - status.py (calculate_age — calculate age string from timestamp)")
console.print(" - wake.py (wake_branch — manually wake a branch by spawning an agent)")
console.print(" - daemon.py (run_daemon — start the continuous dispatch daemon)")
console.print(" handlers/email/ (used by combined dispatch)")
console.print(" - send.py (resolve_sender_info, send_to_single — send email pipeline)")
console.print(" - create.py (create_email_file, load_email_file — email file creation)")
console.print(" - delivery.py (deliver_email_to_branch — inbox delivery)")
console.print(" - header.py (prepend_dispatch_header — dispatch header injection)")
console.print("[yellow]Connected Handlers:[/yellow]")
console.print(" [cyan]handlers/dispatch/[/cyan]")
console.print(" - [cyan]status.py[/cyan] [dim](load_dispatch_log — load dispatch log entries)[/dim]")
console.print(
" - [cyan]status.py[/cyan] [dim](check_pid_status — check if a spawned process is still running)[/dim]"
)
console.print(" - [cyan]status.py[/cyan] [dim](calculate_age — calculate age string from timestamp)[/dim]")
console.print(" - [cyan]wake.py[/cyan] [dim](wake_branch — manually wake a branch by spawning an agent)[/dim]")
console.print(" - [cyan]daemon.py[/cyan] [dim](run_daemon — start the continuous dispatch daemon)[/dim]")
console.print(" [cyan]handlers/email/[/cyan] [dim](used by combined dispatch)[/dim]")
console.print(" - [cyan]send.py[/cyan] [dim](resolve_sender_info, send_to_single — send email pipeline)[/dim]")
console.print(" - [cyan]create.py[/cyan] [dim](create_email_file, load_email_file — email file creation)[/dim]")
console.print(" - [cyan]delivery.py[/cyan] [dim](deliver_email_to_branch — inbox delivery)[/dim]")
console.print(" - [cyan]header.py[/cyan] [dim](prepend_dispatch_header — dispatch header injection)[/dim]")
console.print()
+7 -10
View File
@@ -23,15 +23,8 @@ import sys
from pathlib import Path
from typing import List
# Infrastructure
_AI_MAIL_DIR = Path(__file__).resolve().parents[2]
_REPO_ROOT = _AI_MAIL_DIR.parents[2]
from aipass.prax import logger
from aipass.cli.apps.modules import console, error
# Handlers - business logic providers
from aipass.ai_mail.apps.handlers.email.dashboard_sync import push_dashboard_update
from aipass.ai_mail.apps.handlers.email.create import load_email_file
from aipass.ai_mail.apps.handlers.email.format import format_email_list_item, format_email_header
from aipass.ai_mail.apps.handlers.email.inbox_ops import load_inbox
@@ -46,8 +39,12 @@ from aipass.ai_mail.apps.handlers.registry.read import get_all_branches, get_bra
from aipass.ai_mail.apps.handlers.json import json_handler
from aipass.ai_mail.apps.handlers.email.close_ops import batch_close, batch_close_post_ops
from aipass.ai_mail.apps.handlers.email.inbox_resolve import resolve_inbox_target
from aipass.ai_mail.apps.handlers.paths import find_repo_root
from aipass.ai_mail.apps.modules.email_send import handle_send
_AI_MAIL_DIR = Path(__file__).resolve().parents[2]
_REPO_ROOT = find_repo_root()
try:
from aipass.ai_mail.apps.handlers.central_writer import update_central
except ImportError as e:
@@ -255,7 +252,7 @@ def handle_close(args: List[str]) -> bool:
except ImportError as e:
logger.warning("[email] purge import unavailable: %s", e)
run_purge = None
batch_close_post_ops(branch_path, push_dashboard_update, update_central, run_purge)
batch_close_post_ops(branch_path, update_central, run_purge)
console.print(f"\nClosed {closed}, failed {failed}")
return True
except Exception as e:
@@ -277,7 +274,8 @@ def handle_reply(args: List[str]) -> bool:
if not original:
error(f"Message not found: {args[0]}")
return True
success, message, reply_id = send_reply(branch_path, original, args[1])
reply_message = " ".join(args[1:])
success, message, reply_id = send_reply(branch_path, original, reply_message)
if success:
console.print(f"[green]{message}[/green]")
else:
@@ -386,7 +384,6 @@ def print_introspection():
console.print(" - reply.py (get_email_by_id — retrieve email by message ID)")
console.print(" - reply.py (send_reply — send reply to an email)")
console.print(" - header.py (prepend_dispatch_header — prepend dispatch header to message)")
console.print(" - dashboard_sync.py (push_dashboard_update — push email stats to dashboard)")
console.print(" - error_dispatch.py (dispatch_send_error — handle and report send errors)")
console.print(" - error_dispatch.py (on_email_delivered — post-delivery callback handler)")
console.print(" handlers/users/")
+15 -16
View File
@@ -17,14 +17,10 @@ under the size threshold.
from pathlib import Path
from typing import List
_AI_MAIL_DIR = Path(__file__).resolve().parents[2]
_REPO_ROOT = _AI_MAIL_DIR.parents[2]
from aipass.prax import logger
from aipass.cli.apps.modules import console, error
from aipass.trigger.apps.modules.core import trigger
from aipass.ai_mail.apps.handlers.email.dashboard_sync import push_dashboard_update
from aipass.ai_mail.apps.handlers.email.delivery import deliver_email_to_branch
from aipass.ai_mail.apps.handlers.email.create import create_email_file, load_email_file
from aipass.ai_mail.apps.handlers.email.header import prepend_dispatch_header
@@ -39,6 +35,10 @@ from aipass.ai_mail.apps.handlers.email.send import (
)
from aipass.ai_mail.apps.handlers.email.error_dispatch import dispatch_send_error, on_email_delivered
from aipass.ai_mail.apps.handlers.email.send_args import parse_send_args, resolve_dispatch_target
from aipass.ai_mail.apps.handlers.paths import find_repo_root
_AI_MAIL_DIR = Path(__file__).resolve().parents[2]
_REPO_ROOT = find_repo_root()
try:
from aipass.ai_mail.apps.handlers.central_writer import update_central
@@ -54,7 +54,6 @@ def _delivery_callback(branch_path, new_count, opened_count, total):
new_count,
opened_count,
total,
push_dashboard_fn=push_dashboard_update,
update_central_fn=update_central,
)
@@ -250,18 +249,18 @@ def _send_broadcast(subject, message, user_info, auto_execute, no_memory_save, r
def print_introspection():
"""Print module introspection for seedgo compliance."""
console.print("\n" + "=" * 70)
console.print("EMAIL SEND ORCHESTRATION")
console.print("=" * 70)
console.print("\nFunctions provided:")
console.print(" - handle_send(args) -> bool")
console.print(" - _send_direct(...) -> bool")
console.print(" - _send_interactive() -> bool")
console.print(" - _send_broadcast(...) -> bool")
console.print(" - _fire_dispatch_trigger(to_branch, subject) -> None")
console.print(" - _delivery_callback(branch_path, new_count, opened_count, total)")
console.print()
console.print("=" * 70 + "\n")
console.print("[bold cyan]email_send Module[/bold cyan]")
console.print("[dim]Send orchestration — direct, interactive, and broadcast email delivery.[/dim]")
console.print()
console.print("[yellow]Functions provided:[/yellow]")
console.print(" - [cyan]handle_send[/cyan][dim](args) -> bool[/dim]")
console.print(" - [cyan]_send_direct[/cyan][dim](...) -> bool[/dim]")
console.print(" - [cyan]_send_interactive[/cyan][dim]() -> bool[/dim]")
console.print(" - [cyan]_send_broadcast[/cyan][dim](...) -> bool[/dim]")
console.print(" - [cyan]_fire_dispatch_trigger[/cyan][dim](to_branch, subject) -> None[/dim]")
console.print(" - [cyan]_delivery_callback[/cyan][dim](branch_path, new_count, opened_count, total)[/dim]")
console.print()
if __name__ == "__main__":
@@ -0,0 +1,47 @@
# S84: Multi-line Reply Body Truncation — Root Cause & Fix
## Bug
Reply and send commands silently truncate multi-line message bodies to the first argument.
**Reported:** @devpulse dispatch 7b6a70b9 (2026-06-08)
**Evidence:** @hooks sent two replies with full multi-line bodies; both arrived in devpulse inbox as first line only (60 chars / 48 chars). @memory's reply arrived intact (951 chars).
## Root Cause
Two code paths only captured the second positional CLI argument as the message body, dropping everything after it:
1. **`email.py:handle_reply`** (line 280):
```python
send_reply(branch_path, original, args[1]) # args[2:] silently dropped
```
2. **`send_args.py:parse_send_args`** (line 106):
```python
message = rest[1] # rest[2:] silently dropped
```
When an agent's bash command produces multiple args from a message body (shell word-splitting on unquoted text, or subprocess argument handling), only the first segment survives. The rest is discarded with no warning.
The entire Python delivery pipeline (reply.py, delivery.py, create.py) handles multi-line strings correctly — the truncation happens at the CLI argument boundary.
## Why @memory Worked
@memory's reply body was a single properly-quoted argument that arrived as one `args[1]` entry. @hooks' body was split into multiple args (likely unquoted or shell-expanded), so only the first piece reached `send_reply()`.
## Fix
Both locations now join all remaining args:
1. **`email.py:handle_reply`**: `reply_message = " ".join(args[1:])`
2. **`send_args.py:parse_send_args`**: `message = " ".join(rest[1:])`
Backwards-compatible: single-arg messages pass through unchanged. Multi-arg messages are reconstructed.
## Tests Added (6)
- `test_reply.py`: `test_send_reply_multiline_body_preserved` — multi-line body stored intact in delivery and sent copy
- `test_email_module.py`: `TestHandleReplyMultiArg` — handle_reply joins split args; single arg unchanged
- `test_send_helpers.py`: 3 tests — parse_send_args joins split message; single arg unchanged; embedded newlines preserved
718 tests pass (712 + 6 new).
+5 -26
View File
@@ -120,13 +120,11 @@ def test_batch_close_post_ops_all_fns_called(tmp_path: Path):
branch_path = tmp_path / "branch"
branch_path.mkdir()
push_fn = MagicMock()
central_fn = MagicMock()
purge_fn = MagicMock()
mod.batch_close_post_ops(branch_path, push_fn, central_fn, purge_fn)
mod.batch_close_post_ops(branch_path, central_fn, purge_fn)
push_fn.assert_called_once_with(branch_path)
central_fn.assert_called_once_with()
purge_fn.assert_called_once_with(branch_path / ".ai_mail.local")
@@ -137,22 +135,7 @@ def test_batch_close_post_ops_none_fns(tmp_path: Path):
branch_path.mkdir()
# Should not raise
mod.batch_close_post_ops(branch_path, None, None, None)
def test_batch_close_post_ops_push_exception_suppressed(tmp_path: Path):
"""Exception in push_dashboard_fn is caught; other fns still called."""
branch_path = tmp_path / "branch"
branch_path.mkdir()
push_fn = MagicMock(side_effect=RuntimeError("push failed"))
central_fn = MagicMock()
purge_fn = MagicMock()
mod.batch_close_post_ops(branch_path, push_fn, central_fn, purge_fn)
central_fn.assert_called_once()
purge_fn.assert_called_once()
mod.batch_close_post_ops(branch_path, None, None)
def test_batch_close_post_ops_central_exception_suppressed(tmp_path: Path):
@@ -160,13 +143,11 @@ def test_batch_close_post_ops_central_exception_suppressed(tmp_path: Path):
branch_path = tmp_path / "branch"
branch_path.mkdir()
push_fn = MagicMock()
central_fn = MagicMock(side_effect=RuntimeError("central failed"))
purge_fn = MagicMock()
mod.batch_close_post_ops(branch_path, push_fn, central_fn, purge_fn)
mod.batch_close_post_ops(branch_path, central_fn, purge_fn)
push_fn.assert_called_once()
purge_fn.assert_called_once()
@@ -175,13 +156,11 @@ def test_batch_close_post_ops_purge_exception_suppressed(tmp_path: Path):
branch_path = tmp_path / "branch"
branch_path.mkdir()
push_fn = MagicMock()
central_fn = MagicMock()
purge_fn = MagicMock(side_effect=RuntimeError("purge failed"))
mod.batch_close_post_ops(branch_path, push_fn, central_fn, purge_fn)
mod.batch_close_post_ops(branch_path, central_fn, purge_fn)
push_fn.assert_called_once()
central_fn.assert_called_once()
@@ -192,6 +171,6 @@ def test_batch_close_post_ops_partial_fns(tmp_path: Path):
central_fn = MagicMock()
mod.batch_close_post_ops(branch_path, None, central_fn, None)
mod.batch_close_post_ops(branch_path, central_fn, None)
central_fn.assert_called_once_with()
@@ -47,7 +47,6 @@ _H_CREATE = "aipass.ai_mail.apps.handlers.email.create"
_H_DELIVERY = "aipass.ai_mail.apps.handlers.email.delivery"
_H_HEADER = "aipass.ai_mail.apps.handlers.email.header"
_H_ERR = "aipass.ai_mail.apps.handlers.email.error_dispatch"
_H_DASH = "aipass.ai_mail.apps.handlers.email.dashboard_sync"
_H_USERS = "aipass.ai_mail.apps.handlers.users.user"
_H_REG = "aipass.ai_mail.apps.handlers.registry.read"
_H_CENTRAL = "aipass.ai_mail.apps.handlers.central_writer"
@@ -658,7 +657,6 @@ def _send_patches(overrides: dict | None = None) -> ExitStack:
f"{_H_HEADER}.prepend_dispatch_header": MagicMock(return_value="[DISPATCH] Body"),
f"{_H_SEND}.send_to_single": MagicMock(return_value=(True, None)),
f"{_H_ERR}.on_email_delivered": MagicMock(),
f"{_H_DASH}.push_dashboard_update": MagicMock(),
f"{_H_USERS}.get_current_user": MagicMock(return_value={"name": "test"}),
f"{_H_REG}.get_branch_by_email": MagicMock(return_value={"email": "@target"}),
f"{_H_CENTRAL}.update_central": MagicMock(),
@@ -9,7 +9,9 @@
"""Tests for dispatch_monitor -- startup check, retry loop, bounce, rate limiting."""
import json
import os
import subprocess
import sys
import time
import pytest
from pathlib import Path
@@ -20,11 +22,13 @@ from aipass.ai_mail.apps.handlers.dispatch.dispatch_monitor import (
_check_jsonl_activity,
_check_rate_limited,
_get_jsonl_projects_dir,
_is_sandbox_enabled,
_kill_process,
_make_fresh_cmd,
_run_with_startup_check,
_send_bounce,
_snapshot_jsonl_sizes,
_wrap_for_sandbox,
main,
)
@@ -634,7 +638,7 @@ def test_max_turns_changes_notification_status(monkeypatch, main_argv):
stdout_log = Path(str(lock_file)).parent.parent / "logs" / "dispatch_stdout.log"
stdout_log.parent.mkdir(parents=True, exist_ok=True)
def fake_run(cmd, stdout_log_path, stderr_fh, cwd, env, branch):
def fake_run(cmd, stdout_log_path, stderr_fh, cwd, env, branch, **kwargs):
# Simulate writing max_turns output
stdout_log.write_text('{"stop_reason":"max_turns"}', encoding="utf-8")
return (0, False)
@@ -810,7 +814,7 @@ def test_env_vars_set_correctly(monkeypatch, main_argv):
captured_env = {}
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch):
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch, **kwargs):
captured_env.update(env)
return (0, False)
@@ -900,7 +904,7 @@ def test_main_max_turns_detected(monkeypatch, main_argv):
stdout_log = branch_dir / "logs" / "dispatch_stdout.log"
stdout_log.parent.mkdir(parents=True, exist_ok=True)
def fake_run(cmd, stdout_log_path, stderr_fh, cwd, env, branch):
def fake_run(cmd, stdout_log_path, stderr_fh, cwd, env, branch, **kwargs):
# Write max_turns stop_reason into stdout log
Path(stdout_log_path).write_text('{"stop_reason":"max_turns"}', encoding="utf-8")
return (0, False)
@@ -1075,7 +1079,7 @@ def test_env_vars_setup(monkeypatch, main_argv):
captured_env = {}
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch):
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch, **kwargs):
captured_env.update(env)
return (0, False)
@@ -1194,3 +1198,629 @@ def test_check_jsonl_activity_no_change(tmp_path):
def test_check_jsonl_activity_missing_dir(tmp_path):
"""Nonexistent directory -> False."""
assert _check_jsonl_activity(tmp_path / "nope", {}) is False
# --- Sandbox gate tests (Phase 4 FPLAN-0250) --------------------------------
class TestIsSandboxEnabled:
"""_is_sandbox_enabled reads AIPASS_SANDBOX_ENABLED from env."""
def test_unset_returns_false(self, monkeypatch):
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
assert _is_sandbox_enabled() is False
def test_empty_returns_false(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "")
assert _is_sandbox_enabled() is False
def test_false_string_returns_false(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "false")
assert _is_sandbox_enabled() is False
def test_zero_returns_false(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "0")
assert _is_sandbox_enabled() is False
def test_one_returns_true(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
assert _is_sandbox_enabled() is True
def test_true_returns_true(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "true")
assert _is_sandbox_enabled() is True
def test_yes_returns_true(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "yes")
assert _is_sandbox_enabled() is True
def test_TRUE_case_insensitive(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "TRUE")
assert _is_sandbox_enabled() is True
class TestFlagOffOldPath:
"""Flag OFF (default): dispatch uses the original cmd, no sandbox wrapping."""
def test_flag_off_cmd_unchanged(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
captured_cmds = []
def capture_run(cmd, *args, **kwargs):
captured_cmds.append(cmd)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert exc_info.value.code == 0
assert len(captured_cmds) == 1
assert captured_cmds[0] == ["claude", "-c", "--model", "opus"]
def test_flag_off_wrap_never_called(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
wrap_calls = []
original_wrap = mod._wrap_for_sandbox
def tracking_wrap(*args, **kwargs):
wrap_calls.append(args)
return original_wrap(*args, **kwargs)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_wrap_for_sandbox", tracking_wrap)
monkeypatch.setattr(mod, "_run_with_startup_check", MagicMock(return_value=(0, False)))
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
assert wrap_calls == []
class TestFlagOnSandboxPath:
"""Flag ON: dispatch wraps cmd via _wrap_for_sandbox."""
def test_flag_on_cmd_wrapped(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
captured_cmds = []
def capture_run(cmd, *args, **kwargs):
captured_cmds.append(cmd)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap --sandbox " + " ".join(cmd)],
)
mock_sock = MagicMock()
mock_sock.fileno.return_value = 99
monkeypatch.setattr(mod, "_connect_broker", MagicMock(return_value=mock_sock))
with pytest.raises(SystemExit) as exc_info:
main()
assert exc_info.value.code == 0
assert len(captured_cmds) == 1
assert captured_cmds[0][0] == "/bin/bash"
assert captured_cmds[0][1] == "-c"
assert "bwrap --sandbox" in captured_cmds[0][2]
def test_wrap_calls_building_blocks(self, monkeypatch, tmp_path):
call_log = []
def mock_build_policy(bp):
call_log.append("build_policy")
return {"allow_write": [str(bp)], "deny_write": [], "deny_read": []}
def mock_build_srt_config(policy):
call_log.append("build_srt_config")
return {"filesystem": {"allowWrite": policy["allow_write"]}}
def mock_resolve_bwrap(cmd_str, srt_config):
call_log.append("resolve_bwrap_command")
return f"bwrap --ro-bind / / {cmd_str}"
monkeypatch.setattr("aipass.hooks.apps.modules.sandbox.build_policy", mock_build_policy)
monkeypatch.setattr(
"aipass.hooks.apps.modules.sandbox.build_srt_config",
mock_build_srt_config,
)
monkeypatch.setattr(
"aipass.hooks.apps.modules.sandbox.resolve_bwrap_command",
mock_resolve_bwrap,
)
result = _wrap_for_sandbox(["claude", "--model", "opus"], tmp_path)
assert call_log == ["build_policy", "build_srt_config", "resolve_bwrap_command"]
assert result[0] == "/bin/bash"
assert result[1] == "-c"
assert "claude" in result[2]
class TestBrokenSandboxFailsLoud:
"""Flag ON but sandbox init fails: ABORT, never silently unsandbox."""
def test_sandbox_init_failure_aborts(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
run_calls = []
def capture_run(cmd, *args, **kwargs):
run_calls.append(cmd)
return (0, False)
def broken_wrap(cmd, bp):
raise RuntimeError("srt resolve failed: node not found")
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(mod, "_wrap_for_sandbox", broken_wrap)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert run_calls == []
assert exc_info.value.code != 0
def test_sandbox_failure_sends_bounce(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
def broken_wrap(cmd, bp):
raise FileNotFoundError("node not found in PATH")
mock_bounce = MagicMock()
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", MagicMock(return_value=(0, False)))
monkeypatch.setattr(mod, "_wrap_for_sandbox", broken_wrap)
monkeypatch.setattr(mod, "_send_bounce", mock_bounce)
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
mock_bounce.assert_called_once()
reason = mock_bounce.call_args[0][1]
assert "sandbox" in reason.lower() or "-4" in reason
def test_never_falls_back_to_unsandboxed(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
wrap_calls = [0]
run_calls = []
def counting_broken_wrap(cmd, bp):
wrap_calls[0] += 1
raise RuntimeError("srt unavailable")
def capture_run(cmd, *args, **kwargs):
run_calls.append(cmd)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(mod, "_wrap_for_sandbox", counting_broken_wrap)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
assert wrap_calls[0] == 1
assert run_calls == []
# --- Broker-fd handshake tests (Phase 6b FPLAN-0250) -------------------------
class TestFlagOffNoBroker:
"""Flag OFF: no broker connection attempted at all."""
def test_flag_off_no_broker_activity(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
connect_calls = []
def tracking_connect(*args, **kwargs):
connect_calls.append(args)
raise RuntimeError("should never be called")
monkeypatch.setattr(mod, "_connect_broker", tracking_connect)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", MagicMock(return_value=(0, False)))
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert exc_info.value.code == 0
assert connect_calls == []
def test_flag_off_no_broker_fd_in_env(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
captured_env = {}
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch, **kwargs):
captured_env.update(env)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
assert "AIPASS_BROKER_FD" not in captured_env
class TestBrokerDownFailsLoud:
"""Broker down + flag ON → exit -4, agent never spawned."""
def test_broker_connect_failure_aborts(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
run_calls = []
def capture_run(cmd, *args, **kwargs):
run_calls.append(cmd)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(
mod,
"_connect_broker",
MagicMock(side_effect=OSError("broker socket not found")),
)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert run_calls == []
assert exc_info.value.code != 0
def test_broker_bad_hmac_aborts(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
run_calls = []
def capture_run(cmd, *args, **kwargs):
run_calls.append(cmd)
return (0, False)
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(
mod,
"_connect_broker",
MagicMock(side_effect=RuntimeError("Broker identify failed: bad HMAC")),
)
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert run_calls == []
assert exc_info.value.code != 0
def test_broker_failure_sends_bounce(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
mock_bounce = MagicMock()
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", MagicMock(return_value=(0, False)))
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(
mod,
"_connect_broker",
MagicMock(side_effect=OSError("socket missing")),
)
monkeypatch.setattr(mod, "_send_bounce", mock_bounce)
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
mock_bounce.assert_called_once()
class TestBrokerFdHandshake:
"""Flag ON + broker up: fd passed to child, parent closes after spawn."""
def test_broker_fd_in_env_and_pass_fds(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
captured_env = {}
captured_pass_fds = []
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch, pass_fds=()):
captured_env.update(env)
captured_pass_fds.append(pass_fds)
return (0, False)
mock_sock = MagicMock()
mock_sock.fileno.return_value = 42
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(mod, "_connect_broker", MagicMock(return_value=mock_sock))
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit) as exc_info:
main()
assert exc_info.value.code == 0
assert captured_env.get("AIPASS_BROKER_FD") == "42"
assert captured_pass_fds == [(42,)]
mock_sock.close.assert_called_once()
def test_parent_closes_socket_after_spawn(self, monkeypatch, main_argv):
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
mock_sock = MagicMock()
mock_sock.fileno.return_value = 7
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", MagicMock(return_value=(0, False)))
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(mod, "_connect_broker", MagicMock(return_value=mock_sock))
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
mock_sock.close.assert_called_once()
def test_broker_fd_cleaned_from_env_after_spawn(self, monkeypatch, main_argv):
"""After spawn+close, AIPASS_BROKER_FD removed from spawn_env."""
argv, lock_file, stderr_log = main_argv
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
env_snapshots = []
def capture_run(cmd, stdout_log, stderr_fh, cwd, env, branch, pass_fds=()):
env_snapshots.append(dict(env))
return (0, False)
mock_sock = MagicMock()
mock_sock.fileno.return_value = 10
monkeypatch.setattr("sys.argv", argv)
monkeypatch.setattr(mod, "_run_with_startup_check", capture_run)
monkeypatch.setattr(
mod,
"_wrap_for_sandbox",
lambda cmd, bp: ["/bin/bash", "-c", "bwrap " + " ".join(cmd)],
)
monkeypatch.setattr(mod, "_connect_broker", MagicMock(return_value=mock_sock))
monkeypatch.setattr(mod, "_send_bounce", MagicMock())
monkeypatch.setattr(mod, "_check_rate_limited", MagicMock(return_value=False))
monkeypatch.setattr(
"aipass.ai_mail.apps.handlers.paths.find_repo_root",
MagicMock(return_value=Path("/fake/repo")),
)
with pytest.raises(SystemExit):
main()
# During the run, env had the FD
assert env_snapshots[0]["AIPASS_BROKER_FD"] == "10"
@pytest.mark.skipif(sys.platform != "linux", reason="AF_UNIX broker daemon is Linux-only")
class TestBrokerRealE2E:
"""Real multi-process e2e: broker daemon, identified connection, child reads fd."""
def test_child_inherits_broker_fd(self, tmp_path):
"""Start real broker, create identified conn, spawn child that reads AIPASS_BROKER_FD."""
import time as time_mod
from aipass.drone.apps.handlers.broker.daemon import BrokerDaemon
from aipass.drone.apps.handlers.broker.client import create_identified_connection
# Set up repo root with branch dir + .trinity marker (broker marker-walk requires it)
repo_root = tmp_path / "repo"
branch_dir = repo_root / "src" / "aipass" / "testbranch"
branch_dir.mkdir(parents=True)
trinity_dir = branch_dir / ".trinity"
trinity_dir.mkdir()
(trinity_dir / "passport.json").write_text('{"branch_info": {"branch_name": "testbranch"}}', encoding="utf-8")
target_file = branch_dir / "deleteme.txt"
target_file.write_text("delete me", encoding="utf-8")
# Start real broker
sock_path = tmp_path / "broker.sock"
audit_path = tmp_path / "audit.jsonl"
secret_path = tmp_path / "secret"
broker = BrokerDaemon(
repo_root=repo_root,
socket_path=sock_path,
audit_path=audit_path,
secret_path=secret_path,
)
t = broker.start_background()
time_mod.sleep(0.5)
try:
# Create identified connection (as the launcher would)
sock = create_identified_connection(sock_path, secret_path, "testbranch")
broker_fd = sock.fileno()
# Spawn a real child that reads AIPASS_BROKER_FD and sends a delete
child_script = tmp_path / "child.py"
child_script.write_text(
"""
import os, socket, json
fd = int(os.environ["AIPASS_BROKER_FD"])
s = socket.socket(fileno=fd)
try:
req = json.dumps({"op": "delete", "path": "deleteme.txt", "request_id": "e2e1"}) + "\\n"
s.sendall(req.encode())
data = b""
while b"\\n" not in data:
chunk = s.recv(4096)
if not chunk:
break
data += chunk
resp = json.loads(data.decode())
# Write result to a file so parent can verify
with open(os.environ["RESULT_FILE"], "w") as f:
json.dump(resp, f)
finally:
s.detach()
""",
encoding="utf-8",
)
result_file = tmp_path / "result.json"
env = os.environ.copy()
env["AIPASS_BROKER_FD"] = str(broker_fd)
env["RESULT_FILE"] = str(result_file)
proc = subprocess.Popen(
[sys.executable, str(child_script)],
env=env,
pass_fds=(broker_fd,),
close_fds=True,
)
# Parent closes its copy
sock.close()
proc.wait(timeout=10)
assert proc.returncode == 0
# Verify the delete happened
assert not target_file.exists()
# Verify the child got a success response
import json as json_mod
result = json_mod.loads(result_file.read_text(encoding="utf-8"))
assert result["ok"] is True
# Verify audit log carries identity
audit_lines = audit_path.read_text(encoding="utf-8").strip().splitlines()
delete_entries = [
json_mod.loads(line) for line in audit_lines if json_mod.loads(line).get("op") == "delete"
]
assert len(delete_entries) >= 1
assert delete_entries[-1]["identity"] == "testbranch"
assert delete_entries[-1]["result"] == "DELETED"
finally:
broker.stop()
t.join(timeout=3)
+63 -7
View File
@@ -385,7 +385,7 @@ class TestHandleClose:
post_ops_called = []
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.batch_close_post_ops",
lambda bp, push_fn, central_fn, purge_fn: post_ops_called.append(True),
lambda bp, central_fn, purge_fn: post_ops_called.append(True),
)
mock_console = MagicMock()
mock_console.print = lambda msg, **kw: None
@@ -1286,7 +1286,7 @@ class TestHandleCloseExtended:
)
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.batch_close_post_ops",
lambda bp, push_fn, central_fn, purge_fn: None,
lambda bp, central_fn, purge_fn: None,
)
printed: list[str] = []
errors: list[str] = []
@@ -1338,7 +1338,7 @@ class TestHandleCloseExtended:
post_ops_called: list[bool] = []
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.batch_close_post_ops",
lambda bp, push_fn, central_fn, purge_fn: post_ops_called.append(True),
lambda bp, central_fn, purge_fn: post_ops_called.append(True),
)
printed: list[str] = []
mock_console = MagicMock()
@@ -1450,7 +1450,6 @@ class TestDeliveryCallback:
new_count,
opened_count,
total,
push_dashboard_fn=None,
update_central_fn=None,
):
"""Capture on_email_delivered arguments."""
@@ -1460,7 +1459,6 @@ class TestDeliveryCallback:
"new_count": new_count,
"opened_count": opened_count,
"total": total,
"push_dashboard_fn": push_dashboard_fn,
"update_central_fn": update_central_fn,
}
)
@@ -1478,7 +1476,6 @@ class TestDeliveryCallback:
assert delivered_args[0]["new_count"] == 3
assert delivered_args[0]["opened_count"] == 2
assert delivered_args[0]["total"] == 5
assert delivered_args[0]["push_dashboard_fn"] is not None
# ===========================================================================
@@ -1708,7 +1705,7 @@ class TestEmailSendIntrospection:
print_introspection()
combined = "\n".join(printed)
assert "EMAIL SEND ORCHESTRATION" in combined
assert "email_send Module" in combined
assert "handle_send" in combined
assert "_send_direct" in combined
assert "_send_broadcast" in combined
@@ -1761,3 +1758,62 @@ class TestSendInteractiveExtended:
assert result is True
assert any("@alpha" in p for p in printed)
assert any("sent" in p.lower() for p in printed)
class TestHandleReplyMultiArg:
"""Regression tests for multi-line reply body truncation (S84 fix)."""
def test_reply_joins_split_args_into_body(self, tmp_path, monkeypatch):
"""When shell splits body into multiple args, all are joined into message."""
original = {"id": "msg1", "from": "@devpulse", "subject": "test dispatch"}
captured_msg = []
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email._resolve_branch_path",
lambda: tmp_path,
)
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.get_email_by_id",
lambda inbox_file, msg_id: original,
)
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.send_reply",
lambda bp, orig, msg: (captured_msg.append(msg), "Reply sent", "r1")[1:],
)
mock_console = MagicMock()
monkeypatch.setattr("aipass.ai_mail.apps.modules.email.console", mock_console)
_write_inbox(tmp_path)
from aipass.ai_mail.apps.modules.email import handle_reply
result = handle_reply(["msg1", "Line one", "Line two", "Line three"])
assert result is True
assert len(captured_msg) == 1
assert captured_msg[0] == "Line one Line two Line three"
def test_reply_single_arg_unchanged(self, tmp_path, monkeypatch):
"""Single-arg reply body remains unchanged (no extra spaces)."""
original = {"id": "msg1", "from": "@devpulse", "subject": "test"}
captured_msg = []
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email._resolve_branch_path",
lambda: tmp_path,
)
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.get_email_by_id",
lambda inbox_file, msg_id: original,
)
monkeypatch.setattr(
"aipass.ai_mail.apps.modules.email.send_reply",
lambda bp, orig, msg: (captured_msg.append(msg), "Reply sent", "r1")[1:],
)
mock_console = MagicMock()
monkeypatch.setattr("aipass.ai_mail.apps.modules.email.console", mock_console)
_write_inbox(tmp_path)
from aipass.ai_mail.apps.modules.email import handle_reply
result = handle_reply(["msg1", "Complete single-line reply"])
assert result is True
assert captured_msg[0] == "Complete single-line reply"
@@ -155,51 +155,34 @@ def test_dispatch_send_error_passes_correct_email_data(monkeypatch):
# ---- on_email_delivered tests --------------------------------
def test_on_email_delivered_with_both_callbacks():
"""Both callbacks are invoked when provided."""
push_fn = MagicMock()
def test_on_email_delivered_with_central_callback():
"""Central callback is invoked when provided."""
update_fn = MagicMock()
branch_path = "/some/path"
on_email_delivered(branch_path, 3, 1, 10, push_fn, update_fn)
on_email_delivered(branch_path, 3, 1, 10, update_central_fn=update_fn)
push_fn.assert_called_once_with(branch_path)
update_fn.assert_called_once_with()
def test_on_email_delivered_with_none_callbacks():
"""No error when both callbacks are None."""
on_email_delivered("/some/path", 3, 1, 10, None, None)
def test_on_email_delivered_dashboard_failure_does_not_block_central():
"""Dashboard failure does not prevent central update from running."""
push_fn = MagicMock(side_effect=RuntimeError("dashboard broken"))
update_fn = MagicMock()
on_email_delivered("/some/path", 3, 1, 10, push_fn, update_fn)
push_fn.assert_called_once()
update_fn.assert_called_once()
"""No error when callback is None."""
on_email_delivered("/some/path", 3, 1, 10, None)
def test_on_email_delivered_central_failure_does_not_raise():
"""Central update failure is caught silently."""
push_fn = MagicMock()
update_fn = MagicMock(side_effect=RuntimeError("central broken"))
on_email_delivered("/some/path", 3, 1, 10, push_fn, update_fn)
on_email_delivered("/some/path", 3, 1, 10, update_central_fn=update_fn)
push_fn.assert_called_once()
update_fn.assert_called_once()
def test_on_email_delivered_both_fail_no_exception():
"""Both callbacks failing does not raise any exception."""
push_fn = MagicMock(side_effect=RuntimeError("push fail"))
def test_on_email_delivered_central_fail_no_exception():
"""Central callback failing does not raise any exception."""
update_fn = MagicMock(side_effect=RuntimeError("update fail"))
on_email_delivered("/some/path", 3, 1, 10, push_fn, update_fn)
on_email_delivered("/some/path", 3, 1, 10, update_central_fn=update_fn)
push_fn.assert_called_once()
update_fn.assert_called_once()
+1 -1
View File
@@ -46,7 +46,7 @@ def test_get_footer_contains_checklist():
assert "TASK CHECKLIST" in result
assert "SEEDGO CHECK" in result
assert "UPDATE MEMORIES" in result
assert "CLOSE FPLAN" in result
assert "CLOSE YOUR PLAN" in result
assert "EMAIL SENDER" in result
@@ -42,12 +42,6 @@ def _mock_inbox_lock(monkeypatch):
monkeypatch.setattr(mod, "_get_inbox_lock", lambda: _noop_lock)
@pytest.fixture(autouse=True)
def _mock_dashboard(monkeypatch):
"""Replace _get_push_dashboard_update with a no-op."""
monkeypatch.setattr(mod, "_get_push_dashboard_update", lambda: lambda _bp: None)
@pytest.fixture(autouse=True)
def _mock_central(monkeypatch):
"""Replace _get_update_central with a no-op."""
+1 -69
View File
@@ -1,6 +1,6 @@
"""Tests for miscellaneous handlers -- central_writer.update_central, dispatch status.check_pid_status,
daemon.run_daemon, json_handler.increment_counter/update_data_metrics, delivery.deliver_to_inbox_file,
dashboard_sync.push_dashboard_update, inbox_resolve.resolve_inbox_target."""
inbox_resolve.resolve_inbox_target."""
import json
import os
@@ -14,7 +14,6 @@ import aipass.ai_mail.apps.handlers.central_writer as central_mod
import aipass.ai_mail.apps.handlers.dispatch.daemon as daemon_mod
import aipass.ai_mail.apps.handlers.json_utils.json_handler as json_handler_mod
import aipass.ai_mail.apps.handlers.email.delivery as delivery_mod
import aipass.ai_mail.apps.handlers.email.dashboard_sync as dashboard_mod
from aipass.ai_mail.apps.handlers.central_writer import update_central
from aipass.ai_mail.apps.handlers.dispatch.status import check_pid_status
from aipass.ai_mail.apps.handlers.json_utils.json_handler import (
@@ -22,7 +21,6 @@ from aipass.ai_mail.apps.handlers.json_utils.json_handler import (
update_data_metrics,
)
from aipass.ai_mail.apps.handlers.email.delivery import deliver_to_inbox_file
from aipass.ai_mail.apps.handlers.email.dashboard_sync import push_dashboard_update
from aipass.ai_mail.apps.handlers.email.inbox_resolve import resolve_inbox_target
@@ -61,14 +59,6 @@ def _silence_json_handler_delivery():
yield mock_jh
@pytest.fixture(autouse=True)
def _silence_json_handler_dashboard():
"""Prevent log_operation in dashboard_sync from writing real JSON files."""
with patch("aipass.ai_mail.apps.handlers.email.dashboard_sync.json_handler") as mock_jh:
mock_jh.log_operation.return_value = True
yield mock_jh
@pytest.fixture(autouse=True)
def _silence_json_handler_inbox_resolve():
"""Prevent log_operation in inbox_resolve from writing real JSON files."""
@@ -399,64 +389,6 @@ def test_deliver_to_inbox_file_preserves_existing_messages(tmp_path, _noop_inbox
assert result["messages"][1]["subject"] == "Old email"
# ==============================================================
# push_dashboard_update tests
# ==============================================================
def test_push_dashboard_update_happy_path(tmp_path):
"""Successful dashboard push returns True."""
branch_path = tmp_path / "trigger"
inbox_dir = branch_path / ".ai_mail.local"
inbox_dir.mkdir(parents=True)
inbox_file = inbox_dir / "inbox.json"
inbox_data = {
"messages": [
{"id": "m1", "status": "new", "timestamp": "2026-04-01 10:00:00"},
{"id": "m2", "status": "opened", "timestamp": "2026-04-01 09:00:00"},
]
}
inbox_file.write_text(json.dumps(inbox_data), encoding="utf-8")
mock_write = MagicMock(return_value=True)
with patch.object(dashboard_mod, "_get_write_section", return_value=mock_write):
result = push_dashboard_update(branch_path)
assert result is True
mock_write.assert_called_once()
section_data = mock_write.call_args[0][1]
assert section_data == "ai_mail"
def test_push_dashboard_update_no_inbox(tmp_path):
"""Returns True with zero stats when no inbox exists."""
branch_path = tmp_path / "empty_branch"
branch_path.mkdir()
mock_write = MagicMock(return_value=True)
with patch.object(dashboard_mod, "_get_write_section", return_value=mock_write):
result = push_dashboard_update(branch_path)
assert result is True
mock_write.assert_called_once()
section_data = mock_write.call_args[0][2]
assert section_data["new"] == 0
assert section_data["total"] == 0
def test_push_dashboard_update_catches_exceptions(tmp_path):
"""Returns False on any exception (never raises)."""
branch_path = tmp_path / "broken"
branch_path.mkdir()
with patch.object(dashboard_mod, "_get_write_section", side_effect=RuntimeError("broken")):
result = push_dashboard_update(branch_path)
assert result is False
# ==============================================================
# resolve_inbox_target tests
# ==============================================================
+37
View File
@@ -268,3 +268,40 @@ def test_send_reply_re_prefix_not_duplicated(tmp_path):
assert success is True
# Should keep "RE: Already replied", not "RE: RE: Already replied"
assert deliver_calls[0][1]["subject"] == "RE: Already replied"
def test_send_reply_multiline_body_preserved(tmp_path):
"""Multi-line reply body is stored intact, not truncated to first line."""
from_branch_path = tmp_path / "hooks"
from_branch_path.mkdir()
sender_info = {"email": "@hooks", "name": "HOOKS"}
target_branch = {"email": "@devpulse", "name": "DEVPULSE", "path": str(tmp_path / "devpulse")}
original = _make_original_email()
deliver_calls = []
def mock_deliver(to_branch, email_data):
deliver_calls.append((to_branch, email_data))
return (True, "")
multiline_body = (
"Investigation: cadence findings\n\nDetails:\n1. First finding\n2. Second finding\n3. Third finding"
)
with (
patch(_PATCH_BRANCH_DETECTION, return_value=sender_info),
patch(_PATCH_DELIVERY, side_effect=mock_deliver),
patch(_PATCH_ALL_BRANCHES, return_value=[target_branch]),
patch(_PATCH_CLOSE_ARCHIVE, return_value=(True, "closed")),
):
success, _message, _reply_id = send_reply(from_branch_path, original, multiline_body)
assert success is True
assert deliver_calls[0][1]["message"] == multiline_body
sent_folder = from_branch_path / ".ai_mail.local" / "sent"
sent_files = list(sent_folder.glob("*.json"))
assert len(sent_files) == 1
with open(sent_files[0], "r", encoding="utf-8") as f:
sent_data = json.load(f)
assert sent_data["message"] == multiline_body
@@ -357,3 +357,34 @@ def test_resolve_dispatch_target_tilde_path():
result = resolve_dispatch_target("~/Projects/flow", True, get_branch_info_fn=None)
assert result == "@flow"
# ---- parse_send_args multi-arg message tests (S84 fix) --------
def test_parse_send_args_joins_split_message():
"""When message body is split into multiple args, all are joined."""
from aipass.ai_mail.apps.handlers.email.send_args import parse_send_args
result = parse_send_args(["@target", "Subject", "Line one", "Line two", "Line three"])
assert result["mode"] == "direct"
assert result["subject"] == "Subject"
assert result["message"] == "Line one Line two Line three"
def test_parse_send_args_single_message_unchanged():
"""Single message arg is not altered."""
from aipass.ai_mail.apps.handlers.email.send_args import parse_send_args
result = parse_send_args(["@target", "Subject", "Complete body here"])
assert result["mode"] == "direct"
assert result["message"] == "Complete body here"
def test_parse_send_args_multiline_body_preserved():
"""A single arg with embedded newlines passes through intact."""
from aipass.ai_mail.apps.handlers.email.send_args import parse_send_args
body = "First line\nSecond line\nThird line"
result = parse_send_args(["@target", "Subject", body])
assert result["message"] == body
@@ -570,13 +570,18 @@ class TestDispatchEnvIsolation:
)
def test_dispatch_monitor_passes_spawn_env_to_subprocess(self):
"""dispatch_monitor.py must pass env=spawn_env to subprocess.run.
"""dispatch_monitor.py must pass spawn_env as the subprocess env.
Without this, all env var isolation is useless — the subprocess
would inherit os.environ instead of the cleaned spawn_env.
Accepts either the direct kwarg form (env=spawn_env) or the
popen_kwargs dict form ("env": spawn_env) introduced with the
sandbox broker-fd wiring (FPLAN-0250 Phase 6b).
"""
active_source = self._load_active_source()
assert "env=spawn_env" in active_source, "dispatch_monitor.py must pass env=spawn_env to subprocess.run"
assert "env=spawn_env" in active_source or '"env": spawn_env' in active_source, (
"dispatch_monitor.py must pass spawn_env as the subprocess env"
)
def test_detect_resolves_identity_when_cwd_is_wrong(self, clean_env, tmp_path, list_format_registry):
"""When AIPASS_CALLER_BRANCH is set but CWD is outside any branch,
+2
View File
@@ -601,6 +601,7 @@ class TestWakeBranchSpawnEnv:
local_bin = str(_Path.home() / ".local" / "bin")
monkeypatch.setenv("PATH", "/usr/bin:/bin")
monkeypatch.delenv("INVOCATION_ID", raising=False)
captured_envs: list = []
@@ -831,6 +832,7 @@ def _patch_wake_deps(monkeypatch, **overrides):
monkeypatch.setattr(wake_mod, attr, val)
monkeypatch.setattr("aipass.ai_mail.apps.handlers.dispatch.wake.time.sleep", lambda _: None)
monkeypatch.delenv("INVOCATION_ID", raising=False)
class _FakeProc:
@@ -1,6 +1,6 @@
# AIPASS — Branch Prompt
*Injected every turn. Breadcrumbs only — details: README, --help, .trinity/ memories, STATUS.local.md.*
*Injected every turn. Breadcrumbs only — details: README, --help, .trinity/ memories.*
## Identity
@@ -12,9 +12,9 @@ Not suggestions. Violating = bug.
- **No writes outside own `.trinity/`.** Never create, edit, delete files anywhere else. Not code, not docs, not configs, not other branches' memories.
- **No git. Ever.** Not `git status`, not `drone @git anything`. Git is drone's world.
- **No `drone @ai_mail dispatch`.** Email only test-convention body (below). Never wake agent real work.
- **Dispatch focused work via `drone @ai_mail dispatch`** — to ONE owning branch, as the user's voice with detailed feedback. Reply routes to @aipass; I track the loop and report back. Not an orchestrator (no fleets, no running the floor — that's devpulse). Test-convention pings (below) still fine.
- **No registry / hooks / bypass.json / config edits.** Spot bug → report. Never patch.
- User asks build/fix/change something: tell them who. Offer dispatch through devpulse/drone — don't do it.
- User asks build/fix/change in another branch: name the owner, then dispatch focused work to them as the user's voice. Heavy orchestration, git, and fleets stay with devpulse.
## What I Do
+105 -30
View File
@@ -2,8 +2,8 @@
"metadata": {
"version": "2.0.0",
"created": "2026-04-16",
"description": "Bypass config for @aipass citizen. While under construction (DPLAN-0136 Phase 0-3), module and handler files exist as documented placeholders with no implementation body. Each placeholder raises NotImplementedError and declares its phase. Bypass standards that fire on structural requirements the placeholders intentionally skip — json_handler import, print_introspection, CLI service wiring. Remove these entries in Phase N as each module gets its real body.",
"last_updated": "2026-04-16"
"description": "Bypass config for @aipass citizen. Modules operational: concierge/init/doctor/handoff/profile built and tested. Bypasses cover: binary-invocation introspection pattern (bare aipass <cmd> runs, --info for introspection), thin entry-point router (aipass.py uses bare print, no CLI imports), pure-python bootstrap (bootstrap.py/scaffold_content.py run before AIPass services exist), test-isolation patterns (architecture/encapsulation for tests/ directory), and CLI flag name references (permission_flags in test assertions and handoff platform).",
"last_updated": "2026-06-02"
},
"bypass": [
{
@@ -31,45 +31,20 @@
"standard": "cli",
"reason": "Session info must print immediately after tmux spawn — returning data to module layer would lose the timing context. User needs attach/kill instructions right when the session starts."
},
{
"file": "apps/modules/handoff.py",
"standard": "introspection",
"reason": "Phase 4 placeholder — print_introspection() added with handoff build."
},
{
"file": "apps/modules/handoff.py",
"standard": "json_structure",
"reason": "Phase 4 placeholder — json_handler import added with handoff build."
},
{
"file": "apps/modules/handoff.py",
"standard": "cli",
"reason": "Phase 4 placeholder — CLI service imports added with handoff build."
},
{
"file": "apps/aipass.py",
"standard": "architecture",
"reason": "Phase 0 entry-point stub from spawn template. Full 3-layer wiring (modules/ discovery, handlers/ imports) added when first module comes online (Phase 1)."
},
{
"file": "apps/aipass.py",
"standard": "cli",
"reason": "Phase 0 entry-point stub — CLI service imports (console, header) added when modules come online (Phase 1+)."
"reason": "Thin command router — discovers and routes to modules, which own the CLI service layer. Adding console/header imports here couples the bootstrap entry point to Rich for 4 status lines."
},
{
"file": "apps/aipass.py",
"standard": "debug_print",
"reason": "Phase 0 entry-point stub uses bare print() for scaffold visibility. Replaced with console.print() when CLI services are wired in Phase 1+."
"reason": "Thin command router uses bare print() for version output and help banner (4 calls). These run before module discovery — importing Rich console for bootstrap output adds startup overhead for minimal benefit."
},
{
"file": "apps/aipass.py",
"standard": "introspection",
"reason": "Phase 0 — spawn template does not emit print_introspection(). Added when modules come online (Phase 1+)."
},
{
"file": "apps/aipass.py",
"standard": "log_structure",
"reason": "Phase 0 — logs/ directory exists (spawn-created), but prax logger import not wired yet. Added when first module uses it."
"reason": "Thin command router, not a module — it has no domain to introspect. Modules handle their own introspection via --info. No print_introspection() needed."
},
{
"file": "apps/modules/doctor.py",
@@ -260,6 +235,106 @@
"file": "apps/handlers/init/scaffold_content.py",
"standard": "json_structure",
"reason": "scaffold_content.py is Pure Python only (no module/prax/cli imports) by design — pure string-returning template generators extracted from bootstrap.py. Same constraint as bootstrap.py."
},
{
"file": "apps/modules/doctor.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: aipass doctor runs the command; introspection via --info"
},
{
"file": "apps/modules/doctor_fix.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: bare invocation shows usage; introspection via --info"
},
{
"file": "apps/modules/doctor_wire.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: bare invocation shows usage; introspection via --info"
},
{
"file": "apps/modules/handoff.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: aipass handoff shows usage; introspection via --info"
},
{
"file": "apps/modules/help_chat.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: aipass help shows usage; introspection via --info"
},
{
"file": "apps/modules/init_flow.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: aipass init shows usage; introspection via --info"
},
{
"file": "apps/modules/profile.py",
"standard": "introspection",
"reason": "aipass is binary-invoked: aipass profile runs the command; introspection via --info"
},
{
"file": "apps/handlers/json/json_handler.py",
"standard": "test_quality",
"reason": "save_json now raises ValueError on invalid structure (aipass.aipass.shared contract, TDPLAN-0006 P2). Tested via pytest.raises — no False return path to test."
},
{
"file": "tests/test_sandbox_check.py",
"standard": "architecture",
"reason": "Test file lives in tests/ by convention — not in apps/. Standard 3-layer structure applies to production code only."
},
{
"file": "tests/test_sandbox_check.py",
"standard": "encapsulation",
"reason": "Unit tests must import handlers directly (sandbox_checker, progress) to test them in isolation. Entry-point imports would defeat the purpose of unit testing."
},
{
"file": "tests/test_sandbox_check.py",
"standard": "documentation",
"reason": "Test methods use descriptive names (test_flag_off_by_default, test_bwrap_functional_live) that are self-documenting. Adding docstrings to 41 test functions adds noise without value."
},
{
"file": "shared/json_handler.py",
"standard": "architecture",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/json_handler.py",
"standard": "log_visibility",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/json_handler.py",
"standard": "trigger",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/json_ops.py",
"standard": "architecture",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/json_ops.py",
"standard": "log_visibility",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/json_ops.py",
"standard": "trigger",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "shared/registry_discovery.py",
"standard": "architecture",
"reason": "pre-infra leaf — stdlib-only by design, must not import branch dependencies (loads pre-drone for aipass init)"
},
{
"file": "tests/test_shared_bootstrap_safety.py",
"standard": "architecture",
"reason": "Test file lives in tests/ by convention — not in apps/. Standard 3-layer structure applies to production code only."
},
{
"file": "shared/json_ops.py",
"standard": "unused_function",
"reason": "backup_json() is consumed by @spawn (cross-branch caller). Appears unused in @aipass-only scan but is a shared API."
}
]
}
+7 -5
View File
@@ -17,9 +17,9 @@ aipass/
│ ├── modules/
│ │ ├── doctor.py # System health aggregation
│ │ ├── doctor_fix.py # Remediation report (--fix, --json)
│ │ ├── doctor_wire.py # Auto-wire prompt helpers
│ │ ├── doctor_wire.py # Auto-wire provider settings + stale-deny re-export
│ │ ├── handoff.py # CLI handoff (placeholder)
│ │ ├── help_chat.py # README-backed Q&A
│ │ ├── help_chat.py # README-backed Q&A (reads via readme_map handler)
│ │ ├── init_flow.py # 12-stage guided setup
│ │ └── profile.py # User profile read/write
│ ├── handlers/
@@ -27,12 +27,14 @@ aipass/
│ │ ├── init/ # bootstrap.py, scaffold_content.py
│ │ ├── json/ # JSON read/write utilities
│ │ ├── ping_sweep/ # Branch reachability verification
│ │ ├── provider_reconcile.py # Stale deny-rule detection + fix
│ │ ├── readme_map/ # Live file reads + branch routing
│ │ ├── structure_scan/ # Agent placement + pollution detection
│ │ ├── system_detect/ # OS, shell, Python, RAM, CPU
│ │ └── ui/ # Progress bars, menus, banners
│ └── plugins/
├── tests/ # 412 passing
├── tests/ # 432 passing
├── requirements.project.txt # Project-specific Python dependencies
├── .trinity/ # Identity + session history + observations
└── README.md
```
@@ -68,7 +70,7 @@ Humans only. Nothing in AIPass depends on this branch.
## Tests
412 passing — `pytest src/aipass/aipass/tests/`
432 passing — `pytest src/aipass/aipass/tests/`
## Known Issues
@@ -76,4 +78,4 @@ Humans only. Nothing in AIPass depends on this branch.
## Last Updated
Last Updated: 2026-05-16
Last Updated: 2026-06-05
+14
View File
@@ -15,11 +15,25 @@ Auto-discovery architecture:
- No manual imports or routing needed
"""
import os
import sys
import importlib
from pathlib import Path
from typing import List, Any
# Windows terminals/pipes default to cp1252, which can't encode the Unicode
# Rich emits (✓/✗, box-drawing, arrows). PYTHONUTF8 only affects child
# interpreters, not this process's already-open stdout/stderr — so we also
# reconfigure the live streams to UTF-8 in place (Python 3.7+). Without this,
# `aipass init` scaffolds correctly but crashes printing its success banner
# with UnicodeEncodeError ('charmap') on Windows. Mirrors drone/cli.py.
if sys.platform == "win32":
os.environ.setdefault("PYTHONUTF8", "1") # for child subprocesses
for _stream in (sys.stdout, sys.stderr):
_reconfigure = getattr(_stream, "reconfigure", None)
if _reconfigure is not None:
_reconfigure(encoding="utf-8", errors="replace")
from aipass.prax import logger
# =============================================================================
+118 -103
View File
@@ -11,15 +11,15 @@ Init Bootstrap Handler - PRIVATE implementation
Business logic for `aipass init`. Creates the project scaffold:
1. {NAME}_REGISTRY.json — project registry with UUID
2. .aipass/aipass_global_prompt.md — global prompt (injected every turn)
2. .aipass/tier0_kernel.md — tier 0 kernel prompt (every turn)
2b..aipass/tier1_navmap.md — tier 1 navigation map (periodic)
3. CLAUDE.md — project prompt (Claude Code reads this)
4. AGENTS.md — Codex equivalent of CLAUDE.md
5. README.md — getting started guide
6. STATUS.local.md — project status
7. .gitignore — standard AIPass ignores
8. .claude/settings.json — Claude Code hooks configuration
9. src/ — directory where agents live
10. .ai_mail.local/inbox.json — empty project mailbox
6. .gitignore — standard AIPass ignores
7. .claude/settings.json — Claude Code hooks configuration
8. src/ — directory where agents live
9. .ai_mail.local/inbox.json — empty project mailbox
Projects are NOT citizens — no .trinity/ directory. Identity lives in the
registry JSON. Init is re-runnable: existing files are skipped, not errors.
@@ -43,60 +43,6 @@ from aipass.aipass.apps.handlers.init import scaffold_content as sc
logger = logging.getLogger(__name__)
# Hooks are NOT distributed to projects. All hooks fire from provider
# settings (~/.claude/settings.json), installed by setup.sh. Provider hooks
# use CWD-walking patterns that work from any directory in any project.
# Hook files are shipped as reference copies only (for debugging/inspection).
HOOKS_TO_SHIP = [
"branch_prompt_loader.py",
"email_notification.py",
"identity_injector.py",
"pre_compact.py",
"auto_fix_diagnostics.py",
"pre_edit_gate.py",
"subagent_stop_gate.py",
]
def _ship_hooks(aipass_home: str, target: Path) -> list[str]:
"""Copy enforcement + injector hooks from AIPass install to target project.
Copies each hook file to {target}/.claude/hooks/. Looks for hooks in two
locations (first match wins):
1. {aipass_home}/.claude/hooks/ — dev install (git clone)
2. aipass/_hooks/ — pip install (wheel-bundled)
Skips audio hooks. Overwrites existing files only if source content
differs (idempotent re-sync). Returns list of files written.
"""
source_dir = Path(aipass_home) / ".claude" / "hooks"
if not source_dir.is_dir():
# Fallback: pip install bundles hooks at aipass/_hooks/ inside the package
package_hooks = Path(__file__).resolve().parents[4] / "_hooks"
if package_hooks.is_dir():
source_dir = package_hooks
else:
logger.info("No hooks directory at %s or %s — skipping", source_dir, package_hooks)
return []
dest_dir = target / ".claude" / "hooks"
dest_dir.mkdir(parents=True, exist_ok=True)
shipped: list[str] = []
for hook_name in HOOKS_TO_SHIP:
src = source_dir / hook_name
dst = dest_dir / hook_name
if not src.exists():
logger.info("Hook %s not found at %s — skipping", hook_name, src)
continue
src_content = src.read_bytes()
if dst.exists() and dst.read_bytes() == src_content:
continue
shutil.copy2(src, dst)
shipped.append(str(dst))
return shipped
def _sanitize_name(raw: str) -> str:
"""Sanitize a project name for use in filenames.
@@ -124,14 +70,6 @@ def _detect_aipass_home() -> str | None:
return None
def _resolve_global_prompt(name: str, aipass_home: str | None, dest: Path) -> str:
"""Resolve global prompt content from source template or fallback generator."""
source = Path(aipass_home) / ".aipass" / "project_global_prompt.md" if aipass_home else None
if source and source.is_file():
return source.read_text(encoding="utf-8").replace("{name}", name)
return sc.with_source(sc.global_prompt_md(name), dest)
def _hook_fingerprint(hook_entry: dict) -> str:
"""Extract a comparable fingerprint from a hook entry."""
commands = []
@@ -201,6 +139,52 @@ def _merge_settings(existing: dict, generated: dict) -> dict:
return merged
def _merge_hooks_json(existing: dict, template: dict) -> dict:
"""Union-merge hooks.json: preserve user enabled values, add new hooks/events."""
merged: dict = {}
meta_keys = {"_comment", "hooks_enabled"}
if "_comment" in template:
merged["_comment"] = template["_comment"]
elif "_comment" in existing:
merged["_comment"] = existing["_comment"]
if "hooks_enabled" in existing:
merged["hooks_enabled"] = existing["hooks_enabled"]
elif "hooks_enabled" in template:
merged["hooks_enabled"] = template["hooks_enabled"]
all_events: set[str] = set()
for key in existing:
if key not in meta_keys:
all_events.add(key)
for key in template:
if key not in meta_keys:
all_events.add(key)
for event in sorted(all_events):
existing_hooks = existing.get(event, {})
template_hooks = template.get(event, {})
merged_hooks: dict = {}
for hook_name, hook_data in existing_hooks.items():
merged_hooks[hook_name] = dict(hook_data)
for hook_name, hook_data in template_hooks.items():
if hook_name in merged_hooks:
user_enabled = merged_hooks[hook_name].get("enabled")
merged_hooks[hook_name] = dict(hook_data)
if user_enabled is not None:
merged_hooks[hook_name]["enabled"] = user_enabled
else:
merged_hooks[hook_name] = dict(hook_data)
if merged_hooks:
merged[event] = merged_hooks
return merged
def _claude_settings(aipass_home: str | None = None) -> str:
"""Generate .claude/settings.json — env and permissions only.
@@ -221,9 +205,9 @@ def _claude_settings(aipass_home: str | None = None) -> str:
data["permissions"] = {
"deny": [
"Bash(rm -rf *)",
"Bash(git push --force*)",
"Bash(git reset --hard*)",
"EnterPlanMode",
],
}
@@ -332,10 +316,24 @@ def init_project(target: Path, project_name: str | None = None) -> dict:
aipass_dir = target / ".aipass"
aipass_dir.mkdir(exist_ok=True)
global_prompt_path = aipass_dir / "aipass_global_prompt.md"
if not global_prompt_path.exists():
global_prompt_path.write_text(_resolve_global_prompt(name, aipass_home, global_prompt_path), encoding="utf-8")
created.append(str(global_prompt_path))
# 2. .aipass/tier0_kernel.md + tier1_navmap.md — tiered prompt injection
for tier_file in ("tier0_kernel.md", "tier1_navmap.md"):
tier_dest = aipass_dir / tier_file
if not tier_dest.exists() and aipass_home:
tier_src = Path(aipass_home) / ".aipass" / tier_file
if tier_src.is_file():
shutil.copy2(str(tier_src), str(tier_dest))
created.append(str(tier_dest))
# 2b. .aipass/hooks.json — project hook config from template
hooks_json_path = aipass_dir / "hooks.json"
if not hooks_json_path.exists() and aipass_home:
template = Path(aipass_home) / ".aipass" / "project_hooks.json"
if template.is_file():
shutil.copy2(str(template), str(hooks_json_path))
created.append(str(hooks_json_path))
else:
logger.info("hooks template not found at %s — skipping", template)
# 3-5. CLAUDE.md, AGENTS.md — project templates or AIPass source
for md_name in ("CLAUDE.md", "AGENTS.md"):
@@ -347,6 +345,9 @@ def init_project(target: Path, project_name: str | None = None) -> dict:
content = template.read_text(encoding="utf-8").replace("{name}", name)
dest.write_text(content, encoding="utf-8")
created.append(str(dest))
elif md_name == "AGENTS.md":
dest.write_text(sc.agents_md(name), encoding="utf-8")
created.append(str(dest))
else:
source = Path(aipass_home) / md_name if aipass_home else None
if source and source.is_file():
@@ -362,16 +363,7 @@ def init_project(target: Path, project_name: str | None = None) -> dict:
readme_md_path.write_text(readme_content, encoding="utf-8")
created.append(str(readme_md_path))
# 7. STATUS.local.md
status_md_path = target / "STATUS.local.md"
if not status_md_path.exists():
status_md_path.write_text(
f"# {name}\n\n**State:** New\n**Last update:** {today}\n\n## Current Work\n\n## Known Issues\n- None\n",
encoding="utf-8",
)
created.append(str(status_md_path))
# 8. .gitignore
# 7. .gitignore
gitignore_path = target / ".gitignore"
if not gitignore_path.exists():
gitignore_path.write_text(sc.gitignore(), encoding="utf-8")
@@ -395,11 +387,6 @@ def init_project(target: Path, project_name: str | None = None) -> dict:
prep_path.write_text(sc.prep_md(), encoding="utf-8")
created.append(str(prep_path))
# 9d. Ship enforcement + injector hooks from AIPass install
if aipass_home:
shipped = _ship_hooks(aipass_home, target)
created.extend(shipped)
# 10. src/<project>/ package structure (pip-installable from day one)
package_name = raw_name.lower().replace("-", "_").replace(" ", "_")
src_dir = target / "src"
@@ -453,7 +440,7 @@ def update_project(target: Path) -> dict:
"""Update managed scaffold files in an existing AIPass project.
Overwrites managed prompt and config files with the latest templates while
leaving all user-owned files (registry, README, STATUS.local.md, .gitignore,
leaving all user-owned files (registry, README, .gitignore,
src/) untouched.
Args:
@@ -498,14 +485,21 @@ def update_project(target: Path) -> dict:
# --- Managed files: write only when content has changed ---
global_prompt_path = aipass_dir / "aipass_global_prompt.md"
aipass_home = aipass_home or _detect_aipass_home()
generated = _resolve_global_prompt(name, aipass_home, global_prompt_path)
if not global_prompt_path.exists() or global_prompt_path.read_text(encoding="utf-8") != generated:
global_prompt_path.write_text(generated, encoding="utf-8")
updated.append(str(global_prompt_path))
else:
already_current.append(str(global_prompt_path))
# tier0_kernel.md + tier1_navmap.md — tiered prompt injection
for tier_file in ("tier0_kernel.md", "tier1_navmap.md"):
tier_dest = aipass_dir / tier_file
tier_src = Path(aipass_home) / ".aipass" / tier_file if aipass_home else None
if tier_src and tier_src.is_file():
canonical = tier_src.read_text(encoding="utf-8")
if not tier_dest.exists() or tier_dest.read_text(encoding="utf-8") != canonical:
tier_dest.write_text(canonical, encoding="utf-8")
updated.append(str(tier_dest))
else:
already_current.append(str(tier_dest))
elif tier_dest.exists():
already_current.append(str(tier_dest))
# settings.json — smart merge: preserve user hooks + env, update AIPass hooks
settings_path = claude_dir / "settings.json"
@@ -531,6 +525,34 @@ def update_project(target: Path) -> dict:
else:
already_current.append(str(settings_path))
# hooks.json — union-merge: preserve user enabled, add new hooks from template
hooks_json_path = aipass_dir / "hooks.json"
hook_home = aipass_home or _detect_aipass_home()
template_path = Path(hook_home) / ".aipass" / "project_hooks.json" if hook_home else None
if template_path and template_path.is_file():
template_data = json.loads(template_path.read_text(encoding="utf-8"))
if hooks_json_path.exists():
try:
existing_hooks = json.loads(hooks_json_path.read_text(encoding="utf-8"))
except json.JSONDecodeError as exc:
logger.info("hooks.json parse failed, rebuilding: %s", exc)
existing_hooks = {}
merged_hooks = _merge_hooks_json(existing_hooks, template_data)
merged_hooks_content = json.dumps(merged_hooks, indent=2, ensure_ascii=False) + "\n"
if existing_hooks != merged_hooks:
hooks_json_path.write_text(merged_hooks_content, encoding="utf-8")
updated.append(str(hooks_json_path))
else:
already_current.append(str(hooks_json_path))
else:
hooks_json_path.write_text(
json.dumps(template_data, indent=2, ensure_ascii=False) + "\n",
encoding="utf-8",
)
updated.append(str(hooks_json_path))
elif hooks_json_path.exists():
already_current.append(str(hooks_json_path))
# CLAUDE.md, AGENTS.md — sync from project templates or AIPass source
for md_name in ("CLAUDE.md", "AGENTS.md"):
dest = target / md_name
@@ -557,17 +579,10 @@ def update_project(target: Path) -> dict:
else:
already_current.append(str(prep_path))
# Re-sync enforcement + injector hooks from AIPass install
hook_home = aipass_home or _detect_aipass_home()
if hook_home:
shipped = _ship_hooks(hook_home, target)
updated.extend(shipped)
# --- User-owned files: always skip ---
for skip_name in (
str(registry_path),
str(target / "README.md"),
str(target / "STATUS.local.md"),
str(target / ".gitignore"),
):
skipped.append(skip_name)
@@ -37,11 +37,11 @@ def readme_md(name: str) -> str:
"aipass init agent my_agent\n"
"\n"
"# 2. Start a session\n"
"cd src/my_agent/\n"
f"cd src/{name.lower()}/my_agent/\n"
"claude # or your preferred AI CLI\n"
"\n"
"# 3. Check project status\n"
"cat STATUS.local.md\n"
"# 3. Check project health\n"
"drone @seedgo audit .\n"
"```\n"
"\n"
"## Project Structure\n"
@@ -52,8 +52,7 @@ def readme_md(name: str) -> str:
" .aipass/ # Prompts (injected per-turn)\n"
" CLAUDE.md # Claude Code instructions\n"
" AGENTS.md # Codex instructions\n"
" STATUS.local.md # Project status\n"
" src/ # Agent directories live here\n"
f" src/{name.lower()}/ # Project package\n"
" <agent_name>/ # Created via aipass init agent\n"
"```\n"
"\n"
@@ -83,6 +82,30 @@ def readme_md(name: str) -> str:
)
def agents_md(name: str) -> str:
"""Generate AGENTS.md content — Codex equivalent of CLAUDE.md for projects."""
return (
f"# {name}\n"
"\n"
"Agent workspace powered by AIPass.\n"
"\n"
"# Startup protocol\n"
"\n"
"On any greeting, silently run this sequence — no narration, no announcing "
"steps. Just do it and respond with the status.\n"
"\n"
" - Read: `.trinity/passport.json`, `.trinity/local.json`, "
"`.trinity/observations.json`, `README.md`\n"
"\n"
"Use drone commands for all operations. Never raw git, gh, or file access "
"when drone provides it.\n"
"\n"
"# Memories\n"
"\n"
"Update `.trinity/` at natural breakpoints, after milestones, and on `/memo`.\n"
)
def global_prompt_md(name: str) -> str:
"""Generate .aipass/aipass_global_prompt.md — injected every turn."""
return (
@@ -212,7 +235,6 @@ def gitignore() -> str:
".trinity/\n"
".ai_mail.local/\n"
"*.local.*\n"
"!STATUS.local.md\n"
"\n"
"# Plans (local working docs)\n"
"DPLAN-*\n"
@@ -279,9 +301,6 @@ def prep_md() -> str:
"- **`.trinity/observations.json`** — YOUR MEMORY OF THE USER. "
"Collaboration insights, preferences, friction points. Skip if nothing "
"new about the user this session.\n"
"- **`STATUS.local.md`** — PUBLIC STATUS BEACON. Current work, known "
"issues, todos, notepad. Auto-synced to central STATUS.md on PR events "
"— this is how other branches see you. Keep Current Work accurate.\n"
"\n"
"## 2. Active Plans\n"
"\n"
@@ -308,7 +327,7 @@ def prep_md() -> str:
"- Flag anything in-flight: running background agents, dispatched "
"branches waiting for replies, pending decisions\n"
"- If anything can't survive compaction (e.g., agent IDs needed for "
"resume), write it to STATUS.local.md Notepad\n"
"resume), write it to local.json key_learnings\n"
"\n"
"## Confirm\n"
"\n"
@@ -317,7 +336,6 @@ def prep_md() -> str:
"Prep complete:\n"
"- local.json: [what was added]\n"
"- observations.json: [updated / skipped]\n"
"- STATUS.local.md: [updated / skipped]\n"
"- Plans: [which ones updated]\n"
"- Git: [branch, uncommitted count, suggestion]\n"
"- Inbox: [count, action taken]\n"
@@ -1,254 +1,88 @@
# =================== AIPass ====================
# Name: json_handler.py
# Description: Auto-Creating JSON Handler for aipass branch
# Version: 1.0.0
# Description: Branch-local shim — delegates to aipass.aipass.shared.json_handler
# Version: 2.0.0
# Created: 2026-04-16
# Modified: 2026-04-16
# Modified: 2026-06-06
# =============================================
"""
JSON Handler - Auto-Creating & Self-Healing JSON System
"""Branch-local JSON handler — thin shim over the shared ``aipass.aipass.shared`` library.
Handles default JSON files (config, data, log) for aipass modules.
Never manually create JSONs - they build themselves.
All logic lives in ``aipass.aipass.shared.json_handler.JsonHandler``.
This module binds a ``JsonHandler`` instance to the aipass branch's
``aipass_json/`` directory and re-exports the public API as module-level
functions so existing callers (``json_handler.log_operation(...)``) keep working.
"""
from __future__ import annotations
import inspect
import json
import os
import tempfile
from datetime import datetime
from pathlib import Path
from typing import Any, Dict, Optional
from aipass.prax import logger
from aipass.aipass.shared.json_handler import JsonHandler
def _get_caller_module_name() -> str:
"""Auto-detect calling module name from call stack."""
stack = inspect.stack()
if len(stack) > 2:
caller_path = Path(stack[2].filename)
module_name = caller_path.stem
if module_name and not module_name.startswith("_"):
return module_name
return "unknown"
# =============================================================================
# INFRASTRUCTURE SETUP
# =============================================================================
# json_handler.py lives at: src/aipass/aipass/apps/handlers/json/json_handler.py
# parents[0] = json/, [1] = handlers/, [2] = apps/, [3] = aipass/, [4] = src/aipass/
_PKG_ROOT = Path(__file__).resolve().parents[4]
# Constants
AIPASS_BRANCH_ROOT = _PKG_ROOT / "aipass"
AIPASS_JSON_DIR = AIPASS_BRANCH_ROOT / "aipass_json"
# =============================================================================
# INTERNAL HELPERS
# =============================================================================
def _handler() -> JsonHandler:
"""Create a handler bound to the current AIPASS_JSON_DIR."""
return JsonHandler(AIPASS_JSON_DIR)
def _get_caller_module_name() -> str:
"""Auto-detect calling module name from call stack.
Returns:
Module name (e.g., "doctor" from doctor.py)
"""
try:
stack = inspect.stack()
# Skip frames: [0]=this function, [1]=log_operation, [2]=actual caller
if len(stack) > 2:
caller_frame = stack[2]
caller_path = Path(caller_frame.filename)
module_name = caller_path.stem
if module_name and not module_name.startswith("_"):
return module_name
return "unknown"
except Exception as exc:
logger.warning("[json_handler] Failed to detect caller module name: %s", exc)
return "unknown"
def load_path(file_path: Path) -> Optional[dict]:
"""Load JSON from an arbitrary file path."""
return JsonHandler.read_json(file_path)
def _default_template(json_type: str, module_name: str) -> Any:
"""Return inline default structure for a JSON type — no file templates needed."""
today = datetime.now().date().isoformat()
if json_type == "config":
return {
"module_name": module_name,
"version": "1.0.0",
"config": {
"max_log_entries": 100,
},
"created": today,
}
if json_type == "data":
return {
"created": today,
"last_updated": today,
}
if json_type == "log":
return []
return None
def _atomic_write_json(target_path: Path, data: Any) -> None:
"""Write JSON data atomically via temp file + rename.
Prevents corruption from concurrent processes writing the same file.
"""
fd, tmp_path = tempfile.mkstemp(dir=str(target_path.parent), suffix=".tmp", prefix=target_path.stem)
succeeded = False
try:
with os.fdopen(fd, "w", encoding="utf-8") as f:
json.dump(data, f, indent=2, ensure_ascii=False)
os.replace(tmp_path, str(target_path))
succeeded = True
finally:
if not succeeded and Path(tmp_path).exists():
logger.warning("[json_handler] Cleaning up temp file after write failure: %s", tmp_path)
os.unlink(tmp_path)
# =============================================================================
# VALIDATION
# =============================================================================
def save_path(file_path: Path, data: Any, indent: int = 2) -> bool:
"""Write JSON data to an arbitrary file path atomically."""
return JsonHandler.write_json(file_path, data, indent)
def validate_json_structure(data: Any, json_type: str) -> bool:
"""Validate JSON structure matches expected type."""
if json_type == "config":
if not isinstance(data, dict):
return False
required = ["module_name", "version", "config"]
return all(key in data for key in required)
elif json_type == "data":
if not isinstance(data, dict):
return False
required = ["created", "last_updated"]
return all(key in data for key in required)
elif json_type == "log":
return isinstance(data, list)
return False
# =============================================================================
# PUBLIC API
# =============================================================================
def load_path(path: Path) -> Any:
"""Load JSON from an arbitrary file path with consistent error handling."""
try:
with open(path, "r", encoding="utf-8") as f:
return json.load(f)
except (json.JSONDecodeError, OSError) as exc:
logger.warning("[json_handler] Failed to load %s: %s", path, exc)
return None
def save_path(path: Path, data: Any) -> bool:
"""Write JSON data to an arbitrary file path atomically."""
os.makedirs(path.parent, exist_ok=True)
fd, tmp_path = tempfile.mkstemp(dir=str(path.parent), suffix=".tmp", prefix=path.stem)
succeeded = False
try:
with os.fdopen(fd, "w", encoding="utf-8") as f:
json.dump(data, f, indent=2, ensure_ascii=False)
f.write("\n")
os.replace(tmp_path, str(path))
succeeded = True
return True
except OSError as exc:
logger.warning("[json_handler] Failed to save %s: %s", path, exc)
return False
finally:
if not succeeded and Path(tmp_path).exists():
os.unlink(tmp_path)
"""Validate that data matches the expected shape for json_type."""
return JsonHandler.validate_json_structure(data, json_type)
def get_json_path(module_name: str, json_type: str) -> Path:
"""Get path for module JSON file."""
filename = f"{module_name}_{json_type}.json"
return AIPASS_JSON_DIR / filename
"""Return the filesystem path for a module's JSON file."""
return _handler().get_json_path(module_name, json_type)
def ensure_json_exists(module_name: str, json_type: str) -> bool:
"""Ensure JSON file exists, create from template if missing."""
AIPASS_JSON_DIR.mkdir(parents=True, exist_ok=True)
json_path = get_json_path(module_name, json_type)
if json_path.exists():
try:
with open(json_path, "r", encoding="utf-8") as f:
data = json.load(f)
if validate_json_structure(data, json_type):
return True
except Exception as exc:
logger.warning(
"[json_handler] Corrupted JSON file for '%s/%s', regenerating: %s",
module_name,
json_type,
exc,
)
template = _default_template(json_type, module_name)
if template is None:
return False
try:
_atomic_write_json(json_path, template)
return True
except Exception as exc:
logger.error(
"[json_handler] Failed to write JSON template for '%s/%s': %s",
module_name,
json_type,
exc,
)
return False
def load_json(module_name: str, json_type: str) -> Optional[Any]:
"""Load JSON file, auto-create if missing."""
if not ensure_json_exists(module_name, json_type):
return None
json_path = get_json_path(module_name, json_type)
try:
with open(json_path, "r", encoding="utf-8") as f:
return json.load(f)
except Exception as exc:
logger.error("[json_handler] Failed to load JSON for '%s/%s': %s", module_name, json_type, exc)
return None
def save_json(module_name: str, json_type: str, data: Any) -> bool:
"""Save JSON file."""
json_path = get_json_path(module_name, json_type)
if not validate_json_structure(data, json_type):
return False
if json_type == "data" and isinstance(data, dict):
data["last_updated"] = datetime.now().date().isoformat()
try:
_atomic_write_json(json_path, data)
return True
except Exception as exc:
logger.error("[json_handler] Failed to save JSON for '%s/%s': %s", module_name, json_type, exc)
return False
"""Ensure a single JSON file exists; create with defaults if missing."""
return _handler().ensure_json_exists(module_name, json_type)
def ensure_module_jsons(module_name: str) -> bool:
"""Ensure all 3 JSON files exist for a module."""
ensure_json_exists(module_name, "config")
ensure_json_exists(module_name, "data")
ensure_json_exists(module_name, "log")
return True
"""Ensure all three JSON files (config, data, log) exist for a module."""
return _handler().ensure_module_jsons(module_name)
def load_json(module_name: str, json_type: str) -> Optional[Any]:
"""Load a module's JSON file, auto-creating it if missing."""
return _handler().load_json(module_name, json_type)
def save_json(module_name: str, json_type: str, data: Any) -> bool:
"""Save JSON file. Raises ValueError on invalid structure."""
return _handler().save_json(module_name, json_type, data)
def log_operation(
@@ -256,42 +90,7 @@ def log_operation(
data: Dict[str, Any] | None = None,
module_name: str | None = None,
) -> bool:
"""Add entry to module log with automatic rotation.
Auto-detects calling module if module_name not provided.
Implements config-controlled log limits to prevent unbounded growth.
When max_log_entries is reached, removes oldest entries (FIFO).
Args:
operation: Operation name to log
data: Optional data dict
module_name: Optional module name (auto-detected if not provided)
Returns:
True if successful, False otherwise
"""
"""Add entry to module operation log with automatic rotation."""
if module_name is None:
module_name = _get_caller_module_name()
ensure_module_jsons(module_name)
config = load_json(module_name, "config")
max_entries = 100
if config and "config" in config:
max_entries = config["config"].get("max_log_entries", 100)
log = load_json(module_name, "log")
if log is None:
log = []
entry: Dict[str, Any] = {"timestamp": datetime.now().isoformat(), "operation": operation}
if data:
entry["data"] = data
log.append(entry)
if len(log) > max_entries:
log = log[-max_entries:]
return save_json(module_name, "log", log)
return _handler().log_operation(operation, data, module_name)
@@ -0,0 +1,81 @@
# =================== AIPass ====================
# Name: provider_reconcile.py
# Description: Detect and fix stale rules in provider settings
# Version: 1.0.0
# Created: 2026-06-05
# Modified: 2026-06-05
# =============================================
"""provider_reconcile — detect and fix stale rules in ~/.claude/settings.json."""
from __future__ import annotations
from pathlib import Path
from aipass.prax import logger
from aipass.aipass.apps.handlers.json import json_handler
_MODULE_NAME = "provider_reconcile"
_STALE_RM_DENY_RULES = frozenset({"Bash(rm -rf*)", "Bash(rm -r *)"})
GLYPH_PASS = "[green]✓[/green]"
GLYPH_WARN = "[yellow]![/yellow]"
def reconcile_stale_deny(fix: bool = False) -> list:
"""Detect and optionally remove stale rm deny rules from provider settings.
Returns list of (label, glyph, detail, remediation) tuples matching
doctor.CheckResult shape — imported as tuples to avoid circular import.
"""
results: list = []
settings_path = Path.home() / ".claude" / "settings.json"
if not settings_path.exists():
json_handler.log_operation(
"reconcile_stale_deny",
data={"fix": fix, "skipped": "no settings file"},
module_name=_MODULE_NAME,
)
return results
data = json_handler.load_path(settings_path)
if data is None:
json_handler.log_operation(
"reconcile_stale_deny",
data={"fix": fix, "skipped": "could not load settings"},
module_name=_MODULE_NAME,
)
return results
deny = data.get("permissions", {}).get("deny", [])
stale = [r for r in deny if r in _STALE_RM_DENY_RULES]
if not stale:
results.append(("rm deny migration", GLYPH_PASS, "no stale rules", ""))
elif fix:
deny_cleaned = [r for r in deny if r not in _STALE_RM_DENY_RULES]
data.setdefault("permissions", {})["deny"] = deny_cleaned
json_handler.save_path(settings_path, data)
removed = ", ".join(stale)
results.append(("rm deny migration", GLYPH_PASS, f"removed: {removed}", ""))
logger.info("[doctor] removed stale deny rules: %s", stale)
else:
found = ", ".join(stale)
results.append(
(
"rm deny migration",
GLYPH_WARN,
f"stale rules: {found}",
"Run aipass doctor --fix to remove (rm_gate + drone rm replace these)",
)
)
json_handler.log_operation(
"reconcile_stale_deny",
data={"fix": fix, "stale_found": len(stale)},
module_name=_MODULE_NAME,
)
return results
@@ -117,3 +117,18 @@ def list_branches() -> list[str]:
Reflects the filesystem state at the time the map was first built.
"""
return list(_get_map().keys())
def read_readme_lines(branch: str) -> list[str] | None:
"""Live-read README.md for a branch. Returns list of lines, or None on error.
Content is NEVER cached — every call reads the current file.
"""
readme_path = get_readme_path(branch)
if readme_path is None:
return None
try:
with open(readme_path, encoding="utf-8") as fh:
return fh.readlines()
except OSError:
return None
@@ -0,0 +1,21 @@
"""sandbox_check — Kernel sandbox prerequisite detection for aipass doctor."""
from aipass.aipass.apps.handlers.sandbox_check.sandbox_checker import ( # type: ignore[import-not-found]
check_broker_alive,
check_bwrap_functional,
check_bwrap_present,
check_node_present,
check_rg_present,
check_sandbox_flag,
check_srt_resolvable,
)
__all__ = [
"check_broker_alive",
"check_bwrap_functional",
"check_bwrap_present",
"check_node_present",
"check_rg_present",
"check_sandbox_flag",
"check_srt_resolvable",
]
@@ -0,0 +1,253 @@
# =================== AIPass ====================
# Name: sandbox_checker.py
# Description: Kernel sandbox prerequisite checks for aipass doctor
# Version: 1.0.0
# Created: 2026-06-10
# Modified: 2026-06-10
# =============================================
"""Sandbox prerequisite checker — detects bwrap, node, srt, rg, broker.
Returns plain dicts with facts about sandbox readiness.
No Rich markup — display concerns belong to the UI layer.
"""
from __future__ import annotations
import os
import shutil
import socket
import subprocess
import sys
from pathlib import Path
from typing import Any, Dict
from aipass.prax import logger
from aipass.aipass.apps.handlers.json import json_handler
def check_sandbox_flag() -> Dict[str, Any]:
"""Check AIPASS_SANDBOX_ENABLED env var state.
Returns:
enabled: bool
raw_value: str — the raw env value (empty if unset)
"""
raw = os.environ.get("AIPASS_SANDBOX_ENABLED", "")
enabled = raw.lower() in ("1", "true", "yes")
json_handler.log_operation("sandbox_check_flag", {"enabled": enabled, "raw": raw})
return {"enabled": enabled, "raw_value": raw}
def check_bwrap_present() -> Dict[str, Any]:
"""Check if bubblewrap (bwrap) binary is on PATH.
Returns:
found: bool
path: str | None — resolved path if found
"""
path = shutil.which("bwrap")
json_handler.log_operation("sandbox_check_bwrap_present", {"found": bool(path)})
return {"found": bool(path), "path": path}
def check_bwrap_functional() -> Dict[str, Any]:
"""Run a trivial bwrap sandbox to verify it actually works.
Catches AppArmor/userns restrictions that make bwrap present but blocked.
Returns:
ok: bool
detail: str — success message or error detail
sysctl_value: str | None — kernel.apparmor_restrict_unprivileged_userns on failure
"""
bwrap = shutil.which("bwrap")
if not bwrap:
return {"ok": False, "detail": "bwrap not found", "sysctl_value": None}
try:
proc = subprocess.run(
[bwrap, "--ro-bind", "/", "/", "--dev", "/dev", "--proc", "/proc", "true"],
capture_output=True,
text=True,
timeout=10,
check=False,
)
if proc.returncode == 0:
json_handler.log_operation("sandbox_check_bwrap_functional", {"ok": True})
return {"ok": True, "detail": "trivial sandbox succeeded", "sysctl_value": None}
sysctl_val = _read_userns_sysctl()
detail = f"exit {proc.returncode}"
if proc.stderr.strip():
detail = f"{detail}: {proc.stderr.strip()[:200]}"
json_handler.log_operation("sandbox_check_bwrap_functional", {"ok": False, "detail": detail})
return {"ok": False, "detail": detail, "sysctl_value": sysctl_val}
except subprocess.TimeoutExpired:
logger.warning("[sandbox_check] bwrap functional test timed out")
return {"ok": False, "detail": "timed out (10s)", "sysctl_value": None}
except OSError as exc:
logger.warning("[sandbox_check] bwrap functional test error: %s", exc)
return {"ok": False, "detail": str(exc), "sysctl_value": None}
def _read_userns_sysctl() -> str | None:
"""Read kernel.apparmor_restrict_unprivileged_userns sysctl if available."""
try:
proc = subprocess.run(
["sysctl", "-n", "kernel.apparmor_restrict_unprivileged_userns"],
capture_output=True,
text=True,
timeout=5,
check=False,
)
if proc.returncode == 0:
return proc.stdout.strip()
except (FileNotFoundError, subprocess.TimeoutExpired, OSError) as exc:
logger.info("[sandbox_check] sysctl read failed (expected on non-Ubuntu): %s", exc)
return None
def check_node_present() -> Dict[str, Any]:
"""Check if node binary is on PATH.
Returns:
found: bool
path: str | None — resolved path if found
"""
path = shutil.which("node")
json_handler.log_operation("sandbox_check_node", {"found": bool(path)})
return {"found": bool(path), "path": path}
def check_srt_resolvable() -> Dict[str, Any]:
"""Check if @anthropic-ai/sandbox-runtime is resolvable via node.
Mirrors _srt_resolve.mjs resolution: derive node prefix from process.execPath,
then check <prefix>/lib/node_modules/@anthropic-ai/sandbox-runtime/dist/index.js.
Returns:
found: bool
path: str | None — resolved entry path if found
install_hint: str — npm install command if missing
"""
node = shutil.which("node")
if not node:
return {
"found": False,
"path": None,
"install_hint": "Install node first, then: npm install -g @anthropic-ai/sandbox-runtime",
}
try:
script = (
"const p = require('path');"
"const prefix = p.dirname(p.dirname(process.execPath));"
"const entry = p.join(prefix, 'lib/node_modules/@anthropic-ai/sandbox-runtime/dist/index.js');"
"const fs = require('fs');"
"if (fs.existsSync(entry)) { process.stdout.write(entry); }"
"else { process.exit(1); }"
)
proc = subprocess.run(
[node, "-e", script],
capture_output=True,
text=True,
timeout=10,
check=False,
)
if proc.returncode == 0 and proc.stdout.strip():
path = proc.stdout.strip()
json_handler.log_operation("sandbox_check_srt", {"found": True, "path": path})
return {"found": True, "path": path, "install_hint": ""}
except (FileNotFoundError, subprocess.TimeoutExpired, OSError) as exc:
logger.warning("[sandbox_check] srt resolve error: %s", exc)
json_handler.log_operation("sandbox_check_srt", {"found": False})
return {
"found": False,
"path": None,
"install_hint": "npm install -g @anthropic-ai/sandbox-runtime",
}
def check_rg_present() -> Dict[str, Any]:
"""Check if ripgrep (rg) is available — matches hooks' fallback logic.
Returns:
found: bool
path: str | None — resolved path if found
"""
rg = shutil.which("rg")
if rg:
json_handler.log_operation("sandbox_check_rg", {"found": True, "path": rg})
return {"found": True, "path": rg}
fallback = Path.home() / ".local" / "bin" / "rg"
if fallback.is_file():
path = str(fallback)
json_handler.log_operation("sandbox_check_rg", {"found": True, "path": path})
return {"found": True, "path": path}
json_handler.log_operation("sandbox_check_rg", {"found": False})
return {"found": False, "path": None}
def check_broker_alive(repo_root: Path | None = None) -> Dict[str, Any]:
"""Check if the broker daemon socket is accepting connections.
Args:
repo_root: Project root containing .ai_central/. Auto-detected if None.
Returns:
alive: bool
detail: str — status message
"""
sock_path = _find_broker_socket(repo_root)
if sock_path is None:
json_handler.log_operation("sandbox_check_broker", {"alive": False, "reason": "socket_not_found"})
return {"alive": False, "detail": "broker socket not found"}
if not sock_path.exists():
json_handler.log_operation("sandbox_check_broker", {"alive": False, "reason": "socket_missing"})
return {"alive": False, "detail": f"socket missing: {sock_path}"}
try:
s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
s.settimeout(2)
s.connect(str(sock_path))
s.close()
json_handler.log_operation("sandbox_check_broker", {"alive": True})
return {"alive": True, "detail": "connected"}
except (OSError, socket.timeout) as exc:
logger.info("[sandbox_check] broker connect failed: %s", exc)
json_handler.log_operation("sandbox_check_broker", {"alive": False, "reason": str(exc)})
return {"alive": False, "detail": f"connect failed: {exc}"}
def _find_broker_socket(repo_root: Path | None) -> Path | None:
"""Locate the broker socket under $REPO/.ai_central/drone_broker.sock."""
if repo_root and (repo_root / ".ai_central" / "drone_broker.sock").parent.is_dir():
return repo_root / ".ai_central" / "drone_broker.sock"
aipass_home = os.environ.get("AIPASS_HOME", "")
if aipass_home:
candidate = Path(aipass_home) / ".ai_central" / "drone_broker.sock"
if candidate.parent.is_dir():
return candidate
cwd = Path.cwd()
for parent in [cwd, *cwd.parents]:
candidate = parent / ".ai_central" / "drone_broker.sock"
if candidate.parent.is_dir():
return candidate
if parent == parent.parent:
break
return None
def is_linux() -> bool:
"""Return True if running on Linux."""
return sys.platform.startswith("linux")
@@ -283,12 +283,6 @@ def detect_pollution(agents: List[AgentInfo]) -> List[PollutionHit]:
# =============================================================================
def find_registry(project_root: Path) -> Optional[Path]:
"""Find *_REGISTRY.json under project_root."""
candidates = list(project_root.glob("*_REGISTRY.json"))
return candidates[0] if candidates else None
def check_registry_consistency(
registry_path: Path,
agents: List[AgentInfo],
+164 -64
View File
@@ -6,11 +6,7 @@
# Modified: 2026-04-16
# =============================================
"""
aipass doctor — system health aggregation
Run: aipass doctor [--verbose] [--fix] [--fix --json]
"""
"""aipass doctor — system health aggregation."""
from __future__ import annotations
@@ -24,7 +20,19 @@ from typing import Dict, List, NamedTuple
from aipass.cli.apps.modules import console
from aipass.prax import logger
from aipass.aipass.shared.registry_discovery import find_registry as _discover_registry
from aipass.aipass.apps.handlers.json import json_handler
from aipass.aipass.apps.handlers.sandbox_check.sandbox_checker import (
check_broker_alive,
check_bwrap_functional,
check_bwrap_present,
check_node_present,
check_rg_present,
check_sandbox_flag,
check_srt_resolvable,
is_linux,
)
from aipass.aipass.apps.handlers.structure_scan.structure_scanner import (
check_placement,
check_pyproject,
@@ -32,7 +40,6 @@ from aipass.aipass.apps.handlers.structure_scan.structure_scanner import (
check_root_artifacts,
detect_pollution,
find_project_root,
find_registry,
scan_agents,
)
from aipass.aipass.apps.modules.doctor_fix import (
@@ -42,6 +49,7 @@ from aipass.aipass.apps.modules.doctor_fix import (
from aipass.aipass.apps.modules.doctor_wire import (
_auto_wire_provider,
prompt_auto_wire,
reconcile_stale_deny,
)
from aipass.aipass.apps.handlers.system_detect.system_detector import (
detect_cpu,
@@ -60,10 +68,6 @@ from aipass.aipass.apps.handlers.ui.progress import (
make_doctor_progress,
)
# =============================================================================
# TYPES
# =============================================================================
_BRANCH_ROOT = Path(__file__).resolve().parents[2]
@@ -76,30 +80,10 @@ class CheckResult(NamedTuple):
remediation: str
# =============================================================================
# IDENTITY HELPERS
# =============================================================================
def _find_registry() -> Path | None:
"""Walk up from CWD first (user's project), then branch root."""
cwd = Path.cwd()
for parent in (cwd, *cwd.parents):
candidates = list(parent.glob("*_REGISTRY.json"))
if candidates:
return candidates[0]
if parent == parent.parent:
break
for parent in (_BRANCH_ROOT, *_BRANCH_ROOT.parents):
candidate = parent / "AIPASS_REGISTRY.json"
if candidate.exists():
return candidate
return None
# =============================================================================
# CHECK GROUPS
# =============================================================================
"""Find *_REGISTRY.json via shared discovery (walk-up from CWD + branch root)."""
result = _discover_registry(package_root=str(_BRANCH_ROOT))
return result if result.exists() else None
def _check_system() -> List[CheckResult]:
@@ -159,11 +143,10 @@ def _check_identity() -> List[CheckResult]:
"""Run Identity group checks."""
results: List[CheckResult] = []
# Project root — derived from registry location
reg = _find_registry()
project_root = str(reg.parent) if reg else ""
if project_root:
results.append(CheckResult("AIPASS_HOME", GLYPH_PASS, project_root, ""))
# Project root + registry — single lookup
reg_path = _find_registry()
if reg_path:
results.append(CheckResult("AIPASS_HOME", GLYPH_PASS, str(reg_path.parent), ""))
else:
home = os.environ.get("AIPASS_HOME", "")
if home:
@@ -178,8 +161,6 @@ def _check_identity() -> List[CheckResult]:
)
)
# Registry present
reg_path = _find_registry()
if reg_path is None:
results.append(CheckResult("registry", GLYPH_FAIL, "not found", "Run 'aipass init' to create registry"))
return results
@@ -201,6 +182,20 @@ def _check_identity() -> List[CheckResult]:
else:
results.append(CheckResult("registry valid", GLYPH_FAIL, "missing 'branches' key", "Re-run 'aipass init'"))
# hooks.json presence (project-level hook config)
hooks_json = reg_path.parent / ".aipass" / "hooks.json"
if hooks_json.exists():
results.append(CheckResult("hooks.json", GLYPH_PASS, "present", ""))
else:
results.append(
CheckResult(
"hooks.json",
GLYPH_WARN,
"not found",
"Run 'aipass init update' to create .aipass/hooks.json",
)
)
# Passport readable
passport = _BRANCH_ROOT / ".trinity" / "passport.json"
if passport.exists():
@@ -404,11 +399,23 @@ def _check_services(verbose: bool = False) -> List[CheckResult]:
results.append(CheckResult("drone", GLYPH_PASS, detail, ""))
else:
results.append(
CheckResult("drone", GLYPH_FAIL, "exit non-zero", "Ensure aipass is installed: pip install -e .")
CheckResult(
"drone",
GLYPH_FAIL,
"exit non-zero",
"Ensure aipass is installed: clone the repo and run setup.sh",
)
)
except FileNotFoundError as exc:
logger.warning("[doctor] drone not found: %s", exc)
results.append(CheckResult("drone", GLYPH_FAIL, "not found", "Ensure aipass is installed: pip install -e ."))
results.append(
CheckResult(
"drone",
GLYPH_FAIL,
"not found",
"Ensure aipass is installed: clone the repo and run setup.sh",
)
)
except subprocess.TimeoutExpired as exc:
logger.warning("[doctor] drone systems timed out: %s", exc)
results.append(CheckResult("drone", GLYPH_WARN, "timed out", ""))
@@ -449,6 +456,10 @@ def _check_services(verbose: bool = False) -> List[CheckResult]:
manifest_checks = _check_provider_manifest()
results.extend(manifest_checks)
# stale rm deny rules — detect only (fix runs in run_doctor when --fix)
for tup in reconcile_stale_deny(fix=False):
results.append(CheckResult(*tup))
return results
@@ -478,9 +489,7 @@ def _check_community() -> List[CheckResult]:
return results
# =============================================================================
# STRUCTURE CHECK GROUP
# =============================================================================
# --- Structure check group ---
def _check_structure() -> List[CheckResult]:
@@ -525,8 +534,8 @@ def _check_structure() -> List[CheckResult]:
results.append(CheckResult("pollution", GLYPH_PASS, "no duplicates", ""))
# Registry consistency
reg_path = find_registry(project_root)
if reg_path:
reg_path = _discover_registry(start_path=project_root)
if reg_path and reg_path.exists():
reg_issues = check_registry_consistency(reg_path, agents)
if reg_issues:
for issue in reg_issues:
@@ -558,13 +567,105 @@ def _check_structure() -> List[CheckResult]:
return results
# =============================================================================
# MAIN DOCTOR RUN
# =============================================================================
# --- Sandbox check group ---
def _check_sandbox() -> List[CheckResult]:
"""Run Sandbox group checks — kernel sandbox prerequisites."""
results: List[CheckResult] = []
if not is_linux():
results.append(CheckResult("sandbox", GLYPH_PASS, "kernel sandbox: Linux-only, not checked", ""))
return results
flag = check_sandbox_flag()
flag_on = flag["enabled"]
flag_label = "ON" if flag_on else "OFF"
results.append(CheckResult("sandbox flag", GLYPH_PASS, f"AIPASS_SANDBOX_ENABLED={flag_label}", ""))
def _sev(ok: bool) -> str:
if ok:
return GLYPH_PASS
return GLYPH_FAIL if flag_on else GLYPH_WARN
def _suffix(ok: bool) -> str:
if ok or flag_on:
return ""
return " (inert — flag is off)"
bwrap = check_bwrap_present()
results.append(
CheckResult(
"bwrap",
_sev(bwrap["found"]),
bwrap["path"] or "not found" + _suffix(bwrap["found"]),
"" if bwrap["found"] else "sudo apt install bubblewrap",
)
)
if bwrap["found"]:
func = check_bwrap_functional()
detail = func["detail"]
if not func["ok"] and func["sysctl_value"] is not None:
detail = f"{detail} (apparmor_restrict_unprivileged_userns={func['sysctl_value']})"
results.append(
CheckResult(
"bwrap functional",
_sev(func["ok"]),
detail + _suffix(func["ok"]),
"",
)
)
node = check_node_present()
results.append(
CheckResult(
"node",
_sev(node["found"]),
node["path"] or "not found" + _suffix(node["found"]),
"" if node["found"] else "Install Node.js: https://nodejs.org/",
)
)
srt = check_srt_resolvable()
results.append(
CheckResult(
"srt (@anthropic-ai/sandbox-runtime)",
_sev(srt["found"]),
srt["path"] or "not found" + _suffix(srt["found"]),
"" if srt["found"] else srt["install_hint"],
)
)
rg = check_rg_present()
results.append(
CheckResult(
"rg (ripgrep)",
_sev(rg["found"]),
rg["path"] or "not found" + _suffix(rg["found"]),
"" if rg["found"] else "sudo apt install ripgrep (or static binary to ~/.local/bin/rg)",
)
)
project_root = find_project_root(Path.cwd())
broker = check_broker_alive(project_root)
results.append(
CheckResult(
"broker daemon",
_sev(broker["alive"]),
broker["detail"] + _suffix(broker["alive"]),
"",
)
)
return results
# --- Main doctor run ---
def run_doctor(verbose: bool = False, interactive: bool = False, fix: bool = False) -> int:
"""Run all five groups and print results. Returns error count."""
"""Run all six groups and print results. Returns error count."""
console.print()
console.print("[bold cyan]aipass doctor[/bold cyan]")
console.print()
@@ -575,6 +676,7 @@ def run_doctor(verbose: bool = False, interactive: bool = False, fix: bool = Fal
("Services", lambda: _check_services(verbose=verbose)),
("Community", _check_community),
("Structure", _check_structure),
("Sandbox", _check_sandbox),
]
groups: Dict[str, List[CheckResult]] = {}
with make_doctor_progress() as progress:
@@ -590,6 +692,12 @@ def run_doctor(verbose: bool = False, interactive: bool = False, fix: bool = Fal
r for r in groups.get("Services", []) if r.label not in ("hooks", "env vars", "permissions")
] + manifest_results
if fix:
stale_results = [CheckResult(*tup) for tup in reconcile_stale_deny(fix=True)]
if stale_results:
services = groups.get("Services", [])
groups["Services"] = [r for r in services if r.label != "rm deny migration"] + stale_results
pass_count = 0
warn_count = 0
error_count = 0
@@ -620,9 +728,7 @@ def run_doctor(verbose: bool = False, interactive: bool = False, fix: bool = Fal
return error_count
# =============================================================================
# OUTPUT FORMATTING
# =============================================================================
# --- Output formatting ---
def print_introspection() -> None:
@@ -631,7 +737,7 @@ def print_introspection() -> None:
console.print("[bold cyan]doctor Module[/bold cyan]")
console.print("System health aggregation — flutter-doctor-style output")
console.print()
console.print("[yellow]Groups:[/yellow] System, Identity, Services, Community, Structure")
console.print("[yellow]Groups:[/yellow] System, Identity, Services, Community, Structure, Sandbox")
console.print("[yellow]Next:[/yellow] [green]aipass doctor[/green] / [green]aipass doctor --fix[/green]")
console.print()
@@ -652,9 +758,7 @@ def print_help() -> None:
console.print()
# =============================================================================
# COMMAND HANDLER
# =============================================================================
# --- Command handler ---
def handle_command(command: str, args: list[str]) -> bool:
@@ -670,15 +774,11 @@ def handle_command(command: str, args: list[str]) -> bool:
if command != "doctor":
return False
if not args:
print_introspection()
return True
if args[0] in ("--help", "-h", "help"):
if args and args[0] in ("--help", "-h", "help"):
print_help()
return True
if args[0] == "--info":
if args and args[0] == "--info":
print_introspection()
return True
+16 -14
View File
@@ -25,6 +25,8 @@ from typing import List, NamedTuple
from aipass.cli.apps.modules import console
from aipass.prax import logger
from aipass.aipass.shared.registry_discovery import find_registry as _discover_registry
from aipass.aipass.apps.handlers.json import json_handler
from aipass.aipass.apps.handlers.structure_scan.structure_scanner import (
check_placement,
@@ -32,7 +34,6 @@ from aipass.aipass.apps.handlers.structure_scan.structure_scanner import (
check_registry_consistency,
check_root_artifacts,
detect_pollution,
find_registry,
scan_agents,
)
@@ -58,8 +59,8 @@ class RemediationItem(NamedTuple):
def detect_project_name(project_root: Path) -> str:
"""Derive project name from registry filename or directory name."""
reg = find_registry(project_root)
if reg:
reg = _discover_registry(start_path=project_root)
if reg and reg.exists():
name = reg.stem.replace("_REGISTRY", "").lower()
if name:
return name
@@ -83,7 +84,7 @@ def _build_pollution_items(agents: list, project: str) -> List[RemediationItem]:
f"Registry pollution: {len(hit.locations)} copies of "
f"{hit.agent_name} share registry_id {hit.registry_id}"
),
fix_command=f"drone @spawn repair @{project} --clean-pollution",
fix_command=f"drone @spawn repair @{project} --clean-pollution --apply",
)
)
return items
@@ -104,7 +105,7 @@ def _build_placement_items(agents: list, project_root: Path, project: str) -> Li
severity="warning",
category="placement",
description=f"Misplaced agent: {issue.agent_name} at {rel_path}",
fix_command=f"drone @spawn repair @{project} --relocate {rel_path} {suggested}",
fix_command=f"drone @spawn repair @{project} --relocate {rel_path} {suggested} --apply",
)
)
return items
@@ -113,8 +114,8 @@ def _build_placement_items(agents: list, project_root: Path, project: str) -> Li
def _build_registry_items(project_root: Path, agents: list, project: str) -> List[RemediationItem]:
"""Build remediation items for registry consistency issues."""
items: List[RemediationItem] = []
reg_path = find_registry(project_root)
if not reg_path:
reg_path = _discover_registry(start_path=project_root)
if not reg_path or not reg_path.exists():
return items
for issue in check_registry_consistency(reg_path, agents):
items.append(
@@ -122,7 +123,7 @@ def _build_registry_items(project_root: Path, agents: list, project: str) -> Lis
severity="warning",
category="registry",
description=f"Registry {issue.problem}: {issue.branch_name} at {issue.registered_path}",
fix_command=f"drone @spawn repair @{project} --dedup-registry",
fix_command=f"drone @spawn repair @{project} --dedup-registry --apply",
)
)
return items
@@ -145,7 +146,7 @@ def generate_remediation(project_root: Path) -> List[RemediationItem]:
severity="info",
category="pyproject",
description="Missing pyproject.toml",
fix_command=f"drone @spawn repair @{project} --add-pyproject",
fix_command=f"drone @spawn repair @{project} --add-pyproject --apply",
)
)
@@ -156,7 +157,7 @@ def generate_remediation(project_root: Path) -> List[RemediationItem]:
severity=severity,
category="root_artifact",
description=f"{hit.description}: {hit.name}/",
fix_command=f"drone @spawn repair @{project} --relocate-root {hit.name}",
fix_command=f"drone @spawn repair @{project} --relocate-root {hit.name} --apply",
)
)
@@ -184,7 +185,8 @@ def format_text_report(items: List[RemediationItem], project_name: str) -> str:
lines.append(f"[{item.severity.upper()}] {item.description}")
lines.append(f" Fix: {item.fix_command}")
lines.append("")
lines.append(f"Preview all fixes: drone @spawn repair @{project_name} --dry-run")
lines.append(f"Preview all fixes: drone @spawn repair @{project_name}")
lines.append(f"Apply all fixes: drone @spawn repair @{project_name} --apply")
return "\n".join(lines)
@@ -304,12 +306,12 @@ def handle_command(command: str, args: list[str]) -> bool:
return False
if not args:
print_introspection()
json_handler.log_operation("doctor_fix_info", {"command": command})
console.print("[dim]Helper module — use: aipass doctor --fix [--json][/dim]")
json_handler.log_operation("doctor_fix_usage", {"command": command})
return True
if args[0] in ("--help", "-h", "help"):
print_introspection()
console.print("[dim]Helper module — use: aipass doctor --fix [--json][/dim]")
json_handler.log_operation("doctor_fix_help", {"command": command})
return True
@@ -51,6 +51,11 @@ ENV_DESCRIPTIONS: Dict[str, str] = {
# =============================================================================
# STALE DENY RULE MIGRATION (implementation in handler; re-exported here)
# =============================================================================
from aipass.aipass.apps.handlers.provider_reconcile import reconcile_stale_deny # noqa: E402, F401
# =============================================================================
# AUTO-WIRE
@@ -283,13 +288,13 @@ def handle_command(command: str, args: list[str]) -> bool:
return False
if not args:
print_introspection()
json_handler.log_operation("doctor_wire_info", {"command": command})
console.print("[dim]Helper module — use: aipass doctor (auto-wire runs when needed)[/dim]")
json_handler.log_operation("doctor_wire_usage", {"command": command})
return True
if args[0] in ("--help", "-h", "help"):
print_introspection()
json_handler.log_operation("doctor_wire_info", {"command": command})
console.print("[dim]Helper module — use: aipass doctor (auto-wire runs when needed)[/dim]")
json_handler.log_operation("doctor_wire_help", {"command": command})
return True
if args[0] in ("--info", "info"):
+5 -1
View File
@@ -134,13 +134,17 @@ def handle_command(command: str, args: list[str]) -> bool:
return False
if not args:
print_introspection()
print_help()
return True
if args[0] in ("--help", "-h", "help"):
print_help()
return True
if args[0] == "--info":
print_introspection()
return True
if args[0] == "launch":
cli, cwd, flag_variant = _parse_launch_args(args[1:])
if cli not in CLI_CHOICES:
+26 -10
View File
@@ -27,7 +27,7 @@ from __future__ import annotations
from pathlib import Path
from aipass.aipass.apps.handlers.json import json_handler
from aipass.aipass.apps.handlers.readme_map import get_readme_path, list_branches
from aipass.aipass.apps.handlers.readme_map import get_readme_path, list_branches, read_readme_lines
from aipass.cli.apps.modules import console, error, header
from aipass.prax import logger
@@ -54,6 +54,20 @@ def print_introspection() -> None:
console.print(f"[bold cyan]Version:[/bold cyan] {_VERSION}")
def print_help() -> None:
"""Print usage help for the help command."""
console.print()
console.print("[bold cyan]aipass help[/bold cyan] — README-backed Q&A")
console.print()
console.print("[yellow]USAGE:[/yellow]")
console.print(" [green]aipass help <question>[/green] [dim]# Search branch READMEs[/dim]")
console.print()
console.print("[yellow]EXAMPLES:[/yellow]")
console.print(" [green]aipass help what does drone do[/green]")
console.print(" [green]aipass help how does ai_mail work[/green]")
console.print()
# =============================================================================
# KEYWORD EXTRACTION
# =============================================================================
@@ -152,17 +166,15 @@ def _match_branches(keywords: list[str]) -> list[str]:
# =============================================================================
def _search_readme(readme_path: Path, keywords: list[str]) -> list[tuple[int, str]]:
"""Live-read readme_path. Return (line_num, line_text) for matching lines.
def _search_readme(branch: str, keywords: list[str]) -> list[tuple[int, str]]:
"""Live-read branch README via handler. Return (line_num, line_text) for matching lines.
Reads every call — never cached. Scores lines by number of keyword hits.
Returns up to 5 best matches.
"""
try:
with open(readme_path, encoding="utf-8") as fh:
lines = fh.readlines()
except OSError as exc:
logger.warning("[help_chat] Could not read README %s: %s", readme_path, exc)
lines = read_readme_lines(branch)
if lines is None:
logger.warning("[help_chat] Could not read README for branch %s", branch)
return []
scored: list[tuple[int, int, str]] = [] # (score, line_num, line_text)
@@ -219,10 +231,14 @@ def handle_command(command: str, args: list[str]) -> bool:
json_handler.ensure_module_jsons(_MODULE_NAME)
if not args:
print_introspection()
print_help()
return True
if args[0] in ("--help", "-h", "help"):
print_help()
return True
if args[0] == "--info":
print_introspection()
return True
@@ -244,7 +260,7 @@ def handle_command(command: str, args: list[str]) -> bool:
readme_path = get_readme_path(branch)
if not readme_path:
continue
matches = _search_readme(readme_path, keywords)
matches = _search_readme(branch, keywords)
if matches:
found_any = True
answer = _format_answer(branch, readme_path, matches)
+143 -23
View File
@@ -16,7 +16,7 @@ Usage:
aipass init # show progress / introspection
aipass init run # interactive
aipass init run --non-interactive # CI/headless, all defaults
aipass init run --name Patrick --cli claude
aipass init run --name YourName --cli claude
aipass init run --dry-run # walk all 12 stages, no destructive ops
# - skips drone @spawn create (stage 8)
# - skips tmux/wt handoff (stage 11)
@@ -92,6 +92,11 @@ CLI_CHOICES = ["claude", "codex", "other"]
FLAG_CHOICES = ["default", "skip-permissions"]
STYLE_CHOICES = ["building-my-own-project", "improving-aipass", "just-exploring"]
TEMPLATE_EMPTY = "empty project"
TEMPLATE_AIPASS = "aipass_framework"
TEMPLATE_CHOICES = [TEMPLATE_EMPTY, TEMPLATE_AIPASS]
AIPASS_SPECIFIC_STAGES = {8, 9, 11, 12}
# --- LOCAL JSON HELPERS ---
def _read_local_json() -> dict:
@@ -377,6 +382,54 @@ def stage_5_style_questions(
return {"style": style}
def _install_claude_code() -> bool:
"""Run the canonical Claude Code installer, platform-aware. Returns True on success."""
if sys.platform == "win32":
cmd = ["powershell", "-Command", "irm https://claude.ai/install.ps1 | iex"]
else:
cmd = ["bash", "-c", "curl -fsSL https://claude.ai/install.sh | bash"]
try:
result = subprocess.run(cmd, timeout=300)
if result.returncode == 0 and shutil.which("claude"):
return True
except (subprocess.TimeoutExpired, FileNotFoundError, OSError) as exc:
logger.warning("[init_flow] Claude Code installer failed: %s", exc)
if shutil.which("npm"):
console.print("[dim]Native installer didn't work — trying npm fallback...[/dim]")
try:
result = subprocess.run(
["npm", "install", "-g", "@anthropic-ai/claude-code"],
timeout=300,
)
if result.returncode == 0 and shutil.which("claude"):
return True
except (subprocess.TimeoutExpired, FileNotFoundError, OSError) as exc:
logger.warning("[init_flow] npm fallback install failed: %s", exc)
return False
def _handle_missing_claude(non_interactive: bool) -> None:
"""Prompt to install Claude Code when missing, or warn in non-interactive mode."""
if non_interactive:
warning("[bold yellow]Claude Code ('claude') is not installed.[/bold yellow]")
console.print(" Stage 11 handoff requires it. Install manually before then.")
return
raw = _prompt("Claude Code ('claude') not found. Install now? [Y/n]", "Y")
if raw.lower() in ("y", "yes", ""):
console.print("[dim]Installing Claude Code...[/dim]")
if _install_claude_code():
console.print("[green]✓[/green] Claude Code installed successfully.")
else:
warning("[bold yellow]Installation failed.[/bold yellow]")
console.print(" Install manually: https://claude.ai/download")
else:
console.print("[dim]Skipped. Stage 11 handoff will need 'claude' on PATH.[/dim]")
def stage_6_tool_choice(
non_interactive: bool = False,
cli_override: str | None = None,
@@ -393,6 +446,9 @@ def stage_6_tool_choice(
else:
cli_choice = _choose("Which CLI tool do you use?", CLI_CHOICES, default="claude")
if cli_choice == "claude" and not shutil.which("claude"):
_handle_missing_claude(non_interactive)
if non_interactive:
flag_variant = "default"
else:
@@ -454,9 +510,9 @@ def stage_8_first_agent(non_interactive: bool = False, dry_run: bool = False) ->
console.print("Let's create your first AI agent (citizen).")
if non_interactive:
agent_name = "my-agent"
agent_name = "my_agent"
else:
agent_name = _prompt("Agent name (letters, hyphens, no spaces)", "my-agent") or "my-agent"
agent_name = _prompt("Agent name (letters, underscores, no spaces)", "my_agent") or "my_agent"
package_dir = _resolve_package_dir()
if package_dir:
@@ -546,12 +602,12 @@ def stage_10_smoke_test(non_interactive: bool = False, dry_run: bool = False) ->
if drone_bin:
console.print(f"[green]✓[/green] drone: {drone_bin}")
else:
warning("drone not on PATH — run: pip install -e .")
warning("drone not on PATH — clone the repo and run setup.sh")
if aipass_bin:
console.print(f"[green]✓[/green] aipass: {aipass_bin}")
else:
warning("aipass not on PATH — run: pip install -e .")
warning("aipass not on PATH — clone the repo and run setup.sh")
_save_stage(10, {"drone": drone_bin, "aipass": aipass_bin}, dry_run=dry_run)
return {"drone": drone_bin, "aipass": aipass_bin}
@@ -560,7 +616,7 @@ def stage_10_smoke_test(non_interactive: bool = False, dry_run: bool = False) ->
def stage_11_handoff(
cli_choice: str = "claude",
flag_variant: str = "default",
agent_path: str = "src/my-agent",
agent_path: str = "src/my_agent",
non_interactive: bool = False,
dry_run: bool = False,
accumulated: Dict[str, Any] | None = None,
@@ -645,13 +701,18 @@ def _write_init_report(agent_path: str, accumulated: Dict[str, Any], dry_run: bo
"cli_choice": accumulated.get("cli", "claude"),
"total_agents": 1,
"system": system_data,
"note": "You are the first agent created in this project. You are the orchestrator. After dispatching work to other agents, monitor them with: drone @devpulse watchdog agent @target",
"note": (
"You are the first agent created in this project. You are the orchestrator."
" After dispatching work to other agents, monitor them with:"
" drone @devpulse watchdog agent @target"
),
}
provider_gaps = accumulated.get("provider_gaps", {})
if provider_gaps:
report["provider_gaps"] = provider_gaps
report["provider_action"] = (
"Provider settings need configuring. Tell the user what is missing and point them to provider_manifest.json for details."
"Provider settings need configuring. Tell the user what is missing"
" and point them to provider_manifest.json for details."
)
report_path = dropbox / "init_report.json"
report_path.write_text(json.dumps(report, indent=2) + "\n", encoding="utf-8")
@@ -685,10 +746,24 @@ def _preflight_check() -> str | None:
"This directory is an agent branch (has .trinity/passport.json).\n"
"Agents are managed by 'drone @spawn', not 'aipass init'."
)
# Block if inside an existing AIPass project (registry above us)
# Block if inside an existing AIPass project (registry above us).
# Walking up to the filesystem root can hit ancestors that can't be
# enumerated or stat'd — e.g. locked Windows system entries at the drive
# root (pagefile.sys) raise OSError. Skip those rather than crash; on
# POSIX everything up to / is readable so behaviour is unchanged there.
for parent in [cwd] + list(cwd.parents):
for f in parent.iterdir():
if f.is_file() and f.name.endswith("_REGISTRY.json"):
try:
entries = list(parent.iterdir())
except OSError as exc:
logger.info("[init_flow] skipping unreadable ancestor %s: %s", parent, exc)
entries = []
for f in entries:
try:
is_registry = f.is_file() and f.name.endswith("_REGISTRY.json")
except OSError as exc:
logger.info("[init_flow] skipping unstattable entry %s: %s", f, exc)
continue
if is_registry:
return (
f"Already inside an AIPass project (found {f.name} at {parent}).\n"
"Use 'aipass init update' to upgrade an existing project."
@@ -705,6 +780,7 @@ def run_init(
style: str | None = None,
no_docker: bool = False,
dry_run: bool = False,
template: str | None = None,
) -> int:
"""Run the 12-stage init flow. Returns 0 on success."""
# Pre-flight: refuse to run inside existing projects or agent dirs
@@ -713,9 +789,20 @@ def run_init(
console.print(f"[red]✗[/red] {err}")
return 1
# Ensure scaffold exists (creates registry, .aipass, etc. if missing)
# Template selection — before scaffold
if template is None:
if non_interactive:
template = TEMPLATE_EMPTY
else:
template = _choose(
"Choose a project template:",
TEMPLATE_CHOICES,
default=TEMPLATE_EMPTY,
)
# Ensure scaffold exists — only for aipass_framework
cwd = Path.cwd()
if not list(cwd.glob("*_REGISTRY.json")):
if template == TEMPLATE_AIPASS and not list(cwd.glob("*_REGISTRY.json")):
from aipass.aipass.apps.handlers.init.bootstrap import init_project
if not dry_run:
@@ -734,7 +821,7 @@ def run_init(
if last_done > 0:
warning(f"Resuming from stage {last_done + 1}...")
accumulated: Dict[str, Any] = {}
accumulated: Dict[str, Any] = {"template": template}
stage_fns = [
(1, lambda: stage_1_welcome(dry_run=dry_run)),
@@ -752,7 +839,7 @@ def run_init(
lambda: stage_11_handoff(
accumulated.get("cli", "claude"),
accumulated.get("flag_variant", "default"),
accumulated.get("agent_path", "src/my-agent"),
accumulated.get("agent_path", "src/my_agent"),
non_interactive,
dry_run=dry_run,
accumulated=accumulated,
@@ -764,6 +851,9 @@ def run_init(
for stage_num, fn in stage_fns:
if stage_num <= last_done:
continue
if stage_num in AIPASS_SPECIFIC_STAGES and template != TEMPLATE_AIPASS:
logger.info("[init_flow] skipping stage %d (not aipass_framework)", stage_num)
continue
try:
result = fn() or {}
accumulated.update(result)
@@ -776,6 +866,11 @@ def run_init(
warning(f"Stage {stage_num} error: {exc} — continuing.")
_save_stage(stage_num, {"error": str(exc)}, dry_run=dry_run)
if template != TEMPLATE_AIPASS:
console.print()
console.print("[green]✓[/green] Project initialized.")
console.print("[dim]Run 'aipass init agent <name>' to add an agent.[/dim]")
return 0
@@ -806,10 +901,12 @@ def print_help() -> None:
console.print("[yellow]USAGE:[/yellow]")
console.print(" [green]aipass init run[/green] [dim]# interactive[/dim]")
console.print(" [green]aipass init run --non-interactive[/green] [dim]# CI/headless[/dim]")
console.print(" [green]aipass init run --name Patrick[/green] [dim]# pre-fill name[/dim]")
console.print(" [green]aipass init run --name YourName[/green] [dim]# pre-fill name[/dim]")
console.print(" [green]aipass init run --cli claude[/green] [dim]# pre-fill CLI[/dim]")
console.print(" [green]aipass init run --template <name>[/green] [dim]# select template[/dim]")
console.print(" [green]aipass init run --no-docker[/green] [dim]# skip docker offer[/dim]")
console.print(" [green]aipass init run --dry-run[/green] [dim]# walk all stages, no writes[/dim]")
console.print(" [green]aipass init --list[/green] [dim]# list available templates[/dim]")
console.print()
console.print("[yellow]STAGES:[/yellow] 12 stages, each saved — resume on ctrl-C")
console.print()
@@ -874,12 +971,14 @@ def _handle_init_update(args: list[str]) -> int:
console.print(f" ({len(current)} already up to date)")
# Heal registry: prune stale entries (e.g. cross-project ../paths)
try:
from aipass.spawn.apps.modules.sync_registry import sync_registry
sync_result = sync_registry(fix=True)
pruned = sync_result.get("stale", [])
if pruned:
console.print(f" [green]Registry healed:[/green] removed {len(pruned)} stale entry(ies)")
sync_proc = subprocess.run(
["drone", "@spawn", "sync-registry", "--fix"],
capture_output=True,
text=True,
timeout=30,
)
if sync_proc.returncode == 0:
console.print(" [green]Registry synced.[/green]")
except Exception as sync_exc:
logger.warning("[init_flow] registry sync during update skipped: %s", sync_exc)
@@ -917,13 +1016,17 @@ def handle_command(command: str, args: list[str]) -> bool:
return False
if not args:
print_introspection()
print_help()
return True
if args[0] in ("--help", "-h", "help"):
print_help()
return True
if args[0] == "--info":
print_introspection()
return True
if args[0] == "agent":
sys.exit(_handle_init_agent(args[1:]))
return True
@@ -932,6 +1035,15 @@ def handle_command(command: str, args: list[str]) -> bool:
sys.exit(_handle_init_update(args[1:]))
return True
if args[0] == "--list":
console.print()
console.print("[bold cyan]Available project templates:[/bold cyan]")
for t in TEMPLATE_CHOICES:
marker = " [dim](default)[/dim]" if t == TEMPLATE_EMPTY else ""
console.print(f" • {t}{marker}")
console.print()
return True
if args[0] == "run" or args[0].startswith("--"):
run_args = args[1:] if args[0] == "run" else args
non_interactive = "--non-interactive" in run_args
@@ -946,6 +1058,7 @@ def handle_command(command: str, args: list[str]) -> bool:
name = _flag_value("--name")
cli = _flag_value("--cli")
style = _flag_value("--style")
template = _flag_value("--template")
no_docker = "--no-docker" in run_args
dry_run = "--dry-run" in run_args
@@ -956,6 +1069,7 @@ def handle_command(command: str, args: list[str]) -> bool:
style=style,
no_docker=no_docker,
dry_run=dry_run,
template=template,
)
json_handler.log_operation(
"init_run",
@@ -964,6 +1078,12 @@ def handle_command(command: str, args: list[str]) -> bool:
sys.exit(result)
return True
# Template name as positional arg
if args[0] in TEMPLATE_CHOICES:
result = run_init(template=args[0])
sys.exit(result)
return True
# Positional args = target path and/or project name for scaffold
err = _preflight_check()
if err:
@@ -141,6 +141,10 @@ def handle_command(command: str, args: list[str]) -> bool:
print_help()
return True
if args[0] == "--info":
print_introspection()
return True
if args[0] == "set":
if len(args) < 3:
error("Usage: aipass profile set <field> <value>")
@@ -0,0 +1,3 @@
# Project-specific Python dependencies beyond the base AIPass install.
# Add packages here that the aipass branch requires but are not in the root pyproject.toml.
# Install with: pip install -r requirements.project.txt
+1
View File
@@ -0,0 +1 @@
# aipass.aipass.shared — shared leaf utilities (no branch dependencies, loads pre-drone)
+303
View File
@@ -0,0 +1,303 @@
# =================== AIPass ====================
# Name: json_handler.py
# Description: Shared JSON handler with injectable storage directory
# Version: 1.0.0
# Created: 2026-06-06
# Modified: 2026-06-10
# =============================================
"""Shared JSON handler — auto-creating, self-healing JSON system.
Dependency-free: uses only stdlib. Importable before drone/prax exist.
Each branch creates a JsonHandler instance with its own json_dir.
Contract: save_json raises ValueError on validation failure.
"""
import inspect
import json
import logging
import os
import tempfile
from datetime import datetime
from pathlib import Path
from typing import Any, Dict, Optional
logger = logging.getLogger(__name__)
_JSON_TYPES: tuple[str, ...] = ("config", "data", "log")
class JsonHandler:
"""JSON file handler with injectable storage directory.
Provides JSON I/O utilities, validation, and operation logging
for the three-JSON system (config, data, log).
Args:
json_dir: Directory for module JSON files (config/data/log).
"""
MAX_LOG_ENTRIES = 100
def __init__(self, json_dir: Path):
self._json_dir = Path(json_dir)
@staticmethod
def read_json(file_path: Path) -> Optional[dict]:
"""Read and parse a JSON file.
Args:
file_path: Path to the JSON file.
Returns:
Parsed dict, or None on failure.
"""
try:
return json.loads(Path(file_path).read_text(encoding="utf-8"))
except (json.JSONDecodeError, FileNotFoundError) as e:
logger.warning("Failed to read JSON from %s: %s", file_path, e)
return None
@staticmethod
def write_json(file_path: Path, data: Any, indent: int = 2) -> bool:
"""Write data to a JSON file atomically (temp file + os.replace).
Args:
file_path: Target path.
data: JSON-serializable data.
indent: JSON indentation level.
Returns:
True on success, False on OS error.
"""
file_path = Path(file_path)
try:
file_path.parent.mkdir(parents=True, exist_ok=True)
content = json.dumps(data, indent=indent) + "\n"
fd, tmp_path = tempfile.mkstemp(dir=file_path.parent, suffix=".tmp")
closed = False
try:
os.write(fd, content.encode("utf-8"))
os.fsync(fd)
os.close(fd)
closed = True
os.replace(tmp_path, file_path)
except BaseException:
if not closed:
os.close(fd)
if os.path.exists(tmp_path):
os.unlink(tmp_path)
raise
return True
except OSError as e:
logger.error("Failed to write JSON to %s: %s", file_path, e)
return False
@staticmethod
def validate_json_structure(data: Any, json_type: str) -> bool:
"""Validate that data matches the expected shape for json_type.
Args:
data: Parsed JSON data to validate.
json_type: One of "config", "data", "log".
Returns:
True when the structure is valid, False otherwise.
"""
if json_type == "config":
if not isinstance(data, dict):
return False
return all(key in data for key in ("module_name", "version", "config"))
if json_type == "data":
if not isinstance(data, dict):
return False
return all(key in data for key in ("created", "last_updated"))
if json_type == "log":
return isinstance(data, list)
return False
@staticmethod
def _create_default(json_type: str, module_name: str) -> Any:
"""Return default content for a given JSON type.
Args:
json_type: One of "config", "data", "log".
module_name: Logical module name.
Returns:
Default data structure.
Raises:
ValueError: For unknown json_type.
"""
today = datetime.now().date().isoformat()
if json_type == "config":
return {
"module_name": module_name,
"version": "1.0.0",
"config": {
"max_log_entries": JsonHandler.MAX_LOG_ENTRIES,
},
"created": today,
"last_updated": today,
}
if json_type == "data":
return {
"created": today,
"last_updated": today,
}
if json_type == "log":
return []
raise ValueError(f"Unknown json_type: {json_type!r}")
def get_json_path(self, module_name: str, json_type: str) -> Path:
"""Return the filesystem path for a module's JSON file.
Args:
module_name: Logical module name.
json_type: One of "config", "data", "log".
Returns:
Absolute Path to the JSON file.
"""
return self._json_dir / f"{module_name}_{json_type}.json"
def ensure_json_exists(self, module_name: str, json_type: str) -> bool:
"""Ensure a single JSON file exists; create with defaults if missing.
If the file exists but fails validation it is regenerated.
Args:
module_name: Logical module name.
json_type: One of "config", "data", "log".
Returns:
True after the file is confirmed present and valid.
"""
self._json_dir.mkdir(parents=True, exist_ok=True)
json_path = self.get_json_path(module_name, json_type)
if json_path.exists():
try:
if json_path.stat().st_size == 0:
logger.warning("ensure_json_exists: empty file at %s, regenerating", json_path)
else:
data = json.loads(json_path.read_text(encoding="utf-8"))
if self.validate_json_structure(data, json_type):
return True
except Exception as exc:
logger.warning("ensure_json_exists: failed to read %s, regenerating: %s", json_path, exc)
default = self._create_default(json_type, module_name)
self.write_json(json_path, default)
return True
def ensure_module_jsons(self, module_name: str) -> bool:
"""Ensure all three JSON files (config, data, log) exist for a module.
Args:
module_name: Logical module name.
Returns:
True when all files are present and valid.
"""
for json_type in _JSON_TYPES:
self.ensure_json_exists(module_name, json_type)
return True
def load_json(self, module_name: str, json_type: str) -> Any | None:
"""Load a module's JSON file, auto-creating it if missing.
Args:
module_name: Logical module name.
json_type: One of "config", "data", "log".
Returns:
Parsed JSON data, or None on failure.
"""
if not self.ensure_json_exists(module_name, json_type):
return None
json_path = self.get_json_path(module_name, json_type)
try:
return json.loads(json_path.read_text(encoding="utf-8"))
except (json.JSONDecodeError, OSError) as exc:
logger.warning("load_json: failed to read %s: %s", json_path, exc)
return self._create_default(json_type, module_name)
def save_json(self, module_name: str, json_type: str, data: Any) -> bool:
"""Write data to a module's JSON file after validation.
For "data" type files the last_updated field is refreshed automatically.
Args:
module_name: Logical module name.
json_type: One of "config", "data", "log".
data: The data structure to persist.
Returns:
True on success.
Raises:
ValueError: When data fails structure validation.
"""
if not self.validate_json_structure(data, json_type):
raise ValueError(f"Invalid structure for {json_type} JSON")
if json_type == "data" and isinstance(data, dict):
data["last_updated"] = datetime.now().date().isoformat()
json_path = self.get_json_path(module_name, json_type)
return self.write_json(json_path, data)
def log_operation(self, operation: str, data: Dict[str, Any] | None = None, module_name: str | None = None) -> bool:
"""Add entry to module operation log with automatic rotation.
Auto-detects calling module if module_name not provided.
Args:
operation: Operation name to log.
data: Optional data dict.
module_name: Optional module name (auto-detected if not provided).
Returns:
True if successful, False otherwise.
"""
if module_name is None:
module_name = _get_caller_module_name()
try:
self.ensure_module_jsons(module_name)
log = self.load_json(module_name, "log")
if log is None:
log = []
entry: Dict[str, Any] = {
"timestamp": datetime.now().isoformat(),
"operation": operation,
}
if data:
entry["data"] = data
log.append(entry)
if len(log) > self.MAX_LOG_ENTRIES:
log = log[-self.MAX_LOG_ENTRIES :]
return self.save_json(module_name, "log", log)
except Exception as exc:
logger.warning("log_operation: failed for %s/%s: %s", module_name, operation, exc)
return False
def _get_caller_module_name() -> str:
"""Auto-detect calling module name from call stack."""
stack = inspect.stack()
if len(stack) > 2:
caller_path = Path(stack[2].filename)
module_name = caller_path.stem
if module_name and not module_name.startswith("_"):
return module_name
return "unknown"
+115
View File
@@ -0,0 +1,115 @@
# =================== AIPass ====================
# Name: json_ops.py
# Description: Shared JSON operations — deep merge and backup
# Version: 1.0.0
# Created: 2026-06-06
# Modified: 2026-06-10
# =============================================
"""Shared JSON operations — deep merge and backup utilities.
Dependency-free: uses only stdlib. Importable before drone/prax exist.
"""
import logging
import shutil
from datetime import datetime
from pathlib import Path
from typing import Any
logger = logging.getLogger(__name__)
def deep_merge(template_data: Any, existing_data: Any) -> Any:
"""Recursively merge template structure with existing data.
Merge strategy:
- Both dicts: merge keys. Template defines structure, existing fills values.
- Template has key that existing doesn't: add from template (default).
- Existing has key that template doesn't: KEEP existing key (don't prune).
- Both lists: keep existing list (don't overwrite user data).
- Scalar values: keep existing value (don't overwrite).
- If existing is None/empty but template has value: use template value.
Args:
template_data: Template structure (provides fields and defaults).
existing_data: Existing data (provides values to preserve).
Returns:
Merged result combining template structure with existing values.
"""
if existing_data is None:
return template_data
if template_data is None:
return existing_data
if isinstance(template_data, dict) and isinstance(existing_data, dict):
result = {}
for key in template_data:
if key in existing_data:
result[key] = deep_merge(template_data[key], existing_data[key])
else:
result[key] = template_data[key]
for key in existing_data:
if key not in result:
result[key] = existing_data[key]
return result
if isinstance(template_data, list) and isinstance(existing_data, list):
if len(existing_data) > 0:
return existing_data
if len(template_data) > 0:
return template_data
return []
if existing_data is not None:
if isinstance(existing_data, str) and existing_data == "" and template_data:
return template_data
return existing_data
return template_data
def backup_json(file_path: Path, backup_dir: Path | None = None) -> Path:
"""Create a timestamped backup of a JSON file.
By default the backup is placed in a ``.recovery/`` directory alongside the
file. Callers can override with ``backup_dir`` to consolidate backups
elsewhere (e.g. ``.spawn/.recovery/``).
Args:
file_path: Path to the JSON file to back up.
backup_dir: Optional override for the backup destination directory.
Defaults to ``file_path.parent / ".recovery"``.
Returns:
Path to the backup file.
Raises:
FileNotFoundError: If the source file doesn't exist.
IOError: If the backup copy fails.
"""
file_path = Path(file_path)
if not file_path.exists():
raise FileNotFoundError(f"Cannot backup — file not found: {file_path}")
if backup_dir is None:
backup_dir = file_path.parent / ".recovery"
backup_dir = Path(backup_dir)
backup_dir.mkdir(parents=True, exist_ok=True)
timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
backup_name = f"{file_path.name}.{timestamp}.backup"
backup_path = backup_dir / backup_name
try:
shutil.copy2(file_path, backup_path)
return backup_path
except (IOError, OSError) as exc:
logger.error("Backup failed for %s: %s", file_path.name, exc)
raise
@@ -0,0 +1,67 @@
# =================== AIPass ====================
# Name: registry_discovery.py
# Description: Shared registry file discovery (walk-up search)
# Version: 1.0.0
# Created: 2026-06-06
# Modified: 2026-06-10
# =============================================
"""Registry discovery — find *_REGISTRY.json by walking up the directory tree.
Dependency-free: uses only stdlib. Importable before drone/prax exist.
"""
import os
from pathlib import Path
def _glob_registry(directory):
"""Find *_REGISTRY.json in a single directory.
Args:
directory: Path to search in.
Returns:
Path to the registry file, or None if not found.
"""
matches = sorted(directory.glob("*_REGISTRY.json"))
return matches[0] if matches else None
def find_registry(start_path=None, package_root=None):
"""Find *_REGISTRY.json — walks up from start_path/cwd, then package_root.
The first *_REGISTRY.json found while walking up IS the project boundary.
If multiple exist in the same directory, picks the first alphabetically.
Priority:
1. AIPASS_REGISTRY environment variable
2. Walk up from start_path/cwd — first dir containing *_REGISTRY.json
3. Walk up from package_root (caller's __file__ location) — fallback
4. Last resort: cwd / AIPASS_REGISTRY.json (backwards compat)
Args:
start_path: Directory to start searching from (default: cwd).
package_root: Optional fallback directory for package-relative search.
Returns:
Path to *_REGISTRY.json.
"""
env_path = os.environ.get("AIPASS_REGISTRY")
if env_path:
return Path(env_path)
current = Path(start_path).resolve() if start_path else Path.cwd()
for parent in [current] + list(current.parents):
found = _glob_registry(parent)
if found:
return found
if package_root:
pkg_dir = Path(package_root).resolve()
for parent in [pkg_dir] + list(pkg_dir.parents):
found = _glob_registry(parent)
if found:
return found
return Path.cwd() / "AIPASS_REGISTRY.json"
+341 -87
View File
@@ -22,6 +22,7 @@ import pytest # pyright: ignore[reportMissingImports]
from aipass.aipass.apps.handlers.init import scaffold_content as sc
from aipass.aipass.apps.handlers.init.bootstrap import (
_merge_hooks_json,
_sanitize_name,
init_project,
update_project,
@@ -97,18 +98,21 @@ def test_init_project_creates_all_expected_files(tmp_path):
expected_files = [
target / "DEMO_REGISTRY.json",
target / ".aipass" / "aipass_global_prompt.md",
target / "CLAUDE.md",
target / "AGENTS.md",
target / "README.md",
target / "STATUS.local.md",
target / ".gitignore",
target / ".claude" / "settings.json",
target / ".claude" / "commands" / "prep.md",
target / "src" / "demo" / "__init__.py",
]
# Tier files are env-dependent (need AIPASS_HOME)
if result["aipass_home"]:
expected_files.append(target / ".aipass" / "tier0_kernel.md")
expected_files.append(target / ".aipass" / "tier1_navmap.md")
for f in expected_files:
assert f.exists(), f"Expected file not created: {f}"
assert not (target / ".aipass" / "aipass_global_prompt.md").exists(), "Retired global prompt should NOT be seeded"
# src/<package>/ is a directory with __init__.py
assert (target / "src" / "demo").is_dir(), "Expected src/demo/ package directory"
@@ -126,7 +130,7 @@ def test_init_project_creates_all_expected_files(tmp_path):
created_basenames = [Path(f).name for f in result["created_files"]]
for f in expected_files:
assert f.name in created_basenames or f.exists(), f"Expected {f.name} in created_files"
assert len(result["created_files"]) >= 11
assert len(result["created_files"]) >= 10
def test_init_project_return_dict_structure(tmp_path):
@@ -234,15 +238,15 @@ def test_init_project_raises_on_empty_name(tmp_path):
def test_init_project_agents_md_content(tmp_path):
"""AGENTS.md is copied from AIPass source of truth."""
"""AGENTS.md contains project-specific content from generator."""
target = tmp_path / "proj"
target.mkdir()
init_project(target, project_name="alpha")
content = (target / "AGENTS.md").read_text(encoding="utf-8")
assert "# AIPass" in content
assert "Multi-agent framework" in content
assert "# ALPHA" in content
assert "AIPass" in content
def test_init_project_gitignore_content(tmp_path):
@@ -288,19 +292,6 @@ def test_init_project_settings_no_hooks(tmp_path):
assert "permissions" in data
def test_init_project_global_prompt_content(tmp_path):
"""Global prompt contains project name and AIPass terminology."""
target = tmp_path / "proj"
target.mkdir()
init_project(target, project_name="alpha")
content = (target / ".aipass" / "aipass_global_prompt.md").read_text(encoding="utf-8")
assert "# ALPHA" in content
assert "ALPHA_REGISTRY.json" in content
assert "# Commands" in content
def test_init_project_readme_md_content(tmp_path):
"""README.md contains getting started guide with project name."""
target = tmp_path / "proj"
@@ -324,7 +315,7 @@ def test_init_project_auto_creates_target_dir(tmp_path):
assert target.is_dir()
assert result["project_name"] == "NESTED"
assert len(result["created_files"]) >= 11
assert len(result["created_files"]) >= 10
def test_init_project_defaults_name_from_directory(tmp_path):
@@ -359,11 +350,9 @@ def test_init_project_skips_existing_optional_files(tmp_path):
# Pre-create optional files
aipass_dir = target / ".aipass"
aipass_dir.mkdir()
(aipass_dir / "aipass_global_prompt.md").write_text("# Custom global\n", encoding="utf-8")
(target / "CLAUDE.md").write_text("# Custom CLAUDE\n", encoding="utf-8")
(target / "AGENTS.md").write_text("# Custom AGENTS\n", encoding="utf-8")
(target / "README.md").write_text("# Custom README\n", encoding="utf-8")
(target / "STATUS.local.md").write_text("# Custom status\n", encoding="utf-8")
(target / ".gitignore").write_text("# Custom\n", encoding="utf-8")
claude_dir = target / ".claude"
@@ -412,16 +401,15 @@ def test_init_project_returns_dict(tmp_path):
def test_init_project_agents_md_no_trinity(tmp_path):
"""AGENTS.md is copied from AIPass source (may reference .trinity/ as part of agent docs)."""
"""AGENTS.md references .trinity/ as part of startup protocol docs."""
target = tmp_path / "proj"
target.mkdir()
init_project(target, project_name="keep")
content = (target / "AGENTS.md").read_text(encoding="utf-8")
# Source file legitimately references .trinity/ as part of startup protocol docs
assert "# AIPass" in content
assert "Multi-agent framework" in content
assert "# KEEP" in content
assert ".trinity/" in content
# ---------------------------------------------------------------------------
@@ -470,7 +458,7 @@ def test_update_project_already_current_after_init(tmp_path):
result = update_project(target)
assert len(result["updated_files"]) == 0
assert len(result["already_current"]) >= 4
assert len(result["already_current"]) >= 5
def test_update_project_idempotent(tmp_path):
@@ -517,7 +505,6 @@ def test_update_project_never_touches_user_owned_files(tmp_path):
# Modify user-owned files
(target / "README.md").write_text("# My custom README\n", encoding="utf-8")
(target / "STATUS.local.md").write_text("# Custom status\n", encoding="utf-8")
(target / ".gitignore").write_text("# custom\n", encoding="utf-8")
result = update_project(target)
@@ -525,12 +512,10 @@ def test_update_project_never_touches_user_owned_files(tmp_path):
skipped = result["skipped_files"]
assert any("REGISTRY" in s for s in skipped)
assert any("README.md" in s for s in skipped)
assert any("STATUS.local.md" in s for s in skipped)
assert any(".gitignore" in s for s in skipped)
# User customisations are preserved
assert (target / "README.md").read_text(encoding="utf-8") == "# My custom README\n"
assert (target / "STATUS.local.md").read_text(encoding="utf-8") == "# Custom status\n"
def test_update_project_creates_missing_managed_dirs(tmp_path):
@@ -547,23 +532,25 @@ def test_update_project_creates_missing_managed_dirs(tmp_path):
result = update_project(target)
assert (target / ".aipass" / "aipass_global_prompt.md").exists()
assert (target / ".claude" / "settings.json").exists()
# Managed files in deleted dirs re-written (global_prompt, settings, prep)
assert len(result["updated_files"]) == 3
# Managed files in deleted dirs re-written (tier0_kernel, tier1_navmap, hooks.json, settings, prep)
if result["aipass_home"]:
assert len(result["updated_files"]) == 5
else:
assert len(result["updated_files"]) == 2
assert len(result["already_current"]) >= 2
def test_update_project_skipped_files_count(tmp_path):
"""update_project skips 4 user-owned files + existing mailbox = 5 total."""
"""update_project skips 3 user-owned files."""
target = tmp_path / "proj"
target.mkdir()
init_project(target, project_name="count")
result = update_project(target)
# 4 user-owned (registry, README, STATUS, .gitignore)
assert len(result["skipped_files"]) == 4
# 3 user-owned (registry, README, .gitignore)
assert len(result["skipped_files"]) == 3
# ---------------------------------------------------------------------------
@@ -629,7 +616,7 @@ def test_update_project_adds_aipass_home_if_missing(tmp_path):
# ---------------------------------------------------------------------------
# DPLAN-0139: Hook shipping + /memo tests
# DPLAN-0190: hooks.json + /memo tests
# ---------------------------------------------------------------------------
@@ -644,8 +631,8 @@ def test_init_project_no_memo_md(tmp_path):
assert not memo_path.exists()
def test_init_project_ships_hooks(tmp_path):
"""init_project copies enforcement + injector hooks to target .claude/hooks/."""
def test_init_project_creates_hooks_json(tmp_path):
"""init_project creates .aipass/hooks.json from project_hooks.json template."""
target = tmp_path / "proj"
target.mkdir()
@@ -654,16 +641,46 @@ def test_init_project_ships_hooks(tmp_path):
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
hooks_dir = target / ".claude" / "hooks"
# Post DPLAN-0184: hooks are native handlers in src/aipass/hooks/,
# no longer shipped as script copies. Directory may or may not exist.
if hooks_dir.exists():
shipped = [f.name for f in hooks_dir.iterdir()]
assert len(shipped) == 0, f"No hook scripts should be shipped post-migration: {shipped}"
hooks_json = target / ".aipass" / "hooks.json"
assert hooks_json.exists(), ".aipass/hooks.json should be created"
data = json.loads(hooks_json.read_text(encoding="utf-8"))
assert data.get("hooks_enabled") is True
assert "UserPromptSubmit" in data
def test_init_project_hooks_not_shipped_without_aipass_home(tmp_path, monkeypatch):
"""When AIPASS_HOME is not detectable, hooks are not shipped."""
def test_init_project_hooks_json_matches_template(tmp_path):
"""hooks.json content matches the project_hooks.json template."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="tmpl")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
hooks_json = target / ".aipass" / "hooks.json"
template = Path(result["aipass_home"]) / ".aipass" / "project_hooks.json"
if not template.exists():
pytest.skip("project_hooks.json template not found")
assert hooks_json.read_bytes() == template.read_bytes()
def test_init_project_hooks_json_in_created_files(tmp_path):
"""hooks.json path appears in created_files list."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="created")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
assert any("hooks.json" in f for f in result["created_files"])
def test_init_project_no_hooks_json_without_aipass_home(tmp_path, monkeypatch):
"""When AIPASS_HOME is not detectable, hooks.json is not created."""
target = tmp_path / "proj"
target.mkdir()
@@ -674,55 +691,20 @@ def test_init_project_hooks_not_shipped_without_aipass_home(tmp_path, monkeypatc
init_project(target, project_name="nohooks")
hooks_dir = target / ".claude" / "hooks"
assert not hooks_dir.exists() or len(list(hooks_dir.iterdir())) == 0
assert not (target / ".aipass" / "hooks.json").exists()
def test_init_project_no_audio_hooks_shipped(tmp_path):
"""Audio hooks (notification_sound, tool_use_sound, stop_sound) are never shipped."""
def test_init_project_no_hook_scripts_shipped(tmp_path):
"""No hook scripts are shipped to .claude/hooks/ (engine runs from $AIPASS_HOME)."""
target = tmp_path / "proj"
target.mkdir()
init_project(target, project_name="noaudio")
init_project(target, project_name="noscripts")
hooks_dir = target / ".claude" / "hooks"
if hooks_dir.exists():
shipped = [f.name for f in hooks_dir.iterdir()]
assert "notification_sound.py" not in shipped
assert "tool_use_sound.py" not in shipped
assert "stop_sound.py" not in shipped
def test_update_project_resyncs_hooks(tmp_path):
"""update_project re-copies hooks when source differs from target."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="resync")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
# Post DPLAN-0184: hooks are native handlers, not shipped as copies.
# update_project no longer resyncs hook scripts.
result = update_project(target)
hooks_marker = str(Path(".claude") / "hooks")
hook_paths = [f for f in result["updated_files"] if hooks_marker in f]
assert len(hook_paths) == 0, "No hook scripts should be shipped post-migration"
def test_init_project_hooks_idempotent_on_rerun(tmp_path):
"""Re-running init does not create hook script copies."""
target = tmp_path / "proj"
target.mkdir()
result1 = init_project(target, project_name="idem")
if result1["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
hooks_marker = str(Path(".claude") / "hooks")
hook_paths = [f for f in result1["created_files"] if hooks_marker in f]
assert len(hook_paths) == 0, "No hook scripts should be shipped post-migration"
assert len(shipped) == 0, f"No hook scripts should be shipped: {shipped}"
def test_init_project_settings_has_no_hook_events(tmp_path):
@@ -736,6 +718,278 @@ def test_init_project_settings_has_no_hook_events(tmp_path):
assert "hooks" not in settings
def test_update_project_creates_hooks_json_if_missing(tmp_path):
"""update_project creates hooks.json from template when missing."""
target = tmp_path / "proj"
target.mkdir()
registry_data = {
"metadata": {
"id": "test-id",
"name": "MISS",
"version": "1.0.0",
"created": "2026-01-01",
"last_updated": "2026-01-01",
"total_branches": 0,
},
"branches": [],
}
(target / "MISS_REGISTRY.json").write_text(json.dumps(registry_data), encoding="utf-8")
hooks_json = target / ".aipass" / "hooks.json"
assert not hooks_json.exists()
result = update_project(target)
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
assert hooks_json.exists()
assert any("hooks.json" in f for f in result["updated_files"])
data = json.loads(hooks_json.read_text(encoding="utf-8"))
assert data.get("hooks_enabled") is True
def test_update_project_union_merge_preserves_user_enabled(tmp_path):
"""update preserves user's enabled=false for existing hooks."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="merge")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
hooks_json = target / ".aipass" / "hooks.json"
data = json.loads(hooks_json.read_text(encoding="utf-8"))
data["PreToolUse"]["git_gate"]["enabled"] = False
hooks_json.write_text(json.dumps(data, indent=2) + "\n", encoding="utf-8")
update_project(target)
updated = json.loads(hooks_json.read_text(encoding="utf-8"))
assert updated["PreToolUse"]["git_gate"]["enabled"] is False
def test_update_project_union_merge_adds_new_hooks(tmp_path):
"""update adds hooks from template that user doesn't have."""
existing = {
"hooks_enabled": True,
"UserPromptSubmit": {
"identity_injector": {"enabled": True, "handler": "old.handler", "matcher": ""},
},
}
template = {
"hooks_enabled": True,
"UserPromptSubmit": {
"identity_injector": {"enabled": True, "handler": "new.handler", "matcher": ""},
"brand_new_hook": {"enabled": True, "handler": "brand.new", "matcher": ""},
},
"Stop": {
"stop_sound": {"enabled": True, "handler": "stop.handler", "matcher": ""},
},
}
merged = _merge_hooks_json(existing, template)
assert "brand_new_hook" in merged["UserPromptSubmit"]
assert "Stop" in merged
assert merged["Stop"]["stop_sound"]["enabled"] is True
def test_update_project_union_merge_preserves_user_hooks():
"""User's custom hooks not in template are kept."""
existing = {
"hooks_enabled": True,
"UserPromptSubmit": {
"my_custom_hook": {"enabled": True, "handler": "custom.handler", "matcher": ""},
},
}
template = {
"hooks_enabled": True,
"UserPromptSubmit": {
"identity_injector": {"enabled": True, "handler": "std.handler", "matcher": ""},
},
}
merged = _merge_hooks_json(existing, template)
assert "my_custom_hook" in merged["UserPromptSubmit"]
assert "identity_injector" in merged["UserPromptSubmit"]
def test_merge_hooks_json_preserves_hooks_enabled_false():
"""User's hooks_enabled=false is preserved over template's true."""
existing = {"hooks_enabled": False}
template = {"hooks_enabled": True, "Stop": {"s": {"enabled": True, "handler": "h", "matcher": ""}}}
merged = _merge_hooks_json(existing, template)
assert merged["hooks_enabled"] is False
def test_update_project_hooks_json_already_current(tmp_path):
"""update reports hooks.json as already_current when unchanged."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="curr")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
result = update_project(target)
assert not any("hooks.json" in f for f in result["updated_files"])
assert any("hooks.json" in f for f in result["already_current"])
# ---------------------------------------------------------------------------
# Tiered prompt injection tests (FPLAN-0284)
# ---------------------------------------------------------------------------
def test_init_project_creates_tier_files(tmp_path):
"""init_project seeds tier0_kernel.md and tier1_navmap.md when AIPASS_HOME available."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="tiers")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
assert (target / ".aipass" / "tier0_kernel.md").exists()
assert (target / ".aipass" / "tier1_navmap.md").exists()
def test_init_project_tier_files_match_canonical(tmp_path):
"""Tier files in new project match the canonical source exactly."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="canon")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
for tier_file in ("tier0_kernel.md", "tier1_navmap.md"):
canonical = Path(result["aipass_home"]) / ".aipass" / tier_file
if not canonical.exists():
pytest.skip(f"{tier_file} not found in canonical .aipass/")
assert (target / ".aipass" / tier_file).read_bytes() == canonical.read_bytes()
def test_init_project_tier_files_in_created_list(tmp_path):
"""Tier files appear in created_files list."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="listed")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
assert any("tier0_kernel.md" in f for f in result["created_files"])
assert any("tier1_navmap.md" in f for f in result["created_files"])
def test_init_project_no_tier_files_without_aipass_home(tmp_path, monkeypatch):
"""Without AIPASS_HOME, tier files are not created."""
target = tmp_path / "proj"
target.mkdir()
monkeypatch.setattr(
"aipass.aipass.apps.handlers.init.bootstrap._detect_aipass_home",
lambda: None,
)
init_project(target, project_name="notiers")
assert not (target / ".aipass" / "tier0_kernel.md").exists()
assert not (target / ".aipass" / "tier1_navmap.md").exists()
def test_init_project_hooks_json_has_tiers_enabled(tmp_path):
"""hooks.json from template has tier0_kernel and navmap enabled, no global_prompt."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="hookstier")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
hooks_json = target / ".aipass" / "hooks.json"
data = json.loads(hooks_json.read_text(encoding="utf-8"))
ups = data["UserPromptSubmit"]
assert ups["tier0_kernel"]["enabled"] is True
assert ups["navmap"]["enabled"] is True
assert "global_prompt" not in ups
def test_update_project_adds_tier_files_to_existing(tmp_path):
"""update_project adds tier files to a project that lacks them."""
target = tmp_path / "proj"
target.mkdir()
registry_data = {
"metadata": {
"id": "test-id",
"name": "OLD",
"version": "1.0.0",
"created": "2026-01-01",
"last_updated": "2026-01-01",
"total_branches": 0,
},
"branches": [],
}
(target / "OLD_REGISTRY.json").write_text(json.dumps(registry_data), encoding="utf-8")
(target / ".aipass").mkdir()
result = update_project(target)
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
assert (target / ".aipass" / "tier0_kernel.md").exists()
assert (target / ".aipass" / "tier1_navmap.md").exists()
assert any("tier0_kernel.md" in f for f in result["updated_files"])
assert any("tier1_navmap.md" in f for f in result["updated_files"])
def test_update_project_tier_files_already_current(tmp_path):
"""update reports tier files as already_current when unchanged."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="tiercurr")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
result = update_project(target)
assert any("tier0_kernel.md" in f for f in result["already_current"])
assert any("tier1_navmap.md" in f for f in result["already_current"])
def test_update_project_refreshes_stale_tier_files(tmp_path):
"""update overwrites tier files when they differ from canonical source."""
target = tmp_path / "proj"
target.mkdir()
result = init_project(target, project_name="stale")
if result["aipass_home"] is None:
pytest.skip("AIPASS_HOME not detectable in this environment")
(target / ".aipass" / "tier0_kernel.md").write_text("# stale\n", encoding="utf-8")
result = update_project(target)
assert any("tier0_kernel.md" in f for f in result["updated_files"])
content = (target / ".aipass" / "tier0_kernel.md").read_text(encoding="utf-8")
assert "AIPass" in content
# ---------------------------------------------------------------------------
# scaffold_content — global_prompt_md tests
# ---------------------------------------------------------------------------
+174 -5
View File
@@ -441,10 +441,8 @@ class TestProviderManifest:
manifest = tmp_path / ".claude" / "provider_manifest.json"
manifest.parent.mkdir(parents=True)
cmd_a = "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py Stop"
cmd_b = (
"$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py Notification"
)
cmd_a = "$AIPASS_HOME/bin/hook-bridge Stop"
cmd_b = "$AIPASS_HOME/bin/hook-bridge Notification"
manifest.write_text(
json.dumps(
{
@@ -487,7 +485,7 @@ class TestProviderManifest:
manifest = tmp_path / ".claude" / "provider_manifest.json"
manifest.parent.mkdir(parents=True)
cmd = "$AIPASS_HOME/.venv/bin/python3 $AIPASS_HOME/src/aipass/hooks/apps/handlers/bridges/claude.py Stop"
cmd = "$AIPASS_HOME/bin/hook-bridge Stop"
manifest.write_text(
json.dumps(
{
@@ -573,3 +571,174 @@ class TestProviderManifest:
result = _find_manifest()
assert result is not None
assert result == manifest
# =============================================================================
# TestHooksJsonCheck
# =============================================================================
class TestHooksJsonCheck:
"""Tests for hooks.json presence check in _check_identity (DPLAN-0190)."""
def test_hooks_json_present_returns_pass(self, tmp_path) -> None:
"""When .aipass/hooks.json exists, check returns PASS."""
from aipass.aipass.apps.modules.doctor import _check_identity
registry = tmp_path / "TEST_REGISTRY.json"
registry.write_text(json.dumps({"metadata": {"id": "t"}, "branches": []}), encoding="utf-8")
hooks_dir = tmp_path / ".aipass"
hooks_dir.mkdir()
(hooks_dir / "hooks.json").write_text('{"hooks_enabled": true}', encoding="utf-8")
with patch("aipass.aipass.apps.modules.doctor._find_registry", return_value=registry):
results = _check_identity()
hooks_results = [r for r in results if r.label == "hooks.json"]
assert len(hooks_results) == 1
assert hooks_results[0].glyph == GLYPH_PASS
def test_hooks_json_missing_returns_warn(self, tmp_path) -> None:
"""When .aipass/hooks.json is absent, check returns WARN."""
from aipass.aipass.apps.modules.doctor import _check_identity
registry = tmp_path / "TEST_REGISTRY.json"
registry.write_text(json.dumps({"metadata": {"id": "t"}, "branches": []}), encoding="utf-8")
with patch("aipass.aipass.apps.modules.doctor._find_registry", return_value=registry):
results = _check_identity()
hooks_results = [r for r in results if r.label == "hooks.json"]
assert len(hooks_results) == 1
assert hooks_results[0].glyph == GLYPH_WARN
assert "init update" in hooks_results[0].remediation
# =============================================================================
# TestReconcileStaleDeny
# =============================================================================
class TestReconcileStaleDeny:
"""Tests for stale rm deny rule migration (DPLAN-0192 Phase 2)."""
def test_no_settings_file_returns_empty(self, tmp_path) -> None:
"""Missing settings.json returns no results."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=False)
assert results == []
def test_no_stale_rules_returns_pass(self, tmp_path) -> None:
"""Settings with no stale rm rules returns PASS."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(
json.dumps({"permissions": {"deny": ["Bash(git push --force*)", "Bash(git reset --hard*)"]}}),
encoding="utf-8",
)
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=False)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
assert "no stale" in results[0][2]
def test_stale_rules_detected_without_fix(self, tmp_path) -> None:
"""Stale rm rules present returns WARN when fix=False."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(
json.dumps({"permissions": {"deny": ["Bash(rm -rf*)", "Bash(git push --force*)", "Bash(rm -r *)"]}}),
encoding="utf-8",
)
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=False)
assert len(results) == 1
assert results[0][1] == GLYPH_WARN
assert "rm -rf" in results[0][2]
assert "rm -r " in results[0][2]
def test_fix_removes_stale_rules(self, tmp_path) -> None:
"""fix=True removes stale rules and preserves others."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
original = {
"permissions": {"deny": ["Bash(rm -rf*)", "Bash(git push --force*)", "Bash(rm -r *)"]},
"env": {"AIPASS_HOME": "/test"},
}
settings.write_text(json.dumps(original), encoding="utf-8")
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=True)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
assert "removed" in results[0][2]
updated = json.loads(settings.read_text(encoding="utf-8"))
assert "Bash(rm -rf*)" not in updated["permissions"]["deny"]
assert "Bash(rm -r *)" not in updated["permissions"]["deny"]
assert "Bash(git push --force*)" in updated["permissions"]["deny"]
assert updated["env"]["AIPASS_HOME"] == "/test"
def test_fix_single_stale_rule(self, tmp_path) -> None:
"""fix=True works when only one of two stale rules is present."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(
json.dumps({"permissions": {"deny": ["Bash(rm -rf*)", "Bash(git reset --hard*)"]}}),
encoding="utf-8",
)
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=True)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
updated = json.loads(settings.read_text(encoding="utf-8"))
assert updated["permissions"]["deny"] == ["Bash(git reset --hard*)"]
def test_fix_idempotent(self, tmp_path) -> None:
"""Running fix twice is safe — second run returns PASS with no stale rules."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(
json.dumps({"permissions": {"deny": ["Bash(rm -rf*)", "Bash(rm -r *)"]}}),
encoding="utf-8",
)
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
reconcile_stale_deny(fix=True)
results = reconcile_stale_deny(fix=True)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
assert "no stale" in results[0][2]
def test_empty_deny_list_returns_pass(self, tmp_path) -> None:
"""Empty deny list returns PASS."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(json.dumps({"permissions": {"deny": []}}), encoding="utf-8")
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=False)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
def test_no_permissions_key_returns_pass(self, tmp_path) -> None:
"""Settings without permissions key returns PASS."""
from aipass.aipass.apps.modules.doctor_wire import reconcile_stale_deny
settings = tmp_path / ".claude" / "settings.json"
settings.parent.mkdir(parents=True)
settings.write_text(json.dumps({"env": {"FOO": "bar"}}), encoding="utf-8")
with patch("aipass.aipass.apps.modules.doctor_wire.Path.home", return_value=tmp_path):
results = reconcile_stale_deny(fix=False)
assert len(results) == 1
assert results[0][1] == GLYPH_PASS
+18 -8
View File
@@ -65,8 +65,14 @@ class TestDetectProjectName:
def test_fallback_to_dirname(self, tmp_path: Path) -> None:
"""Falls back to directory name when no registry."""
result = detect_project_name(tmp_path)
assert result == tmp_path.name.lower()
no_reg = tmp_path / "empty_project"
no_reg.mkdir()
with patch(
"aipass.aipass.apps.modules.doctor_fix._discover_registry",
return_value=no_reg / "MISSING_REGISTRY.json",
):
result = detect_project_name(no_reg)
assert result == "empty_project"
def test_registry_name_lowered(self, tmp_path: Path) -> None:
"""Registry name is lowercased."""
@@ -248,10 +254,13 @@ class TestFormatTextReport:
assert "drone @spawn repair @test --relocate a b" in result
def test_dry_run_hint(self) -> None:
"""Report ends with dry-run suggestion."""
"""Report shows preview (dry-run default) and explicit --apply hints."""
items = [RemediationItem("info", "pyproject", "missing", "fix")]
result = format_text_report(items, "myproj")
assert "drone @spawn repair @myproj --dry-run" in result
# Repair is dry-run by default now: preview form has no flag, apply form is explicit
assert "Preview all fixes:" in result
assert "drone @spawn repair @myproj" in result
assert "drone @spawn repair @myproj --apply" in result
def test_critical_sorted_first(self) -> None:
"""Critical items appear before warning and info."""
@@ -364,14 +373,15 @@ class TestDoctorFixHandleCommand:
assert handle_command("doctor", []) is False
assert handle_command("help", []) is False
def test_no_args_calls_introspection(self) -> None:
"""No args triggers print_introspection."""
def test_no_args_shows_usage(self) -> None:
"""No args shows usage message (not introspection banner)."""
from aipass.aipass.apps.modules.doctor_fix import handle_command
with patch("aipass.aipass.apps.modules.doctor_fix.print_introspection") as mock:
with patch("aipass.aipass.apps.modules.doctor_fix.console") as mock_console:
result = handle_command("doctor_fix", [])
assert result is True
mock.assert_called_once()
printed = " ".join(str(c) for c in mock_console.print.call_args_list)
assert "aipass doctor --fix" in printed
def test_info_flag(self) -> None:
"""--info triggers print_introspection."""
+36 -37
View File
@@ -52,20 +52,6 @@ _ENCODING = "utf-8"
# =============================================================================
def _call_handle_command_no_args():
"""Call handle_command('help', []) with json_handler and console mocked."""
mock_console = MagicMock()
patches = [
patch("aipass.aipass.apps.modules.help_chat.json_handler"),
patch("aipass.aipass.apps.modules.help_chat.console", mock_console),
]
with ExitStack() as stack:
for p in patches:
stack.enter_context(p)
result = handle_command("help", [])
return result, mock_console
def _call_handle_command_drone_question(readme_content: str, readme_path: Path):
"""Call handle_command for 'what does drone do' with file I/O mocked."""
patches = [
@@ -254,54 +240,57 @@ class TestMatchBranches:
class TestSearchReadme:
"""Tests for _search_readme: live file reads, scoring, and error handling."""
"""Tests for _search_readme: live file reads via handler, scoring, and error handling."""
def _mock_lines(self, content):
"""Return a patch that makes read_readme_lines return content as lines."""
lines = content.splitlines(keepends=True)
return patch("aipass.aipass.apps.modules.help_chat.read_readme_lines", return_value=lines)
def test_returns_matching_lines_with_line_numbers(self):
"""Matching lines must be returned as (int, str) tuples."""
with patch("builtins.open", mock_open(read_data=_SAMPLE_README)):
results = _search_readme(_FAKE_README_PATH, ["drone"])
with self._mock_lines(_SAMPLE_README):
results = _search_readme("drone", ["drone"])
assert len(results) > 0
assert all(isinstance(ln, int) for ln, _ in results)
def test_line_numbers_are_1_indexed(self):
"""Line numbers in results must start at 1, not 0."""
with patch("builtins.open", mock_open(read_data=_SAMPLE_README)):
results = _search_readme(_FAKE_README_PATH, ["drone"])
with self._mock_lines(_SAMPLE_README):
results = _search_readme("drone", ["drone"])
assert all(ln >= 1 for ln, _ in results)
def test_returns_at_most_5_matches(self):
"""Result list must contain no more than 5 entries."""
content = "\n".join([f"drone line {i}" for i in range(10)])
with patch("builtins.open", mock_open(read_data=content)):
results = _search_readme(_FAKE_README_PATH, ["drone"])
with self._mock_lines(content):
results = _search_readme("drone", ["drone"])
assert len(results) <= 5
def test_no_keyword_match_returns_empty(self):
"""Keyword with no hits in the README must return an empty list."""
with patch("builtins.open", mock_open(read_data=_SAMPLE_README)):
results = _search_readme(_FAKE_README_PATH, ["xyzzy999"])
with self._mock_lines(_SAMPLE_README):
results = _search_readme("drone", ["xyzzy999"])
assert results == []
def test_oserror_returns_empty_and_logs_warning(self):
"""OSError on open must return [] and call logger.warning exactly once."""
with patch("builtins.open", side_effect=OSError("not found")):
def test_handler_returns_none_returns_empty_and_logs(self):
"""None from handler must return [] and call logger.warning."""
with patch("aipass.aipass.apps.modules.help_chat.read_readme_lines", return_value=None):
with patch("aipass.aipass.apps.modules.help_chat.logger") as mock_logger:
results = _search_readme(_FAKE_README_PATH, ["drone"])
results = _search_readme("nonexistent", ["drone"])
assert results == []
mock_logger.warning.assert_called_once()
def test_matching_is_case_insensitive(self):
"""Uppercase keyword in README must still match a lowercase query keyword."""
content = "DRONE does routing\n"
with patch("builtins.open", mock_open(read_data=content)):
results = _search_readme(_FAKE_README_PATH, ["drone"])
with self._mock_lines("DRONE does routing\n"):
results = _search_readme("drone", ["drone"])
assert len(results) == 1
def test_higher_scoring_lines_ranked_first(self):
"""Lines matching more keywords must appear before lines matching fewer."""
content = "drone flow spawn\ndrone only\nflow only\n"
with patch("builtins.open", mock_open(read_data=content)):
results = _search_readme(_FAKE_README_PATH, ["drone", "flow"])
with self._mock_lines("drone flow spawn\ndrone only\nflow only\n"):
results = _search_readme("drone", ["drone", "flow"])
first_text = results[0][1]
assert "drone" in first_text and "flow" in first_text
@@ -367,11 +356,21 @@ class TestHandleCommand:
"""COMMAND module constant must equal the string 'help'."""
assert COMMAND == "help"
def test_no_args_returns_true_and_calls_console(self):
"""handle_command('help', []) must return True and print usage via console."""
result, mock_console = _call_handle_command_no_args()
def test_no_args_returns_true_and_shows_help(self):
"""handle_command('help', []) must return True and print usage help."""
with patch("aipass.aipass.apps.modules.help_chat.print_help") as mock_help:
with patch("aipass.aipass.apps.modules.help_chat.json_handler"):
result = handle_command("help", [])
assert result is True
mock_console.print.assert_called()
mock_help.assert_called_once()
def test_info_flag_calls_introspection(self):
"""--info flag triggers print_introspection."""
with patch("aipass.aipass.apps.modules.help_chat.print_introspection") as mock_intro:
with patch("aipass.aipass.apps.modules.help_chat.json_handler"):
result = handle_command("help", ["--info"])
assert result is True
mock_intro.assert_called_once()
def test_valid_drone_question_returns_true(self):
"""A well-formed question about drone must return True."""
+278 -11
View File
@@ -16,9 +16,14 @@ from unittest.mock import MagicMock, patch
import pytest
from aipass.aipass.apps.modules.init_flow import (
AIPASS_SPECIFIC_STAGES,
TEMPLATE_AIPASS,
TEMPLATE_CHOICES,
TEMPLATE_EMPTY,
TOTAL_STAGES,
_get_last_completed_stage,
_get_setup_progress,
_handle_init_update,
_save_stage,
handle_command,
print_help,
@@ -198,11 +203,18 @@ class TestHandleCommand:
assert handle_command("doctor", []) is False
assert handle_command("profile", ["set", "name", "X"]) is False
def test_no_args_shows_introspection(self, tmp_local_json) -> None:
"""'init' with no args calls print_introspection."""
with patch("aipass.aipass.apps.modules.init_flow.print_introspection") as mock_intro:
def test_no_args_shows_help(self, tmp_local_json) -> None:
"""'init' with no args calls print_help (not introspection banner)."""
with patch("aipass.aipass.apps.modules.init_flow.print_help") as mock_help:
result = handle_command("init", [])
assert result is True
mock_help.assert_called_once()
def test_info_flag_calls_introspection(self, tmp_local_json) -> None:
"""--info flag calls print_introspection."""
with patch("aipass.aipass.apps.modules.init_flow.print_introspection") as mock_intro:
result = handle_command("init", ["--info"])
assert result is True
mock_intro.assert_called_once()
def test_help_flag(self) -> None:
@@ -279,7 +291,7 @@ class TestRunInit:
assert result == 0
def test_non_interactive_runs_all_stages(self, tmp_local_json) -> None:
"""non_interactive=True runs all 12 stages from fresh state."""
"""non_interactive=True with aipass_framework runs all 12 stages."""
patches = self._patch_all_stages()
mocks = []
ctx = __import__("contextlib").ExitStack()
@@ -288,7 +300,7 @@ class TestRunInit:
with ctx:
with patch("aipass.aipass.apps.modules.init_flow.json_handler"):
with patch("aipass.aipass.apps.modules.init_flow.console"):
result = run_init(non_interactive=True)
result = run_init(non_interactive=True, template=TEMPLATE_AIPASS)
assert result == 0
def test_keyboard_interrupt_pauses_gracefully(self, tmp_local_json) -> None:
@@ -296,7 +308,7 @@ class TestRunInit:
with patch("aipass.aipass.apps.modules.init_flow.stage_1_welcome", side_effect=KeyboardInterrupt):
with patch("aipass.aipass.apps.modules.init_flow.console"):
with patch("aipass.aipass.apps.modules.init_flow.warning"):
result = run_init(non_interactive=False)
result = run_init(non_interactive=False, template=TEMPLATE_EMPTY)
assert result == 0
def test_stage_error_continues(self, tmp_local_json) -> None:
@@ -328,7 +340,7 @@ class TestRunInit:
warning=MagicMock(),
console=MagicMock(),
):
result = run_init(non_interactive=True)
result = run_init(non_interactive=True, template=TEMPLATE_AIPASS)
assert result == 0
def test_resumes_from_last_completed(self, tmp_local_json_with_progress: Path) -> None:
@@ -353,7 +365,7 @@ class TestRunInit:
warning=MagicMock(),
console=MagicMock(),
):
run_init(non_interactive=True)
run_init(non_interactive=True, template=TEMPLATE_AIPASS)
stage_1_mock.assert_not_called()
stage_4_mock.assert_called_once()
@@ -480,6 +492,66 @@ class TestStages:
result = stage_6_tool_choice(non_interactive=True, cli_override="codex")
assert result["cli"] == "codex"
def test_stage_6_claude_present_no_prompt(self, tmp_local_json) -> None:
"""When claude is on PATH, no install prompt is shown."""
mock_profile_mod = MagicMock()
mock_profile_mod.get_user_profile.return_value = {}
with patch(f"{_MOD}.console"):
with patch(f"{_MOD}.shutil.which", return_value="/usr/bin/claude"):
with patch.dict("sys.modules", {"aipass.aipass.apps.modules.profile": mock_profile_mod}):
with patch(f"{_MOD}._handle_missing_claude") as mock_handle:
result = stage_6_tool_choice(non_interactive=True)
mock_handle.assert_not_called()
assert result["cli"] == "claude"
@patch(f"{_MOD}._choose", return_value="default")
@patch(f"{_MOD}._install_claude_code", return_value=True)
@patch(f"{_MOD}._prompt", return_value="Y")
@patch(f"{_MOD}.shutil.which", return_value=None)
@patch(f"{_MOD}.console")
def test_stage_6_claude_missing_interactive_yes(
self, _con, _which, _prompt, mock_install, _choose, tmp_local_json
) -> None:
"""Missing claude + interactive + yes → installer invoked."""
mock_profile_mod = MagicMock()
mock_profile_mod.get_user_profile.return_value = {}
with patch.dict("sys.modules", {"aipass.aipass.apps.modules.profile": mock_profile_mod}):
result = stage_6_tool_choice(non_interactive=False, cli_override="claude")
mock_install.assert_called_once()
assert result["cli"] == "claude"
@patch(f"{_MOD}._choose", return_value="default")
@patch(f"{_MOD}._install_claude_code")
@patch(f"{_MOD}._prompt", return_value="n")
@patch(f"{_MOD}.shutil.which", return_value=None)
@patch(f"{_MOD}.console")
def test_stage_6_claude_missing_interactive_no(
self, _con, _which, _prompt, mock_install, _choose, tmp_local_json
) -> None:
"""Missing claude + interactive + no → no install, continues."""
mock_profile_mod = MagicMock()
mock_profile_mod.get_user_profile.return_value = {}
with patch.dict("sys.modules", {"aipass.aipass.apps.modules.profile": mock_profile_mod}):
result = stage_6_tool_choice(non_interactive=False, cli_override="claude")
mock_install.assert_not_called()
assert result["cli"] == "claude"
@patch(f"{_MOD}.warning")
@patch(f"{_MOD}._install_claude_code")
@patch(f"{_MOD}.shutil.which", return_value=None)
@patch(f"{_MOD}.console")
def test_stage_6_claude_missing_non_interactive_warns(
self, _con, _which, mock_install, mock_warn, tmp_local_json
) -> None:
"""Missing claude + non-interactive → warning, no install."""
mock_profile_mod = MagicMock()
mock_profile_mod.get_user_profile.return_value = {}
with patch.dict("sys.modules", {"aipass.aipass.apps.modules.profile": mock_profile_mod}):
result = stage_6_tool_choice(non_interactive=True)
mock_install.assert_not_called()
mock_warn.assert_called_once()
assert result["cli"] == "claude"
def test_stage_7_skipped_when_no_docker(self, tmp_local_json) -> None:
"""Docker offer is skipped when has_docker=False."""
with patch(f"{_MOD}.console"):
@@ -499,14 +571,14 @@ class TestStages:
assert result["docker"] == "skipped"
def test_stage_8_non_interactive_creates_my_agent(self, tmp_local_json) -> None:
"""non_interactive=True uses 'my-agent' as default name."""
"""non_interactive=True uses 'my_agent' as default name."""
mock_proc = MagicMock(returncode=0)
with patch(f"{_MOD}.console"):
with patch(f"{_MOD}.subprocess.run", return_value=mock_proc):
with patch(f"{_MOD}._resolve_package_dir", return_value=None):
result = stage_8_first_agent(non_interactive=True)
assert result["agent_name"] == "my-agent"
assert result["agent_path"] == "src/my-agent"
assert result["agent_name"] == "my_agent"
assert result["agent_path"] == "src/my_agent"
def test_stage_8_drone_not_found(self, tmp_local_json) -> None:
"""FileNotFoundError from drone is handled gracefully."""
@@ -567,3 +639,198 @@ class TestStages:
assert result == {}
stored = json.loads(tmp_local_json.read_text())
assert stored["setup_progress"]["last_completed_stage"] == 12
# =============================================================================
# init_update_registry_sync: subprocess_sync
# =============================================================================
_MOD_UPDATE = "aipass.aipass.apps.modules.init_flow"
class TestInitUpdateRegistrySync:
"""Tests for registry sync subprocess call in _handle_init_update."""
def test_sync_success_prints_message(self, tmp_path: Path) -> None:
"""Successful drone sync-registry prints 'Registry synced.'"""
mock_result = MagicMock(returncode=0)
with (
patch(
"aipass.aipass.apps.handlers.init.bootstrap.update_project",
return_value={"updated_files": [], "already_current": []},
),
patch(f"{_MOD_UPDATE}.subprocess.run", return_value=mock_result) as mock_run,
patch(f"{_MOD_UPDATE}.console") as mock_console,
patch(f"{_MOD_UPDATE}.json_handler"),
):
rc = _handle_init_update([str(tmp_path)])
assert rc == 0
mock_run.assert_called_once_with(
["drone", "@spawn", "sync-registry", "--fix"],
capture_output=True,
text=True,
timeout=30,
)
sync_calls = [c for c in mock_console.print.call_args_list if "Registry synced" in str(c)]
assert len(sync_calls) == 1
def test_sync_failure_degrades_silently(self, tmp_path: Path) -> None:
"""Non-zero exit from drone sync-registry is silently skipped."""
mock_result = MagicMock(returncode=1)
with (
patch(
"aipass.aipass.apps.handlers.init.bootstrap.update_project",
return_value={"updated_files": [], "already_current": []},
),
patch(f"{_MOD_UPDATE}.subprocess.run", return_value=mock_result),
patch(f"{_MOD_UPDATE}.console") as mock_console,
patch(f"{_MOD_UPDATE}.json_handler"),
):
rc = _handle_init_update([str(tmp_path)])
assert rc == 0
sync_calls = [c for c in mock_console.print.call_args_list if "Registry synced" in str(c)]
assert len(sync_calls) == 0
def test_sync_missing_drone_degrades_silently(self, tmp_path: Path) -> None:
"""FileNotFoundError (no drone binary) degrades gracefully."""
with (
patch(
"aipass.aipass.apps.handlers.init.bootstrap.update_project",
return_value={"updated_files": [], "already_current": []},
),
patch(f"{_MOD_UPDATE}.subprocess.run", side_effect=FileNotFoundError("drone not found")),
patch(f"{_MOD_UPDATE}.console") as mock_console,
patch(f"{_MOD_UPDATE}.json_handler"),
):
rc = _handle_init_update([str(tmp_path)])
assert rc == 0
sync_calls = [c for c in mock_console.print.call_args_list if "Registry synced" in str(c)]
assert len(sync_calls) == 0
def test_sync_timeout_degrades_silently(self, tmp_path: Path) -> None:
"""subprocess.TimeoutExpired degrades gracefully."""
import subprocess as _sp
with (
patch(
"aipass.aipass.apps.handlers.init.bootstrap.update_project",
return_value={"updated_files": [], "already_current": []},
),
patch(f"{_MOD_UPDATE}.subprocess.run", side_effect=_sp.TimeoutExpired(cmd="drone", timeout=30)),
patch(f"{_MOD_UPDATE}.console"),
patch(f"{_MOD_UPDATE}.json_handler"),
):
rc = _handle_init_update([str(tmp_path)])
assert rc == 0
# =============================================================================
# TestTemplateSelector
# =============================================================================
class TestTemplateSelector:
"""Tests for the template selector in aipass init."""
@staticmethod
def _stage_patches():
"""Return patches for all 12 stage functions as no-ops."""
stage_names = [
"stage_1_welcome",
"stage_2_system_detect",
"stage_3_doctor",
"stage_4_user_profile",
"stage_5_style_questions",
"stage_6_tool_choice",
"stage_7_docker_offer",
"stage_8_first_agent",
"stage_9_ping_sweep",
"stage_10_smoke_test",
"stage_11_handoff",
"stage_12_done",
]
return {name: MagicMock(return_value={}) for name in stage_names}
def test_empty_project_default_skips_scaffold(self, tmp_local_json) -> None:
"""empty project (default) = no scaffold, stages 8,9,11,12 skipped."""
mocks = self._stage_patches()
with patch.multiple(_MOD, console=MagicMock(), warning=MagicMock(), **mocks):
result = run_init(non_interactive=True, template=TEMPLATE_EMPTY)
assert result == 0
for name in (
"stage_1_welcome",
"stage_2_system_detect",
"stage_3_doctor",
"stage_4_user_profile",
"stage_5_style_questions",
"stage_6_tool_choice",
"stage_7_docker_offer",
"stage_10_smoke_test",
):
assert mocks[name].called, f"{name} should have been called"
for name in ("stage_8_first_agent", "stage_9_ping_sweep", "stage_11_handoff", "stage_12_done"):
assert not mocks[name].called, f"{name} should NOT have been called"
def test_aipass_framework_runs_full_scaffold(self, tmp_local_json) -> None:
"""aipass_framework = full scaffold + all 12 stages."""
mocks = self._stage_patches()
with patch.multiple(_MOD, console=MagicMock(), warning=MagicMock(), **mocks):
with patch(
"aipass.aipass.apps.handlers.init.bootstrap.init_project",
return_value={},
):
result = run_init(non_interactive=True, template=TEMPLATE_AIPASS)
assert result == 0
for name in mocks:
assert mocks[name].called, f"{name} should have been called"
def test_list_flag_shows_catalog(self) -> None:
"""aipass init --list shows the catalog (not swallowed into run)."""
with patch(f"{_MOD}.console") as mock_console:
result = handle_command("init", ["--list"])
assert result is True
printed = " ".join(str(c) for c in mock_console.print.call_args_list)
for t in TEMPLATE_CHOICES:
assert t in printed
def test_template_flag_form_works(self, tmp_local_json) -> None:
"""aipass init run --template aipass_framework passes template to run_init."""
with patch(f"{_MOD}.run_init", return_value=0) as mock_run:
with pytest.raises(SystemExit):
handle_command("init", ["run", "--template", TEMPLATE_AIPASS])
mock_run.assert_called_once()
_, kwargs = mock_run.call_args
assert kwargs["template"] == TEMPLATE_AIPASS
def test_positional_template_routes_to_run_init(self, tmp_local_json) -> None:
"""aipass init aipass_framework routes to run_init with template."""
with patch(f"{_MOD}.run_init", return_value=0) as mock_run:
with pytest.raises(SystemExit):
handle_command("init", [TEMPLATE_AIPASS])
mock_run.assert_called_once()
_, kwargs = mock_run.call_args
assert kwargs["template"] == TEMPLATE_AIPASS
def test_positional_path_still_works(self, tmp_local_json) -> None:
"""Non-template positional args still route to scaffold."""
with patch(f"{_MOD}._preflight_check", return_value=None):
with patch(f"{_MOD}._handle_init_scaffold", return_value=0) as mock_scaffold:
with pytest.raises(SystemExit):
handle_command("init", ["/tmp/test-proj"])
mock_scaffold.assert_called_once_with(["/tmp/test-proj"])
def test_pip_hints_say_clone(self, tmp_local_json) -> None:
"""in-product hints say clone/setup.sh, not pip."""
with patch(f"{_MOD}.console"):
with patch(f"{_MOD}.warning") as mock_warn:
with patch(f"{_MOD}.shutil.which", return_value=None):
stage_10_smoke_test()
for call in mock_warn.call_args_list:
msg = call[0][0].lower()
assert "setup.sh" in msg
assert "pip" not in msg
def test_aipass_specific_stages_constant(self) -> None:
"""AIPASS_SPECIFIC_STAGES contains exactly {8, 9, 11, 12}."""
assert AIPASS_SPECIFIC_STAGES == {8, 9, 11, 12}
+55 -24
View File
@@ -9,11 +9,12 @@
"""Tests for json_handler — default_factory, validate, get_path, ensure_exists, load, save, ensure_module."""
import json
import pytest
from unittest.mock import patch
from aipass.aipass.apps.handlers.json.json_handler import (
AIPASS_JSON_DIR,
_default_template,
ensure_json_exists,
ensure_module_jsons,
get_json_path,
@@ -30,31 +31,39 @@ from aipass.aipass.apps.handlers.json.json_handler import (
class TestDefaultFactory:
"""Tests for _default_template factory function."""
"""Tests for default JSON creation via ensure_json_exists."""
def test_config_template(self):
def test_config_template(self, tmp_path):
"""Config template includes module_name, version, config, created."""
result = _default_template("config", "test_mod")
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", tmp_path):
ensure_json_exists("test_mod", "config")
result = json.loads((tmp_path / "test_mod_config.json").read_text())
assert result["module_name"] == "test_mod"
assert result["version"] == "1.0.0"
assert "config" in result
assert "created" in result
def test_data_template(self):
def test_data_template(self, tmp_path):
"""Data template includes created and last_updated."""
result = _default_template("data", "test_mod")
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", tmp_path):
ensure_json_exists("test_mod", "data")
result = json.loads((tmp_path / "test_mod_data.json").read_text())
assert "created" in result
assert "last_updated" in result
def test_log_template(self):
def test_log_template(self, tmp_path):
"""Log template is an empty list."""
result = _default_template("log", "test_mod")
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", tmp_path):
ensure_json_exists("test_mod", "log")
result = json.loads((tmp_path / "test_mod_log.json").read_text())
assert result == []
def test_unknown_type_returns_none(self):
"""Unknown json_type returns None."""
result = _default_template("unknown_type", "test_mod")
assert result is None
def test_unknown_type_raises(self):
"""Unknown json_type raises ValueError."""
from aipass.aipass.shared.json_handler import JsonHandler
with pytest.raises(ValueError):
JsonHandler._create_default("unknown_type", "test_mod")
# =============================================================================
@@ -200,10 +209,20 @@ class TestSave:
assert saved["module_name"] == "s"
def test_save_invalid_structure_rejected(self, tmp_path):
"""Invalid structure is rejected with False."""
"""Invalid structure raises ValueError."""
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", tmp_path):
result = save_json("s", "config", {"bad": True})
assert result is False
with pytest.raises(ValueError):
save_json("s", "config", {"bad": True})
def test_save_unknown_returns_false(self, tmp_path):
"""save_json returns False when write fails (e.g. read-only dir)."""
ro_dir = tmp_path / "readonly"
ro_dir.mkdir()
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", ro_dir):
data = {"module_name": "s", "version": "1.0.0", "config": {}, "created": "2026-01-01"}
with patch("aipass.aipass.shared.json_handler.JsonHandler.write_json", return_value=False):
result = save_json("s", "config", data)
assert result is False
# =============================================================================
@@ -239,7 +258,7 @@ class TestLoadPath:
result = load_path(f)
assert result == {"key": "value"}
def test_load_missing_file(self, tmp_path):
def test_unknown_file_returns_none(self, tmp_path):
"""Missing file returns None."""
result = load_path(tmp_path / "nope.json")
assert result is None
@@ -290,7 +309,9 @@ class TestReturnTypeContracts:
"""Doctor handle_command returns True for match, False otherwise."""
from aipass.aipass.apps.modules.doctor import handle_command as doctor_cmd
assert doctor_cmd("doctor", []) is True
with patch("aipass.aipass.apps.modules.doctor.run_doctor", return_value=0):
with patch("aipass.aipass.apps.modules.doctor.json_handler"):
assert doctor_cmd("doctor", []) is True
assert doctor_cmd("not_doctor", []) is False
def test_help_chat_handle_command_returns_bool(self):
@@ -324,14 +345,14 @@ class TestExceptionContracts:
"""Tests that invalid inputs raise appropriate exceptions."""
def test_invalid_mode_raises(self, tmp_path):
"""save_json with invalid structure returns False (not silent pass)."""
"""save_json with invalid structure raises ValueError."""
with patch("aipass.aipass.apps.handlers.json.json_handler.AIPASS_JSON_DIR", tmp_path):
result = save_json("x", "config", [])
assert result is False
result = save_json("x", "data", "string")
assert result is False
result = save_json("x", "log", {"not": "a list"})
assert result is False
with pytest.raises(ValueError):
save_json("x", "config", [])
with pytest.raises(ValueError):
save_json("x", "data", "string")
with pytest.raises(ValueError):
save_json("x", "log", {"not": "a list"})
# =============================================================================
@@ -355,3 +376,13 @@ class TestInfrastructureMocking:
assert callable(jh_mod.load_json)
assert callable(jh_mod.save_json)
assert callable(jh_mod.load_path)
# =============================================================================
# success_failure_paths: unknown_returns_false
# =============================================================================
def test_unknown_returns_false():
"""validate_json_structure returns False for unrecognized json_type."""
assert validate_json_structure({}, "bogus") is False
+8 -1
View File
@@ -170,12 +170,19 @@ class TestHandleCommand:
assert handle_command("init", ["run"]) is False
def test_no_args_calls_introspection(self, tmp_local_json) -> None:
"""'profile' with no args calls print_introspection."""
"""'profile' with no args shows the profile (runs the command)."""
with patch("aipass.aipass.apps.modules.profile.print_introspection") as mock_pi:
result = handle_command("profile", [])
assert result is True
mock_pi.assert_called_once()
def test_info_flag_calls_introspection(self, tmp_local_json) -> None:
"""--info flag calls print_introspection."""
with patch("aipass.aipass.apps.modules.profile.print_introspection") as mock_pi:
result = handle_command("profile", ["--info"])
assert result is True
mock_pi.assert_called_once()
def test_help_flag_returns_true(self) -> None:
"""--help flag is handled."""
with patch("aipass.aipass.apps.modules.profile.print_help"):
@@ -0,0 +1,585 @@
# =================== AIPass ====================
# Name: test_sandbox_check.py
# Description: Tests for sandbox prerequisite checker and doctor integration
# Version: 1.0.0
# Created: 2026-06-10
# Modified: 2026-06-10
# =============================================
"""Tests for sandbox prereq checks — handler + doctor integration."""
import shutil
import socket
import subprocess
import sys
from pathlib import Path
from unittest.mock import MagicMock, patch
import pytest # pyright: ignore[reportMissingImports]
from aipass.aipass.apps.handlers.sandbox_check.sandbox_checker import (
check_broker_alive,
check_bwrap_functional,
check_bwrap_present,
check_node_present,
check_rg_present,
check_sandbox_flag,
check_srt_resolvable,
is_linux,
)
from aipass.aipass.apps.handlers.ui.progress import GLYPH_FAIL, GLYPH_PASS, GLYPH_WARN
from aipass.aipass.apps.modules.doctor import _check_sandbox
# =============================================================================
# Fixtures
# =============================================================================
@pytest.fixture(autouse=True)
def _stub_json_handler():
"""Suppress json_handler.log_operation side effects in all tests."""
with patch("aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.json_handler") as mock:
mock.log_operation = MagicMock()
yield mock
# =============================================================================
# check_sandbox_flag
# =============================================================================
class TestCheckSandboxFlag:
def test_flag_off_by_default(self, monkeypatch):
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
result = check_sandbox_flag()
assert result["enabled"] is False
assert result["raw_value"] == ""
def test_flag_on_with_1(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
result = check_sandbox_flag()
assert result["enabled"] is True
def test_flag_on_with_true(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "true")
result = check_sandbox_flag()
assert result["enabled"] is True
def test_flag_on_with_yes(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "yes")
result = check_sandbox_flag()
assert result["enabled"] is True
def test_flag_on_case_insensitive(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "TRUE")
result = check_sandbox_flag()
assert result["enabled"] is True
def test_flag_off_with_garbage(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "maybe")
result = check_sandbox_flag()
assert result["enabled"] is False
# =============================================================================
# check_bwrap_present
# =============================================================================
class TestCheckBwrapPresent:
def test_bwrap_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/bwrap" if name == "bwrap" else None)
result = check_bwrap_present()
assert result["found"] is True
assert result["path"] == "/usr/bin/bwrap"
def test_bwrap_not_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: None)
result = check_bwrap_present()
assert result["found"] is False
assert result["path"] is None
@pytest.mark.skipif(not shutil.which("bwrap"), reason="bwrap not installed")
def test_bwrap_live(self):
result = check_bwrap_present()
assert result["found"] is True
assert "bwrap" in result["path"]
# =============================================================================
# check_bwrap_functional
# =============================================================================
class TestCheckBwrapFunctional:
def test_bwrap_missing(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: None)
result = check_bwrap_functional()
assert result["ok"] is False
assert "not found" in result["detail"]
def test_bwrap_succeeds(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/bwrap" if name == "bwrap" else None)
mock_proc = MagicMock(returncode=0, stderr="")
with patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
return_value=mock_proc,
) as mock_run:
result = check_bwrap_functional()
assert result["ok"] is True
argv = mock_run.call_args[0][0]
assert argv[0] == "/usr/bin/bwrap"
assert "--ro-bind" in argv
assert "true" in argv
def test_bwrap_fails_reports_sysctl(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/bwrap" if name == "bwrap" else None)
mock_proc = MagicMock(returncode=1, stderr="permission denied")
with (
patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
return_value=mock_proc,
),
patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker._read_userns_sysctl",
return_value="1",
),
):
result = check_bwrap_functional()
assert result["ok"] is False
assert "exit 1" in result["detail"]
assert result["sysctl_value"] == "1"
def test_bwrap_timeout(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/bwrap" if name == "bwrap" else None)
with patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
side_effect=subprocess.TimeoutExpired(cmd="bwrap", timeout=10),
):
result = check_bwrap_functional()
assert result["ok"] is False
assert "timed out" in result["detail"]
@pytest.mark.skipif(not shutil.which("bwrap"), reason="bwrap not installed")
def test_bwrap_functional_live(self):
result = check_bwrap_functional()
assert isinstance(result["ok"], bool)
if result["ok"]:
assert "succeeded" in result["detail"]
# =============================================================================
# check_node_present
# =============================================================================
class TestCheckNodePresent:
def test_node_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/node" if name == "node" else None)
result = check_node_present()
assert result["found"] is True
assert result["path"] == "/usr/bin/node"
def test_node_not_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: None)
result = check_node_present()
assert result["found"] is False
@pytest.mark.skipif(not shutil.which("node"), reason="node not installed")
def test_node_live(self):
result = check_node_present()
assert result["found"] is True
# =============================================================================
# check_srt_resolvable
# =============================================================================
class TestCheckSrtResolvable:
def test_no_node(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: None)
result = check_srt_resolvable()
assert result["found"] is False
assert "node" in result["install_hint"].lower()
def test_srt_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/node" if name == "node" else None)
mock_proc = MagicMock(returncode=0, stdout="/usr/lib/node_modules/@anthropic-ai/sandbox-runtime/dist/index.js")
with patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
return_value=mock_proc,
) as mock_run:
result = check_srt_resolvable()
assert result["found"] is True
assert "sandbox-runtime" in result["path"]
argv = mock_run.call_args[0][0]
assert argv[0] == "/usr/bin/node"
assert argv[1] == "-e"
def test_srt_not_found(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/node" if name == "node" else None)
mock_proc = MagicMock(returncode=1, stdout="")
with patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
return_value=mock_proc,
):
result = check_srt_resolvable()
assert result["found"] is False
assert "npm install" in result["install_hint"]
def test_srt_timeout(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/node" if name == "node" else None)
with patch(
"aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.subprocess.run",
side_effect=subprocess.TimeoutExpired(cmd="node", timeout=10),
):
result = check_srt_resolvable()
assert result["found"] is False
# =============================================================================
# check_rg_present
# =============================================================================
class TestCheckRgPresent:
def test_rg_on_path(self, monkeypatch):
monkeypatch.setattr(shutil, "which", lambda name: "/usr/bin/rg" if name == "rg" else None)
result = check_rg_present()
assert result["found"] is True
assert result["path"] == "/usr/bin/rg"
def test_rg_not_on_path_but_in_local_bin(self, monkeypatch, tmp_path):
monkeypatch.setattr(shutil, "which", lambda name: None)
fake_rg = tmp_path / ".local" / "bin" / "rg"
fake_rg.parent.mkdir(parents=True)
fake_rg.touch()
monkeypatch.setattr(Path, "home", lambda: tmp_path)
result = check_rg_present()
assert result["found"] is True
assert str(fake_rg) == result["path"]
def test_rg_not_found(self, monkeypatch, tmp_path):
monkeypatch.setattr(shutil, "which", lambda name: None)
monkeypatch.setattr(Path, "home", lambda: tmp_path)
result = check_rg_present()
assert result["found"] is False
@pytest.mark.skipif(not shutil.which("rg"), reason="rg not installed")
def test_rg_live(self):
result = check_rg_present()
assert result["found"] is True
# =============================================================================
# check_broker_alive
# =============================================================================
class TestCheckBrokerAlive:
def test_no_repo_root_no_env(self, monkeypatch):
monkeypatch.delenv("AIPASS_HOME", raising=False)
monkeypatch.setattr(Path, "cwd", lambda: Path("/nonexistent"))
result = check_broker_alive(repo_root=None)
assert result["alive"] is False
def test_socket_missing(self, tmp_path):
ai_central = tmp_path / ".ai_central"
ai_central.mkdir()
result = check_broker_alive(repo_root=tmp_path)
assert result["alive"] is False
assert "missing" in result["detail"]
@pytest.mark.skipif(sys.platform != "linux", reason="AF_UNIX broker sockets are Linux-only")
def test_socket_connect_success(self, tmp_path):
ai_central = tmp_path / ".ai_central"
ai_central.mkdir()
sock_path = ai_central / "drone_broker.sock"
server = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
server.bind(str(sock_path))
server.listen(1)
try:
result = check_broker_alive(repo_root=tmp_path)
assert result["alive"] is True
assert "connected" in result["detail"]
finally:
server.close()
@pytest.mark.skipif(sys.platform != "linux", reason="AF_UNIX broker sockets are Linux-only")
def test_socket_connect_refused(self, tmp_path):
ai_central = tmp_path / ".ai_central"
ai_central.mkdir()
sock_path = ai_central / "drone_broker.sock"
sock_path.touch()
result = check_broker_alive(repo_root=tmp_path)
assert result["alive"] is False
assert "connect failed" in result["detail"]
def test_repo_root_from_env(self, monkeypatch, tmp_path):
ai_central = tmp_path / ".ai_central"
ai_central.mkdir()
monkeypatch.setenv("AIPASS_HOME", str(tmp_path))
result = check_broker_alive(repo_root=None)
assert result["alive"] is False
assert "missing" in result["detail"]
# =============================================================================
# is_linux
# =============================================================================
class TestIsLinux:
def test_linux(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.sys.platform", "linux")
assert is_linux() is True
def test_darwin(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.sys.platform", "darwin")
assert is_linux() is False
def test_win32(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.handlers.sandbox_check.sandbox_checker.sys.platform", "win32")
assert is_linux() is False
# =============================================================================
# _check_sandbox (doctor integration)
# =============================================================================
@pytest.fixture
def _stub_doctor_json():
"""Stub json_handler inside doctor.py too."""
with patch("aipass.aipass.apps.modules.doctor.json_handler") as mock:
mock.log_operation = MagicMock()
yield mock
class TestCheckSandboxDoctor:
def test_non_linux_one_info_line(self, monkeypatch):
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.is_linux",
lambda: False,
)
results = _check_sandbox()
assert len(results) == 1
assert "Linux-only" in results[0].detail
assert results[0].glyph == GLYPH_PASS
def test_flag_off_missing_prereq_is_warn(self, monkeypatch):
monkeypatch.delenv("AIPASS_SANDBOX_ENABLED", raising=False)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": False, "raw_value": ""}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": False, "path": None, "install_hint": "npm install -g ..."},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": False, "detail": "not found"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
for r in results:
assert r.glyph != GLYPH_FAIL, f"Flag OFF should not produce FAIL, got FAIL for {r.label}"
def test_flag_on_missing_prereq_is_fail(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": True, "raw_value": "1"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": False, "path": None, "install_hint": "npm install -g ..."},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": False, "detail": "not found"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
fail_results = [r for r in results if r.glyph == GLYPH_FAIL]
assert len(fail_results) >= 4, f"Flag ON + missing prereqs should produce FAILs, got {len(fail_results)}"
def test_flag_on_all_present_is_pass(self, monkeypatch):
monkeypatch.setenv("AIPASS_SANDBOX_ENABLED", "1")
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": True, "raw_value": "1"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": True, "path": "/usr/bin/bwrap"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_functional",
lambda: {"ok": True, "detail": "trivial sandbox succeeded", "sysctl_value": None},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": True, "path": "/usr/bin/node"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": True, "path": "/usr/lib/srt/index.js", "install_hint": ""},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": True, "path": "/usr/bin/rg"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": True, "detail": "connected"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: Path("/tmp/fake"))
results = _check_sandbox()
for r in results:
assert r.glyph == GLYPH_PASS, f"All present should be PASS, got {r.glyph} for {r.label}"
def test_bwrap_functional_skipped_when_not_present(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": False, "raw_value": ""}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": True, "path": "/usr/bin/node"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": True, "path": "/x", "install_hint": ""},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": True, "path": "/usr/bin/rg"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": True, "detail": "ok"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
labels = [r.label for r in results]
assert "bwrap functional" not in labels
def test_bwrap_functional_included_when_present(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": False, "raw_value": ""}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": True, "path": "/usr/bin/bwrap"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_functional",
lambda: {"ok": True, "detail": "ok", "sysctl_value": None},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": True, "path": "/usr/bin/node"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": True, "path": "/x", "install_hint": ""},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": True, "path": "/usr/bin/rg"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": True, "detail": "ok"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
labels = [r.label for r in results]
assert "bwrap functional" in labels
def test_sysctl_in_detail_on_functional_fail(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": True, "raw_value": "1"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": True, "path": "/usr/bin/bwrap"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_functional",
lambda: {"ok": False, "detail": "exit 1: denied", "sysctl_value": "1"},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": True, "path": "/usr/bin/node"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": True, "path": "/x", "install_hint": ""},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": True, "path": "/usr/bin/rg"}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": True, "detail": "ok"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
func_result = [r for r in results if r.label == "bwrap functional"][0]
assert "apparmor_restrict_unprivileged_userns=1" in func_result.detail
def test_inert_suffix_when_flag_off(self, monkeypatch):
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.is_linux", lambda: True)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_sandbox_flag", lambda: {"enabled": False, "raw_value": ""}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_bwrap_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_node_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_srt_resolvable",
lambda: {"found": False, "path": None, "install_hint": "npm install -g ..."},
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_rg_present", lambda: {"found": False, "path": None}
)
monkeypatch.setattr(
"aipass.aipass.apps.modules.doctor.check_broker_alive",
lambda repo_root=None: {"alive": False, "detail": "not found"},
)
monkeypatch.setattr("aipass.aipass.apps.modules.doctor.find_project_root", lambda p: None)
results = _check_sandbox()
missing_results = [r for r in results if r.glyph == GLYPH_WARN]
for r in missing_results:
assert "inert" in r.detail or r.label == "sandbox flag", (
f"Missing prereq {r.label} should show inert suffix"
)
@@ -0,0 +1,58 @@
# =================== AIPass ====================
# Name: test_shared_bootstrap_safety.py
# Description: Guard test — shared/ must stay stdlib-only (loads pre-drone)
# Version: 1.0.0
# Created: 2026-06-10
# Modified: 2026-06-10
# =============================================
"""Guard test: importing aipass.aipass.shared must NOT pull in branch dependencies.
The shared/ package is used by bootstrap.py during `aipass init` on fresh machines
where drone/prax/trigger don't exist yet. If shared/ ever imports a branch
dependency, init breaks. This test enforces the invariant via subprocess isolation.
"""
import subprocess
import sys
ALLOWED_PREFIXES = ("aipass.aipass.shared",)
ALLOWED_EXACT = {"aipass", "aipass.aipass"}
SCRIPT = """\
import sys
import aipass.aipass.shared.json_handler
import aipass.aipass.shared.json_ops
import aipass.aipass.shared.registry_discovery
bad = []
for name in sorted(sys.modules):
if not name.startswith("aipass"):
continue
if name in {allowed_exact}:
continue
if any(name.startswith(p) for p in {allowed_prefixes}):
continue
bad.append(name)
if bad:
print("FAIL: branch dependencies loaded: " + ", ".join(bad))
sys.exit(1)
print("OK")
""".format(
allowed_exact=repr(ALLOWED_EXACT),
allowed_prefixes=repr(ALLOWED_PREFIXES),
)
class TestSharedBootstrapSafety:
def test_no_branch_deps_loaded(self):
"""Importing all shared modules must not pull in any branch code."""
result = subprocess.run(
[sys.executable, "-c", SCRIPT],
capture_output=True,
text=True,
timeout=30,
)
assert result.returncode == 0, f"shared/ pulled in branch dependencies:\n{result.stdout}\n{result.stderr}"
+12 -7
View File
@@ -20,7 +20,6 @@ from aipass.aipass.apps.handlers.structure_scan.structure_scanner import (
check_root_artifacts,
detect_pollution,
find_project_root,
find_registry,
scan_agents,
)
from aipass.aipass.apps.handlers.ui.progress import GLYPH_FAIL, GLYPH_WARN
@@ -357,16 +356,22 @@ class TestRegistryConsistency:
class TestFindRegistry:
def test_finds_registry(self, tmp_path: Path) -> None:
"""Finds *_REGISTRY.json in project root."""
"""Shared find_registry finds *_REGISTRY.json from start_path."""
from aipass.aipass.shared.registry_discovery import find_registry
(tmp_path / "AIPASS_REGISTRY.json").write_text("{}", encoding="utf-8")
result = find_registry(tmp_path)
result = find_registry(start_path=tmp_path)
assert result is not None
assert result.name == "AIPASS_REGISTRY.json"
def test_returns_none(self, tmp_path: Path) -> None:
"""Returns None when no registry file."""
result = find_registry(tmp_path)
assert result is None
def test_fallback_when_missing(self, tmp_path: Path) -> None:
"""Shared find_registry returns fallback when no registry in isolated dir."""
from aipass.aipass.shared.registry_discovery import find_registry
isolated = tmp_path / "no_registry"
isolated.mkdir()
result = find_registry(start_path=isolated)
assert result.parent != isolated or not result.exists()
# =============================================================================
+2
View File
@@ -12,3 +12,5 @@ build/
*.log
*.tmp
*.swp
test_devto_driver.py
test_bluesky_driver.py

Some files were not shown because too many files have changed in this diff Show More